]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Experimental improvements to TreeSocket::Split
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 35a57567522fa803b50f9b00952c20a088f52d23..ce3d00b8c1f3f02059a0957326a38fcbcff4c4a0 100644 (file)
@@ -74,7 +74,7 @@ class ModuleSpanningTree;
 static ModuleSpanningTree* TreeProtocolModule;
 
 extern ServerConfig* Config;
-
+extern InspIRCd* ServerInstance;
 extern std::vector<Module*> modules;
 extern std::vector<ircd_module*> factory;
 extern int MODCOUNT;
@@ -109,7 +109,7 @@ class TreeSocket;
  */
 TreeServer *TreeRoot;
 
-Server* Srv;
+static Server* Srv;
 
 /* This hash_map holds the hash equivalent of the server
  * tree, used for rapid linear lookups.
@@ -121,7 +121,7 @@ server_hash serverlist;
 bool DoOneToOne(std::string prefix, std::string command, std::deque<std::string> &params, std::string target);
 bool DoOneToAllButSender(std::string prefix, std::string command, std::deque<std::string> &params, std::string omit);
 bool DoOneToMany(std::string prefix, std::string command, std::deque<std::string> &params);
-bool DoOneToAllButSenderRaw(std::string data, std::string omit, std::string prefix, std::string command, std::deque<std::string> &params);
+bool DoOneToAllButSenderRaw(std::string data, std::string omit, std::string prefix, irc::string command, std::deque<std::string> &params);
 void ReadConfiguration(bool rebind);
 
 /* Flatten links and /MAP for non-opers */
@@ -864,13 +864,14 @@ class TreeSocket : public InspSocket
        }
 
        /* FMODE command */
-       bool ForceMode(std::string source, std::deque<std::string> params)
+       bool ForceMode(std::string source, std::deque<std::string> &params)
        {
-               userrec* who = new userrec;
-               who->fd = FD_MAGIC_NUMBER;
                if (params.size() < 2)
                        return true;
-               char* modelist[255];
+               userrec* who = new userrec();
+               who->fd = FD_MAGIC_NUMBER;
+               char* modelist[64];
+               memset(&modelist,0,sizeof(modelist));
                for (unsigned int q = 0; q < params.size(); q++)
                {
                        modelist[q] = (char*)params[q].c_str();
@@ -882,7 +883,7 @@ class TreeSocket : public InspSocket
        }
 
        /* FTOPIC command */
-       bool ForceTopic(std::string source, std::deque<std::string> params)
+       bool ForceTopic(std::string source, std::deque<std::string> &params)
        {
                if (params.size() != 4)
                        return true;
@@ -896,7 +897,7 @@ class TreeSocket : public InspSocket
                        {
                                std::string oldtopic = c->topic;
                                strlcpy(c->topic,params[3].c_str(),MAXTOPIC);
-                               strlcpy(c->setby,params[2].c_str(),NICKMAX);
+                               strlcpy(c->setby,params[2].c_str(),NICKMAX-1);
                                c->topicset = ts;
                                /* if the topic text is the same as the current topic,
                                 * dont bother to send the TOPIC command out, just silently
@@ -927,7 +928,7 @@ class TreeSocket : public InspSocket
        }
 
        /* FJOIN, similar to unreal SJOIN */
-       bool ForceJoin(std::string source, std::deque<std::string> params)
+       bool ForceJoin(std::string source, std::deque<std::string> &params)
        {
                if (params.size() < 3)
                        return true;
@@ -935,6 +936,7 @@ class TreeSocket : public InspSocket
                char first[MAXBUF];
                char modestring[MAXBUF];
                char* mode_users[127];
+               memset(&mode_users,0,sizeof(mode_users));
                mode_users[0] = first;
                mode_users[1] = modestring;
                strcpy(mode_users[1],"+");
@@ -1057,7 +1059,7 @@ class TreeSocket : public InspSocket
        }
 
        /* NICK command */
-       bool IntroduceClient(std::string source, std::deque<std::string> params)
+       bool IntroduceClient(std::string source, std::deque<std::string> &params)
        {
                if (params.size() < 8)
                        return true;
@@ -1091,7 +1093,7 @@ class TreeSocket : public InspSocket
 
                clientlist[tempnick] = new userrec();
                clientlist[tempnick]->fd = FD_MAGIC_NUMBER;
-               strlcpy(clientlist[tempnick]->nick, tempnick,NICKMAX);
+               strlcpy(clientlist[tempnick]->nick, tempnick,NICKMAX-1);
                strlcpy(clientlist[tempnick]->host, params[2].c_str(),160);
                strlcpy(clientlist[tempnick]->dhost, params[3].c_str(),160);
                clientlist[tempnick]->server = (char*)FindServerNamePtr(source.c_str());
@@ -1203,47 +1205,81 @@ class TreeSocket : public InspSocket
        void SendXLines(TreeServer* Current)
        {
                char data[MAXBUF];
-               const char* sn = Srv->GetServerName().c_str();
+               std::string n = Srv->GetServerName();
+               const char* sn = n.c_str();
+               int iterations = 0;
                /* Yes, these arent too nice looking, but they get the job done */
-               for (std::vector<ZLine>::iterator i = zlines.begin(); i != zlines.end(); i++)
+               for (std::vector<ZLine>::iterator i = zlines.begin(); i != zlines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<QLine>::iterator i = qlines.begin(); i != qlines.end(); i++)
+               for (std::vector<QLine>::iterator i = qlines.begin(); i != qlines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<GLine>::iterator i = glines.begin(); i != glines.end(); i++)
+               for (std::vector<GLine>::iterator i = glines.begin(); i != glines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<ELine>::iterator i = elines.begin(); i != elines.end(); i++)
+               for (std::vector<ELine>::iterator i = elines.begin(); i != elines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<ZLine>::iterator i = pzlines.begin(); i != pzlines.end(); i++)
+               for (std::vector<ZLine>::iterator i = pzlines.begin(); i != pzlines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<QLine>::iterator i = pqlines.begin(); i != pqlines.end(); i++)
+               for (std::vector<QLine>::iterator i = pqlines.begin(); i != pqlines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<GLine>::iterator i = pglines.begin(); i != pglines.end(); i++)
+               for (std::vector<GLine>::iterator i = pglines.begin(); i != pglines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
-               for (std::vector<ELine>::iterator i = pelines.begin(); i != pelines.end(); i++)
+               for (std::vector<ELine>::iterator i = pelines.begin(); i != pelines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
+                       if ((iterations % 10) == 0)
+                       {
+                               ServerInstance->DoOneIteration(false);
+                       }
                }
        }
 
@@ -1252,8 +1288,10 @@ class TreeSocket : public InspSocket
        {
                char data[MAXBUF];
                std::deque<std::string> list;
-               const char* sn = Srv->GetServerName().c_str();
-               for (chan_hash::iterator c = chanlist.begin(); c != chanlist.end(); c++)
+               int iterations = 0;
+               std::string n = Srv->GetServerName();
+               const char* sn = n.c_str();
+               for (chan_hash::iterator c = chanlist.begin(); c != chanlist.end(); c++, iterations++)
                {
                        SendFJoins(Current, c->second);
                        snprintf(data,MAXBUF,":%s FMODE %s +%s",sn,c->second->name,chanmodes(c->second,true));
@@ -1283,7 +1321,8 @@ class TreeSocket : public InspSocket
        {
                char data[MAXBUF];
                std::deque<std::string> list;
-               for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
+               int iterations = 0;
+               for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++, iterations++)
                {
                        if (u->second->registered == 7)
                        {
@@ -1315,19 +1354,31 @@ class TreeSocket : public InspSocket
         */
        void DoBurst(TreeServer* s)
        {
+               /* The calls here to ServerInstance->DoOneIteration(false); yield the processing
+                * back to the core so that a large burst is split into at least 6 sections
+                * (possibly more)
+                */
+               std::string burst = "BURST";
+               std::string endburst = "ENDBURST";
                Srv->SendOpers("*** Bursting to \2"+s->GetName()+"\2.");
-               this->WriteLine("BURST");
+               this->WriteLine(burst);
+               ServerInstance->DoOneIteration(false);
                /* send our version string */
                this->WriteLine(":"+Srv->GetServerName()+" VERSION :"+Srv->GetVersion());
                /* Send server tree */
                this->SendServers(TreeRoot,s,1);
+               ServerInstance->DoOneIteration(false);
                /* Send users and their oper status */
                this->SendUsers(s);
+               ServerInstance->DoOneIteration(false);
                /* Send everything else (channel modes, xlines etc) */
                this->SendChannelModes(s);
+               ServerInstance->DoOneIteration(false);
                this->SendXLines(s);
+               ServerInstance->DoOneIteration(false);
                FOREACH_MOD(I_OnSyncOtherMetaData,OnSyncOtherMetaData((Module*)TreeProtocolModule,(void*)this));
-               this->WriteLine("ENDBURST");
+               ServerInstance->DoOneIteration(false);
+               this->WriteLine(endburst);
                Srv->SendOpers("*** Finished bursting to \2"+s->GetName()+"\2.");
        }
 
@@ -1341,18 +1392,22 @@ class TreeSocket : public InspSocket
         */
        virtual bool OnDataReady()
        {
-               log(DEBUG,"TreeSocket::OnDataReady");
+               int iterations = 0;
                char* data = this->Read();
                /* Check that the data read is a valid pointer and it has some content */
                if (data && *data)
                {
-                       log(DEBUG,"got some data");
                        this->in_buffer.append(data);
                        /* While there is at least one new line in the buffer,
                         * do something useful (we hope!) with it.
                         */
                        while (in_buffer.find("\n") != std::string::npos)
                        {
+                               iterations++;
+                               if ((iterations % 10) == 0)
+                               {
+                                       ServerInstance->DoOneIteration(false);
+                               }
                                std::string ret = in_buffer.substr(0,in_buffer.find("\n")-1);
                                in_buffer = in_buffer.substr(in_buffer.find("\n")+1,in_buffer.length()-in_buffer.find("\n"));
                                if (ret.find("\r") != std::string::npos)
@@ -1374,7 +1429,7 @@ class TreeSocket : public InspSocket
                                                if ((nbytes > 0) && (nbytes < 1024))
                                                {
                                                        log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
-                                                       ctx_in->Decrypt(out, result, nbytes, 1);
+                                                       ctx_in->Decrypt(out, result, nbytes, 0);
                                                        for (int t = 0; t < nbytes; t++)
                                                                if (result[t] == '\7') result[t] = 0;
                                                        ret = result;
@@ -1387,11 +1442,12 @@ class TreeSocket : public InspSocket
                                        return false;
                                }
                        }
+                       return true;
                }
                /* EAGAIN returns an empty but non-NULL string, so this
                 * evaluates to TRUE for EAGAIN but to FALSE for EOF.
                 */
-               return (data != NULL);
+               return (data && !*data);
        }
 
        int WriteLine(std::string line)
@@ -1404,15 +1460,15 @@ class TreeSocket : public InspSocket
                        if (this->keylength)
                        {
                                // pad it to the key length
-                               int n = line.length() % this->keylength;
+                               int n = this->keylength - (line.length() % this->keylength);
                                if (n)
                                {
-                                       log(DEBUG,"Append %d chars to line to make it %d long from %d",n,n+line.length(),line.length());
+                                       log(DEBUG,"Append %d chars to line to make it %d long from %d, key length %d",n,n+line.length(),line.length(),this->keylength);
                                        line.append(n,'\7');
                                }
                        }
                        unsigned int ll = line.length();
-                       ctx_out->Encrypt(line.c_str(), result, ll, 1);
+                       ctx_out->Encrypt(line.c_str(), result, ll, 0);
                        to64frombits((unsigned char*)result64,(unsigned char*)result,ll);
                        line = result64;
                        //int from64tobits(char *out, const char *in, int maxlen);
@@ -1444,7 +1500,7 @@ class TreeSocket : public InspSocket
                userrec* u = Srv->FindNick(prefix);
                if (u)
                {
-                       strlcpy(u->oper,opertype.c_str(),NICKMAX);
+                       strlcpy(u->oper,opertype.c_str(),NICKMAX-1);
                        if (!strchr(u->modes,'o'))
                        {
                                strcat(u->modes,"o");
@@ -2016,49 +2072,56 @@ class TreeSocket : public InspSocket
 
        void Split(std::string line, bool stripcolon, std::deque<std::string> &n)
        {
+               // we don't do anything with a line > 2048
+               if (line.length() > 2048)
+                       return;
                if (!strchr(line.c_str(),' '))
                {
                        n.push_back(line);
                        return;
                }
                std::stringstream s(line);
-               std::string param = "";
+               int count = 0;
+               char param[1024];
+               char* pptr = param;
 
                n.clear();
                int item = 0;
                while (!s.eof())
                {
-                       char c;
+                       char c = 0;
                        s.get(c);
                        if (c == ' ')
                        {
                                n.push_back(param);
-                               param = "";
+                               *param = count = 0;
                                item++;
                        }
                        else
                        {
                                if (!s.eof())
                                {
-                                       param = param + c;
+                                       *pptr++ = c;
+                                       count++;
                                }
-                               if ((param == ":") && (item > 0))
+                               if ((*param == ':') && (count == 1) && (item > 0))
                                {
-                                       param = "";
+                                       *param = 0;
                                        while (!s.eof())
                                        {
                                                s.get(c);
                                                if (!s.eof())
                                                {
-                                                       param = param + c;
+                                                       *pptr++ = c;
+                                                       count++;
                                                }
                                        }
                                        n.push_back(param);
-                                       param = "";
+                                       *param = count = 0;
                                }
                        }
                }
-               if (param != "")
+               if (*param)
                {
                        n.push_back(param);
                }
@@ -2077,12 +2140,12 @@ class TreeSocket : public InspSocket
                
                std::deque<std::string> params;
                this->Split(line,true,params);
-               std::string command = "";
+               irc::string command = "";
                std::string prefix = "";
                if (((params[0].c_str())[0] == ':') && (params.size() > 1))
                {
                        prefix = params[0];
-                       command = params[1];
+                       command = params[1].c_str();
                        char* pref = (char*)prefix.c_str();
                        prefix = ++pref;
                        params.pop_front();
@@ -2091,7 +2154,7 @@ class TreeSocket : public InspSocket
                else
                {
                        prefix = "";
-                       command = params[0];
+                       command = params[0].c_str();
                        params.pop_front();
                }
 
@@ -2295,6 +2358,16 @@ class TreeSocket : public InspSocket
                                }
                                else if (command == "PING")
                                {
+                                       /*
+                                        * We just got a ping from a server that's bursting.
+                                        * This can't be right, so set them to not bursting, and
+                                        * apply their lines.
+                                        */
+                                       if (this->bursting)
+                                       {
+                                               this->bursting = false;
+                                               apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                       }
                                        if (prefix == "")
                                        {
                                                prefix = this->GetName();
@@ -2303,6 +2376,16 @@ class TreeSocket : public InspSocket
                                }
                                else if (command == "PONG")
                                {
+                                       /*
+                                        * We just got a pong from a server that's bursting.
+                                        * This can't be right, so set them to not bursting, and
+                                        * apply their lines.
+                                        */
+                                       if (this->bursting)
+                                       {
+                                               this->bursting = false;
+                                               apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                       }
                                        if (prefix == "")
                                        {
                                                prefix = this->GetName();
@@ -2345,6 +2428,24 @@ class TreeSocket : public InspSocket
                                {
                                        return this->Time(prefix,params);
                                }
+                               else if ((command == "KICK") && (IsServer(prefix)))
+                               {
+                                       std::string sourceserv = this->myhost;
+                                       if (params.size() == 3)
+                                       {
+                                               userrec* user = Srv->FindNick(params[1]);
+                                               chanrec* chan = Srv->FindChannel(params[0]);
+                                               if (user && chan)
+                                               {
+                                                       server_kick_channel(user,chan,(char*)params[2].c_str(),false);
+                                               }
+                                       }
+                                       if (this->InboundServerName != "")
+                                       {
+                                               sourceserv = this->InboundServerName;
+                                       }
+                                       return DoOneToAllButSenderRaw(line,sourceserv,prefix,command,params);
+                               }
                                else if (command == "SVSJOIN")
                                {
                                        if (prefix == "")
@@ -2365,6 +2466,12 @@ class TreeSocket : public InspSocket
                                {
                                        this->bursting = false;
                                        apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                       std::string sourceserv = this->myhost;
+                                       if (this->InboundServerName != "")
+                                       {
+                                               sourceserv = this->InboundServerName;
+                                       }
+                                       WriteOpers("*** Received end of netburst from \2%s\2",sourceserv.c_str());
                                        return true;
                                }
                                else
@@ -2413,7 +2520,11 @@ class TreeSocket : public InspSocket
                                                {
                                                        strparams[q] = (char*)params[q].c_str();
                                                }
-                                               Srv->CallCommandHandler(command, strparams, params.size(), who);
+                                               if (!Srv->CallCommandHandler(command.c_str(), strparams, params.size(), who))
+                                               {
+                                                       this->WriteLine("ERROR :Unrecognised command -- possibly loaded mismatched modules");
+                                                       return false;
+                                               }
                                        }
                                        else
                                        {
@@ -2511,7 +2622,7 @@ void GetListOfServersForChannel(chanrec* c, std::deque<TreeServer*> &list)
        return;
 }
 
-bool DoOneToAllButSenderRaw(std::string data, std::string omit, std::string prefix, std::string command, std::deque<std::string> &params)
+bool DoOneToAllButSenderRaw(std::string data, std::string omit, std::string prefix, irc::string command, std::deque<std::string> &params)
 {
        TreeServer* omitroute = BestRouteTo(omit);
        if ((command == "NOTICE") || (command == "PRIVMSG"))
@@ -2532,7 +2643,7 @@ bool DoOneToAllButSenderRaw(std::string data, std::string omit, std::string pref
                                        std::deque<std::string> par;
                                        par.push_back(params[0]);
                                        par.push_back(":"+params[1]);
-                                       DoOneToOne(prefix,command,par,d->server);
+                                       DoOneToOne(prefix,command.c_str(),par,d->server);
                                        return true;
                                }
                        }
@@ -2683,7 +2794,11 @@ void ReadConfiguration(bool rebind)
        for (int j =0; j < Conf->Enumerate("link"); j++)
        {
                Link L;
+               char ServerN[MAXBUF];
                L.Name = Conf->ReadValue("link","name",j);
+               strlcpy(ServerN,L.Name.c_str(),MAXBUF);
+               strlower(ServerN);
+               L.Name = ServerN;
                L.IPAddr = Conf->ReadValue("link","ipaddr",j);
                L.Port = Conf->ReadInteger("link","port",j,true);
                L.SendPass = Conf->ReadValue("link","sendpass",j);
@@ -2757,7 +2872,7 @@ class ModuleSpanningTree : public Module
                }
                for (unsigned int q = 0; q < Current->ChildCount(); q++)
                {
-                       if ((HideULines) && (Srv->IsUlined(Current->GetName())))
+                       if ((HideULines) && (Srv->IsUlined(Current->GetChild(q)->GetName())))
                        {
                                if (*user->oper)
                                {
@@ -2769,6 +2884,9 @@ class ModuleSpanningTree : public Module
                                ShowLinks(Current->GetChild(q),user,hops+1);
                        }
                }
+               /* Don't display the line if its a uline, hide ulines is on, and the user isnt an oper */
+               if ((HideULines) && (Srv->IsUlined(Current->GetName())) && (!*user->oper))
+                       return;
                WriteServ(user->fd,"364 %s %s %s :%d %s",user->nick,Current->GetName().c_str(),(FlatLinks && (!*user->oper)) ? Srv->GetServerName().c_str() : Parent.c_str(),(FlatLinks && (!*user->oper)) ? 0 : hops,Current->GetDesc().c_str());
        }
 
@@ -3463,6 +3581,14 @@ class ModuleSpanningTree : public Module
                        params.push_back(":"+reason);
                        DoOneToMany(source->nick,"KICK",params);
                }
+               else if (!source)
+               {
+                       std::deque<std::string> params;
+                       params.push_back(chan->name);
+                       params.push_back(user->nick);
+                       params.push_back(":"+reason);
+                       DoOneToMany(Srv->GetServerName(),"KICK",params);
+               }
        }
 
        virtual void OnRemoteKill(userrec* source, userrec* dest, std::string reason)