]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Experimental improvements to TreeSocket::Split
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 99d24cf0241b57f41024b0bc2de645882e976e96..ce3d00b8c1f3f02059a0957326a38fcbcff4c4a0 100644 (file)
@@ -864,13 +864,14 @@ class TreeSocket : public InspSocket
        }
 
        /* FMODE command */
-       bool ForceMode(std::string source, std::deque<std::string> params)
+       bool ForceMode(std::string source, std::deque<std::string> &params)
        {
-               userrec* who = new userrec;
-               who->fd = FD_MAGIC_NUMBER;
                if (params.size() < 2)
                        return true;
-               char* modelist[255];
+               userrec* who = new userrec();
+               who->fd = FD_MAGIC_NUMBER;
+               char* modelist[64];
+               memset(&modelist,0,sizeof(modelist));
                for (unsigned int q = 0; q < params.size(); q++)
                {
                        modelist[q] = (char*)params[q].c_str();
@@ -882,7 +883,7 @@ class TreeSocket : public InspSocket
        }
 
        /* FTOPIC command */
-       bool ForceTopic(std::string source, std::deque<std::string> params)
+       bool ForceTopic(std::string source, std::deque<std::string> &params)
        {
                if (params.size() != 4)
                        return true;
@@ -927,7 +928,7 @@ class TreeSocket : public InspSocket
        }
 
        /* FJOIN, similar to unreal SJOIN */
-       bool ForceJoin(std::string source, std::deque<std::string> params)
+       bool ForceJoin(std::string source, std::deque<std::string> &params)
        {
                if (params.size() < 3)
                        return true;
@@ -935,6 +936,7 @@ class TreeSocket : public InspSocket
                char first[MAXBUF];
                char modestring[MAXBUF];
                char* mode_users[127];
+               memset(&mode_users,0,sizeof(mode_users));
                mode_users[0] = first;
                mode_users[1] = modestring;
                strcpy(mode_users[1],"+");
@@ -1057,7 +1059,7 @@ class TreeSocket : public InspSocket
        }
 
        /* NICK command */
-       bool IntroduceClient(std::string source, std::deque<std::string> params)
+       bool IntroduceClient(std::string source, std::deque<std::string> &params)
        {
                if (params.size() < 8)
                        return true;
@@ -1203,14 +1205,15 @@ class TreeSocket : public InspSocket
        void SendXLines(TreeServer* Current)
        {
                char data[MAXBUF];
-               const char* sn = Srv->GetServerName().c_str();
+               std::string n = Srv->GetServerName();
+               const char* sn = n.c_str();
                int iterations = 0;
                /* Yes, these arent too nice looking, but they get the job done */
                for (std::vector<ZLine>::iterator i = zlines.begin(); i != zlines.end(); i++, iterations++)
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1219,7 +1222,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1228,7 +1231,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1237,7 +1240,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1246,7 +1249,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1255,7 +1258,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1264,7 +1267,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1273,7 +1276,7 @@ class TreeSocket : public InspSocket
                {
                        snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
-                       if ((iterations % 20) == 0)
+                       if ((iterations % 10) == 0)
                        {
                                ServerInstance->DoOneIteration(false);
                        }
@@ -1286,7 +1289,8 @@ class TreeSocket : public InspSocket
                char data[MAXBUF];
                std::deque<std::string> list;
                int iterations = 0;
-               const char* sn = Srv->GetServerName().c_str();
+               std::string n = Srv->GetServerName();
+               const char* sn = n.c_str();
                for (chan_hash::iterator c = chanlist.begin(); c != chanlist.end(); c++, iterations++)
                {
                        SendFJoins(Current, c->second);
@@ -1354,20 +1358,27 @@ class TreeSocket : public InspSocket
                 * back to the core so that a large burst is split into at least 6 sections
                 * (possibly more)
                 */
+               std::string burst = "BURST";
+               std::string endburst = "ENDBURST";
                Srv->SendOpers("*** Bursting to \2"+s->GetName()+"\2.");
-               this->WriteLine("BURST");
+               this->WriteLine(burst);
+               ServerInstance->DoOneIteration(false);
                /* send our version string */
                this->WriteLine(":"+Srv->GetServerName()+" VERSION :"+Srv->GetVersion());
                /* Send server tree */
                this->SendServers(TreeRoot,s,1);
+               ServerInstance->DoOneIteration(false);
                /* Send users and their oper status */
                this->SendUsers(s);
+               ServerInstance->DoOneIteration(false);
                /* Send everything else (channel modes, xlines etc) */
                this->SendChannelModes(s);
+               ServerInstance->DoOneIteration(false);
                this->SendXLines(s);
+               ServerInstance->DoOneIteration(false);
                FOREACH_MOD(I_OnSyncOtherMetaData,OnSyncOtherMetaData((Module*)TreeProtocolModule,(void*)this));
                ServerInstance->DoOneIteration(false);
-               this->WriteLine("ENDBURST");
+               this->WriteLine(endburst);
                Srv->SendOpers("*** Finished bursting to \2"+s->GetName()+"\2.");
        }
 
@@ -1381,13 +1392,11 @@ class TreeSocket : public InspSocket
         */
        virtual bool OnDataReady()
        {
-               log(DEBUG,"TreeSocket::OnDataReady");
                int iterations = 0;
                char* data = this->Read();
                /* Check that the data read is a valid pointer and it has some content */
                if (data && *data)
                {
-                       log(DEBUG,"got some data");
                        this->in_buffer.append(data);
                        /* While there is at least one new line in the buffer,
                         * do something useful (we hope!) with it.
@@ -1395,7 +1404,7 @@ class TreeSocket : public InspSocket
                        while (in_buffer.find("\n") != std::string::npos)
                        {
                                iterations++;
-                               if ((iterations % 20) == 0)
+                               if ((iterations % 10) == 0)
                                {
                                        ServerInstance->DoOneIteration(false);
                                }
@@ -1420,7 +1429,7 @@ class TreeSocket : public InspSocket
                                                if ((nbytes > 0) && (nbytes < 1024))
                                                {
                                                        log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
-                                                       ctx_in->Decrypt(out, result, nbytes, 1);
+                                                       ctx_in->Decrypt(out, result, nbytes, 0);
                                                        for (int t = 0; t < nbytes; t++)
                                                                if (result[t] == '\7') result[t] = 0;
                                                        ret = result;
@@ -1433,11 +1442,12 @@ class TreeSocket : public InspSocket
                                        return false;
                                }
                        }
+                       return true;
                }
                /* EAGAIN returns an empty but non-NULL string, so this
                 * evaluates to TRUE for EAGAIN but to FALSE for EOF.
                 */
-               return (data != NULL);
+               return (data && !*data);
        }
 
        int WriteLine(std::string line)
@@ -1458,7 +1468,7 @@ class TreeSocket : public InspSocket
                                }
                        }
                        unsigned int ll = line.length();
-                       ctx_out->Encrypt(line.c_str(), result, ll, 1);
+                       ctx_out->Encrypt(line.c_str(), result, ll, 0);
                        to64frombits((unsigned char*)result64,(unsigned char*)result,ll);
                        line = result64;
                        //int from64tobits(char *out, const char *in, int maxlen);
@@ -2062,49 +2072,56 @@ class TreeSocket : public InspSocket
 
        void Split(std::string line, bool stripcolon, std::deque<std::string> &n)
        {
+               // we don't do anything with a line > 2048
+               if (line.length() > 2048)
+                       return;
                if (!strchr(line.c_str(),' '))
                {
                        n.push_back(line);
                        return;
                }
                std::stringstream s(line);
-               std::string param = "";
+               int count = 0;
+               char param[1024];
+               char* pptr = param;
 
                n.clear();
                int item = 0;
                while (!s.eof())
                {
-                       char c;
+                       char c = 0;
                        s.get(c);
                        if (c == ' ')
                        {
                                n.push_back(param);
-                               param = "";
+                               *param = count = 0;
                                item++;
                        }
                        else
                        {
                                if (!s.eof())
                                {
-                                       param = param + c;
+                                       *pptr++ = c;
+                                       count++;
                                }
-                               if ((param == ":") && (item > 0))
+                               if ((*param == ':') && (count == 1) && (item > 0))
                                {
-                                       param = "";
+                                       *param = 0;
                                        while (!s.eof())
                                        {
                                                s.get(c);
                                                if (!s.eof())
                                                {
-                                                       param = param + c;
+                                                       *pptr++ = c;
+                                                       count++;
                                                }
                                        }
                                        n.push_back(param);
-                                       param = "";
+                                       *param = count = 0;
                                }
                        }
                }
-               if (param != "")
+               if (*param)
                {
                        n.push_back(param);
                }
@@ -2449,6 +2466,12 @@ class TreeSocket : public InspSocket
                                {
                                        this->bursting = false;
                                        apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                       std::string sourceserv = this->myhost;
+                                       if (this->InboundServerName != "")
+                                       {
+                                               sourceserv = this->InboundServerName;
+                                       }
+                                       WriteOpers("*** Received end of netburst from \2%s\2",sourceserv.c_str());
                                        return true;
                                }
                                else
@@ -2497,7 +2520,11 @@ class TreeSocket : public InspSocket
                                                {
                                                        strparams[q] = (char*)params[q].c_str();
                                                }
-                                               Srv->CallCommandHandler(command.c_str(), strparams, params.size(), who);
+                                               if (!Srv->CallCommandHandler(command.c_str(), strparams, params.size(), who))
+                                               {
+                                                       this->WriteLine("ERROR :Unrecognised command -- possibly loaded mismatched modules");
+                                                       return false;
+                                               }
                                        }
                                        else
                                        {