]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Fake direction check in FJOIN on all users, plus tidyup of the code that forms the...
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 5e7ba436744588d9fc3c063a444be98f14752beb..e94209885b51581dcfd247d38fdb6f9b2f9252b0 100644 (file)
@@ -705,11 +705,14 @@ class TreeSocket : public InspSocket
                }
                else
                {
-                       this->Instance->SNO->WriteToSnoMask('l',"\2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
-                       ctx_in->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
-                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
-                       ctx_out->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
-                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                       if (this->GetState() != I_ERROR)
+                       {
+                               this->Instance->SNO->WriteToSnoMask('l',"\2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
+                               ctx_in->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                                       \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                               ctx_out->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                                       \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                       }
                }
        }
        
@@ -728,7 +731,7 @@ class TreeSocket : public InspSocket
                        {
                                if (x->Name == this->myhost)
                                {
-                                       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] established.");
+                                       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] started.");
                                        this->SendCapabilities();
                                        if (x->EncryptionKey != "")
                                        {
@@ -1306,7 +1309,7 @@ class TreeSocket : public InspSocket
                                modelist[0] = params[0].c_str();
                                modelist[1] = to_keep.c_str();
 
-                               if (params_to_keep.size() > 1)
+                               if (params_to_keep.size() > 0)
                                {
                                        for (q = 0; (q < params_to_keep.size()) && (q < 64); q++)
                                        {
@@ -1318,12 +1321,12 @@ class TreeSocket : public InspSocket
                                if (smode)
                                {
                                        Instance->Log(DEBUG,"Send mode");
-                                       this->Instance->SendMode(modelist, n+2, who);
+                                       this->Instance->SendMode(modelist, n, who);
                                }
                                else
                                {
                                        Instance->Log(DEBUG,"Send mode client");
-                                       this->Instance->CallCommandHandler("MODE", modelist, n+2, who);
+                                       this->Instance->CallCommandHandler("MODE", modelist, n, who);
                                }
 
                                /* HOT POTATO! PASS IT ON! */
@@ -1531,20 +1534,17 @@ class TreeSocket : public InspSocket
                
                chanrec* chan = this->Instance->FindChan(channel);
                if (chan)
-               {
                        key = chan->key;
-               }
+
                strlcpy(mode_users[0],channel.c_str(),MAXBUF);
 
                /* default is a high value, which if we dont have this
                 * channel will let the other side apply their modes.
                 */
                time_t ourTS = time(NULL)+600;
-               chanrec* us = this->Instance->FindChan(channel);
-               if (us)
-               {
-                       ourTS = us->age;
-               }
+
+               if (chan)
+                       ourTS = chan->age;
 
                /* XXX: PAY ATTENTION:
                 * In 1.1, if they have the newer channel, we immediately clear
@@ -1553,13 +1553,15 @@ class TreeSocket : public InspSocket
                 * Note that this causes the losing server to send out confirming
                 * FMODE lines.
                 */
-               if ((ourTS > TS) || (this->Instance->ULine(who->server)))
+               if (ourTS > TS)
+// || (this->Instance->ULine(source.c_str())))
                {
                        Instance->Log(DEBUG,"FJOIN detected, our TS=%lu, their TS=%lu",ourTS,TS);
                        std::deque<std::string> param_list;
-                       us->age = TS;
+                       if (chan)
+                               chan->age = TS;
                        ourTS = TS;
-                       param_list.push_back(chan->name);
+                       param_list.push_back(channel);
                        Instance->Log(DEBUG,"REMOVE ALL STATUS MODES FROM OUR USERS *NOW*");
                        this->RemoveStatus(Instance->Config->ServerName, param_list);
                }
@@ -1583,47 +1585,61 @@ class TreeSocket : public InspSocket
                        {
                                char* permissions = usr;
                                int ntimes = 0;
-                               while ((*permissions) && (*permissions != ','))
+                               char* nm = new char[MAXBUF];
+                               char* tnm = nm;
+
+                               while ((*permissions) && (*permissions != ',') && (ntimes < MAXBUF))
                                {
                                        ModeHandler* mh = Instance->Modes->FindPrefix(*permissions);
                                        if (mh)
                                        {
                                                ntimes++;
-                                               charlcat(modestring,mh->GetModeChar(),MAXBUF);
+                                               *tnm++ = mh->GetModeChar();
                                        }
                                        else
                                        {
-                                               this->Instance->WriteOpers("ERROR: We received a user with an unknown prefix '%c'. Closed connection to avoid a desync.",mh->GetPrefix());
-                                               this->WriteLine(std::string("ERROR :Invalid prefix '")+mh->GetModeChar()+"' in FJOIN");
+                                               this->Instance->WriteOpers("ERROR: We received a user with an unknown prefix '%c'. Closed connection to avoid a desync.",*permissions);
+                                               this->WriteLine(std::string("ERROR :Invalid prefix '")+(*permissions)+"' in FJOIN");
                                                return false;
                                        }
                                        usr++;
                                        permissions++;
                                }
-                               usr++;
 
-                               /* Did they get any modes? How many times? */
-                               for (int k = 0; k < ntimes; k++)
-                                       mode_users[modectr++] = strdup(usr);
+                               *tnm = 0;
+                               usr++;
 
                                who = this->Instance->FindNick(usr);
                                if (who)
                                {
+                                       /* Did they get any modes? How many times? */
+                                       strlcat(modestring, nm, MAXBUF);
+                                       for (int k = 0; k < ntimes; k++)
+                                               mode_users[modectr++] = strdup(usr);
+
+                                       delete[] nm;
+
+                                       TreeServer* route_back_again = BestRouteTo(who->server);
+                                       if ((!route_back_again) || (route_back_again->GetSocket() != this))
+                                       {
+                                               Instance->Log(DEBUG,"Fake direction in FJOIN, user '%s'",who->nick);
+                                               continue;
+                                       }
                                        chanrec::JoinUser(this->Instance, who, channel.c_str(), true, key);
                                        if (modectr >= (MAXMODES-1))
                                        {
                                                /* theres a mode for this user. push them onto the mode queue, and flush it
                                                 * if there are more than MAXMODES to go.
                                                 */
-                                               if ((ourTS >= TS) || (this->Instance->ULine(who->server)))
+                                               if (ourTS >= TS)
                                                {
                                                        /* We also always let u-lined clients win, no matter what the TS value */
                                                        Instance->Log(DEBUG,"Our our channel newer than theirs, accepting their modes");
                                                        this->Instance->SendMode((const char**)mode_users,modectr,who);
                                                        if (ourTS != TS)
                                                        {
-                                                               Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",us->name,ourTS,TS);
-                                                               us->age = TS;
+                                                               Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",chan->name,ourTS,TS);
+                                                               chan->age = TS;
                                                                ourTS = TS;
                                                        }
                                                }
@@ -1635,6 +1651,7 @@ class TreeSocket : public InspSocket
                                }
                                else
                                {
+                                       delete[] nm;
                                        Instance->Log(SPARSE,"Warning! Invalid user in FJOIN to channel %s IGNORED", channel.c_str());
                                        continue;
                                }
@@ -1643,7 +1660,7 @@ class TreeSocket : public InspSocket
                /* there werent enough modes built up to flush it during FJOIN,
                 * or, there are a number left over. flush them out.
                 */
-               if ((modectr > 2) && (who) && (us))
+               if ((modectr > 2) && (who) && (chan))
                {
                        if (ourTS >= TS)
                        {
@@ -1651,8 +1668,8 @@ class TreeSocket : public InspSocket
                                this->Instance->SendMode((const char**)mode_users,modectr,who);
                                if (ourTS != TS)
                                {
-                                       Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",us->name,ourTS,TS);
-                                       us->age = TS;
+                                       Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",chan->name,ourTS,TS);
+                                       chan->age = TS;
                                        ourTS = TS;
                                }
                        }
@@ -1732,6 +1749,8 @@ class TreeSocket : public InspSocket
                        SourceServer->AddUserCount();
                }
 
+               FOREACH_MOD(I_OnPostConnect,OnPostConnect(_new));
+
                return true;
        }
 
@@ -2224,6 +2243,7 @@ class TreeSocket : public InspSocket
                        this->Instance->SNO->WriteToSnoMask('l',"Remote rehash initiated from server \002"+prefix+"\002.");
                        this->Instance->RehashServer();
                        ReadConfiguration(false);
+                       InitializeDisabledCommands(ServerInstance->Config->DisabledCommands, ServerInstance);
                }
                DoOneToAllButSender(prefix,"REHASH",params,prefix);
                return true;
@@ -2611,38 +2631,50 @@ class TreeSocket : public InspSocket
 
                if (c)
                {
+                       irc::modestacker modestack(false);
                        CUList *ulist = c->GetUsers();
+                       const char* y[127];
+                       std::deque<std::string> stackresult;
+                       std::string x;
+
                        for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
                                std::string modesequence = Instance->Modes->ModeString(i->second, c);
                                if (modesequence.length())
                                {
-                                       modesequence = "-" + modesequence;
-
-                                       std::deque<std::string> items;
-                                       const char* y[127];
-                                       unsigned int z = 0;
-                                       std::string x = "*";
+                                       ServerInstance->Log(DEBUG,"Mode sequence = '%s'",modesequence.c_str());
                                        irc::spacesepstream sep(modesequence);
+                                       std::string modeletters = sep.GetToken();
+                                       ServerInstance->Log(DEBUG,"Mode letters = '%s'",modeletters.c_str());
                                        
-                                       while ((x = sep.GetToken()) != "")
+                                       while (!modeletters.empty())
                                        {
-                                               if (!z)
-                                               {
-                                                       y[z++] = c->name;
-                                                       items.push_back(c->name);
-                                                       items.push_back(ConvToStr(c->age));
-                                               }
-                                               items.push_back(x);
-                                               y[z++] = (items.end() - 1)->c_str();
+                                               char mletter = *(modeletters.begin());
+                                               modestack.Push(mletter,sep.GetToken());
+                                               ServerInstance->Log(DEBUG,"Push letter = '%c'",mletter);
+                                               modeletters.erase(modeletters.begin());
+                                               ServerInstance->Log(DEBUG,"Mode letters = '%s'",modeletters.c_str());
                                        }
+                               }
+                       }
 
-                                       DoOneToMany(Instance->Config->ServerName, "FMODE", items);
-                                       userrec* n = new userrec(Instance);
-                                       n->SetFd(FD_MAGIC_NUMBER);
-                                       Instance->SendMode(y,z,n);
-                                       delete n;
+                       while (modestack.GetStackedLine(stackresult))
+                       {
+                               ServerInstance->Log(DEBUG,"Stacked line size %d",stackresult.size());
+                               stackresult.push_front(ConvToStr(c->age));
+                               stackresult.push_front(c->name);
+                               DoOneToMany(Instance->Config->ServerName, "FMODE", stackresult);
+                               stackresult.erase(stackresult.begin() + 1);
+                               ServerInstance->Log(DEBUG,"Stacked items:");
+                               for (size_t z = 0; z < stackresult.size(); z++)
+                               {
+                                       y[z] = stackresult[z].c_str();
+                                       ServerInstance->Log(DEBUG,"\tstackresult[%d]='%s'",z,stackresult[z].c_str());
                                }
+                               userrec* n = new userrec(Instance);
+                               n->SetFd(FD_MAGIC_NUMBER);
+                               Instance->SendMode(y, stackresult.size(), n);
+                               delete n;
                        }
                }
                return true;
@@ -4852,7 +4884,7 @@ class ModuleSpanningTree : public Module
 
        virtual Version GetVersion()
        {
-               return Version(1,0,0,0,VF_STATIC|VF_VENDOR);
+               return Version(1,1,0,2,VF_STATIC|VF_VENDOR,API_VERSION);
        }
 
        void Implements(char* List)