]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Added User Counts to /map
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 09a3b2c56b2a0b302e62d858c3dbc290621f2b4c..ea5d0664afb981230167afe884559be31b740534 100644 (file)
@@ -73,6 +73,8 @@ using namespace std;
 class ModuleSpanningTree;
 static ModuleSpanningTree* TreeProtocolModule;
 
+extern ServerConfig* Config;
+
 extern std::vector<Module*> modules;
 extern std::vector<ircd_module*> factory;
 extern int MODCOUNT;
@@ -95,8 +97,6 @@ extern int MODCOUNT;
 enum ServerState { LISTENER, CONNECTING, WAIT_AUTH_1, WAIT_AUTH_2, CONNECTED };
 
 /* We need to import these from the core for use in netbursts */
-/*typedef nspace::hash_map<std::string, userrec*, nspace::hash<string>, irc::StrHashComp> user_hash;
-typedef nspace::hash_map<std::string, chanrec*, nspace::hash<string>, irc::StrHashComp> chan_hash;*/
 extern user_hash clientlist;
 extern chan_hash chanlist;
 
@@ -191,6 +191,7 @@ class TreeServer
                UserCount = OperCount = 0;
                VersionString = Srv->GetVersion();
                Route = NULL;
+               Socket = NULL; /* Fix by brain */
                AddHashEntry();
        }
 
@@ -294,17 +295,17 @@ class TreeServer
 
        std::string GetName()
        {
-               return this->ServerName;
+               return ServerName;
        }
 
        std::string GetDesc()
        {
-               return this->ServerDesc;
+               return ServerDesc;
        }
 
        std::string GetVersion()
        {
-               return this->VersionString;
+               return VersionString;
        }
 
        void SetNextPingTime(time_t t)
@@ -315,7 +316,7 @@ class TreeServer
 
        time_t NextPingTime()
        {
-               return this->NextPing;
+               return NextPing;
        }
 
        bool AnsweredLastPing()
@@ -330,22 +331,32 @@ class TreeServer
 
        int GetUserCount()
        {
-               return this->UserCount;
+               return UserCount;
+       }
+
+       void AddUserCount()
+       {
+               UserCount++;
+       }
+
+       void DelUserCount()
+       {
+               UserCount--;
        }
 
        int GetOperCount()
        {
-               return this->OperCount;
+               return OperCount;
        }
 
        TreeSocket* GetSocket()
        {
-               return this->Socket;
+               return Socket;
        }
 
        TreeServer* GetParent()
        {
-               return this->Parent;
+               return Parent;
        }
 
        void SetVersion(std::string Version)
@@ -538,7 +549,8 @@ class TreeSocket : public InspSocket
        time_t NextPing;
        bool LastPingWasGood;
        bool bursting;
-       AES* ctx;
+       AES* ctx_in;
+       AES* ctx_out;
        unsigned int keylength;
        
  public:
@@ -553,6 +565,8 @@ class TreeSocket : public InspSocket
        {
                myhost = host;
                this->LinkState = LISTENER;
+               this->ctx_in = NULL;
+               this->ctx_out = NULL;
        }
 
        TreeSocket(std::string host, int port, bool listening, unsigned long maxtime, std::string ServerName)
@@ -560,6 +574,8 @@ class TreeSocket : public InspSocket
        {
                myhost = ServerName;
                this->LinkState = CONNECTING;
+               this->ctx_in = NULL;
+               this->ctx_out = NULL;
        }
 
        /* When a listening socket gives us a new file descriptor,
@@ -570,31 +586,40 @@ class TreeSocket : public InspSocket
                : InspSocket(newfd, ip)
        {
                this->LinkState = WAIT_AUTH_1;
+               this->ctx_in = NULL;
+               this->ctx_out = NULL;
+               this->SendCapabilities();
        }
 
-       void InitAES(std::string key)
+       ~TreeSocket()
+       {
+               if (ctx_in)
+                       delete ctx_in;
+               if (ctx_out)
+                       delete ctx_out;
+       }
+
+       void InitAES(std::string key,std::string SName)
        {
                if (key == "")
                        return;
 
-               ctx = new AES();
+               ctx_in = new AES();
+               ctx_out = new AES();
                log(DEBUG,"Initialized AES key %s",key.c_str());
                // key must be 16, 24, 32 etc bytes (multiple of 8)
                keylength = key.length();
                if (!(keylength == 16 || keylength == 24 || keylength == 32))
                {
-                       WriteOpers("\2ERROR\2: Key length for encryptionkey is not 16, 24 or 32 bytes in length!");
+                       WriteOpers("*** \2ERROR\2: Key length for encryptionkey is not 16, 24 or 32 bytes in length!");
                        log(DEBUG,"Key length not 16, 24 or 32 characters!");
                }
                else
                {
-                       std::string SName = myhost;
-                       if (InboundServerName != "")
-                       {
-                               SName = InboundServerName;
-                       }
-                       WriteOpers("\2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
-                       ctx->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                       WriteOpers("*** \2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
+                       ctx_in->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                       ctx_out->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
                                \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
                }
        }
@@ -615,10 +640,18 @@ class TreeSocket : public InspSocket
                        {
                                if (x->Name == this->myhost)
                                {
+                                       this->SendCapabilities();
                                        if (x->EncryptionKey != "")
                                        {
-                                               this->WriteLine("AES "+Srv->GetServerName());
-                                               this->InitAES(x->EncryptionKey);
+                                               if (!(x->EncryptionKey.length() == 16 || x->EncryptionKey.length() == 24 || x->EncryptionKey.length() == 32))
+                                               {
+                                                       WriteOpers("\2WARNING\2: Your encryption key is NOT 16, 24 or 32 characters in length, encryption will \2NOT\2 be enabled.");
+                                               }
+                                               else
+                                               {
+                                                       this->WriteLine("AES "+Srv->GetServerName());
+                                                       this->InitAES(x->EncryptionKey,x->Name);
+                                               }
                                        }
                                        /* found who we're supposed to be connecting to, send the neccessary gubbins. */
                                        this->WriteLine("SERVER "+Srv->GetServerName()+" "+x->SendPass+" 0 :"+Srv->GetServerDescription());
@@ -676,6 +709,56 @@ class TreeSocket : public InspSocket
                }
        }
 
+       std::string MyCapabilities()
+       {
+               ServerConfig* Config = Srv->GetConfig();
+               std::vector<std::string> modlist;
+               std::string capabilities = "";
+
+                for (int i = 0; i <= MODCOUNT; i++)
+                {
+                       if ((modules[i]->GetVersion().Flags & VF_STATIC) || (modules[i]->GetVersion().Flags & VF_COMMON))
+                               modlist.push_back(Config->module_names[i]);
+                }
+               sort(modlist.begin(),modlist.end());
+               for (unsigned int i = 0; i < modlist.size(); i++)
+               {
+                       if (i)
+                               capabilities = capabilities + ",";
+                       capabilities = capabilities + modlist[i];
+               }
+               return capabilities;
+       }
+       
+       void SendCapabilities()
+       {
+               this->WriteLine("CAPAB "+MyCapabilities());
+       }
+
+       bool Capab(std::deque<std::string> params)
+       {
+               if (params.size() != 1)
+               {
+                       this->WriteLine("ERROR :Invalid number of parameters for CAPAB");
+                       return false;
+               }
+               if (params[0] != this->MyCapabilities())
+               {
+                       std::string quitserver = this->myhost;
+                       if (this->InboundServerName != "")
+                       {
+                               quitserver = this->InboundServerName;
+                       }
+                       WriteOpers("*** \2ERROR\2: Server '%s' does not have the same set of modules loaded, cannot link!",quitserver.c_str());
+                       WriteOpers("*** Our networked module set is: '%s'",this->MyCapabilities().c_str());
+                       WriteOpers("*** Other server's networked module set is: '%s'",params[0].c_str());
+                       WriteOpers("*** These lists must match exactly on both servers. Please correct these errors, and try again.");
+                       this->WriteLine("ERROR :CAPAB mismatch; My capabilities: '"+this->MyCapabilities()+"'");
+                       return false;
+               }
+               return true;
+       }
+
        /* This function forces this server to quit, removing this server
         * and any users on it (and servers and users below that, etc etc).
         * It's very slow and pretty clunky, but luckily unless your network
@@ -712,7 +795,7 @@ class TreeSocket : public InspSocket
         */
        void Squit(TreeServer* Current,std::string reason)
        {
-               if (Current)
+               if ((Current) && (Current != TreeRoot))
                {
                        std::deque<std::string> params;
                        params.push_back(Current->GetName());
@@ -981,6 +1064,13 @@ class TreeSocket : public InspSocket
                }
                params[7] = ":" + params[7];
                DoOneToAllButSender(source,"NICK",params,source);
+
+               // Increment the Source Servers User Count..
+               TreeServer* SourceServer = FindServer(source);
+               if (SourceServer) {
+                       SourceServer->AddUserCount();
+               }
+
                return true;
        }
 
@@ -1082,12 +1172,12 @@ class TreeSocket : public InspSocket
                                snprintf(data,MAXBUF,":%s FMODE %s +b %s",Srv->GetServerName().c_str(),c->second->name,b->data);
                                this->WriteLine(data);
                        }
-                       FOREACH_MOD OnSyncChannel(c->second,(Module*)TreeProtocolModule,(void*)this);
+                       FOREACH_MOD(I_OnSyncChannel,OnSyncChannel(c->second,(Module*)TreeProtocolModule,(void*)this));
                        list.clear();
                        c->second->GetExtList(list);
                        for (unsigned int j = 0; j < list.size(); j++)
                        {
-                               FOREACH_MOD OnSyncChannelMetaData(c->second,(Module*)TreeProtocolModule,(void*)this,list[j]);
+                               FOREACH_MOD(I_OnSyncChannelMetaData,OnSyncChannelMetaData(c->second,(Module*)TreeProtocolModule,(void*)this,list[j]));
                        }
                }
        }
@@ -1107,12 +1197,12 @@ class TreeSocket : public InspSocket
                                {
                                        this->WriteLine(":"+std::string(u->second->nick)+" OPERTYPE "+std::string(u->second->oper));
                                }
-                               FOREACH_MOD OnSyncUser(u->second,(Module*)TreeProtocolModule,(void*)this);
+                               FOREACH_MOD(I_OnSyncUser,OnSyncUser(u->second,(Module*)TreeProtocolModule,(void*)this));
                                list.clear();
                                u->second->GetExtList(list);
                                for (unsigned int j = 0; j < list.size(); j++)
                                {
-                                       FOREACH_MOD OnSyncUserMetaData(u->second,(Module*)TreeProtocolModule,(void*)this,list[j]);
+                                       FOREACH_MOD(I_OnSyncUserMetaData,OnSyncUserMetaData(u->second,(Module*)TreeProtocolModule,(void*)this,list[j]));
                                }
                        }
                }
@@ -1163,7 +1253,8 @@ class TreeSocket : public InspSocket
                                std::string ret = "";
                                while ((*line != '\n') && (strlen(line)))
                                {
-                                       ret = ret + *line;
+                                       if ((*line != '\r') && (*line != '\n'))
+                                               ret = ret + *line;
                                        line++;
                                }
                                if ((*line == '\n') || (*line == '\r'))
@@ -1172,17 +1263,26 @@ class TreeSocket : public InspSocket
                                /* Process this one, abort if it
                                 * didnt return true.
                                 */
-                               if (this->ctx)
+                               if (this->ctx_in)
                                {
                                        char out[1024];
                                        char result[1024];
+                                       memset(result,0,1024);
+                                       memset(out,0,1024);
                                        log(DEBUG,"Original string '%s'",ret.c_str());
-                                       int nbytes = from64tobits(out, ret.c_str(), 1024);
-                                       log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
-                                       ctx->Decrypt(out, result, nbytes, 0);
-                                       for (int t = 0; t < nbytes; t++)
-                                               if (result[t] == '\7') result[t] = 0;
-                                       ret = result;
+                                       /* ERROR + CAPAB is still allowed unencryped */
+                                       if ((ret.substr(0,7) != "ERROR :") && (ret.substr(0,6) != "CAPAB "))
+                                       {
+                                               int nbytes = from64tobits(out, ret.c_str(), 1024);
+                                               if ((nbytes > 0) && (nbytes < 1024))
+                                               {
+                                                       log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
+                                                       ctx_in->Decrypt(out, result, nbytes, 1);
+                                                       for (int t = 0; t < nbytes; t++)
+                                                               if (result[t] == '\7') result[t] = 0;
+                                                       ret = result;
+                                               }
+                                       }
                                }
                                if (!this->ProcessLine(ret))
                                {
@@ -1196,11 +1296,11 @@ class TreeSocket : public InspSocket
        int WriteLine(std::string line)
        {
                log(DEBUG,"OUT: %s",line.c_str());
-               if (this->ctx)
+               if (this->ctx_out)
                {
                        log(DEBUG,"AES context");
-                       char result[1024];
-                       char result64[1024];
+                       char result[10240];
+                       char result64[10240];
                        if (this->keylength)
                        {
                                while (line.length() % this->keylength != 0)
@@ -1209,10 +1309,11 @@ class TreeSocket : public InspSocket
                                        line = line + "\7";
                                }
                        }
-                       ctx->Encrypt(line.c_str(), result, line.length(),0);
-                       to64frombits((unsigned char*)result64,
-                                       (unsigned char*)result,
-                                       line.length());
+                       unsigned int ll = line.length();
+                       log(DEBUG,"Plaintext line with padding = %d chars",ll);
+                       ctx_out->Encrypt(line.c_str(), result, ll, 1);
+                       log(DEBUG,"Encrypted.");
+                       to64frombits((unsigned char*)result64,(unsigned char*)result,ll);
                        line = result64;
                        log(DEBUG,"Encrypted: %s",line.c_str());
                        //int from64tobits(char *out, const char *in, int maxlen);
@@ -1354,7 +1455,7 @@ class TreeSocket : public InspSocket
                                chanrec* c = Srv->FindChannel(params[0]);
                                if (c)
                                {
-                                       FOREACH_MOD OnDecodeMetaData(TYPE_CHANNEL,c,params[1],params[2]);
+                                       FOREACH_MOD(I_OnDecodeMetaData,OnDecodeMetaData(TYPE_CHANNEL,c,params[1],params[2]));
                                }
                        }
                        else
@@ -1362,7 +1463,7 @@ class TreeSocket : public InspSocket
                                userrec* u = Srv->FindNick(params[0]);
                                if (u)
                                {
-                                       FOREACH_MOD OnDecodeMetaData(TYPE_USER,u,params[1],params[2]);
+                                       FOREACH_MOD(I_OnDecodeMetaData,OnDecodeMetaData(TYPE_USER,u,params[1],params[2]));
                                }
                        }
                }
@@ -1541,6 +1642,7 @@ class TreeSocket : public InspSocket
                if (CheckDupe)
                {
                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
                        return false;
                }
                TreeServer* Node = new TreeServer(servername,description,ParentOfThis,NULL);
@@ -1561,6 +1663,7 @@ class TreeSocket : public InspSocket
                if (hops)
                {
                        this->WriteLine("ERROR :Server too far away for authentication");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, server is too far away for authentication");
                        return false;
                }
                std::string description = params[3];
@@ -1572,6 +1675,7 @@ class TreeSocket : public InspSocket
                                if (CheckDupe)
                                {
                                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
                                        return false;
                                }
                                // Begin the sync here. this kickstarts the
@@ -1592,6 +1696,7 @@ class TreeSocket : public InspSocket
                        }
                }
                this->WriteLine("ERROR :Invalid credentials");
+               Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, invalid link credentials");
                return false;
        }
 
@@ -1605,6 +1710,7 @@ class TreeSocket : public InspSocket
                if (hops)
                {
                        this->WriteLine("ERROR :Server too far away for authentication");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, server is too far away for authentication");
                        return false;
                }
                std::string description = params[3];
@@ -1616,6 +1722,17 @@ class TreeSocket : public InspSocket
                                if (CheckDupe)
                                {
                                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
+                                       return false;
+                               }
+                               /* If the config says this link is encrypted, but the remote side
+                                * hasnt bothered to send the AES command before SERVER, then we
+                                * boot them off as we MUST have this connection encrypted.
+                                */
+                               if ((x->EncryptionKey != "") && (!this->ctx_in))
+                               {
+                                       this->WriteLine("ERROR :This link requires AES encryption to be enabled. Plaintext connection refused.");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, remote server did not enable AES.");
                                        return false;
                                }
                                Srv->SendOpers("*** Verified incoming server connection from \002"+servername+"\002["+this->GetIP()+"] ("+description+")");
@@ -1630,6 +1747,7 @@ class TreeSocket : public InspSocket
                        }
                }
                this->WriteLine("ERROR :Invalid credentials");
+               Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, invalid link credentials");
                return false;
        }
 
@@ -1712,19 +1830,23 @@ class TreeSocket : public InspSocket
                        params.pop_front();
                }
 
-               if ((!this->ctx) && (command == "AES"))
+               if ((!this->ctx_in) && (command == "AES"))
                {
                         std::string sserv = params[0];
                         for (std::vector<Link>::iterator x = LinkBlocks.begin(); x < LinkBlocks.end(); x++)
                         {
                                 if ((x->EncryptionKey != "") && (x->Name == sserv))
                                 {
-                                        this->InitAES(x->EncryptionKey);
+                                        this->InitAES(x->EncryptionKey,sserv);
                                 }
                         }
                         return true;
                }
-               
+               else if ((this->ctx_in) && (command == "AES"))
+               {
+                       WriteOpers("*** \2AES\2: Encryption already enabled on this connection yet %s is trying to enable it twice!",params[0].c_str());
+               }
+
                switch (this->LinkState)
                {
                        TreeServer* Node;
@@ -1735,7 +1857,11 @@ class TreeSocket : public InspSocket
                                // replies with theirs if its happy, then if the initiator is happy,
                                // it starts to send its net sync, which starts the merge, otherwise
                                // it sends an ERROR.
-                               if (command == "SERVER")
+                               if (command == "PASS")
+                               {
+                                       /* Silently ignored */
+                               }
+                               else if (command == "SERVER")
                                {
                                        return this->Inbound_Server(params);
                                }
@@ -1743,6 +1869,20 @@ class TreeSocket : public InspSocket
                                {
                                        return this->Error(params);
                                }
+                               else if (command == "USER")
+                               {
+                                       this->WriteLine("ERROR :Client connections to this port are prohibited.");
+                                       return false;
+                               }
+                               else if (command == "CAPAB")
+                               {
+                                       return this->Capab(params);
+                               }
+                               else
+                               {
+                                       this->WriteLine("ERROR :Invalid command in negotiation phase.");
+                                       return false;
+                               }
                        break;
                        case WAIT_AUTH_2:
                                // Waiting for start of other side's netmerge to say they liked our
@@ -1771,6 +1911,10 @@ class TreeSocket : public InspSocket
                                {
                                        return this->Error(params);
                                }
+                               else if (command == "CAPAB")
+                               {
+                                       return this->Capab(params);
+                               }
                                
                        break;
                        case LISTENER:
@@ -1809,14 +1953,7 @@ class TreeSocket : public InspSocket
                                        if ((!route_back_again) || (route_back_again->GetSocket() != this))
                                        {
                                                if (route_back_again)
-                                               {
-                                                       WriteOpers("Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
-                                               }
-                                               else
-                                               {
-                                                       WriteOpers("Protocol violation: Invalid source '%s' in command '%s' from connection '%s'",direction.c_str(),line.c_str(),this->GetName().c_str());
-                                               }
-                                               
+                                                       log(DEBUG,"Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
                                                return true;
                                        }
                                }
@@ -2007,6 +2144,7 @@ class TreeSocket : public InspSocket
                {
                        Squit(s,"Remote host closed the connection");
                }
+               WriteOpers("Server '\2%s\2[%s]' closed the connection.",quitserver.c_str(),this->GetIP().c_str());
        }
 
        virtual int OnIncomingConnection(int newsock, char* ip)
@@ -2229,7 +2367,22 @@ void ReadConfiguration(bool rebind)
                }
                else
                {
-                       log(DEFAULT,"m_spanningtree: Invalid configuration for server '%s', ignored!",L.Name.c_str());
+                       if (L.RecvPass == "")
+                       {
+                               log(DEFAULT,"Invalid configuration for server '%s', recvpass not defined!",L.Name.c_str());
+                       }
+                       else if (L.SendPass == "")
+                       {
+                               log(DEFAULT,"Invalid configuration for server '%s', sendpass not defined!",L.Name.c_str());
+                       }
+                       else if (L.Name == "")
+                       {
+                               log(DEFAULT,"Invalid configuration, link tag without a name!");
+                       }
+                       else if (!L.Port)
+                       {
+                               log(DEFAULT,"Invalid configuration for server '%s', no port specified!",L.Name.c_str());
+                       }
                }
        }
        delete Conf;
@@ -2307,7 +2460,28 @@ class ModuleSpanningTree : public Module
                        {
                                matrix[line][t] = ' ';
                        }
-                       strlcpy(&matrix[line][depth],Current->GetName().c_str(),80);
+
+                       // For Aligning, we need to work out exactly how deep this thing is, and produce
+                       // a 'Spacer' String to compensate.
+                       char spacer[40];
+
+                       memset(spacer,' ',40);
+                       if ((40 - Current->GetName().length() - depth) > 1) {
+                               spacer[40 - Current->GetName().length() - depth] = '\0';
+                       } else {
+                               spacer[5] = '\0';
+                       }
+
+                       float percent;
+                       char text[80];
+                       if (clientlist.size() == 0) {
+                               // If there are no users, WHO THE HELL DID THE /MAP?!?!?!
+                               percent = 0;
+                       } else {
+                               percent = ((float)Current->GetUserCount() / (float)clientlist.size()) * 100;
+                       }
+                       snprintf(text, 80, "%s %s%d [%.2f%%]", Current->GetName().c_str(), spacer, Current->GetUserCount(), percent);
+                       strlcpy(&matrix[line][depth],text,80);
                        line++;
                        for (unsigned int q = 0; q < Current->ChildCount(); q++)
                        {
@@ -2382,9 +2556,15 @@ class ModuleSpanningTree : public Module
                TreeServer* s = FindServerMask(parameters[0]);
                if (s)
                {
+                       if (s == TreeRoot)
+                       {
+                                WriteServ(user->fd,"NOTICE %s :*** SQUIT: Foolish mortal, you cannot make a server SQUIT itself! (%s matches local server name)",user->nick,parameters[0]);
+                               return 1;
+                       }
                        TreeSocket* sock = s->GetSocket();
                        if (sock)
                        {
+                               log(DEBUG,"Splitting server %s",s->GetName().c_str());
                                WriteOpers("*** SQUIT: Server \002%s\002 removed from network by %s",parameters[0],user->nick);
                                sock->Squit(s,"Server quit by "+std::string(user->nick)+"!"+std::string(user->ident)+"@"+std::string(user->host));
                                sock->Close();
@@ -2518,7 +2698,7 @@ class ModuleSpanningTree : public Module
                {
                        for (unsigned int i = 0; i < LinkBlocks.size(); i++)
                        {
-                               WriteServ(user->fd,"213 %s C *@%s * %s %d 0 M",user->nick,LinkBlocks[i].IPAddr.c_str(),LinkBlocks[i].Name.c_str(),LinkBlocks[i].Port);
+                               WriteServ(user->fd,"213 %s C *@%s * %s %d 0 %s",user->nick,LinkBlocks[i].IPAddr.c_str(),LinkBlocks[i].Name.c_str(),LinkBlocks[i].Port,(LinkBlocks[i].EncryptionKey != "" ? "es" : " s"));
                                WriteServ(user->fd,"244 %s H * * %s",user->nick,LinkBlocks[i].Name.c_str());
                        }
                        WriteServ(user->fd,"219 %s %s :End of /STATS report",user->nick,parameters[0]);
@@ -2528,8 +2708,12 @@ class ModuleSpanningTree : public Module
                return false;
        }
 
-       virtual int OnPreCommand(std::string command, char **parameters, int pcnt, userrec *user)
+       virtual int OnPreCommand(std::string command, char **parameters, int pcnt, userrec *user, bool validated)
        {
+               /* If the command doesnt appear to be valid, we dont want to mess with it. */
+               if (!validated)
+                       return 0;
+
                if (command == "CONNECT")
                {
                        return this->HandleConnect(parameters,pcnt,user);
@@ -2784,6 +2968,13 @@ class ModuleSpanningTree : public Module
                        params.push_back(user->ip);
                        params.push_back(":"+std::string(user->fullname));
                        DoOneToMany(Srv->GetServerName(),"NICK",params);
+
+                       // User is Local, change needs to be reflected!
+                       TreeServer* SourceServer = FindServer(user->server);
+                       if (SourceServer) {
+                               SourceServer->AddUserCount();
+                       }
+
                }
        }
 
@@ -2795,6 +2986,12 @@ class ModuleSpanningTree : public Module
                        params.push_back(":"+reason);
                        DoOneToMany(user->nick,"QUIT",params);
                }
+               // Regardless, We need to modify the user Counts..
+               TreeServer* SourceServer = FindServer(user->server);
+               if (SourceServer) {
+                       SourceServer->DelUserCount();
+               }
+
        }
 
        virtual void OnUserPostNick(userrec* user, std::string oldnick)
@@ -2990,6 +3187,17 @@ class ModuleSpanningTree : public Module
        {
                return Version(1,0,0,0,VF_STATIC|VF_VENDOR);
        }
+
+       void Implements(char* List)
+       {
+               List[I_OnPreCommand] = List[I_OnGetServerDescription] = List[I_OnUserInvite] = List[I_OnPostLocalTopicChange] = 1;
+               List[I_OnWallops] = List[I_OnUserNotice] = List[I_OnUserMessage] = List[I_OnBackgroundTimer] = 1;
+               List[I_OnUserJoin] = List[I_OnChangeHost] = List[I_OnChangeName] = List[I_OnUserPart] = List[I_OnUserConnect] = 1;
+               List[I_OnUserQuit] = List[I_OnUserPostNick] = List[I_OnUserKick] = List[I_OnRemoteKill] = List[I_OnRehash] = 1;
+               List[I_OnOper] = List[I_OnAddGLine] = List[I_OnAddZLine] = List[I_OnAddQLine] = List[I_OnAddELine] = 1;
+               List[I_OnDelGLine] = List[I_OnDelZLine] = List[I_OnDelQLine] = List[I_OnDelELine] = List[I_ProtoSendMode] = List[I_OnMode] = 1;
+               List[I_ProtoSendMetaData] = 1;
+       }
 };