Added some missing parameter checking in m_swhois

[user/henk/code/inspircd.git] / src / modules / m_stripcolor.cpp

diff --git a/src/modules/m_stripcolor.cpp b/src/modules/m_stripcolor.cpp
index 25d2f5a495e9c6553bbc25e6193af0e4ae71359a..aad253bc740bfbc1445ed6e00b3ffa80556ece6d 100644 (file)
--- a/src/modules/m_stripcolor.cpp
+++ b/src/modules/m_stripcolor.cpp
@@ -112,52 +112,31 @@ class ModuleStripColor : public Module
                DELETE(csc);
        }
        
-       // ANSI colour stripping based on C example by Doc (Peter Wood)
        virtual void ReplaceLine(std::string &sentence)
        {
-               int i, a, len, remove;
-               len = sentence.length();
-
-               for (i = 0; i < len; i++)
-               {
-                       remove = 0;
-
-                       switch (sentence[i])
+               /* refactor this completely due to SQUIT bug since the old code would strip last char and replace with \0 --peavey */
+               int seq = 0;
+               std::string::iterator i,safei;
+               for (i = sentence.begin(); i != sentence.end(); ++i)
+               {
+                       if ((*i == 3))
+                               seq = 1;
+                       else if (seq && ( (*i >= '0') && (*i <= '9') || (*i == ',') ) )
                        {
-                               case 2:
-                               case 15:
-                               case 22:
-                               case 21:
-                               case 31:
-                                       remove++;
-                               break;
-
-                               case 3:
-                                       remove = 1;
-
-                                       if (isdigit(sentence[i + remove]))
-                                               remove++;
-
-                                       if (isdigit(sentence[i + remove]))
-                                               remove++;
-
-                                       if (sentence[i + remove] == ',')
-                                       {
-                                               remove += 2;
-
-                                               if (isdigit(sentence[i + remove]))
-                                                       remove++;
-                                       }
-                               break;
+                               seq++;
+                               if ( (seq <= 4) && (*i == ',') )
+                                       seq = 1;
+                               else if (seq > 3)
+                                       seq = 0;
                        }
-
-                       if (remove != 0)
+                       else
+                               seq = 0;
+                       
+                       if (seq || ((*i == 2) || (*i == 15) || (*i == 22) || (*i == 21) || (*i == 31)))
                        {
-                               len -= remove;
-
-                               for (a = i; a <= len; a++)
-                                       sentence[a] = sentence[a + remove];
-                               i--;
+                               safei = i;
+                               --i;
+                               sentence.erase(safei);
                        }
                }
        }
@@ -203,4 +182,4 @@ class ModuleStripColor : public Module
        
 };
 
-MODULE_INIT(ModuleStripColor);
+MODULE_INIT(ModuleStripColor)