]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_timedbans.cpp
m_timedbans Notice user when trying to set a ban that's already set
[user/henk/code/inspircd.git] / src / modules / m_timedbans.cpp
index d290ec18d260831f55a8100d02d7db03f2508685..b473277046c0af470fbd3afea566c89711090711 100644 (file)
@@ -1,16 +1,25 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2005-2008 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Robin Burchell <robin+git@viroteck.net>
  *
- * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 /* $ModDesc: Adds timed bans */
 
 #include "inspircd.h"
@@ -23,6 +32,7 @@ class TimedBan
        std::string channel;
        std::string mask;
        time_t expire;
+       Channel* chan;
 };
 
 typedef std::vector<TimedBan> timedbans;
@@ -32,6 +42,16 @@ timedbans TimedBanList;
  */
 class CommandTban : public Command
 {
+       static bool IsBanSet(Channel* chan, const std::string& mask)
+       {
+               for (BanList::const_iterator i = chan->bans.begin(); i != chan->bans.end(); ++i)
+               {
+                       if (!strcasecmp(i->data.c_str(), mask.c_str()))
+                               return true;
+               }
+               return false;
+       }
+
  public:
        CommandTban(Module* Creator) : Command(Creator,"TBAN", 3)
        {
@@ -53,41 +73,55 @@ class CommandTban : public Command
                        user->WriteNumeric(482, "%s %s :You do not have permission to set bans on this channel",
                                user->nick.c_str(), channel->name.c_str());
                        return CMD_FAILURE;
-               }
-               if (!ServerInstance->IsValidMask(parameters[2]))
-               {
-                       user->WriteServ("NOTICE "+std::string(user->nick)+" :Invalid ban mask");
-                       return CMD_FAILURE;
-               }
+               }               
+
                TimedBan T;
                std::string channelname = parameters[0];
                long duration = ServerInstance->Duration(parameters[1]);
                unsigned long expire = duration + ServerInstance->Time();
                if (duration < 1)
                {
-                       user->WriteServ("NOTICE "+std::string(user->nick)+" :Invalid ban time");
+                       user->WriteServ("NOTICE "+user->nick+" :Invalid ban time");
                        return CMD_FAILURE;
                }
                std::string mask = parameters[2];
                std::vector<std::string> setban;
                setban.push_back(parameters[0]);
                setban.push_back("+b");
-               setban.push_back(parameters[2]);
-               // use CallCommandHandler to make it so that the user sets the mode
+               bool isextban = ((mask.size() > 2) && (mask[1] == ':'));
+               if (!isextban && !ServerInstance->IsValidMask(mask))
+                       mask.append("!*@*");
+               if ((mask.length() > 250) || (!ServerInstance->IsValidMask(mask) && !isextban))
+               {
+                       user->WriteServ("NOTICE "+user->nick+" :Invalid ban mask");
+                       return CMD_FAILURE;
+               }
+
+               if (IsBanSet(channel, mask))
+               {
+                       user->WriteServ("NOTICE %s :Ban already set", user->nick.c_str());
+                       return CMD_FAILURE;
+               }
+
+               setban.push_back(mask);
+               // use CallHandler to make it so that the user sets the mode
                // themselves
-               ServerInstance->CallCommandHandler("MODE",setban,user);
-               for (BanList::iterator i = channel->bans.begin(); i != channel->bans.end(); i++)
-                       if (!strcasecmp(i->data.c_str(), mask.c_str()))
-                               goto found;
-               return CMD_FAILURE;
-found:
+               ServerInstance->Parser->CallHandler("MODE",setban,user);
+               if (!IsBanSet(channel, mask))
+                       return CMD_FAILURE;
+
                CUList tmp;
                T.channel = channelname;
                T.mask = mask;
-               T.expire = expire;
+               T.expire = expire + (IS_REMOTE(user) ? 5 : 0);
+               T.chan = channel;
                TimedBanList.push_back(T);
-               channel->WriteAllExcept(ServerInstance->FakeClient, true, '@', tmp, "NOTICE %s :%s added a timed ban on %s lasting for %ld seconds.", channel->name.c_str(), user->nick.c_str(), mask.c_str(), duration);
-               ServerInstance->PI->SendChannelNotice(channel, '@', user->nick + " added a timed ban on " + mask + " lasting for " + ConvToStr(duration) + " seconds.");
+
+               // If halfop is loaded, send notice to halfops and above, otherwise send to ops and above
+               ModeHandler* mh = ServerInstance->Modes->FindMode('h', MODETYPE_CHANNEL);
+               char pfxchar = (mh && mh->name == "halfop") ? '%' : '@';
+
+               channel->WriteAllExcept(ServerInstance->FakeClient, true, pfxchar, tmp, "NOTICE %s :%s added a timed ban on %s lasting for %ld seconds.", channel->name.c_str(), user->nick.c_str(), mask.c_str(), duration);
                return CMD_SUCCESS;
        }
 
@@ -97,6 +131,22 @@ found:
        }
 };
 
+class ChannelMatcher
+{
+       Channel* const chan;
+
+ public:
+       ChannelMatcher(Channel* ch)
+               : chan(ch)
+       {
+       }
+
+       bool operator()(const TimedBan& tb) const
+       {
+               return (tb.chan == chan);
+       }
+};
+
 class ModuleTimedBans : public Module
 {
        CommandTban cmd;
@@ -104,15 +154,13 @@ class ModuleTimedBans : public Module
        ModuleTimedBans()
                : cmd(this)
        {
-               ServerInstance->AddCommand(&cmd);
-               TimedBanList.clear();
-               Implementation eventlist[] = { I_OnDelBan, I_OnBackgroundTimer };
-               ServerInstance->Modules->Attach(eventlist, this, 2);
        }
 
-       virtual ~ModuleTimedBans()
+       void init()
        {
-               TimedBanList.clear();
+               ServerInstance->Modules->AddService(cmd);
+               Implementation eventlist[] = { I_OnDelBan, I_OnBackgroundTimer, I_OnChannelDelete };
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
        virtual ModResult OnDelBan(User* source, Channel* chan, const std::string &banmask)
@@ -134,32 +182,44 @@ class ModuleTimedBans : public Module
 
        virtual void OnBackgroundTimer(time_t curtime)
        {
+               timedbans expired;
                for (timedbans::iterator i = TimedBanList.begin(); i != TimedBanList.end();)
                {
                        if (curtime > i->expire)
                        {
-                               std::string chan = i->channel;
-                               std::string mask = i->mask;
-                               Channel* cr = ServerInstance->FindChan(chan);
+                               expired.push_back(*i);
                                i = TimedBanList.erase(i);
-                               if (cr)
-                               {
-                                       std::vector<std::string> setban;
-                                       setban.push_back(chan);
-                                       setban.push_back("-b");
-                                       setban.push_back(mask);
-
-                                       CUList empty;
-                                       std::string expiry = "*** Timed ban on " + chan + " expired.";
-                                       cr->WriteAllExcept(ServerInstance->FakeClient, true, '@', empty, "NOTICE %s :%s", cr->name.c_str(), expiry.c_str());
-                                       ServerInstance->PI->SendChannelNotice(cr, '@', expiry);
-
-                                       ServerInstance->SendGlobalMode(setban, ServerInstance->FakeClient);
-                               }
                        }
                        else
                                ++i;
                }
+
+               for (timedbans::iterator i = expired.begin(); i != expired.end(); i++)
+               {
+                       std::string chan = i->channel;
+                       std::string mask = i->mask;
+                       Channel* cr = ServerInstance->FindChan(chan);
+                       if (cr)
+                       {
+                               std::vector<std::string> setban;
+                               setban.push_back(chan);
+                               setban.push_back("-b");
+                               setban.push_back(mask);
+
+                               CUList empty;
+                               std::string expiry = "*** Timed ban on " + chan + " expired.";
+                               cr->WriteAllExcept(ServerInstance->FakeClient, true, '@', empty, "NOTICE %s :%s", cr->name.c_str(), expiry.c_str());
+                               ServerInstance->PI->SendChannelNotice(cr, '@', expiry);
+
+                               ServerInstance->SendGlobalMode(setban, ServerInstance->FakeClient);
+                       }
+               }
+       }
+
+       void OnChannelDelete(Channel* chan)
+       {
+               // Remove all timed bans affecting the channel from internal bookkeeping
+               TimedBanList.erase(std::remove_if(TimedBanList.begin(), TimedBanList.end(), ChannelMatcher(chan)), TimedBanList.end());
        }
 
        virtual Version GetVersion()