]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_xline_db.cpp
m_spanningtree Remove unneeded #includes
[user/henk/code/inspircd.git] / src / modules / m_xline_db.cpp
index 6caae07d7d1e67ff3071325cbc7cec8852d6e5c4..0c23527ee0bc9a6f81b12fc5de1136b5d8d62830 100644 (file)
 
 class ModuleXLineDB : public Module
 {
-       std::vector<XLine *> xlines;
-       bool reading_db;                        // If this is true, addlines are as a result of db reading, so don't bother flushing the db to disk.
-                                               // DO REMEMBER TO SET IT, otherwise it's annoying :P
+       bool dirty;
        std::string xlinedbpath;
  public:
-       ModuleXLineDB()         {
-               Implementation eventlist[] = { I_OnAddLine, I_OnDelLine, I_OnExpireLine };
-               ServerInstance->Modules->Attach(eventlist, this, 3);
-
+       void init()
+       {
                /* Load the configuration
                 * Note:
                 *              this is on purpose not in the OnRehash() method. It would be non-trivial to change the database on-the-fly.
@@ -44,14 +40,13 @@ class ModuleXLineDB : public Module
                 */
                ConfigTag* Conf = ServerInstance->Config->ConfValue("xlinedb");
                xlinedbpath = Conf->getString("filename", DATA_PATH "/xline.db");
-               
-               reading_db = true;
+
+               // Read xlines before attaching to events
                ReadDatabase();
-               reading_db = false;
-       }
 
-       virtual ~ModuleXLineDB()
-       {
+               Implementation eventlist[] = { I_OnAddLine, I_OnDelLine, I_OnExpireLine, I_OnBackgroundTimer };
+               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
+               dirty = false;
        }
 
        /** Called whenever an xline is added by a local user.
@@ -61,13 +56,7 @@ class ModuleXLineDB : public Module
         */
        void OnAddLine(User* source, XLine* line)
        {
-               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Adding a line");
-               xlines.push_back(line);
-
-               if (!reading_db)
-               {
-                       WriteDatabase();
-               }
+               dirty = true;
        }
 
        /** Called whenever an xline is deleted.
@@ -77,27 +66,21 @@ class ModuleXLineDB : public Module
         */
        void OnDelLine(User* source, XLine* line)
        {
-               RemoveLine(line);
+               dirty = true;
        }
 
        void OnExpireLine(XLine *line)
        {
-               RemoveLine(line);
+               dirty = true;
        }
 
-       void RemoveLine(XLine *line)
+       void OnBackgroundTimer(time_t now)
        {
-               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Removing a line");
-               for (std::vector<XLine *>::iterator i = xlines.begin(); i != xlines.end(); i++)
+               if (dirty)
                {
-                       if ((*i) == line)
-                       {
-                               xlines.erase(i);
-                               break;
-                       }
+                       if (WriteDatabase())
+                               dirty = false;
                }
-
-               WriteDatabase();
        }
 
        bool WriteDatabase()
@@ -110,17 +93,17 @@ class ModuleXLineDB : public Module
                 * Technically, that means that this can block, but I have *never* seen that.
                 *              -- w00t
                 */
-               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Opening temporary database");
+               ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Opening temporary database");
                std::string xlinenewdbpath = xlinedbpath + ".new";
                f = fopen(xlinenewdbpath.c_str(), "w");
                if (!f)
                {
-                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Cannot create database! %s (%d)", strerror(errno), errno);
+                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Cannot create database! %s (%d)", strerror(errno), errno);
                        ServerInstance->SNO->WriteToSnoMask('a', "database: cannot create new db: %s (%d)", strerror(errno), errno);
                        return false;
                }
 
-               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Opened. Writing..");
+               ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Opened. Writing..");
 
                /*
                 * Now, much as I hate writing semi-unportable formats, additional
@@ -132,22 +115,29 @@ class ModuleXLineDB : public Module
                fprintf(f, "VERSION 1\n");
 
                // Now, let's write.
-               XLine *line;
-               for (std::vector<XLine *>::iterator i = xlines.begin(); i != xlines.end(); i++)
+               std::vector<std::string> types = ServerInstance->XLines->GetAllTypes();
+               for (std::vector<std::string>::const_iterator it = types.begin(); it != types.end(); ++it)
                {
-                       line = (*i);
-                       fprintf(f, "LINE %s %s %s %lu %lu :%s\n", line->type.c_str(), line->Displayable(),
-                               ServerInstance->Config->ServerName.c_str(), (unsigned long)line->set_time, (unsigned long)line->duration, line->reason.c_str());
+                       XLineLookup* lookup = ServerInstance->XLines->GetAll(*it);
+                       if (!lookup)
+                               continue; // Not possible as we just obtained the list from XLineManager
+
+                       for (LookupIter i = lookup->begin(); i != lookup->end(); ++i)
+                       {
+                               XLine* line = i->second;
+                               fprintf(f, "LINE %s %s %s %lu %lu :%s\n", line->type.c_str(), line->Displayable(),
+                                       ServerInstance->Config->ServerName.c_str(), (unsigned long)line->set_time, (unsigned long)line->duration, line->reason.c_str());
+                       }
                }
 
-               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Finished writing XLines. Checking for error..");
+               ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Finished writing XLines. Checking for error..");
 
                int write_error = 0;
                write_error = ferror(f);
                write_error |= fclose(f);
                if (write_error)
                {
-                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Cannot write to new database! %s (%d)", strerror(errno), errno);
+                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Cannot write to new database! %s (%d)", strerror(errno), errno);
                        ServerInstance->SNO->WriteToSnoMask('a', "database: cannot write to new db: %s (%d)", strerror(errno), errno);
                        return false;
                }
@@ -155,7 +145,7 @@ class ModuleXLineDB : public Module
 #ifdef _WIN32
                if (remove(xlinedbpath.c_str()))
                {
-                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Cannot remove old database! %s (%d)", strerror(errno), errno);
+                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Cannot remove old database! %s (%d)", strerror(errno), errno);
                        ServerInstance->SNO->WriteToSnoMask('a', "database: cannot remove old database: %s (%d)", strerror(errno), errno);
                        return false;
                }
@@ -163,7 +153,7 @@ class ModuleXLineDB : public Module
                // Use rename to move temporary to new db - this is guarenteed not to fuck up, even in case of a crash.
                if (rename(xlinenewdbpath.c_str(), xlinedbpath.c_str()) < 0)
                {
-                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Cannot move new to old database! %s (%d)", strerror(errno), errno);
+                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Cannot move new to old database! %s (%d)", strerror(errno), errno);
                        ServerInstance->SNO->WriteToSnoMask('a', "database: cannot replace old with new db: %s (%d)", strerror(errno), errno);
                        return false;
                }
@@ -175,7 +165,6 @@ class ModuleXLineDB : public Module
        {
                FILE *f;
                char linebuf[MAXBUF];
-               unsigned int lineno = 0;
 
                f = fopen(xlinedbpath.c_str(), "r");
                if (!f)
@@ -188,7 +177,7 @@ class ModuleXLineDB : public Module
                        else
                        {
                                /* this might be slightly more problematic. */
-                               ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Cannot read database! %s (%d)", strerror(errno), errno);
+                               ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Cannot read database! %s (%d)", strerror(errno), errno);
                                ServerInstance->SNO->WriteToSnoMask('a', "database: cannot read db: %s (%d)", strerror(errno), errno);
                                return false;
                        }
@@ -207,33 +196,31 @@ class ModuleXLineDB : public Module
 
                                c++;
                        }
-                       // Smart man might think of initing to 1, and moving this to the bottom. Don't. We use continue in this loop.
-                       lineno++;
 
                        // Inspired by the command parser. :)
                        irc::tokenstream tokens(linebuf);
                        int items = 0;
-                       std::string command_p[MAXPARAMETERS];
+                       std::string command_p[7];
                        std::string tmp;
 
-                       while (tokens.GetToken(tmp) && (items < MAXPARAMETERS))
+                       while (tokens.GetToken(tmp) && (items < 7))
                        {
                                command_p[items] = tmp;
                                items++;
                        }
 
-                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Processing %s", linebuf);
+                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Processing %s", linebuf);
 
                        if (command_p[0] == "VERSION")
                        {
                                if (command_p[1] == "1")
                                {
-                                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: Reading db version %s", command_p[1].c_str());
+                                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: Reading db version %s", command_p[1].c_str());
                                }
                                else
                                {
                                        fclose(f);
-                                       ServerInstance->Logs->Log("m_xline_db",DEBUG, "xlinedb: I got database version %s - I don't understand it", command_p[1].c_str());
+                                       ServerInstance->Logs->Log("m_xline_db",LOG_DEBUG, "xlinedb: I got database version %s - I don't understand it", command_p[1].c_str());
                                        ServerInstance->SNO->WriteToSnoMask('a', "database: I got a database version (%s) I don't understand", command_p[1].c_str());
                                        return false;
                                }
@@ -265,8 +252,6 @@ class ModuleXLineDB : public Module
                return true;
        }
 
-
-
        virtual Version GetVersion()
        {
                return Version("Keeps a dynamic log of all XLines created, and stores them in a separate conf file (xline.db).", VF_VENDOR);
@@ -274,4 +259,3 @@ class ModuleXLineDB : public Module
 };
 
 MODULE_INIT(ModuleXLineDB)
-