Fix unsafe iteration in m_timedbans

[user/henk/code/inspircd.git] / src / modules / u_listmode.h

diff --git a/src/modules/u_listmode.h b/src/modules/u_listmode.h
index a798284030e25529200c92660fc6232b042396c3..c18ac0f71b92cc8fbb6aa14e902fd1a270f35b0f 100644 (file)
--- a/src/modules/u_listmode.h
+++ b/src/modules/u_listmode.h
@@ -222,11 +222,14 @@ class ListModeBase : public ModeHandler
                // Try and grab the list
                modelist* el = extItem.get(channel);
 
-               if (this->tidy)
-                       ModeParser::CleanMask(parameter);
-
                if (adding)
                {
+                       if (tidy)
+                               ModeParser::CleanMask(parameter);
+
+                       if (parameter.length() > 250)
+                               return MODEACTION_DENY;
+
                        // If there was no list
                        if (!el)
                        {