This segfaults atm. i'm working on it.

[user/henk/code/inspircd.git] / src / modules.cpp

diff --git a/src/modules.cpp b/src/modules.cpp
index 64b560d892a63752c050236177e32bf7cacbcbb9..c3315490ed5b02f238670d3efa6e5a12529f665e 100644 (file)
--- a/src/modules.cpp
+++ b/src/modules.cpp
@@ -66,7 +66,7 @@ Module* Request::GetDest()
        return this->dest;
 }
 
-char* Request::Send()
+const char* Request::Send()
 {
        if (this->dest)
        {
@@ -134,13 +134,13 @@ int               Module::OnKill(User*, User*, const std::string&) { return 0; }
 void           Module::OnLoadModule(Module*, const std::string&) { }
 void           Module::OnUnloadModule(Module*, const std::string&) { }
 void           Module::OnBackgroundTimer(time_t) { }
-int            Module::OnPreCommand(const std::string&, const char**, int, User *, bool, const std::string&) { return 0; }
-void           Module::OnPostCommand(const std::string&, const char**, int, User *, CmdResult, const std::string&) { }
+int            Module::OnPreCommand(const std::string&, const char* const*, int, User *, bool, const std::string&) { return 0; }
+void           Module::OnPostCommand(const std::string&, const char* const*, int, User *, CmdResult, const std::string&) { }
 bool           Module::OnCheckReady(User*) { return true; }
 int            Module::OnUserRegister(User*) { return 0; }
 int            Module::OnUserPreKick(User*, User*, Channel*, const std::string&) { return 0; }
 void           Module::OnUserKick(User*, User*, Channel*, const std::string&, bool&) { }
-int            Module::OnRawMode(User*, Channel*, const char, const std::string &, bool, int) { return 0; }
+int            Module::OnRawMode(User*, Channel*, const char, const std::string &, bool, int, bool) { return 0; }
 int            Module::OnCheckInvite(User*, Channel*) { return 0; }
 int            Module::OnCheckKey(User*, Channel*, const std::string&) { return 0; }
 int            Module::OnCheckLimit(User*, Channel*) { return 0; }
@@ -150,7 +150,7 @@ int         Module::OnChangeLocalUserHost(User*, const std::string&) { return 0; }
 int            Module::OnChangeLocalUserGECOS(User*, const std::string&) { return 0; }
 int            Module::OnLocalTopicChange(User*, Channel*, const std::string&) { return 0; }
 void           Module::OnEvent(Event*) { return; }
-char*          Module::OnRequest(Request*) { return NULL; }
+const char*            Module::OnRequest(Request*) { return NULL; }
 int            Module::OnPassCompare(Extensible* ex, const std::string &password, const std::string &input, const std::string& hashtype) { return 0; }
 void           Module::OnGlobalOper(User*) { }
 void           Module::OnPostConnect(User*) { }
@@ -192,6 +192,7 @@ void                Module::OnBuildExemptList(MessageType, Channel*, User*, char, CUList&, con
 void           Module::OnGarbageCollect() { }
 void           Module::OnBufferFlushed(User*) { }
 void           Module::OnText(User*, void*, int, const std::string&, char, CUList&) { }
+void           Module::OnRunTestSuite() { }
 
 
 ModuleManager::ModuleManager(InspIRCd* Ins) : ModCount(0), Instance(Ins)
@@ -380,21 +381,21 @@ bool ModuleManager::Load(const char* filename)
        if (!ServerConfig::DirValid(modfile))
        {
                LastModuleError = "Module " + filename_str + " is not within the modules directory.";
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
        
        if (!ServerConfig::FileExists(modfile))
        {
                LastModuleError = "Module file could not be found: " + filename_str;
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
        
        if (Modules.find(filename_str) != Modules.end())
        {       
                LastModuleError = "Module " + filename_str + " is already loaded, cannot load a module twice!";
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
                
@@ -419,12 +420,12 @@ bool ModuleManager::Load(const char* filename)
                                delete newmod;
                                delete newhandle;
                                LastModuleError = "Unable to load " + filename_str + ": Incorrect module API version: " + ConvToStr(v.API) + " (our version: " + ConvToStr(API_VERSION) + ")";
-                               Instance->Log(DEFAULT, LastModuleError);
+                               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                                return false;
                        }
                        else
                        {
-                               Instance->Log(DEFAULT,"New module introduced: %s (API version %d, Module version %d.%d.%d.%d)%s", filename, v.API, v.Major, v.Minor, v.Revision, v.Build, (!(v.Flags & VF_VENDOR) ? " [3rd Party]" : " [Vendor]"));
+                               Instance->Logs->Log("MODULE", DEFAULT,"New module introduced: %s (API version %d, Module version %d.%d.%d.%d)%s", filename, v.API, v.Major, v.Minor, v.Revision, v.Build, (!(v.Flags & VF_VENDOR) ? " [3rd Party]" : " [Vendor]"));
                        }
 
                        Modules[filename_str] = std::make_pair(newhandle, newmod);
@@ -433,7 +434,7 @@ bool ModuleManager::Load(const char* filename)
                {
                        delete newhandle;
                        LastModuleError = "Unable to load " + filename_str + ": Probably missing init_module() entrypoint, but dlsym() didn't notice a problem";
-                       Instance->Log(DEFAULT, LastModuleError);
+                       Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                        return false;
                }
        }
@@ -446,7 +447,7 @@ bool ModuleManager::Load(const char* filename)
                if (newhandle)
                        delete newhandle;
                LastModuleError = "Unable to load " + filename_str + ": Error when loading: " + modexcept.GetReason();
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
        catch (FindSymbolException& modexcept)
@@ -457,7 +458,7 @@ bool ModuleManager::Load(const char* filename)
                if (newhandle)
                        delete newhandle;
                LastModuleError = "Unable to load " + filename_str + ": Error finding symbol: " + modexcept.GetReason();
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
        catch (CoreException& modexcept)
@@ -468,7 +469,7 @@ bool ModuleManager::Load(const char* filename)
                if (newhandle)
                        delete newhandle;
                LastModuleError = "Unable to load " + filename_str + ": " + modexcept.GetReason();
-               Instance->Log(DEFAULT, LastModuleError);
+               Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
 
@@ -496,14 +497,14 @@ bool ModuleManager::Unload(const char* filename)
                if (modfind->second.second->GetVersion().Flags & VF_STATIC)
                {
                        LastModuleError = "Module " + filename_str + " not unloadable (marked static)";
-                       Instance->Log(DEFAULT, LastModuleError);
+                       Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                        return false;
                }
                std::pair<int,std::string> intercount = GetInterfaceInstanceCount(modfind->second.second);
                if (intercount.first > 0)
                {
                        LastModuleError = "Failed to unload module " + filename_str + ", being used by " + ConvToStr(intercount.first) + " other(s) via interface '" + intercount.second + "'";
-                       Instance->Log(DEFAULT, LastModuleError);
+                       Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                        return false;
                }
 
@@ -531,14 +532,14 @@ bool ModuleManager::Unload(const char* filename)
                delete modfind->second.first;
                Modules.erase(modfind);
 
-               Instance->Log(DEFAULT,"Module %s unloaded",filename);
+               Instance->Logs->Log("MODULE", DEFAULT,"Module %s unloaded",filename);
                this->ModCount--;
                Instance->BuildISupport();
                return true;
        }
 
        LastModuleError = "Module " + filename_str + " is not loaded, cannot unload it!";
-       Instance->Log(DEFAULT, LastModuleError);
+       Instance->Logs->Log("MODULE", DEFAULT, LastModuleError);
        return false;
 }
 
@@ -550,14 +551,17 @@ void ModuleManager::LoadAll()
 
        for(int count = 0; count < Instance->Config->ConfValueEnum(Instance->Config->config_data, "module"); count++)
        {
-               Instance->Config->ConfValue(Instance->Config->config_data, "module", "name", count, configToken, MAXBUF);
-               printf_c("[\033[1;32m*\033[0m] Loading module:\t\033[1;32m%s\033[0m\n",configToken);
-               
-               if (!this->Load(configToken))           
+               if (!this->Find(configToken))
                {
-                       Instance->Log(DEFAULT, this->LastError());
-                       printf_c("\n[\033[1;31m*\033[0m] %s\n\n", this->LastError().c_str());
-                       Instance->Exit(EXIT_STATUS_MODULE);
+                       Instance->Config->ConfValue(Instance->Config->config_data, "module", "name", count, configToken, MAXBUF);
+                       printf_c("[\033[1;32m*\033[0m] Loading module:\t\033[1;32m%s\033[0m\n",configToken);
+                       
+                       if (!this->Load(configToken))           
+                       {
+                               Instance->Logs->Log("MODULE", DEFAULT, this->LastError());
+                               printf_c("\n[\033[1;31m*\033[0m] %s\n\n", this->LastError().c_str());
+                               Instance->Exit(EXIT_STATUS_MODULE);
+                       }
                }
        }
 }
@@ -720,7 +724,7 @@ bool InspIRCd::MatchText(const std::string &sliteral, const std::string &spatter
        return match(sliteral.c_str(),spattern.c_str());
 }
 
-CmdResult InspIRCd::CallCommandHandler(const std::string &commandname, const char** parameters, int pcnt, User* user)
+CmdResult InspIRCd::CallCommandHandler(const std::string &commandname, const char* const* parameters, int pcnt, User* user)
 {
        return this->Parser->CallHandler(commandname,parameters,pcnt,user);
 }
@@ -739,7 +743,7 @@ void InspIRCd::AddCommand(Command *f)
        }
 }
 
-void InspIRCd::SendMode(const char** parameters, int pcnt, User *user)
+void InspIRCd::SendMode(const char* const* parameters, int pcnt, User *user)
 {
        this->Modes->Process(parameters,pcnt,user,true);
 }