]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules.cpp
Fix module unmapping with culled Module objects
[user/henk/code/inspircd.git] / src / modules.cpp
index 169a3a352746794ab3203fa58f0bb0929fcd9d3b..f1e53deba59056c952f5bb1b594eb19c8a36e469 100644 (file)
@@ -11,8 +11,6 @@
  * ---------------------------------------------------
  */
 
-/* $Core */
-
 #include "inspircd.h"
 #include "xline.h"
 #include "socket.h"
@@ -56,7 +54,6 @@ void Event::Send()
 Module::Module() { }
 bool Module::cull()
 {
-       ServerInstance->GlobalCulls.AddItem(ModuleDLLFactory);
        return true;
 }
 Module::~Module() { }
@@ -85,8 +82,8 @@ void          Module::OnUserPostNick(User*, const std::string&) { }
 ModResult      Module::OnPreMode(User*, User*, Channel*, const std::vector<std::string>&) { return MOD_RES_PASSTHRU; }
 void           Module::On005Numeric(std::string&) { }
 ModResult      Module::OnKill(User*, User*, const std::string&) { return MOD_RES_PASSTHRU; }
-void           Module::OnLoadModule(Module*, const std::string&) { }
-void           Module::OnUnloadModule(Module*, const std::string&) { }
+void           Module::OnLoadModule(Module*) { }
+void           Module::OnUnloadModule(Module*) { }
 void           Module::OnBackgroundTimer(time_t) { }
 ModResult      Module::OnPreCommand(std::string&, std::vector<std::string>&, User *, bool, const std::string&) { return MOD_RES_PASSTHRU; }
 void           Module::OnPostCommand(const std::string&, const std::vector<std::string>&, User *, CmdResult, const std::string&) { }
@@ -372,74 +369,43 @@ bool ModuleManager::Load(const char* filename)
        }
 
        Module* newmod = NULL;
-       DLLFactory* newhandle = NULL;
+       DLLManager* newhandle = new DLLManager(modfile);
 
        try
        {
-               /* This will throw a CoreException if there's a problem loading
-                * the module file or getting a pointer to the init_module symbol.
-                */
-               newhandle = new DLLFactory(modfile, "init_module");
-               if (newhandle->init_func)
-                       newmod = newhandle->init_func();
+               newmod = newhandle->callInit();
 
                if (newmod)
                {
                        newmod->ModuleSourceFile = filename_str;
-                       newmod->ModuleDLLFactory = newhandle;
+                       newmod->ModuleDLLManager = newhandle;
                        Version v = newmod->GetVersion();
 
-                       ServerInstance->Logs->Log("MODULE", DEFAULT,"New module introduced: %s (Module version %s)%s", filename, v.version.c_str(), (!(v.Flags & VF_VENDOR) ? " [3rd Party]" : " [Vendor]"));
+                       ServerInstance->Logs->Log("MODULE", DEFAULT,"New module introduced: %s (Module version %s)%s",
+                               filename, v.version.c_str(), (!(v.Flags & VF_VENDOR) ? " [3rd Party]" : " [Vendor]"));
 
                        Modules[filename_str] = newmod;
                }
                else
                {
-                       delete newhandle;
-                       LastModuleError = "Unable to load " + filename_str + ": Probably missing init_module() entrypoint, but dlsym() didn't notice a problem";
+                       LastModuleError = "Unable to load " + filename_str + ": " + newhandle->LastError();
                        ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
+                       delete newhandle;
                        return false;
                }
        }
-       /** XXX: Is there anything we can do about this mess? -- Brain
-        * Yeah, don't use exceptions without RAII. -- Daniel
-        */
-       catch (LoadModuleException& modexcept)
-       {
-               DetachAll(newmod);
-               if (newmod)
-                       delete newmod;
-               if (newhandle)
-                       delete newhandle;
-               LastModuleError = "Unable to load " + filename_str + ": Error when loading: " + modexcept.GetReason();
-               ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
-               return false;
-       }
-       catch (FindSymbolException& modexcept)
-       {
-               DetachAll(newmod);
-               if (newmod)
-                       delete newmod;
-               if (newhandle)
-                       delete newhandle;
-               LastModuleError = "Unable to load " + filename_str + ": Error finding symbol: " + modexcept.GetReason();
-               ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
-               return false;
-       }
        catch (CoreException& modexcept)
        {
-               DetachAll(newmod);
-               if (newmod)
-                       delete newmod;
-               if (newhandle)
-                       delete newhandle;
+               // failure in module constructor
+               delete newmod;
+               delete newhandle;
                LastModuleError = "Unable to load " + filename_str + ": " + modexcept.GetReason();
                ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
                return false;
        }
 
        this->ModCount++;
-       FOREACH_MOD(I_OnLoadModule,OnLoadModule(newmod, filename_str));
+       FOREACH_MOD(I_OnLoadModule,OnLoadModule(newmod));
 
        /* We give every module a chance to re-prioritize when we introduce a new one,
         * not just the one thats loading, as the new module could affect the preference
@@ -461,72 +427,124 @@ bool ModuleManager::Load(const char* filename)
        return true;
 }
 
-bool ModuleManager::Unload(const char* filename)
+bool ModuleManager::CanUnload(Module* mod)
 {
-       std::string filename_str(filename);
-       std::map<std::string, Module*>::iterator modfind = Modules.find(filename);
+       std::map<std::string, Module*>::iterator modfind = Modules.find(mod->ModuleSourceFile);
 
-       if (modfind != Modules.end())
+       if (modfind == Modules.end() || modfind->second != mod)
        {
-               if (modfind->second->GetVersion().Flags & VF_STATIC)
-               {
-                       LastModuleError = "Module " + filename_str + " not unloadable (marked static)";
-                       ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
-                       return false;
-               }
-               std::pair<int,std::string> intercount = GetInterfaceInstanceCount(modfind->second);
-               if (intercount.first > 0)
-               {
-                       LastModuleError = "Failed to unload module " + filename_str + ", being used by " + ConvToStr(intercount.first) + " other(s) via interface '" + intercount.second + "'";
-                       ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
-                       return false;
-               }
+               LastModuleError = "Module " + mod->ModuleSourceFile + " is not loaded, cannot unload it!";
+               ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
+               return false;
+       }
+       if (mod->GetVersion().Flags & VF_STATIC)
+       {
+               LastModuleError = "Module " + mod->ModuleSourceFile + " not unloadable (marked static)";
+               ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
+               return false;
+       }
+       std::pair<int,std::string> intercount = GetInterfaceInstanceCount(mod);
+       if (intercount.first > 0)
+       {
+               LastModuleError = "Failed to unload module " + mod->ModuleSourceFile + ", being used by " + ConvToStr(intercount.first) + " other(s) via interface '" + intercount.second + "'";
+               ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
+               return false;
+       }
+       return true;
+}
 
-               std::vector<ExtensionItem*> items = Extensible::BeginUnregister(modfind->second);
-               /* Give the module a chance to tidy out all its metadata */
-               for (chan_hash::iterator c = ServerInstance->chanlist->begin(); c != ServerInstance->chanlist->end(); c++)
-               {
-                       modfind->second->OnCleanup(TYPE_CHANNEL,c->second);
-                       c->second->doUnhookExtensions(items);
-                       const UserMembList* users = c->second->GetUsers();
-                       for(UserMembCIter mi = users->begin(); mi != users->end(); mi++)
-                               mi->second->doUnhookExtensions(items);
-               }
-               for (user_hash::iterator u = ServerInstance->Users->clientlist->begin(); u != ServerInstance->Users->clientlist->end(); u++)
-               {
-                       modfind->second->OnCleanup(TYPE_USER,u->second);
-                       u->second->doUnhookExtensions(items);
-               }
+void ModuleManager::DoSafeUnload(Module* mod)
+{
+       std::map<std::string, Module*>::iterator modfind = Modules.find(mod->ModuleSourceFile);
 
-               /* Tidy up any dangling resolvers */
-               ServerInstance->Res->CleanResolvers(modfind->second);
+       std::vector<ExtensionItem*> items;
+       ServerInstance->Extensions.BeginUnregister(modfind->second, items);
+       /* Give the module a chance to tidy out all its metadata */
+       for (chan_hash::iterator c = ServerInstance->chanlist->begin(); c != ServerInstance->chanlist->end(); c++)
+       {
+               mod->OnCleanup(TYPE_CHANNEL,c->second);
+               c->second->doUnhookExtensions(items);
+               const UserMembList* users = c->second->GetUsers();
+               for(UserMembCIter mi = users->begin(); mi != users->end(); mi++)
+                       mi->second->doUnhookExtensions(items);
+       }
+       for (user_hash::iterator u = ServerInstance->Users->clientlist->begin(); u != ServerInstance->Users->clientlist->end(); u++)
+       {
+               mod->OnCleanup(TYPE_USER,u->second);
+               u->second->doUnhookExtensions(items);
+       }
 
-               FOREACH_MOD(I_OnUnloadModule,OnUnloadModule(modfind->second, modfind->first));
+       /* Tidy up any dangling resolvers */
+       ServerInstance->Res->CleanResolvers(mod);
 
-               this->DetachAll(modfind->second);
+       FOREACH_MOD(I_OnUnloadModule,OnUnloadModule(mod));
 
-               ServerInstance->Parser->RemoveCommands(modfind->second);
-               ServerInstance->Modes->RemoveModes(modfind->second);
+       DetachAll(mod);
 
-               ServerInstance->GlobalCulls.AddItem(modfind->second);
-               Modules.erase(modfind);
+       Modules.erase(modfind);
+       ServerInstance->GlobalCulls.AddItem(mod);
 
-               ServerInstance->Logs->Log("MODULE", DEFAULT,"Module %s unloaded",filename);
-               this->ModCount--;
-               ServerInstance->BuildISupport();
-               return true;
-       }
+       ServerInstance->Logs->Log("MODULE", DEFAULT,"Module %s unloaded",mod->ModuleSourceFile.c_str());
+       this->ModCount--;
+       ServerInstance->BuildISupport();
+}
 
-       LastModuleError = "Module " + filename_str + " is not loaded, cannot unload it!";
-       ServerInstance->Logs->Log("MODULE", DEFAULT, LastModuleError);
-       return false;
+namespace {
+       struct UnloadAction : public HandlerBase0<void>
+       {
+               Module* const mod;
+               UnloadAction(Module* m) : mod(m) {}
+               void Call()
+               {
+                       DLLManager* dll = mod->ModuleDLLManager;
+                       ServerInstance->Modules->DoSafeUnload(mod);
+                       ServerInstance->GlobalCulls.Apply();
+                       delete dll;
+                       ServerInstance->GlobalCulls.AddItem(this);
+               }
+       };
+
+       struct ReloadAction : public HandlerBase0<void>
+       {
+               Module* const mod;
+               HandlerBase1<void, bool>* const callback;
+               ReloadAction(Module* m, HandlerBase1<void, bool>* c)
+                       : mod(m), callback(c) {}
+               void Call()
+               {
+                       DLLManager* dll = mod->ModuleDLLManager;
+                       std::string name = mod->ModuleSourceFile;
+                       ServerInstance->Modules->DoSafeUnload(mod);
+                       ServerInstance->GlobalCulls.Apply();
+                       delete dll;
+                       bool rv = ServerInstance->Modules->Load(name.c_str());
+                       callback->Call(rv);
+                       ServerInstance->GlobalCulls.AddItem(this);
+               }
+       };
+}
+
+bool ModuleManager::Unload(Module* mod)
+{
+       if (!CanUnload(mod))
+               return false;
+       ServerInstance->AtomicActions.AddAction(new UnloadAction(mod));
+       return true;
+}
+
+void ModuleManager::Reload(Module* mod, HandlerBase1<void, bool>* callback)
+{
+       if (CanUnload(mod))
+               ServerInstance->AtomicActions.AddAction(new ReloadAction(mod, callback));
+       else
+               callback->Call(false);
 }
 
 /* We must load the modules AFTER initializing the socket engine, now */
 void ModuleManager::LoadAll()
 {
        char configToken[MAXBUF];
-       ModCount = -1;
+       ModCount = 0;
 
        printf("\nLoading core commands");
        fflush(stdout);
@@ -568,6 +586,29 @@ void ModuleManager::LoadAll()
        }
 }
 
+void ModuleManager::UnloadAll()
+{
+       /* We do this more than once, so that any service providers get a
+        * chance to be unhooked by the modules using them, but then get
+        * a chance to be removed themsleves.
+        *
+        * Note: this deliberately does NOT delete the DLLManager objects
+        */
+       for (int tries = 0; tries < 4; tries++)
+       {
+               std::map<std::string, Module*>::iterator i = Modules.begin();
+               while (i != Modules.end())
+               {
+                       std::map<std::string, Module*>::iterator me = i++;
+                       if (CanUnload(me->second))
+                       {
+                               ServerInstance->GlobalCulls.AddItem(me->second);
+                       }
+               }
+               ServerInstance->GlobalCulls.Apply();
+       }
+}
+
 bool ModuleManager::PublishFeature(const std::string &FeatureName, Module* Mod)
 {
        if (Features.find(FeatureName) == Features.end())
@@ -701,24 +742,6 @@ const std::string& ModuleManager::GetModuleName(Module* m)
        return nothing;
 }
 
-/* This is ugly, yes, but hash_map's arent designed to be
- * addressed in this manner, and this is a bit of a kludge.
- * Luckily its a specialist function and rarely used by
- * many modules (in fact, it was specially created to make
- * m_safelist possible, initially).
- */
-
-Channel* InspIRCd::GetChannelIndex(long index)
-{
-       int target = 0;
-       for (chan_hash::iterator n = this->chanlist->begin(); n != this->chanlist->end(); n++, target++)
-       {
-               if (index == target)
-                       return n->second;
-       }
-       return NULL;
-}
-
 CmdResult InspIRCd::CallCommandHandler(const std::string &commandname, const std::vector<std::string>& parameters, User* user)
 {
        return this->Parser->CallHandler(commandname, parameters, user);
@@ -731,10 +754,9 @@ bool InspIRCd::IsValidModuleCommand(const std::string &commandname, int pcnt, Us
 
 void InspIRCd::AddCommand(Command *f)
 {
-       if (!this->Parser->CreateCommand(f))
+       if (!this->Parser->AddCommand(f))
        {
-               ModuleException err("Command "+std::string(f->command)+" already exists.");
-               throw (err);
+               throw ModuleException("Command "+std::string(f->command)+" already exists.");
        }
 }