Fixed an issue that could cause empty parameters in module commands to not be sent...

[user/henk/code/inspircd.git] / src / server.cpp

diff --git a/src/server.cpp b/src/server.cpp
index a18610fab9a6d42b3e797a723df0572b29bdc63a..2722c6831966840b145ad9f0c59bce05e88c2499 100644 (file)
--- a/src/server.cpp
+++ b/src/server.cpp
@@ -69,15 +69,13 @@ void InspIRCd::RehashServer()
 std::string InspIRCd::GetVersionString()
 {
        char versiondata[MAXBUF];
-       char dnsengine[] = "singlethread-object";
-
        if (*Config->CustomVersion)
        {
                snprintf(versiondata,MAXBUF,"%s %s :%s",VERSION,Config->ServerName,Config->CustomVersion);
        }
        else
        {
-               snprintf(versiondata,MAXBUF,"%s %s :%s [FLAGS=%s,%s,%s]",VERSION,Config->ServerName,SYSTEM,REVISION,SE->GetName().c_str(),dnsengine);
+               snprintf(versiondata,MAXBUF,"%s %s :%s [FLAGS=%s,%s,%d]",VERSION,Config->ServerName,SYSTEM,REVISION,SE->GetName().c_str(),Config->sid);
        }
        return versiondata;
 }
@@ -136,10 +134,12 @@ bool InspIRCd::FindServerName(const std::string &servername)
  */
 std::string InspIRCd::GetUID()
 {
-       bool HasUID = false;
        int i;
 
-       while (!HasUID)
+       /*
+        * This will only finish once we return a UUID that is not in use.
+        */
+       while (1)
        {
                /*
                 * Okay. The rules for generating a UID go like this...
@@ -171,22 +171,35 @@ std::string InspIRCd::GetUID()
                                current_uid[i]++;
                        }
 
-                       /*
-                        * XXX!
-                        * Check if it's in use here, continue; if it is!
-                        * This will only be an issue once we have a server that gets
-                        * an assload of connections, but.. -- w00t
-                        *
-                        * Until we have a map to check, just bail. -- w00t
-                        */
                        if (current_uid[3] == 'Z')
                        {
-                               InspIRCd::Exit(0);
+                               /*
+                                * Ugh. We have run out of room.. roll back around to the
+                                * start of the UUID namespace. -- w00t
+                                */
+                               this->InitialiseUID();
+
+                               /*
+                                * and now we need to break the inner for () to continue the while (),
+                                * which will start the checking process over again. -- w00t
+                                */
+                               break;
+                               
                        }
                        
-                       return std::string(current_uid);
+                       if (this->FindUUID(current_uid))
+                       {
+                               /*
+                                * It's in use. We need to try the loop again.
+                                */
+                               continue;
+                       }
+
+                       return current_uid;
                }
        }
+
+       /* not reached. */
        return "";
 }