]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/socket.cpp
Removed a pointless check in ./configure --clean that made it only work with one...
[user/henk/code/inspircd.git] / src / socket.cpp
index eaa8e0d8cb0e164735972728dbab507548f7408d..b286ee96fe1b977cb994c664ee4cbd692aa50863 100644 (file)
@@ -2,14 +2,11 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                    E-mail:
- *             <brain@chatspike.net>
- *               <Craig@chatspike.net>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
+ *
  * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
@@ -21,7 +18,6 @@
 #include "socketengine.h"
 #include "wildcard.h"
 
-using namespace std;
 using namespace irc::sockets;
 
 /* Used when comparing CIDR masks for the modulus bits left over.
@@ -51,7 +47,7 @@ ListenSocket::ListenSocket(InspIRCd* Instance, int sockfd, insp_sockaddr client,
        }
 }
 
-void ListenSocket::HandleEvent(EventType et)
+void ListenSocket::HandleEvent(EventType et, int errornum)
 {
        insp_sockaddr sock_us;  // our port number
        socklen_t uslen;        // length of our port number
@@ -84,9 +80,9 @@ void ListenSocket::HandleEvent(EventType et)
                                ServerInstance->Config->GetIOHook(in_port)->OnRawSocketAccept(incomingSockfd, insp_ntoa(client.sin_addr), in_port);
 #endif
                        }
-                       catch (ModuleException& modexcept)
+                       catch (CoreException& modexcept)
                        {
-                               ServerInstance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
+                               ServerInstance->Log(DEBUG,"%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
                        }
                }
                ServerInstance->stats->statsAccept++;
@@ -215,6 +211,7 @@ bool irc::sockets::MatchCIDR(const char* address, const char* cidr_mask, bool ma
        else
        {
                /* No 'number of bits' field! */
+               free(mask);
                return false;
        }
 
@@ -388,98 +385,83 @@ bool InspIRCd::HasPort(int port, char* addr)
 }
 
 /* XXX: Probably belongs in class InspIRCd */
-int InspIRCd::BindPorts(bool bail)
+int InspIRCd::BindPorts(bool bail, int &ports_found, FailedPortList &failed_ports)
 {
        char configToken[MAXBUF], Addr[MAXBUF], Type[MAXBUF];
        insp_sockaddr client, server;
        int clientportcount = 0;
        int BoundPortCount = 0;
 
-       if (!bail)
+       ports_found = 0;
+
+       int InitialPortCount = stats->BoundPortCount;
+       this->Log(DEBUG,"Initial port count: %d",InitialPortCount);
+
+       for (int count = 0; count < Config->ConfValueEnum(Config->config_data, "bind"); count++)
        {
-               int InitialPortCount = stats->BoundPortCount;
-               this->Log(DEBUG,"Initial port count: %d",InitialPortCount);
+               Config->ConfValue(Config->config_data, "bind", "port", count, configToken, MAXBUF);
+               Config->ConfValue(Config->config_data, "bind", "address", count, Addr, MAXBUF);
+               Config->ConfValue(Config->config_data, "bind", "type", count, Type, MAXBUF);
 
-               for (int count = 0; count < Config->ConfValueEnum(Config->config_data, "bind"); count++)
+               if ((!*Type) || (!strcmp(Type,"clients")))
                {
-                       Config->ConfValue(Config->config_data, "bind", "port", count, configToken, MAXBUF);
-                       Config->ConfValue(Config->config_data, "bind", "address", count, Addr, MAXBUF);
-                       Config->ConfValue(Config->config_data, "bind", "type", count, Type, MAXBUF);
-
-                       if (((!*Type) || (!strcmp(Type,"clients"))) && (!HasPort(atoi(configToken),Addr)))
+                       irc::portparser portrange(configToken, false);
+                       long portno = -1;
+                       while ((portno = portrange.GetToken()))
                        {
-                               // modules handle server bind types now
-                               Config->ports[clientportcount+InitialPortCount] = atoi(configToken);
-                               if (*Addr == '*')
-                                       *Addr = 0;
-
-                               strlcpy(Config->addrs[clientportcount+InitialPortCount],Addr,256);
-                               clientportcount++;
-                               this->Log(DEBUG,"NEW binding %s:%s [%s] from config",Addr,configToken, Type);
+                               if (!HasPort(portno, Addr))
+                               {
+                                       ports_found++;
+                                       Config->ports[clientportcount+InitialPortCount] = portno;
+                                       if (*Addr == '*')
+                                               *Addr = 0;
+
+                                       strlcpy(Config->addrs[clientportcount+InitialPortCount],Addr,256);
+                                       clientportcount++;
+                                       this->Log(DEBUG,"NEW binding %s:%d [%s] from config",Addr, portno, Type);
+                               }
                        }
                }
-               int PortCount = clientportcount;
-               if (PortCount)
+
+               if (!bail)
                {
-                       BoundPortCount = stats->BoundPortCount;
-                       for (int count = InitialPortCount; count < InitialPortCount + PortCount; count++)
+                       int PortCount = clientportcount;
+                       if (PortCount)
                        {
-                               int fd = OpenTCPSocket();
-                               if (fd == ERROR)
+                               BoundPortCount = stats->BoundPortCount;
+                               for (int count = InitialPortCount; count < InitialPortCount + PortCount; count++)
                                {
-                                       this->Log(DEBUG,"Bad fd %d binding port [%s:%d]",fd,Config->addrs[count],Config->ports[count]);
-                               }
-                               else
-                               {
-                                       Config->openSockfd[BoundPortCount] = new ListenSocket(this,fd,client,server,Config->ports[count],Config->addrs[count]);
-                                       if (Config->openSockfd[BoundPortCount]->GetFd() > -1)
+                                       int fd = OpenTCPSocket();
+                                       if (fd == ERROR)
+                                       {
+                                               this->Log(DEBUG,"Bad fd %d binding port [%s:%d]",fd,Config->addrs[count],Config->ports[count]);
+                                               failed_ports.push_back(std::make_pair(Config->addrs[count],Config->ports[count]));
+                                       }
+                                       else
                                        {
-                                               if (!SE->AddFd(Config->openSockfd[BoundPortCount]))
+                                               Config->openSockfd[BoundPortCount] = new ListenSocket(this,fd,client,server,Config->ports[count],Config->addrs[count]);
+                                               if (Config->openSockfd[BoundPortCount]->GetFd() > -1)
                                                {
-                                                       this->Log(DEFAULT,"ERK! Failed to add listening port to socket engine!");
-                                                       shutdown(Config->openSockfd[BoundPortCount]->GetFd(),2);
-                                                       close(Config->openSockfd[BoundPortCount]->GetFd());
-                                                       delete Config->openSockfd[BoundPortCount];
+                                                       if (!SE->AddFd(Config->openSockfd[BoundPortCount]))
+                                                       {
+                                                               this->Log(DEFAULT,"ERK! Failed to add listening port to socket engine!");
+                                                               shutdown(Config->openSockfd[BoundPortCount]->GetFd(),2);
+                                                               close(Config->openSockfd[BoundPortCount]->GetFd());
+                                                               delete Config->openSockfd[BoundPortCount];
+                                                               failed_ports.push_back(std::make_pair(Config->addrs[count],Config->ports[count]));
+                                                       }
+                                                       else
+                                                               BoundPortCount++;
                                                }
-                                               else
-                                                       BoundPortCount++;
                                        }
-                                       /*if (!BindSocket(Config->openSockfd[count],client,server,Config->ports[count],Config->addrs[count]))
-                                       {
-                                               this->Log(DEFAULT,"Failed to bind port [%s:%d]: %s",Config->addrs[count],Config->ports[count],strerror(errno));
-                                       }*/
                                }
+                               return InitialPortCount + BoundPortCount;
                        }
-                       return InitialPortCount + BoundPortCount;
-               }
-               else
-               {
-                       this->Log(DEBUG,"There is nothing new to bind!");
-               }
-               return InitialPortCount;
-       }
-
-       for (int count = 0; count < Config->ConfValueEnum(Config->config_data, "bind"); count++)
-       {
-               Config->ConfValue(Config->config_data, "bind", "port", count, configToken, MAXBUF);
-               Config->ConfValue(Config->config_data, "bind", "address", count, Addr, MAXBUF);
-               Config->ConfValue(Config->config_data, "bind", "type", count, Type, MAXBUF);
-
-               if ((!*Type) || (!strcmp(Type,"clients")))
-               {
-                       // modules handle server bind types now
-                       Config->ports[clientportcount] = atoi(configToken);
-
-                       // If the client put bind "*", this is an unrealism.
-                       // We don't actually support this as documented, but
-                       // i got fed up of people trying it, so now it converts
-                       // it to an empty string meaning the same 'bind to all'.
-                       if (*Addr == '*')
-                               *Addr = 0;
-
-                       strlcpy(Config->addrs[clientportcount],Addr,256);
-                       clientportcount++;
-                       this->Log(DEBUG,"Binding %s:%s [%s] from config",Addr,configToken, Type);
+                       else
+                       {
+                               this->Log(DEBUG,"There is nothing new to bind!");
+                       }
+                       return InitialPortCount;
                }
        }
 
@@ -491,6 +473,7 @@ int InspIRCd::BindPorts(bool bail)
                if (fd == ERROR)
                {
                        this->Log(DEBUG,"Bad fd %d binding port [%s:%d]",fd,Config->addrs[count],Config->ports[count]);
+                       failed_ports.push_back(std::make_pair(Config->addrs[count],Config->ports[count]));
                }
                else
                {
@@ -499,10 +482,8 @@ int InspIRCd::BindPorts(bool bail)
                        {
                                BoundPortCount++;
                        }
-                       /*if (!BindSocket(Config->openSockfd[BoundPortCount],client,server,Config->ports[count],Config->addrs[count]))
-                       {
-                               this->Log(DEFAULT,"Failed to bind port [%s:%d]: %s",Config->addrs[count],Config->ports[count],strerror(errno));
-                       }*/
+                       else
+                               failed_ports.push_back(std::make_pair(Config->addrs[count],Config->ports[count]));
                }
        }
        return BoundPortCount;