Tweaks to closed socket detection

[user/henk/code/inspircd.git] / src / socket.cpp

diff --git a/src/socket.cpp b/src/socket.cpp
index 4528090d4e6809fc18e6d6e49976b0a5a18c457f..fe6516bb5c94548daf1b62def6e48afc44563c8c 100644 (file)
--- a/src/socket.cpp
+++ b/src/socket.cpp
@@ -29,6 +29,7 @@ using namespace std;
 #include <sstream>
 #include <iostream>
 #include <fstream>
+#include <stdexcept>
 #include "socket.h"
 #include "inspircd.h"
 #include "inspircd_io.h"
@@ -46,6 +47,7 @@ InspSocket* socket_ref[MAX_DESCRIPTORS];
 InspSocket::InspSocket()
 {
        this->state = I_DISCONNECTED;
+       this->fd = -1;
 }
 
 InspSocket::InspSocket(int newfd, char* ip)
@@ -57,8 +59,10 @@ InspSocket::InspSocket(int newfd, char* ip)
        socket_ref[this->fd] = this;
 }
 
-InspSocket::InspSocket(std::string host, int port, bool listening, unsigned long maxtime)
+InspSocket::InspSocket(std::string ahost, int aport, bool listening, unsigned long maxtime)
 {
+       this->fd = -1;
+       this->host = ahost;
        if (listening) {
                if ((this->fd = OpenTCPSocket()) == ERROR)
                {
@@ -70,7 +74,7 @@ InspSocket::InspSocket(std::string host, int port, bool listening, unsigned long
                }
                else
                {
-                       if (BindSocket(this->fd,this->client,this->server,port,(char*)host.c_str()) == ERROR)
+                       if (BindSocket(this->fd,this->client,this->server,aport,(char*)ahost.c_str()) == ERROR)
                        {
                                this->Close();
                                this->fd = -1;
@@ -91,8 +95,8 @@ InspSocket::InspSocket(std::string host, int port, bool listening, unsigned long
        }
        else
        {
-               this->host = host;
-               this->port = port;
+               this->host = ahost;
+               this->port = aport;
 
                if (!inet_aton(host.c_str(),&addy))
                {
@@ -100,7 +104,7 @@ InspSocket::InspSocket(std::string host, int port, bool listening, unsigned long
                        /* Its not an ip, spawn the resolver */
                        this->dns.SetNS(std::string(Config->DNSServer));
                        this->dns.ForwardLookupWithFD(host,fd);
-                       timeout_end = time(NULL)+maxtime;
+                       timeout_end = time(NULL) + maxtime;
                        timeout = false;
                        this->state = I_RESOLVING;
                        socket_ref[this->fd] = this;
@@ -109,6 +113,7 @@ InspSocket::InspSocket(std::string host, int port, bool listening, unsigned long
                {
                        log(DEBUG,"No need to resolve %s",this->host.c_str());
                        this->IP = host;
+                       timeout_end = time(NULL) + maxtime;
                        this->DoConnect();
                }
        }
@@ -171,7 +176,7 @@ bool InspSocket::DoConnect()
        flags = fcntl(this->fd, F_GETFL, 0);
        fcntl(this->fd, F_SETFL, flags | O_NONBLOCK);
 
-       if(connect(this->fd, (sockaddr*)&this->addr,sizeof(this->addr)) == -1)
+       if (connect(this->fd, (sockaddr*)&this->addr,sizeof(this->addr)) == -1)
        {
                if (errno != EINPROGRESS)
                {
@@ -186,6 +191,7 @@ bool InspSocket::DoConnect()
        ServerInstance->SE->AddFd(this->fd,false,X_ESTAB_MODULE);
        socket_ref[this->fd] = this;
        this->SetQueues(this->fd);
+       log(DEBUG,"Returning true from InspSocket::DoConnect");
        return true;
 }
 
@@ -209,10 +215,10 @@ std::string InspSocket::GetIP()
 
 char* InspSocket::Read()
 {
-       if ((n < 0) || (n > MAX_DESCRIPTOR))
+       if ((fd < 0) || (fd > MAX_DESCRIPTORS))
                return NULL;
        int n = recv(this->fd,this->ibuf,sizeof(this->ibuf),0);
-       if ((n > 0) && (n <= sizeof(this->ibuf)))
+       if ((n > 0) && (n <= (int)sizeof(this->ibuf)))
        {
                ibuf[n] = 0;
                return ibuf;
@@ -237,7 +243,16 @@ char* InspSocket::Read()
 // and should be aborted.
 int InspSocket::Write(std::string data)
 {
-       this->Buffer.append(data);
+       try
+       {
+               if ((data != "") && (this->Buffer.length() + data.length() < this->Buffer.max_size()))
+                       this->Buffer.append(data);
+       }
+       catch (std::length_error)
+       {
+               log(DEBUG,"std::length_error exception caught while appending to socket buffer!");
+               return 0;
+       }
        return data.length();
 }
 
@@ -268,6 +283,7 @@ bool InspSocket::Timeout(time_t current)
 {
        if (((this->state == I_RESOLVING) || (this->state == I_CONNECTING)) && (current > timeout_end))
        {
+               log(DEBUG,"Timed out, current=%lu timeout_end=%lu");
                // for non-listening sockets, the timeout can occur
                // which causes termination of the connection after
                // the given number of seconds without a successful
@@ -286,7 +302,7 @@ bool InspSocket::Poll()
 {
        int incoming = -1;
        bool n = true;
-       
+
        switch (this->state)
        {
                case I_RESOLVING:
@@ -294,7 +310,7 @@ bool InspSocket::Poll()
                        return this->DoResolve();
                break;
                case I_CONNECTING:
-                       log(DEBUG,"State = I_CONNECTED");
+                       log(DEBUG,"State = I_CONNECTING");
                        this->SetState(I_CONNECTED);
                        /* Our socket was in write-state, so delete it and re-add it
                         * in read-state.