Add OnParameterMissing to modehandler, called when the mode handler should have a...

[user/henk/code/inspircd.git] / src / socketengines / socketengine_epoll.cpp

diff --git a/src/socketengines/socketengine_epoll.cpp b/src/socketengines/socketengine_epoll.cpp
index a749208d1e48c2252c7fd86d9083cc4e80749d3b..6b89544127d40a6afe34b070a28c938823f3522d 100644 (file)
--- a/src/socketengines/socketengine_epoll.cpp
+++ b/src/socketengines/socketengine_epoll.cpp
@@ -19,7 +19,9 @@
 
 EPollEngine::EPollEngine(InspIRCd* Instance) : SocketEngine(Instance)
 {
-       EngineHandle = epoll_create(GetMaxFds());
+       MAX_DESCRIPTORS = 0;
+       // This is not a maximum, just a hint at the eventual number of sockets that may be polled.
+       EngineHandle = epoll_create(GetMaxFds() / 4);
 
        if (EngineHandle == -1)
        {
@@ -49,23 +51,30 @@ bool EPollEngine::AddFd(EventHandler* eh)
        int fd = eh->GetFd();
        if ((fd < 0) || (fd > GetMaxFds() - 1))
        {
-               ServerInstance->Logs->Log("SOCKET",DEBUG,"Out of range FD");
+               ServerInstance->Logs->Log("SOCKET",DEBUG,"AddFd out of range: (fd: %d, max: %d)", fd, GetMaxFds());
                return false;
        }
 
        if (GetRemainingFds() <= 1)
+       {
+               ServerInstance->Logs->Log("SOCKET",DEBUG,"No remaining FDs cannot add fd: %d", fd);
                return false;
+       }
 
        if (ref[fd])
+       {
+               ServerInstance->Logs->Log("SOCKET",DEBUG,"Attempt to add duplicate fd: %d", fd);
                return false;
+       }
 
        struct epoll_event ev;
-       memset(&ev,0,sizeof(struct epoll_event));
+       memset(&ev,0,sizeof(ev));
        eh->Readable() ? ev.events = EPOLLIN : ev.events = EPOLLOUT;
        ev.data.fd = fd;
        int i = epoll_ctl(EngineHandle, EPOLL_CTL_ADD, fd, &ev);
        if (i < 0)
        {
+               ServerInstance->Logs->Log("SOCKET",DEBUG,"Error adding fd: %d to socketengine: %s", fd, strerror(errno));
                return false;
        }
 
@@ -82,7 +91,7 @@ void EPollEngine::WantWrite(EventHandler* eh)
         * status for us and saves us a call.
         */
        struct epoll_event ev;
-       memset(&ev,0,sizeof(struct epoll_event));
+       memset(&ev,0,sizeof(ev));
        ev.events = EPOLLOUT;
        ev.data.fd = eh->GetFd();
        epoll_ctl(EngineHandle, EPOLL_CTL_MOD, eh->GetFd(), &ev);
@@ -92,10 +101,13 @@ bool EPollEngine::DelFd(EventHandler* eh, bool force)
 {
        int fd = eh->GetFd();
        if ((fd < 0) || (fd > GetMaxFds() - 1))
+       {
+               ServerInstance->Logs->Log("SOCKET",DEBUG,"DelFd out of range: (fd: %d, max: %d)", fd, GetMaxFds());
                return false;
+       }
 
        struct epoll_event ev;
-       memset(&ev,0,sizeof(struct epoll_event));
+       memset(&ev,0,sizeof(ev));
        eh->Readable() ? ev.events = EPOLLIN : ev.events = EPOLLOUT;
        ev.data.fd = fd;
        int i = epoll_ctl(EngineHandle, EPOLL_CTL_DEL, fd, &ev);
@@ -169,7 +181,7 @@ int EPollEngine::DispatchEvents()
                {
                        WriteEvents++;
                        struct epoll_event ev;
-                       memset(&ev,0,sizeof(struct epoll_event));
+                       memset(&ev,0,sizeof(ev));
                        ev.events = EPOLLIN;
                        ev.data.fd = events[j].data.fd;
                        epoll_ctl(EngineHandle, EPOLL_CTL_MOD, events[j].data.fd, &ev);