Replace SocketEngine::GetName() with INSPIRCD_SOCKETENGINE_NAME define

[user/henk/code/inspircd.git] / src / socketengines / socketengine_select.cpp

diff --git a/src/socketengines/socketengine_select.cpp b/src/socketengines/socketengine_select.cpp
index b721a6b0a2dcf26d245ab7b0f0ea783c20368d86..e9d7a96602c6410df8168d43e010d6f3ffc5edea 100644 (file)
--- a/src/socketengines/socketengine_select.cpp
+++ b/src/socketengines/socketengine_select.cpp
@@ -1,6 +1,7 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2014 Adam <Adam@anope.org>
  *   Copyright (C) 2009 Daniel De Graaf <danieldg@inspircd.org>
  *   Copyright (C) 2007-2008 Craig Edwards <craigedwards@brainbox.cc>
  *
@@ -36,14 +37,10 @@ public:
        /** Create a new SelectEngine
         */
        SelectEngine();
-       /** Delete a SelectEngine
-        */
-       virtual ~SelectEngine();
        virtual bool AddFd(EventHandler* eh, int event_mask);
        virtual void DelFd(EventHandler* eh);
        void OnSetEvent(EventHandler* eh, int, int);
        virtual int DispatchEvents();
-       virtual std::string GetName();
 };
 
 SelectEngine::SelectEngine()
@@ -51,31 +48,21 @@ SelectEngine::SelectEngine()
        MAX_DESCRIPTORS = FD_SETSIZE;
        CurrentSetSize = 0;
 
-       ref = new EventHandler* [GetMaxFds()];
-       memset(ref, 0, GetMaxFds() * sizeof(EventHandler*));
-
        FD_ZERO(&ReadSet);
        FD_ZERO(&WriteSet);
        FD_ZERO(&ErrSet);
        MaxFD = 0;
 }
 
-SelectEngine::~SelectEngine()
-{
-       delete[] ref;
-}
-
 bool SelectEngine::AddFd(EventHandler* eh, int event_mask)
 {
        int fd = eh->GetFd();
        if ((fd < 0) || (fd > GetMaxFds() - 1))
                return false;
 
-       if (ref[fd])
+       if (!SocketEngine::AddFd(eh))
                return false;
 
-       ref[fd] = eh;
-
        SocketEngine::SetEventMask(eh, event_mask);
        OnSetEvent(eh, 0, event_mask);
        FD_SET(fd, &ErrSet);
@@ -84,7 +71,7 @@ bool SelectEngine::AddFd(EventHandler* eh, int event_mask)
 
        CurrentSetSize++;
 
-       ServerInstance->Logs->Log("SOCKET",LOG_DEBUG,"New file descriptor: %d", fd);
+       ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "New file descriptor: %d", fd);
        return true;
 }
 
@@ -96,7 +83,7 @@ void SelectEngine::DelFd(EventHandler* eh)
                return;
 
        CurrentSetSize--;
-       ref[fd] = NULL;
+       SocketEngine::DelFd(eh);
 
        FD_CLR(fd, &ReadSet);
        FD_CLR(fd, &WriteSet);
@@ -104,7 +91,7 @@ void SelectEngine::DelFd(EventHandler* eh)
        if (fd == MaxFD)
                --MaxFD;
 
-       ServerInstance->Logs->Log("SOCKET",LOG_DEBUG,"Remove file descriptor: %d", fd);
+       ServerInstance->Logs->Log("SOCKET", LOG_DEBUG, "Remove file descriptor: %d", fd);
 }
 
 void SelectEngine::OnSetEvent(EventHandler* eh, int old_mask, int new_mask)
@@ -137,60 +124,54 @@ int SelectEngine::DispatchEvents()
        int sresult = select(MaxFD + 1, &rfdset, &wfdset, &errfdset, &tval);
        ServerInstance->UpdateTime();
 
-       /* Nothing to process this time around */
-       if (sresult < 1)
-               return 0;
-
        for (int i = 0, j = sresult; i <= MaxFD && j > 0; i++)
        {
                int has_read = FD_ISSET(i, &rfdset), has_write = FD_ISSET(i, &wfdset), has_error = FD_ISSET(i, &errfdset);
 
-               if (has_read || has_write || has_error)
-               {
-                       --j;
+               if (!(has_read || has_write || has_error))
+                       continue;
 
-                       EventHandler* ev = ref[i];
-                       if (!ev)
-                               continue;
+               --j;
+
+               EventHandler* ev = GetRef(i);
+               if (!ev)
+                       continue;
 
-                       if (has_error)
-                       {
-                               ErrorEvents++;
+               if (has_error)
+               {
+                       ErrorEvents++;
+
+                       socklen_t codesize = sizeof(int);
+                       int errcode = 0;
+                       if (getsockopt(i, SOL_SOCKET, SO_ERROR, (char*)&errcode, &codesize) < 0)
+                               errcode = errno;
 
-                               socklen_t codesize = sizeof(int);
-                               int errcode = 0;
-                               if (getsockopt(i, SOL_SOCKET, SO_ERROR, (char*)&errcode, &codesize) < 0)
-                                       errcode = errno;
+                       ev->HandleEvent(EVENT_ERROR, errcode);
+                       continue;
+               }
 
-                               ev->HandleEvent(EVENT_ERROR, errcode);
+               if (has_read)
+               {
+                       ReadEvents++;
+                       SetEventMask(ev, ev->GetEventMask() & ~FD_READ_WILL_BLOCK);
+                       ev->HandleEvent(EVENT_READ);
+                       if (ev != GetRef(i))
                                continue;
-                       }
-
-                       if (has_read)
-                       {
-                               ReadEvents++;
-                               SetEventMask(ev, ev->GetEventMask() & ~FD_READ_WILL_BLOCK);
-                               ev->HandleEvent(EVENT_READ);
-                               if (ev != ref[i])
-                                       continue;
-                       }
-                       if (has_write)
-                       {
-                               WriteEvents++;
-                               SetEventMask(ev, ev->GetEventMask() & ~(FD_WRITE_WILL_BLOCK | FD_WANT_SINGLE_WRITE));
-                               ev->HandleEvent(EVENT_WRITE);
-                       }
+               }
+
+               if (has_write)
+               {
+                       WriteEvents++;
+                       int newmask = (ev->GetEventMask() & ~(FD_WRITE_WILL_BLOCK | FD_WANT_SINGLE_WRITE));
+                       this->OnSetEvent(ev, ev->GetEventMask(), newmask);
+                       SetEventMask(ev, newmask);
+                       ev->HandleEvent(EVENT_WRITE);
                }
        }
 
        return sresult;
 }
 
-std::string SelectEngine::GetName()
-{
-       return "select";
-}
-
 SocketEngine* CreateSocketEngine()
 {
        return new SelectEngine;