-/* +------------------------------------+
- * | Inspire Internet Relay Chat Daemon |
- * +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
*
- * InspIRCd: (C) 2002-2007 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
+ * Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ * Copyright (C) 2006-2007 Craig Edwards <craigedwards@brainbox.cc>
+ * Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
*
- * This program is free but copyrighted software; see
- * the file COPYING for details.
+ * This file is part of InspIRCd. InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
*
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
+
+/* $Core */
+
#include "inspircd.h"
#include "timer.h"
-TimerManager::TimerManager() : CantDeleteHere(false)
+TimerManager::TimerManager()
{
}
-void TimerManager::TickTimers(time_t TIME)
+TimerManager::~TimerManager()
{
- this->CantDeleteHere = true;
- timerlist::iterator found = Timers.find(TIME);
-
- if (found != Timers.end())
- {
- timergroup* x = found->second;
- /* There are pending timers to trigger.
- * WARNING: Timers may delete themselves from within
- * their own Tick methods! see the comment below in
- * the DelTimer method.
- */
- for (timergroup::iterator y = x->begin(); y != x->end(); y++)
- {
- InspTimer* n = *y;
- n->Tick(TIME);
- if (n->GetRepeat())
- {
- AddTimer(n, n->GetSecs());
- }
- else
- {
- DELETE(n);
- }
- }
-
- Timers.erase(found);
- DELETE(x);
- }
-
- this->CantDeleteHere = false;
+ for(std::vector<Timer *>::iterator i = Timers.begin(); i != Timers.end(); i++)
+ delete *i;
}
-void TimerManager::DelTimer(InspTimer* T)
+void TimerManager::TickTimers(time_t TIME)
{
- if (this->CantDeleteHere)
+ while ((Timers.size()) && (TIME > (*Timers.begin())->GetTimer()))
{
- /* If a developer tries to delete a timer from within its own Tick method,
- * then chances are this is just going to totally fuck over the timergroup
- * and timerlist iterators and cause a crash. Thanks to peavey and Bricker
- * for noticing this bug.
- * If we're within the tick loop when the DelTimer is called (signified
- * by the var 'CantDeleteHere') then we simply return for non-repeating
- * timers, and cancel the repeat on repeating timers. We can do this because
- * we know that the timer tick loop will safely delete the timer for us
- * anyway and therefore we avoid stack corruption.
- */
- if (T->GetRepeat())
- T->CancelRepeat();
- else
- return;
- }
+ std::vector<Timer *>::iterator i = Timers.begin();
+ Timer *t = (*i);
- timerlist::iterator found = Timers.find(T->GetTimer());
+ // Probable fix: move vector manipulation to *before* we modify the vector.
+ Timers.erase(i);
- if (found != Timers.end())
- {
- timergroup* x = found->second;
- for (timergroup::iterator y = x->begin(); y != x->end(); y++)
+ t->Tick(TIME);
+ if (t->GetRepeat())
{
- InspTimer* n = *y;
- if (n == T)
- {
- DELETE(n);
- x->erase(y);
- if (!x->size())
- {
- Timers.erase(found);
- DELETE(x);
- }
- return;
- }
+ t->SetTimer(TIME + t->GetSecs());
+ AddTimer(t);
}
+ else
+ delete t;
}
}
-/** Because some muppets may do odd things, and their ircd may lock up due
- * to crappy 3rd party modules, or they may change their system time a bit,
- * this accounts for shifts of up to 120 secs by looking behind for missed
- * timers and executing them. This is only executed once every 5 secs.
- * If you move your clock BACK, and your timers move further ahead as a result,
- * then tough titty you'll just have to wait.
- */
-void TimerManager::TickMissedTimers(time_t TIME)
+void TimerManager::DelTimer(Timer* T)
{
- /** See comment above in TickTimers
- */
- this->CantDeleteHere = true;
+ std::vector<Timer *>::iterator i = std::find(Timers.begin(), Timers.end(), T);
- for (time_t n = TIME-1; n > TIME-120; n--)
+ if (i != Timers.end())
{
- timerlist::iterator found = Timers.find(n);
- if (found != Timers.end())
- {
- timergroup* x = found->second;
- for (timergroup::iterator y = x->begin(); y != x->end(); y++)
- {
- InspTimer* z = *y;
- z->Tick(TIME);
- if (z->GetRepeat())
- {
- AddTimer(z, z->GetSecs());
- }
- else
- {
- DELETE(z);
- }
- }
-
- Timers.erase(found);
- DELETE(x);
- }
+ delete (*i);
+ Timers.erase(i);
}
-
- this->CantDeleteHere = false;
}
-void TimerManager::AddTimer(InspTimer* T, long secs_from_now)
+void TimerManager::AddTimer(Timer* T)
{
- timergroup* x = NULL;
-
- int time_to_trigger = 0;
- if (!secs_from_now)
- time_to_trigger = T->GetTimer();
- else
- time_to_trigger = secs_from_now + time(NULL);
-
- timerlist::iterator found = Timers.find(time_to_trigger);
-
- if (found != Timers.end())
- {
- x = found->second;
- }
- else
- {
- x = new timergroup;
- Timers[time_to_trigger] = x;
- }
-
- x->push_back(T);
+ Timers.push_back(T);
+ sort(Timers.begin(), Timers.end(), TimerManager::TimerComparison);
}
+bool TimerManager::TimerComparison( Timer *one, Timer *two)
+{
+ return (one->GetTimer()) < (two->GetTimer());
+}