]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/userprocess.cpp
Passing invalid instance to dns isnt a good idea
[user/henk/code/inspircd.git] / src / userprocess.cpp
index ba05032cacca735f2e5417ec48fcee4361ba3c58..42c3bd3db49aff8bd84fc971eb4a9a19e978b42c 100644 (file)
@@ -56,21 +56,11 @@ extern struct sockaddr_in client,server;
 extern socklen_t length;
 extern std::vector<Module*> modules;
 extern std::vector<ircd_module*> factory;
-extern std::vector<InspSocket*> module_sockets;
 extern time_t TIME;
 extern time_t OLDTIME;
-extern std::vector<userrec*> local_users;
-extern InspSocket* socket_ref[MAX_DESCRIPTORS];
-
-extern InspIRCd* ServerInstance;
-extern ServerConfig *Config;
-extern userrec* fd_ref_table[MAX_DESCRIPTORS];
 char data[65536];
 
-extern user_hash clientlist;
-extern chan_hash chanlist;
-
-void ProcessUser(userrec* cu)
+void InspIRCd::ProcessUser(userrec* cu)
 {
        int result = EAGAIN;
 
@@ -79,14 +69,14 @@ void ProcessUser(userrec* cu)
 
        log(DEBUG,"Processing user with fd %d",cu->fd);
 
-       if (Config->GetIOHook(cu->GetPort()))
+       if (this->Config->GetIOHook(cu->GetPort()))
        {
                int result2 = 0;
                int MOD_RESULT = 0;
 
                try
                {
-                       MOD_RESULT = Config->GetIOHook(cu->GetPort())->OnRawSocketRead(cu->fd,data,65535,result2);
+                       MOD_RESULT = this->Config->GetIOHook(cu->GetPort())->OnRawSocketRead(cu->fd,data,65535,result2);
                        log(DEBUG,"Data result returned by module: %d",MOD_RESULT);
                }
                catch (ModuleException& modexcept)
@@ -116,7 +106,7 @@ void ProcessUser(userrec* cu)
                int currfd;
                int floodlines = 0;
 
-               ServerInstance->stats->statsRecv += result;
+               this->stats->statsRecv += result;
                /*
                 * perform a check on the raw buffer as an array (not a string!) to remove
                 * character 0 which is illegal in the RFC - replace them with spaces.
@@ -157,12 +147,12 @@ void ProcessUser(userrec* cu)
                                        {
                                                log(DEFAULT,"Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
                                                WriteOpers("*** Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
-                                               userrec::QuitUser(current,"Excess flood");
+                                               userrec::QuitUser(this, current,"Excess flood");
                                                return;
                                        }
                                        else
                                        {
-                                               WriteServ(currfd, "NOTICE %s :Your previous line was too long and was not delivered (Over 512chars) Please shorten it.", current->nick);
+                                               current->WriteServ("NOTICE %s :Your previous line was too long and was not delivered (Over 512chars) Please shorten it.", current->nick);
                                                current->recvq = "";
                                        }
                                }
@@ -170,24 +160,24 @@ void ProcessUser(userrec* cu)
                                {
                                        WriteOpers("*** Excess flood from %s",current->GetIPString());
                                        log(DEFAULT,"Excess flood from: %s",current->GetIPString());
-                                       add_zline(120,Config->ServerName,"Flood from unregistered connection",current->GetIPString());
+                                       add_zline(120,this->Config->ServerName,"Flood from unregistered connection",current->GetIPString());
                                        apply_lines(APPLY_ZLINES);
                                }
 
                                return;
                        }
 
-                       if (current->recvq.length() > (unsigned)Config->NetBufferSize)
+                       if (current->recvq.length() > (unsigned)this->Config->NetBufferSize)
                        {
                                if (current->registered == REG_ALL)
                                {
-                                       userrec::QuitUser(current,"RecvQ exceeded");
+                                       userrec::QuitUser(this, current,"RecvQ exceeded");
                                }
                                else
                                {
                                        WriteOpers("*** Excess flood from %s",current->GetIPString());
                                        log(DEFAULT,"Excess flood from: %s",current->GetIPString());
-                                       add_zline(120,Config->ServerName,"Flood from unregistered connection",current->GetIPString());
+                                       add_zline(120,this->Config->ServerName,"Flood from unregistered connection",current->GetIPString());
                                        apply_lines(APPLY_ZLINES);
                                }
 
@@ -207,7 +197,7 @@ void ProcessUser(userrec* cu)
                                {
                                        log(DEFAULT,"Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
                                        WriteOpers("*** Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
-                                       userrec::QuitUser(current,"Excess flood");
+                                       userrec::QuitUser(this, current,"Excess flood");
                                        return;
                                }
 
@@ -217,11 +207,11 @@ void ProcessUser(userrec* cu)
                                        {
                                                log(DEFAULT,"Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
                                                WriteOpers("*** Excess flood from: %s!%s@%s",current->nick,current->ident,current->host);
-                                               userrec::QuitUser(current,"Excess flood");
+                                               userrec::QuitUser(this, current,"Excess flood");
                                        }
                                        else
                                        {
-                                               add_zline(120,Config->ServerName,"Flood from unregistered connection",current->GetIPString());
+                                               add_zline(120,this->Config->ServerName,"Flood from unregistered connection",current->GetIPString());
                                                apply_lines(APPLY_ZLINES);
                                        }
 
@@ -235,17 +225,17 @@ void ProcessUser(userrec* cu)
                                if (single_line.length() > 512)
                                        single_line.resize(512);
 
-                               userrec* old_comp = fd_ref_table[currfd];
+                               userrec* old_comp = this->fd_ref_table[currfd];
 
-                               ServerInstance->Parser->ProcessBuffer(single_line,current);
+                               this->Parser->ProcessBuffer(single_line,current);
                                /*
                                 * look for the user's record in case it's changed... if theyve quit,
                                 * we cant do anything more with their buffer, so bail.
                                 * there used to be an ugly, slow loop here. Now we have a reference
                                 * table, life is much easier (and FASTER)
                                 */
-                               userrec* new_comp = fd_ref_table[currfd];
-                               if ((currfd < 0) || (!fd_ref_table[currfd]) || (old_comp != new_comp))
+                               userrec* new_comp = this->fd_ref_table[currfd];
+                               if ((currfd < 0) || (!this->fd_ref_table[currfd]) || (old_comp != new_comp))
                                {
                                        return;
                                }
@@ -262,7 +252,7 @@ void ProcessUser(userrec* cu)
                if ((result == -1) && (errno != EAGAIN) && (errno != EINTR))
                {
                        log(DEBUG,"killing: %s",cu->nick);
-                       userrec::QuitUser(cu,strerror(errno));
+                       userrec::QuitUser(this,cu,strerror(errno));
                        return;
                }
        }
@@ -275,32 +265,32 @@ void ProcessUser(userrec* cu)
        else if (result == 0)
        {
                log(DEBUG,"InspIRCd: Exited: %s",cu->nick);
-               userrec::QuitUser(cu,"Client exited");
+               userrec::QuitUser(this,cu,"Client exited");
                log(DEBUG,"Bailing from client exit");
                return;
        }
 }
 
-void DoSocketTimeouts(time_t TIME)
+void InspIRCd::DoSocketTimeouts(time_t TIME)
 {
-       unsigned int numsockets = module_sockets.size();
-       SocketEngine* SE = ServerInstance->SE;
+       unsigned int numsockets = this->module_sockets.size();
+       SocketEngine* SE = this->SE;
 
-       for (std::vector<InspSocket*>::iterator a = module_sockets.begin(); a < module_sockets.end(); a++)
+       for (std::vector<InspSocket*>::iterator a = this->module_sockets.begin(); a < this->module_sockets.end(); a++)
        {
                InspSocket* s = (InspSocket*)*a;
-               if ((s) && (s->GetFd() >= 0) && (s->GetFd() < MAX_DESCRIPTORS) && (socket_ref[s->GetFd()] != NULL) && (s->Timeout(TIME)))
+               if ((s) && (s->GetFd() >= 0) && (s->GetFd() < MAX_DESCRIPTORS) && (this->socket_ref[s->GetFd()] != NULL) && (s->Timeout(TIME)))
                {
                        log(DEBUG,"userprocess.cpp: Socket poll returned false, close and bail");
-                       socket_ref[s->GetFd()] = NULL;
+                       this->socket_ref[s->GetFd()] = NULL;
                        SE->DelFd(s->GetFd());
-                       module_sockets.erase(a);
+                       this->module_sockets.erase(a);
                        s->Close();
                        DELETE(s);
                        break;
                }
 
-               if (module_sockets.size() != numsockets)
+               if (this->module_sockets.size() != numsockets)
                        break;
        }
 }
@@ -311,17 +301,17 @@ void DoSocketTimeouts(time_t TIME)
  * stuff like ping checks, registration timeouts, etc. This function is
  * also responsible for checking if InspSocket derived classes are timed out.
  */
-void DoBackgroundUserStuff(time_t TIME)
+void InspIRCd::DoBackgroundUserStuff(time_t TIME)
 {
        CullList GlobalGoners;
 
        /* XXX: IT IS NOT SAFE TO USE AN ITERATOR HERE. DON'T EVEN THINK ABOUT IT. */
-       for (unsigned long count2 = 0; count2 != local_users.size(); count2++)
+       for (unsigned long count2 = 0; count2 != this->local_users.size(); count2++)
        {
-               if (count2 >= local_users.size())
+               if (count2 >= this->local_users.size())
                        break;
 
-               userrec* curr = local_users[count2];
+               userrec* curr = this->local_users[count2];
 
                if (curr)
                {
@@ -344,14 +334,14 @@ void DoBackgroundUserStuff(time_t TIME)
                        {
                                curr->dns_done = true;
                                //ZapThisDns(curr->fd);
-                               ServerInstance->stats->statsDnsBad++;
-                               FullConnectUser(curr,&GlobalGoners);
+                               this->stats->statsDnsBad++;
+                               curr->FullConnect(&GlobalGoners);
                                continue;
                        }
                        if ((curr->dns_done) && (curr->registered == REG_NICKUSER) && (AllModulesReportReady(curr)))
                        {
                                log(DEBUG,"dns done, registered=3, and modules ready, OK");
-                               FullConnectUser(curr,&GlobalGoners);
+                               curr->FullConnect(&GlobalGoners);
                                //ZapThisDns(curr->fd);
                                continue;
                        }
@@ -366,7 +356,7 @@ void DoBackgroundUserStuff(time_t TIME)
                                        curr->nping = TIME+curr->pingmax;
                                        continue;
                                }
-                               Write(curr->fd,"PING :%s",Config->ServerName);
+                               curr->Write("PING :%s",this->Config->ServerName);
                                curr->lastping = 0;
                                curr->nping = TIME+curr->pingmax;
                        }