]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Fix FIDENT response forging to run prior to the ENCAP strip
[user/henk/code/inspircd.git] / src / users.cpp
index f429597daf797f015f785dc9c20395bbb857dbe4..1392af0755af7ea1c41f122346bc445505ad9d7f 100644 (file)
@@ -621,10 +621,7 @@ void User::Oper(OperInfo* info)
                        l->ChangeDisplayedHost(vhost.c_str());
                std::string opClass = oper->getConfig("class");
                if (!opClass.empty())
-               {
                        l->SetClass(opClass);
-                       l->CheckClass();
-               }
        }
 
        ServerInstance->SNO->WriteToSnoMask('o',"%s (%s@%s) is now an IRC operator of type %s (using oper '%s')",
@@ -809,16 +806,18 @@ void LocalUser::FullConnect()
        /* Check the password, if one is required by the user's connect class.
         * This CANNOT be in CheckClass(), because that is called prior to PASS as well!
         */
-       if (!MyClass->pass.empty())
+       if (!MyClass->config->getString("pass").empty())
        {
-               if (ServerInstance->PassCompare(this, MyClass->pass.c_str(), password.c_str(), MyClass->hash.c_str()))
+               if (ServerInstance->PassCompare(this, MyClass->config->getString("pass"), password, MyClass->config->getString("hash")))
                {
                        ServerInstance->Users->QuitUser(this, "Invalid password");
                        return;
                }
        }
+       CheckClass();
+       CheckLines();
 
-       if (this->CheckLines())
+       if (quitting)
                return;
 
        this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",ServerInstance->Config->Network.c_str());
@@ -864,27 +863,6 @@ void LocalUser::FullConnect()
        ServerInstance->BanCache->AddHit(this->GetIPString(), "", "");
 }
 
-/** User::UpdateNick()
- * re-allocates a nick in the user_hash after they change nicknames,
- * returns a pointer to the new user as it may have moved
- */
-User* User::UpdateNickHash(const char* New)
-{
-       //user_hash::iterator newnick;
-       user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
-
-       if (!irc::string(this->nick.c_str()).compare(New))
-               return oldnick->second;
-
-       if (oldnick == ServerInstance->Users->clientlist->end())
-               return NULL; /* doesnt exist */
-
-       User* olduser = oldnick->second;
-       ServerInstance->Users->clientlist->erase(oldnick);
-       (*(ServerInstance->Users->clientlist))[New] = olduser;
-       return olduser;
-}
-
 void User::InvalidateCache()
 {
        /* Invalidate cache */
@@ -971,8 +949,11 @@ bool User::ChangeNick(const std::string& newnick, bool force)
                                /* force the camper to their UUID, and ask them to re-send a NICK. */
                                InUse->WriteTo(InUse, "NICK %s", InUse->uuid.c_str());
                                InUse->WriteNumeric(433, "%s %s :Nickname overruled.", InUse->nick.c_str(), InUse->nick.c_str());
-                               InUse->UpdateNickHash(InUse->uuid.c_str());
-                               InUse->nick.assign(InUse->uuid, 0, IS_LOCAL(InUse) ? ServerInstance->Config->Limits.NickMax : MAXBUF);
+
+                               ServerInstance->Users->clientlist->erase(InUse->nick);
+                               (*(ServerInstance->Users->clientlist))[InUse->uuid] = InUse;
+
+                               InUse->nick = InUse->uuid;
                                InUse->InvalidateCache();
                                InUse->registered &= ~REG_NICK;
                        }
@@ -980,7 +961,7 @@ bool User::ChangeNick(const std::string& newnick, bool force)
                        {
                                /* No camping, tell the incoming user  to stop trying to change nick ;p */
                                this->WriteNumeric(433, "%s %s :Nickname is already in use.", this->registered >= REG_NICK ? this->nick.c_str() : "*", newnick.c_str());
-                               return CMD_FAILURE;
+                               return false;
                        }
                }
        }
@@ -989,9 +970,14 @@ bool User::ChangeNick(const std::string& newnick, bool force)
                this->WriteCommon("NICK %s",newnick.c_str());
        std::string oldnick = nick;
        nick = newnick;
+
        InvalidateCache();
-       UpdateNickHash(newnick.c_str());
-       FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(this,oldnick));
+       ServerInstance->Users->clientlist->erase(oldnick);
+       (*(ServerInstance->Users->clientlist))[newnick] = this;
+
+       if (registered == REG_ALL)
+               FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(this,oldnick));
+
        return true;
 }
 
@@ -1617,15 +1603,20 @@ void LocalUser::SetClass(const std::string &explicit_name)
                {
                        ConnectClass* c = *i;
 
-                       if (c->type == CC_ALLOW)
-                       {
-                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "ALLOW %s %d %s", c->host.c_str(), c->GetPort(), c->GetName().c_str());
-                       }
-                       else
+                       ModResult MOD_RESULT;
+                       FIRST_MOD_RESULT(OnSetConnectClass, MOD_RESULT, (this,c));
+                       if (MOD_RESULT == MOD_RES_DENY)
+                               continue;
+                       if (MOD_RESULT == MOD_RES_ALLOW)
                        {
-                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "DENY %s %d %s", c->GetHost().c_str(), c->GetPort(), c->GetName().c_str());
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Class forced by module to %s", c->GetName().c_str());
+                               found = c;
+                               break;
                        }
 
+                       if (c->type == CC_NAMED)
+                               continue;
+
                        /* check if host matches.. */
                        if (c->GetHost().length() && !InspIRCd::MatchCIDR(this->GetIPString(), c->GetHost(), NULL) &&
                            !InspIRCd::MatchCIDR(this->host, c->GetHost(), NULL))
@@ -1645,16 +1636,14 @@ void LocalUser::SetClass(const std::string &explicit_name)
                        }
 
                        /* if it requires a port ... */
-                       if (c->GetPort())
+                       int port = c->config->getInt("port");
+                       if (port)
                        {
-                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Requires port (%d)", c->GetPort());
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Requires port (%d)", port);
 
                                /* and our port doesn't match, fail. */
-                               if (this->GetServerPort() != c->GetPort())
-                               {
-                                       ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Port match failed (%d)", this->GetServerPort());
+                               if (this->GetServerPort() != port)
                                        continue;
-                               }
                        }
 
                        /* we stop at the first class that meets ALL critera. */
@@ -1715,19 +1704,18 @@ const std::string& FakeUser::GetFullRealHost()
 
 ConnectClass::ConnectClass(ConfigTag* tag, char t, const std::string& mask)
        : config(tag), type(t), fakelag(true), name("unnamed"), registration_timeout(0), host(mask),
-       pingtime(0), pass(""), hash(""), softsendqmax(0), hardsendqmax(0), recvqmax(0),
-       penaltythreshold(0), commandrate(0), maxlocal(0), maxglobal(0), maxchans(0), port(0), limit(0)
+       pingtime(0), softsendqmax(0), hardsendqmax(0), recvqmax(0),
+       penaltythreshold(0), commandrate(0), maxlocal(0), maxglobal(0), maxchans(0), limit(0)
 {
 }
 
 ConnectClass::ConnectClass(ConfigTag* tag, char t, const std::string& mask, const ConnectClass& parent)
        : config(tag), type(t), fakelag(parent.fakelag), name("unnamed"),
        registration_timeout(parent.registration_timeout), host(mask), pingtime(parent.pingtime),
-       pass(parent.pass), hash(parent.hash), softsendqmax(parent.softsendqmax),
-       hardsendqmax(parent.hardsendqmax), recvqmax(parent.recvqmax),
+       softsendqmax(parent.softsendqmax), hardsendqmax(parent.hardsendqmax), recvqmax(parent.recvqmax),
        penaltythreshold(parent.penaltythreshold), commandrate(parent.commandrate),
        maxlocal(parent.maxlocal), maxglobal(parent.maxglobal), maxchans(parent.maxchans),
-       port(parent.port), limit(parent.limit)
+       limit(parent.limit)
 {
 }
 
@@ -1737,8 +1725,6 @@ void ConnectClass::Update(const ConnectClass* src)
        registration_timeout = src->registration_timeout;
        host = src->host;
        pingtime = src->pingtime;
-       pass = src->pass;
-       hash = src->hash;
        softsendqmax = src->softsendqmax;
        hardsendqmax = src->hardsendqmax;
        recvqmax = src->recvqmax;