]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Add ProtocolInterface::Introduce() to prevent confusion over event ordering, and...
[user/henk/code/inspircd.git] / src / users.cpp
index be51cc46a518aed9bd66a77934854d889cb5139a..143313af20e7fd457522aafbf146f1aa88e3f3c9 100644 (file)
 #include "bancache.h"
 #include "commands/cmd_whowas.h"
 
-static unsigned long already_sent[MAX_DESCRIPTORS] = {0};
-
 /* XXX: Used for speeding up WriteCommon operations */
-unsigned long uniq_id = 0;
+unsigned long uniq_id = 1;
+
+static unsigned long* already_sent = NULL;
+
+
+void InitializeAlreadySent(SocketEngine* SE)
+{
+       already_sent = new unsigned long[SE->GetMaxFds()];
+       memset(already_sent, 0, SE->GetMaxFds() * sizeof(unsigned long));
+}
+
 
 std::string User::ProcessNoticeMasks(const char *sm)
 {
@@ -73,6 +81,9 @@ std::string User::ProcessNoticeMasks(const char *sm)
                                                output += *c;
                                        }
                                }
+                               else
+                                       this->WriteNumeric(501, "%s %c :is unknown snomask char to me", this->nick.c_str(), *c);
+
                                oldadding = adding;
                        break;
                }
@@ -88,19 +99,19 @@ void User::StartDNSLookup()
        try
        {
                bool cached;
-               const char* ip = this->GetIPString();
+               const char* sip = this->GetIPString(false);
 
                /* Special case for 4in6 (Have i mentioned i HATE 4in6?) */
-               if (!strncmp(ip, "0::ffff:", 8))
-                       res_reverse = new UserResolver(this->ServerInstance, this, ip + 8, DNS_QUERY_PTR4, cached);
+               if (!strncmp(sip, "0::ffff:", 8))
+                       res_reverse = new UserResolver(this->ServerInstance, this, sip + 8, DNS_QUERY_PTR4, cached);
                else
-                       res_reverse = new UserResolver(this->ServerInstance, this, ip, this->GetProtocolFamily() == AF_INET ? DNS_QUERY_PTR4 : DNS_QUERY_PTR6, cached);
+                       res_reverse = new UserResolver(this->ServerInstance, this, sip, this->GetProtocolFamily() == AF_INET ? DNS_QUERY_PTR4 : DNS_QUERY_PTR6, cached);
 
                this->ServerInstance->AddResolver(res_reverse, cached);
        }
        catch (CoreException& e)
        {
-               ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
+               ServerInstance->Logs->Log("USERS", DEBUG,"Error in resolver: %s",e.GetReason());
        }
 }
 
@@ -156,16 +167,16 @@ const char* User::FormatModes()
 
 void User::DecrementModes()
 {
-       ServerInstance->Log(DEBUG,"DecrementModes()");
+       ServerInstance->Logs->Log("USERS", DEBUG, "DecrementModes()");
        for (unsigned char n = 'A'; n <= 'z'; n++)
        {
                if (modes[n-65])
                {
-                       ServerInstance->Log(DEBUG,"DecrementModes() found mode %c", n);
+                       ServerInstance->Logs->Log("USERS", DEBUG,"DecrementModes() found mode %c", n);
                        ModeHandler* mh = ServerInstance->Modes->FindMode(n, MODETYPE_USER);
                        if (mh)
                        {
-                               ServerInstance->Log(DEBUG,"Found handler %c and call ChangeCount", n);
+                               ServerInstance->Logs->Log("USERS", DEBUG,"Found handler %c and call ChangeCount", n);
                                mh->ChangeCount(-1);
                        }
                }
@@ -174,14 +185,13 @@ void User::DecrementModes()
 
 User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance)
 {
-       *password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = *uuid = 0;
        server = (char*)Instance->FindServerNamePtr(Instance->Config->ServerName);
        reset_due = ServerInstance->Time();
-       age = ServerInstance->Time(true);
+       age = ServerInstance->Time();
        Penalty = 0;
        lines_in = lastping = signon = idle_lastmsg = nping = registered = 0;
        ChannelCount = timeout = bytes_in = bytes_out = cmds_in = cmds_out = 0;
-       OverPenalty = ExemptFromPenalty = quitting = exempt = haspassed = dns_done = false;
+       quietquit = OverPenalty = ExemptFromPenalty = quitting = exempt = haspassed = dns_done = false;
        fd = -1;
        recvq.clear();
        sendq.clear();
@@ -190,20 +200,21 @@ User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance
        Visibility = NULL;
        ip = NULL;
        MyClass = NULL;
+       io = NULL;
+       AllowedUserModes = NULL;
+       AllowedChanModes = NULL;
        AllowedOperCommands = NULL;
        chans.clear();
        invites.clear();
        memset(modes,0,sizeof(modes));
        memset(snomasks,0,sizeof(snomasks));
-       /* Invalidate cache */
-       cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
 
        if (uid.empty())
-               strlcpy(uuid, Instance->GetUID().c_str(), UUID_LENGTH);
+               uuid.assign(Instance->GetUID(), 0, UUID_LENGTH - 1);
        else
-               strlcpy(uuid, uid.c_str(), UUID_LENGTH);
+               uuid.assign(uid, 0, UUID_LENGTH - 1);
 
-       ServerInstance->Log(DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
+       ServerInstance->Logs->Log("USERS", DEBUG,"New UUID for user: %s (%s)", uuid.c_str(), uid.empty() ? "allocated new" : "used remote");
 
        user_hash::iterator finduuid = Instance->Users->uuidlist->find(uuid);
        if (finduuid == Instance->Users->uuidlist->end())
@@ -218,7 +229,7 @@ User::~User()
        if (this->MyClass)
        {
                this->MyClass->RefCount--;
-               ServerInstance->Log(DEBUG, "User destructor -- connect refcount now: %u", this->MyClass->RefCount);
+               ServerInstance->Logs->Log("USERS", DEBUG, "User destructor -- connect refcount now: %lu", this->MyClass->RefCount);
        }
        if (this->AllowedOperCommands)
        {
@@ -226,6 +237,18 @@ User::~User()
                AllowedOperCommands = NULL;
        }
 
+       if (this->AllowedUserModes)
+       {
+               delete[] AllowedUserModes;
+               AllowedUserModes = NULL;
+       }
+
+       if (this->AllowedChanModes)
+       {
+               delete[] AllowedChanModes;
+               AllowedChanModes = NULL;
+       }
+
        this->InvalidateCache();
        this->DecrementModes();
 
@@ -248,70 +271,73 @@ User::~User()
        ServerInstance->Users->uuidlist->erase(uuid);
 }
 
-char* User::MakeHost()
+const std::string& User::MakeHost()
 {
-       if (this->cached_makehost)
+       if (!this->cached_makehost.empty())
                return this->cached_makehost;
 
        char nhost[MAXBUF];
        /* This is much faster than snprintf */
        char* t = nhost;
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = host; *n; n++)
+       for(const char* n = host.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_makehost = strdup(nhost);
+       this->cached_makehost.assign(nhost);
 
        return this->cached_makehost;
 }
 
-char* User::MakeHostIP()
+const std::string& User::MakeHostIP()
 {
-       if (this->cached_hostip)
+       if (!this->cached_hostip.empty())
                return this->cached_hostip;
 
        char ihost[MAXBUF];
        /* This is much faster than snprintf */
        char* t = ihost;
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
        for(const char* n = this->GetIPString(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_hostip = strdup(ihost);
+       this->cached_hostip = ihost;
 
        return this->cached_hostip;
 }
 
 void User::CloseSocket()
 {
-       ServerInstance->SE->Shutdown(this, 2);
-       ServerInstance->SE->Close(this);
+       if (this->fd > -1)
+       {
+               ServerInstance->SE->Shutdown(this, 2);
+               ServerInstance->SE->Close(this);
+       }
 }
 
-char* User::GetFullHost()
+const std::string& User::GetFullHost()
 {
-       if (this->cached_fullhost)
+       if (!this->cached_fullhost.empty())
                return this->cached_fullhost;
 
        char result[MAXBUF];
        char* t = result;
-       for(char* n = nick; *n; n++)
+       for(const char* n = nick.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '!';
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = dhost; *n; n++)
+       for(const char* n = dhost.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_fullhost = strdup(result);
+       this->cached_fullhost = result;
 
        return this->cached_fullhost;
 }
@@ -322,7 +348,7 @@ char* User::MakeWildHost()
        char* t = nresult;
        *t++ = '*';     *t++ = '!';
        *t++ = '*';     *t++ = '@';
-       for(char* n = dhost; *n; n++)
+       for(const char* n = dhost.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
        return nresult;
@@ -343,34 +369,44 @@ int User::ReadData(void* buffer, size_t size)
 }
 
 
-char* User::GetFullRealHost()
+const std::string& User::GetFullRealHost()
 {
-       if (this->cached_fullrealhost)
+       if (!this->cached_fullrealhost.empty())
                return this->cached_fullrealhost;
 
        char fresult[MAXBUF];
        char* t = fresult;
-       for(char* n = nick; *n; n++)
+       for(const char* n = nick.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '!';
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = host; *n; n++)
+       for(const char* n = host.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_fullrealhost = strdup(fresult);
+       this->cached_fullrealhost = fresult;
 
        return this->cached_fullrealhost;
 }
 
 bool User::IsInvited(const irc::string &channel)
 {
-       for (InvitedList::iterator i = invites.begin(); i != invites.end(); i++)
+       time_t now = time(NULL);
+       InvitedList::iterator safei;
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
        {
-               if (channel == *i)
+               if (channel == i->first)
                {
+                       if (i->second != 0 && now > i->second)
+                       {
+                               /* Expired invite, remove it. */
+                               safei = i;
+                               --i;
+                               invites.erase(safei);
+                               continue;
+                       }
                        return true;
                }
        }
@@ -379,19 +415,44 @@ bool User::IsInvited(const irc::string &channel)
 
 InvitedList* User::GetInviteList()
 {
+       time_t now = time(NULL);
+       /* Weed out expired invites here. */
+       InvitedList::iterator safei;
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
+       {
+               if (i->second != 0 && now > i->second)
+               {
+                       /* Expired invite, remove it. */
+                       safei = i;
+                       --i;
+                       invites.erase(safei);
+               }
+       }
        return &invites;
 }
 
-void User::InviteTo(const irc::string &channel)
+void User::InviteTo(const irc::string &channel, time_t invtimeout)
 {
-       invites.push_back(channel);
+       time_t now = time(NULL);
+       if (invtimeout != 0 && now > invtimeout) return; /* Don't add invites that are expired from the get-go. */
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
+       {
+               if (channel == i->first)
+               {
+                       if (i->second != 0 && invtimeout > i->second)
+                       {
+                               i->second = invtimeout;
+                       }
+               }
+       }
+       invites.push_back(std::make_pair(channel, invtimeout));
 }
 
 void User::RemoveInvite(const irc::string &channel)
 {
        for (InvitedList::iterator i = invites.begin(); i != invites.end(); i++)
        {
-               if (channel == *i)
+               if (channel == i->first)
                {
                        invites.erase(i);
                        return;
@@ -399,6 +460,21 @@ void User::RemoveInvite(const irc::string &channel)
        }
 }
 
+bool User::HasModePermission(unsigned char mode, ModeType type)
+{
+       if (!IS_LOCAL(this))
+               return true;
+
+       if (!IS_OPER(this))
+               return false;
+
+       if (!AllowedUserModes || !AllowedChanModes)
+               return false;
+
+       return ((type == MODETYPE_USER ? AllowedUserModes : AllowedChanModes))[(mode - 'A')];
+       
+}
+
 bool User::HasPermission(const std::string &command)
 {
        /*
@@ -428,42 +504,68 @@ bool User::HasPermission(const std::string &command)
        return false;
 }
 
-/** NOTE: We cannot pass a const reference to this method.
- * The string is changed by the workings of the method,
- * so that if we pass const ref, we end up copying it to
- * something we can change anyway. Makes sense to just let
- * the compiler do that copy for us.
- */
-bool User::AddBuffer(std::string a)
+bool User::AddBuffer(const std::string &a)
 {
-       try
-       {
-               std::string::size_type i = a.rfind('\r');
+       std::string::size_type start = 0;
+       std::string::size_type i = a.find('\r');
 
+       /*
+        * The old implementation here took a copy, and rfind() on \r, removing as it found them, before
+        * copying a second time onto the recvq. That's ok, but involves three copies minimum (recv() to buffer,
+        * buffer to here, here to recvq) - The new method now copies twice (recv() to buffer, buffer to recvq).
+        *
+        * We use find() instead of rfind() for clarity, however unlike the old code, our scanning of the string is
+        * contiguous: as we specify a startpoint, we never see characters we have scanned previously, making this
+        * marginally faster in cases with a number of \r hidden early on in the buffer.
+        *
+        * How it works:
+        * Start at first pos of string, find first \r, append everything in the chunk (excluding \r) to recvq. Set
+        * i ahead of the \r, search for next \r, add next chunk to buffer... repeat.
+        *              -- w00t (7 may, 2008)
+        */
+       if (i == std::string::npos)
+       {
+               // no \r that we need to dance around, just add to buffer
+               recvq.append(a);
+       }
+       else
+       {
+               // While we can find the end of a chunk to add
                while (i != std::string::npos)
                {
-                       a.erase(i, 1);
-                       i = a.rfind('\r');
-               }
+                       // Append the chunk that we have
+                       recvq.append(a, start, (i - start));
 
-               if (a.length())
-                       recvq.append(a);
+                       // Start looking for the next one
+                       start = i + 1;
+                       i = a.find('\r', start);
+               }
 
-               if (this->MyClass && (recvq.length() > this->MyClass->GetRecvqMax()))
+               if (start != a.length())
                {
-                       this->SetWriteError("RecvQ exceeded");
-                       ServerInstance->SNO->WriteToSnoMask('A', "User %s RecvQ of %d exceeds connect class maximum of %d",this->nick,recvq.length(),this->MyClass->GetRecvqMax());
-                       return false;
+                       /*
+                        * This is here to catch a corner case when we get something like:
+                        * NICK w0
+                        * 0t\r\nU
+                        * SER ...
+                        * in successive calls to us.
+                        *
+                        * Without this conditional, the 'U' on the second case will be dropped,
+                        * which is most *certainly* not the behaviour we want!
+                        *              -- w00t
+                        */
+                       recvq.append(a, start, (a.length() - start));
                }
-
-               return true;
        }
 
-       catch (...)
+       if (this->MyClass && (recvq.length() > this->MyClass->GetRecvqMax()))
        {
-               ServerInstance->Log(DEBUG,"Exception in User::AddBuffer()");
+               this->SetWriteError("RecvQ exceeded");
+               ServerInstance->SNO->WriteToSnoMask('A', "User %s RecvQ of %lu exceeds connect class maximum of %lu",this->nick.c_str(),(unsigned long int)recvq.length(),this->MyClass->GetRecvqMax());
                return false;
        }
+
+       return true;
 }
 
 bool User::BufferIsReady()
@@ -511,7 +613,7 @@ std::string User::GetBuffer()
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::GetBuffer()");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::GetBuffer()");
                return "";
        }
 }
@@ -529,22 +631,14 @@ void User::AddWriteBuf(const std::string &data)
                 * to repeatedly add the text to the sendq!
                 */
                this->SetWriteError("SendQ exceeded");
-               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ of %d exceeds connect class maximum of %d",this->nick,sendq.length() + data.length(),this->MyClass->GetSendqMax());
+               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ of %lu exceeds connect class maximum of %lu",this->nick.c_str(),(unsigned long int)sendq.length() + data.length(),this->MyClass->GetSendqMax());
                return;
        }
 
-       try
-       {
-               if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
-                       sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
-               else
-                       sendq.append(data);
-       }
-       catch (...)
-       {
-               this->SetWriteError("SendQ exceeded");
-               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ got an exception",this->nick);
-       }
+       if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
+               sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
+       else
+               sendq.append(data);
 }
 
 // send AS MUCH OF THE USERS SENDQ as we are able to (might not be all of it)
@@ -594,7 +688,7 @@ void User::FlushWriteBuf()
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::FlushWriteBuf()");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::FlushWriteBuf()");
        }
 
        if (this->sendq.empty())
@@ -605,17 +699,9 @@ void User::FlushWriteBuf()
 
 void User::SetWriteError(const std::string &error)
 {
-       try
-       {
-               // don't try to set the error twice, its already set take the first string.
-               if (this->WriteError.empty())
-                       this->WriteError = error;
-       }
-
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::SetWriteError()");
-       }
+       // don't try to set the error twice, its already set take the first string.
+       if (this->WriteError.empty())
+               this->WriteError = error;
 }
 
 const char* User::GetWriteError()
@@ -632,13 +718,13 @@ void User::Oper(const std::string &opertype, const std::string &opername)
        try
        {
                this->modes[UM_OPERATOR] = 1;
-               this->WriteServ("MODE %s :+o", this->nick);
+               this->WriteServ("MODE %s :+o", this->nick.c_str());
                FOREACH_MOD(I_OnOper, OnOper(this, opertype));
-               ServerInstance->Log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
-               strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
+               ServerInstance->Logs->Log("OPER", DEFAULT, "%s!%s@%s opered as type: %s", this->nick.c_str(), this->ident.c_str(), this->host.c_str(), opertype.c_str());
+               this->oper.assign(opertype, 0, ServerInstance->Config->Limits.NickMax);
                ServerInstance->Users->all_opers.push_back(this);
 
-               opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper);
+               opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper.c_str());
                if (iter_opertype != ServerInstance->Config->opertypes.end())
                {
 
@@ -647,6 +733,15 @@ void User::Oper(const std::string &opertype, const std::string &opername)
                        else
                                AllowedOperCommands = new std::map<std::string, bool>;
 
+                       if (!AllowedChanModes)
+                               AllowedChanModes = new bool[64];
+
+                       if (!AllowedUserModes)
+                               AllowedUserModes = new bool[64];
+
+                       memset(AllowedUserModes, 0, 64);
+                       memset(AllowedChanModes, 0, 64);
+
                        char* Classes = strdup(iter_opertype->second);
                        char* myclass = strtok_r(Classes," ",&savept);
                        while (myclass)
@@ -654,7 +749,7 @@ void User::Oper(const std::string &opertype, const std::string &opername)
                                operclass_t::iterator iter_operclass = ServerInstance->Config->operclass.find(myclass);
                                if (iter_operclass != ServerInstance->Config->operclass.end())
                                {
-                                       char* CommandList = strdup(iter_operclass->second);
+                                       char* CommandList = strdup(iter_operclass->second.commandlist);
                                        mycmd = strtok_r(CommandList," ",&savept2);
                                        while (mycmd)
                                        {
@@ -662,6 +757,29 @@ void User::Oper(const std::string &opertype, const std::string &opername)
                                                mycmd = strtok_r(NULL," ",&savept2);
                                        }
                                        free(CommandList);
+                                       this->AllowedUserModes['o' - 'A'] = true; // Call me paranoid if you want.
+                                       for (unsigned char* c = (unsigned char*)iter_operclass->second.umodelist; *c; ++c)
+                                       {
+                                               if (*c == '*')
+                                               {
+                                                       memset(this->AllowedUserModes, (int)(true), 64);
+                                               }
+                                               else
+                                               {
+                                                       this->AllowedUserModes[*c - 'A'] = true;
+                                               }
+                                       }
+                                       for (unsigned char* c = (unsigned char*)iter_operclass->second.cmodelist; *c; ++c)
+                                       {
+                                               if (*c == '*')
+                                               {
+                                                       memset(this->AllowedChanModes, (int)(true), 64);
+                                               }
+                                               else
+                                               {
+                                                       this->AllowedChanModes[*c - 'A'] = true;
+                                               }
+                                       }
                                }
                                myclass = strtok_r(NULL," ",&savept);
                        }
@@ -673,45 +791,57 @@ void User::Oper(const std::string &opertype, const std::string &opername)
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::Oper()");
+               ServerInstance->Logs->Log("OPER", DEBUG,"Exception in User::Oper()");
        }
 }
 
 void User::UnOper()
 {
-       try
+       if (IS_OPER(this))
        {
-               if (IS_OPER(this))
-               {
-                       // unset their oper type (what IS_OPER checks), and remove +o
-                       *this->oper = 0;
-                       this->modes[UM_OPERATOR] = 0;
-                       
-                       // remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404
-                       ServerInstance->Users->all_opers.remove(this);
+               /* Remove all oper only modes from the user when the deoper - Bug #466*/
+               std::string moderemove("-");
 
-                       if (AllowedOperCommands)
+               for (unsigned char letter = 'A'; letter <= 'z'; letter++)
+               {
+                       if (letter != 'o')
                        {
-                               delete AllowedOperCommands;
-                               AllowedOperCommands = NULL;
+                               ModeHandler* mh = ServerInstance->Modes->FindMode(letter, MODETYPE_USER);
+                               if (mh && mh->NeedsOper())
+                                       moderemove += letter;
                        }
                }
-       }
 
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::UnOper()");
-       }
-}
+               std::vector<std::string> parameters;
+               parameters.push_back(this->nick);
+               parameters.push_back(moderemove);
 
-void User::QuitUser(InspIRCd* Instance, User *user, const std::string &quitreason, const char* operreason)
-{
-       Instance->Log(DEBUG,"QuitUser: %s '%s'", user->nick, quitreason.c_str());
-       user->Write("ERROR :Closing link (%s@%s) [%s]", user->ident, user->host, *operreason ? operreason : quitreason.c_str());
-       user->quietquit = false;
-       user->quitmsg = quitreason;
-       user->operquitmsg = operreason;
-       Instance->GlobalCulls.AddItem(user);
+               ServerInstance->Parser->CallHandler("MODE", parameters, this);
+
+               /* unset their oper type (what IS_OPER checks), and remove +o */
+               this->oper.clear();
+               this->modes[UM_OPERATOR] = 0;
+                       
+               /* remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404 */
+               ServerInstance->Users->all_opers.remove(this);
+
+               if (AllowedOperCommands)
+               {
+                       delete AllowedOperCommands;
+                       AllowedOperCommands = NULL;
+               }
+               if (AllowedUserModes)
+               {
+                       delete[] AllowedUserModes;
+                       AllowedUserModes = NULL;
+               }
+               if (AllowedChanModes)
+               {
+                       delete[] AllowedChanModes;
+                       AllowedChanModes = NULL;
+               }
+
+       }
 }
 
 /* adds or updates an entry in the whowas list */
@@ -735,18 +865,18 @@ void User::CheckClass()
 
        if ((!a) || (a->GetType() == CC_DENY))
        {
-               User::QuitUser(ServerInstance, this, "Unauthorised connection");
+               ServerInstance->Users->QuitUser(this, "Unauthorised connection");
                return;
        }
        else if ((a->GetMaxLocal()) && (ServerInstance->Users->LocalCloneCount(this) > a->GetMaxLocal()))
        {
-               User::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (local)");
+               ServerInstance->Users->QuitUser(this, "No more connections allowed from your host via this connect class (local)");
                ServerInstance->SNO->WriteToSnoMask('A', "WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a->GetMaxLocal(), this->GetIPString());
                return;
        }
        else if ((a->GetMaxGlobal()) && (ServerInstance->Users->GlobalCloneCount(this) > a->GetMaxGlobal()))
        {
-               User::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (global)");
+               ServerInstance->Users->QuitUser(this, "No more connections allowed from your host via this connect class (global)");
                ServerInstance->SNO->WriteToSnoMask('A', "WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s", a->GetMaxGlobal(), this->GetIPString());
                return;
        }
@@ -756,6 +886,25 @@ void User::CheckClass()
        this->MaxChans = a->GetMaxChans();
 }
 
+void User::CheckLines()
+{
+       const char* check[] = { "G" , "K", NULL };
+
+       if (!this->exempt)
+       {
+               for (int n = 0; check[n]; ++n)
+               {
+                       XLine *r = ServerInstance->XLines->MatchesLine(check[n], this);
+
+                       if (r)
+                       {
+                               r->Apply(this);
+                               return;
+                       }
+               }
+       }
+}
+
 void User::FullConnect()
 {
        ServerInstance->stats->statsConnects++;
@@ -774,38 +923,20 @@ void User::FullConnect()
         */
        if (this->MyClass && !this->MyClass->GetPass().empty() && !this->haspassed)
        {
-               User::QuitUser(ServerInstance, this, "Invalid password");
+               ServerInstance->Users->QuitUser(this, "Invalid password");
                return;
        }
 
-       if (!this->exempt)
-       {
-               GLine *r = (GLine *)ServerInstance->XLines->MatchesLine("G", this);
-
-               if (r)
-               {
-                       r->Apply(this);
-                       return;
-               }
-
-               KLine *n = (KLine *)ServerInstance->XLines->MatchesLine("K", this);
-
-               if (n)
-               {
-                       n->Apply(this);
-                       return;
-               }
-       }
+       CheckLines();
 
        this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",ServerInstance->Config->Network);
-       this->WriteServ("001 %s :Welcome to the %s IRC Network %s!%s@%s",this->nick, ServerInstance->Config->Network, this->nick, this->ident, this->host);
-       this->WriteServ("002 %s :Your host is %s, running version %s",this->nick,ServerInstance->Config->ServerName,VERSION);
-       this->WriteServ("003 %s :This server was created %s %s", this->nick, __TIME__, __DATE__);
-       this->WriteServ("004 %s %s %s %s %s %s", this->nick, ServerInstance->Config->ServerName, VERSION, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
+       this->WriteNumeric(001, "%s :Welcome to the %s IRC Network %s!%s@%s",this->nick.c_str(), ServerInstance->Config->Network, this->nick.c_str(), this->ident.c_str(), this->host.c_str());
+       this->WriteNumeric(002, "%s :Your host is %s, running version InspIRCd-1.2",this->nick.c_str(),ServerInstance->Config->ServerName);
+       this->WriteNumeric(003, "%s :This server was created %s %s", this->nick.c_str(), __TIME__, __DATE__);
+       this->WriteNumeric(004, "%s %s InspIRCd-1.2 %s %s %s", this->nick.c_str(), ServerInstance->Config->ServerName, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
 
        ServerInstance->Config->Send005(this);
-
-       this->WriteServ("042 %s %s :your unique ID", this->nick, this->uuid);
+       this->WriteNumeric(42, "%s %s :your unique ID", this->nick.c_str(), this->uuid.c_str());
 
 
        this->ShowMOTD();
@@ -816,9 +947,9 @@ void User::FullConnect()
 
        /* Trigger LUSERS output, give modules a chance too */
        int MOD_RESULT = 0;
-       FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", NULL, 0, this, true, "LUSERS"));
+       FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", std::vector<std::string>(), this, true, "LUSERS"));
        if (!MOD_RESULT)
-               ServerInstance->CallCommandHandler("LUSERS", NULL, 0, this);
+               ServerInstance->CallCommandHandler("LUSERS", std::vector<std::string>(), this);
 
        /*
         * We don't set REG_ALL until triggering OnUserConnect, so some module events don't spew out stuff
@@ -828,11 +959,12 @@ void User::FullConnect()
 
        this->registered = REG_ALL;
 
-       FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
+       ServerInstance->PI->Introduce(this);
 
-       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString(), this->fullname);
+       FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
 
-       ServerInstance->Log(DEBUG, "BanCache: Adding NEGATIVE hit for %s", this->GetIPString());
+       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick.c_str(), this->ident.c_str(), this->host.c_str(), this->GetIPString(), this->fullname.c_str());
+       ServerInstance->Logs->Log("BANCACHE", DEBUG, "BanCache: Adding NEGATIVE hit for %s", this->GetIPString());
        ServerInstance->BanCache->AddHit(this->GetIPString(), "", "");
 }
 
@@ -842,97 +974,61 @@ void User::FullConnect()
  */
 User* User::UpdateNickHash(const char* New)
 {
-       try
-       {
-               //user_hash::iterator newnick;
-               user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
+       //user_hash::iterator newnick;
+       user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
 
-               if (!strcasecmp(this->nick,New))
-                       return oldnick->second;
+       if (!irc::string(this->nick.c_str()).compare(New))
+               return oldnick->second;
 
-               if (oldnick == ServerInstance->Users->clientlist->end())
-                       return NULL; /* doesnt exist */
+       if (oldnick == ServerInstance->Users->clientlist->end())
+               return NULL; /* doesnt exist */
 
-               User* olduser = oldnick->second;
-               (*(ServerInstance->Users->clientlist))[New] = olduser;
-               ServerInstance->Users->clientlist->erase(oldnick);
-               return olduser;
-       }
-
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::UpdateNickHash()");
-               return NULL;
-       }
+       User* olduser = oldnick->second;
+       (*(ServerInstance->Users->clientlist))[New] = olduser;
+       ServerInstance->Users->clientlist->erase(oldnick);
+       return olduser;
 }
 
 void User::InvalidateCache()
 {
        /* Invalidate cache */
-       if (cached_fullhost)
-               free(cached_fullhost);
-       if (cached_hostip)
-               free(cached_hostip);
-       if (cached_makehost)
-               free(cached_makehost);
-       if (cached_fullrealhost)
-               free(cached_fullrealhost);
-       cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
+       cached_fullhost.clear();
+       cached_hostip.clear();
+       cached_makehost.clear();
+       cached_fullrealhost.clear();
 }
 
 bool User::ForceNickChange(const char* newnick)
 {
-       try
-       {
-               /*
-                * XXX this makes no sense..
-                * why do we do nothing for change on users not REG_ALL?
-                * why do we trigger events twice for everyone previously (and just them now)
-                * i think the first if () needs removing totally, or? -- w00t
-                */
-               if (this->registered != REG_ALL)
-               {
-                       int MOD_RESULT = 0;
-
-                       this->InvalidateCache();
+       int MOD_RESULT = 0;
 
-                       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(this, newnick));
+       this->InvalidateCache();
 
-                       if (MOD_RESULT)
-                       {
-                               ServerInstance->stats->statsCollisions++;
-                               return false;
-                       }
+       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(this, newnick));
 
-                       if (ServerInstance->XLines->MatchesLine("Q",newnick))
-                       {
-                               ServerInstance->stats->statsCollisions++;
-                               return false;
-                       }
-               }
-               else
-               {
-                       std::deque<classbase*> dummy;
-                       Command* nickhandler = ServerInstance->Parser->GetHandler("NICK");
-                       if (nickhandler)
-                       {
-                               nickhandler->HandleInternal(1, dummy);
-                               bool result = (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
-                               nickhandler->HandleInternal(0, dummy);
-                               return result;
-                       }
-               }
+       if (MOD_RESULT)
+       {
+               ServerInstance->stats->statsCollisions++;
                return false;
        }
 
-       catch (...)
+       std::deque<classbase*> dummy;
+       Command* nickhandler = ServerInstance->Parser->GetHandler("NICK");
+       if (nickhandler) // wtfbbq, when would this not be here
        {
-               ServerInstance->Log(DEBUG,"Exception in User::ForceNickChange()");
-               return false;
+               std::vector<std::string> parameters;
+               nickhandler->HandleInternal(1, dummy);
+               parameters.push_back(newnick);
+               bool result = (ServerInstance->Parser->CallHandler("NICK", parameters, this) == CMD_SUCCESS);
+               nickhandler->HandleInternal(0, dummy);
+               return result;
        }
+
+       // Unreachable, we hope
+       return false;
 }
 
-void User::SetSockAddr(int protocol_family, const char* ip, int port)
+void User::SetSockAddr(int protocol_family, const char* sip, int port)
 {
        this->cachedip = "";
 
@@ -944,7 +1040,7 @@ void User::SetSockAddr(int protocol_family, const char* ip, int port)
                        sockaddr_in6* sin = new sockaddr_in6;
                        sin->sin6_family = AF_INET6;
                        sin->sin6_port = port;
-                       inet_pton(AF_INET6, ip, &sin->sin6_addr);
+                       inet_pton(AF_INET6, sip, &sin->sin6_addr);
                        this->ip = (sockaddr*)sin;
                }
                break;
@@ -954,12 +1050,12 @@ void User::SetSockAddr(int protocol_family, const char* ip, int port)
                        sockaddr_in* sin = new sockaddr_in;
                        sin->sin_family = AF_INET;
                        sin->sin_port = port;
-                       inet_pton(AF_INET, ip, &sin->sin_addr);
+                       inet_pton(AF_INET, sip, &sin->sin_addr);
                        this->ip = (sockaddr*)sin;
                }
                break;
                default:
-                       ServerInstance->Log(DEBUG,"Uh oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
+                       ServerInstance->Logs->Log("USERS",DEBUG,"Uh oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick.c_str());
                break;
        }
 }
@@ -1004,7 +1100,7 @@ int User::GetProtocolFamily()
  * XXX the duplication here is horrid..
  * do we really need two methods doing essentially the same thing?
  */
-const char* User::GetIPString()
+const char* User::GetIPString(bool translate4in6)
 {
        static char buf[1024];
 
@@ -1028,6 +1124,12 @@ const char* User::GetIPString()
                        {
                                strlcpy(&temp[1], buf, sizeof(temp) - 1);
                                *temp = '0';
+                               if (translate4in6 && !strncmp(temp, "0::ffff:", 8))
+                               {
+                                       this->cachedip = temp + 8;
+                                       return temp + 8;
+                               }
+
                                this->cachedip = temp;
                                return temp;
                        }
@@ -1066,31 +1168,27 @@ void User::Write(std::string text)
 
        try
        {
-               /* ServerInstance->Log(DEBUG,"C[%d] O %s", this->GetFd(), text.c_str());
-                * WARNING: The above debug line is VERY loud, do NOT
-                * enable it till we have a good way of filtering it
-                * out of the logs (e.g. 1.2 would be good).
-                */
+               ServerInstance->Logs->Log("USEROUTPUT", DEBUG,"C[%d] O %s", this->GetFd(), text.c_str());
                text.append("\r\n");
        }
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::Write() std::string::append");
+               ServerInstance->Logs->Log("USEROUTPUT", DEBUG,"Exception in User::Write() std::string::append");
                return;
        }
 
-       if (ServerInstance->Config->GetIOHook(this->GetPort()))
+       if (this->io)
        {
+               /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
+                * implement their own buffering mechanisms
+                */
                try
                {
-                       /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
-                        * implement their own buffering mechanisms
-                        */
-                       ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length());
+                       this->io->OnRawSocketWrite(this->fd, text.data(), text.length());
                }
                catch (CoreException& modexcept)
                {
-                       ServerInstance->Log(DEBUG, "%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
+                       ServerInstance->Logs->Log("USEROUTPUT", DEBUG, "%s threw an exception: %s", modexcept.GetSource(), modexcept.GetReason());
                }
        }
        else
@@ -1139,11 +1237,37 @@ void User::WriteServ(const char* text, ...)
 }
 
 
+void User::WriteNumeric(unsigned int numeric, const char* text, ...)
+{
+       va_list argsPtr;
+       char textbuffer[MAXBUF];
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteNumeric(numeric, std::string(textbuffer));
+}
+
+void User::WriteNumeric(unsigned int numeric, const std::string &text)
+{
+       char textbuffer[MAXBUF];
+       int MOD_RESULT = 0;
+
+       FOREACH_RESULT(I_OnNumeric, OnNumeric(this, numeric, text));
+
+       if (MOD_RESULT)
+               return;
+
+       snprintf(textbuffer,MAXBUF,":%s %03u %s",ServerInstance->Config->ServerName, numeric, text.c_str());
+       this->Write(std::string(textbuffer));
+}
+
 void User::WriteFrom(User *user, const std::string &text)
 {
        char tb[MAXBUF];
 
-       snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str());
+       snprintf(tb,MAXBUF,":%s %s",user->GetFullHost().c_str(),text.c_str());
 
        this->Write(std::string(tb));
 }
@@ -1201,47 +1325,42 @@ void User::WriteCommon(const char* text, ...)
 
 void User::WriteCommon(const std::string &text)
 {
-       try
-       {
-               bool sent_to_at_least_one = false;
-               char tb[MAXBUF];
+       bool sent_to_at_least_one = false;
+       char tb[MAXBUF];
 
-               if (this->registered != REG_ALL)
-                       return;
+       if (this->registered != REG_ALL)
+               return;
 
-               uniq_id++;
+       uniq_id++;
 
-               /* We dont want to be doing this n times, just once */
-               snprintf(tb,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
-               std::string out = tb;
+       if (!already_sent)
+               InitializeAlreadySent(ServerInstance->SE);
 
-               for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
+       /* We dont want to be doing this n times, just once */
+       snprintf(tb,MAXBUF,":%s %s",this->GetFullHost().c_str(),text.c_str());
+       std::string out = tb;
+
+       for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
+       {
+               CUList* ulist = v->first->GetUsers();
+               for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                {
-                       CUList* ulist = v->first->GetUsers();
-                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
                        {
-                               if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
-                               {
-                                       already_sent[i->first->fd] = uniq_id;
-                                       i->first->Write(out);
-                                       sent_to_at_least_one = true;
-                               }
+                               already_sent[i->first->fd] = uniq_id;
+                               i->first->Write(out);
+                               sent_to_at_least_one = true;
                        }
                }
-
-               /*
-                * if the user was not in any channels, no users will receive the text. Make sure the user
-                * receives their OWN message for WriteCommon
-                */
-               if (!sent_to_at_least_one)
-               {
-                       this->Write(std::string(tb));
-               }
        }
 
-       catch (...)
+       /*
+        * if the user was not in any channels, no users will receive the text. Make sure the user
+        * receives their OWN message for WriteCommon
+        */
+       if (!sent_to_at_least_one)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::WriteCommon()");
+               this->Write(std::string(tb));
        }
 }
 
@@ -1271,8 +1390,12 @@ void User::WriteCommonQuit(const std::string &normal_text, const std::string &op
                return;
 
        uniq_id++;
-       snprintf(tb1,MAXBUF,":%s QUIT :%s",this->GetFullHost(),normal_text.c_str());
-       snprintf(tb2,MAXBUF,":%s QUIT :%s",this->GetFullHost(),oper_text.c_str());
+
+       if (!already_sent)
+               InitializeAlreadySent(ServerInstance->SE);
+
+       snprintf(tb1,MAXBUF,":%s QUIT :%s",this->GetFullHost().c_str(),normal_text.c_str());
+       snprintf(tb2,MAXBUF,":%s QUIT :%s",this->GetFullHost().c_str(),oper_text.c_str());
        std::string out1 = tb1;
        std::string out2 = tb2;
 
@@ -1302,7 +1425,11 @@ void User::WriteCommonExcept(const std::string &text)
                return;
 
        uniq_id++;
-       snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
+
+       if (!already_sent)
+               InitializeAlreadySent(ServerInstance->SE);
+
+       snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost().c_str(),text.c_str());
        out1 = tb1;
 
        for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
@@ -1325,7 +1452,7 @@ void User::WriteCommonExcept(const std::string &text)
 
 void User::WriteWallOps(const std::string &text)
 {
-       if (!IS_OPER(this) && IS_LOCAL(this))
+       if (!IS_LOCAL(this))
                return;
 
        std::string wallop("WALLOPS :");
@@ -1341,6 +1468,9 @@ void User::WriteWallOps(const std::string &text)
 
 void User::WriteWallOps(const char* text, ...)
 {
+       if (!IS_LOCAL(this))
+               return;
+
        char textbuffer[MAXBUF];
        va_list argsPtr;
 
@@ -1382,7 +1512,7 @@ bool User::SharesChannelWith(User *other)
 
 bool User::ChangeName(const char* gecos)
 {
-       if (!strcmp(gecos, this->fullname))
+       if (!this->fullname.compare(gecos))
                return true;
 
        if (IS_LOCAL(this))
@@ -1393,29 +1523,30 @@ bool User::ChangeName(const char* gecos)
                        return false;
                FOREACH_MOD(I_OnChangeName,OnChangeName(this,gecos));
        }
-       strlcpy(this->fullname,gecos,MAXGECOS+1);
+       this->fullname.assign(gecos, 0, ServerInstance->Config->Limits.MaxGecos);
 
        return true;
 }
 
-bool User::ChangeDisplayedHost(const char* host)
+bool User::ChangeDisplayedHost(const char* shost)
 {
-       if (!strcmp(host, this->dhost))
+       if (dhost == shost)
                return true;
 
        if (IS_LOCAL(this))
        {
                int MOD_RESULT = 0;
-               FOREACH_RESULT(I_OnChangeLocalUserHost,OnChangeLocalUserHost(this,host));
+               FOREACH_RESULT(I_OnChangeLocalUserHost,OnChangeLocalUserHost(this,shost));
                if (MOD_RESULT)
                        return false;
-               FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,host));
+               FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,shost));
        }
+
        if (this->ServerInstance->Config->CycleHosts)
                this->WriteCommonExcept("QUIT :Changing hosts");
 
        /* Fix by Om: User::dhost is 65 long, this was truncating some long hosts */
-       strlcpy(this->dhost,host,64);
+       this->dhost.assign(shost, 0, 64);
 
        this->InvalidateCache();
 
@@ -1423,28 +1554,28 @@ bool User::ChangeDisplayedHost(const char* host)
        {
                for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
                {
-                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name);
+                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name.c_str());
                        std::string n = this->ServerInstance->Modes->ModeString(this, i->first);
                        if (n.length() > 0)
-                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name, n.c_str());
+                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name.c_str(), n.c_str());
                }
        }
 
        if (IS_LOCAL(this))
-               this->WriteServ("396 %s %s :is now your displayed host",this->nick,this->dhost);
+               this->WriteNumeric(396, "%s %s :is now your displayed host",this->nick.c_str(),this->dhost.c_str());
 
        return true;
 }
 
 bool User::ChangeIdent(const char* newident)
 {
-       if (!strcmp(newident, this->ident))
+       if (!this->ident.compare(newident))
                return true;
 
        if (this->ServerInstance->Config->CycleHosts)
                this->WriteCommonExcept("%s","QUIT :Changing ident");
 
-       strlcpy(this->ident, newident, IDENTMAX+1);
+       this->ident.assign(newident, 0, ServerInstance->Config->Limits.IdentMax + 1);
 
        this->InvalidateCache();
 
@@ -1452,17 +1583,17 @@ bool User::ChangeIdent(const char* newident)
        {
                for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
                {
-                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name);
+                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name.c_str());
                        std::string n = this->ServerInstance->Modes->ModeString(this, i->first);
                        if (n.length() > 0)
-                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name, n.c_str());
+                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name.c_str(), n.c_str());
                }
        }
 
        return true;
 }
 
-void User::SendAll(const char* command, char* text, ...)
+void User::SendAll(const char* command, const char* text, ...)
 {
        char textbuffer[MAXBUF];
        char formatbuffer[MAXBUF];
@@ -1472,7 +1603,7 @@ void User::SendAll(const char* command, char* text, ...)
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
-       snprintf(formatbuffer,MAXBUF,":%s %s $* :%s", this->GetFullHost(), command, textbuffer);
+       snprintf(formatbuffer,MAXBUF,":%s %s $* :%s", this->GetFullHost().c_str(), command, textbuffer);
        std::string fmt = formatbuffer;
 
        for (std::vector<User*>::const_iterator i = ServerInstance->Users->local_users.begin(); i != ServerInstance->Users->local_users.end(); i++)
@@ -1484,27 +1615,21 @@ void User::SendAll(const char* command, char* text, ...)
 
 std::string User::ChannelList(User* source)
 {
-       try
+       std::string list;
+
+       for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
        {
-               std::string list;
-               for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
+               /* If the target is the same as the sender, let them see all their channels.
+                * If the channel is NOT private/secret OR the user shares a common channel
+                * If the user is an oper, and the <options:operspywhois> option is set.
+                */
+               if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
                {
-                       /* If the target is the same as the sender, let them see all their channels.
-                        * If the channel is NOT private/secret OR the user shares a common channel
-                        * If the user is an oper, and the <options:operspywhois> option is set.
-                        */
-                       if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
-                       {
-                               list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
-                       }
+                       list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
                }
-               return list;
-       }
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::ChannelList()");
-               return "";
        }
+
+       return list;
 }
 
 void User::SplitChanList(User* dest, const std::string &cl)
@@ -1513,42 +1638,34 @@ void User::SplitChanList(User* dest, const std::string &cl)
        std::ostringstream prefix;
        std::string::size_type start, pos, length;
 
-       try
+       prefix << this->nick << " " << dest->nick << " :";
+       line = prefix.str();
+       int namelen = strlen(ServerInstance->Config->ServerName) + 6;
+
+       for (start = 0; (pos = cl.find(' ', start)) != std::string::npos; start = pos+1)
        {
-               prefix << this->nick << " " << dest->nick << " :";
-               line = prefix.str();
-               int namelen = strlen(ServerInstance->Config->ServerName) + 6;
+               length = (pos == std::string::npos) ? cl.length() : pos;
 
-               for (start = 0; (pos = cl.find(' ', start)) != std::string::npos; start = pos+1)
+               if (line.length() + namelen + length - start > 510)
                {
-                       length = (pos == std::string::npos) ? cl.length() : pos;
-
-                       if (line.length() + namelen + length - start > 510)
-                       {
-                               ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
-                               line = prefix.str();
-                       }
-
-                       if(pos == std::string::npos)
-                       {
-                               line.append(cl.substr(start, length - start));
-                               break;
-                       }
-                       else
-                       {
-                               line.append(cl.substr(start, length - start + 1));
-                       }
+                       ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
+                       line = prefix.str();
                }
 
-               if (line.length())
+               if(pos == std::string::npos)
                {
-                       ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
+                       line.append(cl.substr(start, length - start));
+                       break;
+               }
+               else
+               {
+                       line.append(cl.substr(start, length - start + 1));
                }
        }
 
-       catch (...)
+       if (line.length())
        {
-               ServerInstance->Log(DEBUG,"Exception in User::SplitChanList()");
+               ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
        }
 }
 
@@ -1572,14 +1689,20 @@ ConnectClass* User::SetClass(const std::string &explicit_name)
        if (!IS_LOCAL(this))
                return NULL;
 
+       ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Setting connect class for UID %s", this->uuid.c_str());
+
        if (!explicit_name.empty())
        {
                for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
                {
                        ConnectClass* c = *i;
 
-                       if (explicit_name == c->GetName() && !c->GetDisabled())
+                       if (c->GetDisabled())
+                               continue; // can't possibly match, removed from conf
+
+                       if (explicit_name == c->GetName())
                        {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Explicitly set to %s", explicit_name.c_str());
                                found = c;
                        }
                }
@@ -1590,48 +1713,75 @@ ConnectClass* User::SetClass(const std::string &explicit_name)
                {
                        ConnectClass* c = *i;
 
-                       if (((match(this->GetIPString(),c->GetHost().c_str(),true)) || (match(this->host,c->GetHost().c_str()))))
+                       if (c->GetType() == CC_ALLOW)
                        {
-                               if (c->GetPort())
-                               {
-                                       if (this->GetPort() == c->GetPort() && !c->GetDisabled())
-                                       {
-                                               found = c;
-                                       }
-                                       else
-                                               continue;
-                               }
-                               else
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "ALLOW %s %d %s", c->GetHost().c_str(), c->GetPort(), c->GetName().c_str());
+                       }
+                       else
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "DENY %s %d %s", c->GetHost().c_str(), c->GetPort(), c->GetName().c_str());
+                       }
+
+                       /* if it's disabled, we can't match this one. */
+                       if (c->GetDisabled())
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Class disabled");
+                               continue;
+                       }
+
+                       /* check if host matches.. */
+                       if (((!match(this->GetIPString(),c->GetHost(),true)) && (!match(this->host,c->GetHost()))))
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "No host match (for %s)", c->GetHost().c_str());
+                               continue;
+                       }
+
+                       /*
+                        * deny change if change will take class over the limit check it HERE, not after we found a matching class,
+                        * because we should attempt to find another class if this one doesn't match us. -- w00t
+                        */
+                       if (c->limit && (c->RefCount + 1 >= c->limit))
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "OOPS: Connect class limit (%lu) hit, denying", c->limit);
+                               continue;
+                       }
+
+                       /* if it requires a port ... */
+                       if (c->GetPort())
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Requires port (%d)", c->GetPort());
+
+                               /* and our port doesn't match, fail. */
+                               if (this->GetPort() != c->GetPort())
                                {
-                                       if (!c->GetDisabled())
-                                               found = c;
+                                       ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Port match failed (%d)", this->GetPort());
+                                       continue;
                                }
                        }
+
+                       /* we stop at the first class that meets ALL critera. */
+                       found = c;
+                       break;
                }
        }
 
-       /* ensure we don't fuck things up refcount wise, only remove them from a class if we find a new one :P */
+       /*
+        * Okay, assuming we found a class that matches.. switch us into that class, keeping refcounts up to date.
+        */
        if (found)
        {
-               /* deny change if change will take class over the limit */
-               if (found->limit && (found->RefCount + 1 >= found->limit))
-               {
-                       ServerInstance->Log(DEBUG, "OOPS: Connect class limit (%u) hit, denying", found->limit);
-                       return this->MyClass;
-               }
-
-               /* should always be valid, but just in case .. */
+               /* only fiddle with refcounts if they are already in a class .. */
                if (this->MyClass)
                {
                        if (found == this->MyClass) // no point changing this shit :P
                                return this->MyClass;
                        this->MyClass->RefCount--;
-                       ServerInstance->Log(DEBUG, "Untying user from connect class -- refcount: %u", this->MyClass->RefCount);
+                       ServerInstance->Logs->Log("USERS", DEBUG, "Untying user from connect class -- refcount: %lu", this->MyClass->RefCount);
                }
 
                this->MyClass = found;
                this->MyClass->RefCount++;
-               ServerInstance->Log(DEBUG, "User tied to new class -- connect refcount now: %u", this->MyClass->RefCount);
+               ServerInstance->Logs->Log("USERS", DEBUG, "User tied to new class -- connect refcount now: %lu", this->MyClass->RefCount);
        }
 
        return this->MyClass;
@@ -1664,7 +1814,7 @@ void User::PurgeEmptyChannels()
                        }
                        catch (...)
                        {
-                               ServerInstance->Log(DEBUG,"Exception in User::PurgeEmptyChannels to_delete.push_back()");
+                               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::PurgeEmptyChannels to_delete.push_back()");
                        }
                }
        }
@@ -1689,31 +1839,31 @@ void User::ShowMOTD()
 {
        if (!ServerInstance->Config->MOTD.size())
        {
-               this->WriteServ("422 %s :Message of the day file is missing.",this->nick);
+               this->WriteNumeric(422, "%s :Message of the day file is missing.",this->nick.c_str());
                return;
        }
-       this->WriteServ("375 %s :%s message of the day", this->nick, ServerInstance->Config->ServerName);
+       this->WriteNumeric(375, "%s :%s message of the day", this->nick.c_str(), ServerInstance->Config->ServerName);
 
        for (file_cache::iterator i = ServerInstance->Config->MOTD.begin(); i != ServerInstance->Config->MOTD.end(); i++)
-               this->WriteServ("372 %s :- %s",this->nick,i->c_str());
+               this->WriteNumeric(372, "%s :- %s",this->nick.c_str(),i->c_str());
 
-       this->WriteServ("376 %s :End of message of the day.", this->nick);
+       this->WriteNumeric(376, "%s :End of message of the day.", this->nick.c_str());
 }
 
 void User::ShowRULES()
 {
        if (!ServerInstance->Config->RULES.size())
        {
-               this->WriteServ("434 %s :RULES File is missing",this->nick);
+               this->WriteNumeric(434, "%s :RULES File is missing",this->nick.c_str());
                return;
        }
 
-       this->WriteServ("308 %s :- %s Server Rules -",this->nick,ServerInstance->Config->ServerName);
+       this->WriteNumeric(308, "%s :- %s Server Rules -",this->nick.c_str(),ServerInstance->Config->ServerName);
 
        for (file_cache::iterator i = ServerInstance->Config->RULES.begin(); i != ServerInstance->Config->RULES.end(); i++)
-               this->WriteServ("232 %s :- %s",this->nick,i->c_str());
+               this->WriteNumeric(232, "%s :- %s",this->nick.c_str(),i->c_str());
 
-       this->WriteServ("309 %s :End of RULES command.",this->nick);
+       this->WriteNumeric(309, "%s :End of RULES command.",this->nick.c_str());
 }
 
 void User::HandleEvent(EventType et, int errornum)
@@ -1742,7 +1892,7 @@ void User::HandleEvent(EventType et, int errornum)
        }
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::HandleEvent intercepted");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::HandleEvent intercepted");
        }
 
        /* If the user has raised an error whilst being processed, quit them now we're safe to */
@@ -1750,7 +1900,7 @@ void User::HandleEvent(EventType et, int errornum)
        {
                if (!WriteError.empty())
                {
-                       User::QuitUser(ServerInstance, this, GetWriteError());
+                       ServerInstance->Users->QuitUser(this, GetWriteError());
                }
        }
 }
@@ -1760,9 +1910,9 @@ void User::SetOperQuit(const std::string &oquit)
        operquitmsg = oquit;
 }
 
-const char* User::GetOperQuit()
+const std::string& User::GetOperQuit()
 {
-       return operquitmsg.c_str();
+       return operquitmsg;
 }
 
 void User::IncreasePenalty(int increase)