]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Add ProtocolInterface::Introduce() to prevent confusion over event ordering, and...
[user/henk/code/inspircd.git] / src / users.cpp
index cdacdc5c2ab52f126e59a093306e7f3bf8071310..143313af20e7fd457522aafbf146f1aa88e3f3c9 100644 (file)
 #include "bancache.h"
 #include "commands/cmd_whowas.h"
 
+/* XXX: Used for speeding up WriteCommon operations */
+unsigned long uniq_id = 1;
+
 static unsigned long* already_sent = NULL;
 
 
 void InitializeAlreadySent(SocketEngine* SE)
 {
        already_sent = new unsigned long[SE->GetMaxFds()];
-       memset(already_sent, 0, sizeof(already_sent));
+       memset(already_sent, 0, SE->GetMaxFds() * sizeof(unsigned long));
 }
 
-/* XXX: Used for speeding up WriteCommon operations */
-unsigned long uniq_id = 1;
 
 std::string User::ProcessNoticeMasks(const char *sm)
 {
@@ -81,7 +82,7 @@ std::string User::ProcessNoticeMasks(const char *sm)
                                        }
                                }
                                else
-                                       this->WriteNumeric(501, "%s %c :is unknown snomask char to me", this->nick, *c);
+                                       this->WriteNumeric(501, "%s %c :is unknown snomask char to me", this->nick.c_str(), *c);
 
                                oldadding = adding;
                        break;
@@ -184,7 +185,6 @@ void User::DecrementModes()
 
 User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance)
 {
-       *password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = *uuid = 0;
        server = (char*)Instance->FindServerNamePtr(Instance->Config->ServerName);
        reset_due = ServerInstance->Time();
        age = ServerInstance->Time();
@@ -208,15 +208,13 @@ User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance
        invites.clear();
        memset(modes,0,sizeof(modes));
        memset(snomasks,0,sizeof(snomasks));
-       /* Invalidate cache */
-       cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
 
        if (uid.empty())
-               strlcpy(uuid, Instance->GetUID().c_str(), UUID_LENGTH);
+               uuid.assign(Instance->GetUID(), 0, UUID_LENGTH - 1);
        else
-               strlcpy(uuid, uid.c_str(), UUID_LENGTH);
+               uuid.assign(uid, 0, UUID_LENGTH - 1);
 
-       ServerInstance->Logs->Log("USERS", DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
+       ServerInstance->Logs->Log("USERS", DEBUG,"New UUID for user: %s (%s)", uuid.c_str(), uid.empty() ? "allocated new" : "used remote");
 
        user_hash::iterator finduuid = Instance->Users->uuidlist->find(uuid);
        if (finduuid == Instance->Users->uuidlist->end())
@@ -273,42 +271,42 @@ User::~User()
        ServerInstance->Users->uuidlist->erase(uuid);
 }
 
-char* User::MakeHost()
+const std::string& User::MakeHost()
 {
-       if (this->cached_makehost)
+       if (!this->cached_makehost.empty())
                return this->cached_makehost;
 
        char nhost[MAXBUF];
        /* This is much faster than snprintf */
        char* t = nhost;
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = host; *n; n++)
+       for(const char* n = host.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_makehost = strdup(nhost);
+       this->cached_makehost.assign(nhost);
 
        return this->cached_makehost;
 }
 
-char* User::MakeHostIP()
+const std::string& User::MakeHostIP()
 {
-       if (this->cached_hostip)
+       if (!this->cached_hostip.empty())
                return this->cached_hostip;
 
        char ihost[MAXBUF];
        /* This is much faster than snprintf */
        char* t = ihost;
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
        for(const char* n = this->GetIPString(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_hostip = strdup(ihost);
+       this->cached_hostip = ihost;
 
        return this->cached_hostip;
 }
@@ -322,24 +320,24 @@ void User::CloseSocket()
        }
 }
 
-char* User::GetFullHost()
+const std::string& User::GetFullHost()
 {
-       if (this->cached_fullhost)
+       if (!this->cached_fullhost.empty())
                return this->cached_fullhost;
 
        char result[MAXBUF];
        char* t = result;
-       for(char* n = nick; *n; n++)
+       for(const char* n = nick.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '!';
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = dhost; *n; n++)
+       for(const char* n = dhost.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_fullhost = strdup(result);
+       this->cached_fullhost = result;
 
        return this->cached_fullhost;
 }
@@ -350,7 +348,7 @@ char* User::MakeWildHost()
        char* t = nresult;
        *t++ = '*';     *t++ = '!';
        *t++ = '*';     *t++ = '@';
-       for(char* n = dhost; *n; n++)
+       for(const char* n = dhost.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
        return nresult;
@@ -371,24 +369,24 @@ int User::ReadData(void* buffer, size_t size)
 }
 
 
-char* User::GetFullRealHost()
+const std::string& User::GetFullRealHost()
 {
-       if (this->cached_fullrealhost)
+       if (!this->cached_fullrealhost.empty())
                return this->cached_fullrealhost;
 
        char fresult[MAXBUF];
        char* t = fresult;
-       for(char* n = nick; *n; n++)
+       for(const char* n = nick.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '!';
-       for(char* n = ident; *n; n++)
+       for(const char* n = ident.c_str(); *n; n++)
                *t++ = *n;
        *t++ = '@';
-       for(char* n = host; *n; n++)
+       for(const char* n = host.c_str(); *n; n++)
                *t++ = *n;
        *t = 0;
 
-       this->cached_fullrealhost = strdup(fresult);
+       this->cached_fullrealhost = fresult;
 
        return this->cached_fullrealhost;
 }
@@ -506,42 +504,68 @@ bool User::HasPermission(const std::string &command)
        return false;
 }
 
-/** NOTE: We cannot pass a const reference to this method.
- * The string is changed by the workings of the method,
- * so that if we pass const ref, we end up copying it to
- * something we can change anyway. Makes sense to just let
- * the compiler do that copy for us.
- */
-bool User::AddBuffer(std::string a)
+bool User::AddBuffer(const std::string &a)
 {
-       try
-       {
-               std::string::size_type i = a.rfind('\r');
+       std::string::size_type start = 0;
+       std::string::size_type i = a.find('\r');
 
+       /*
+        * The old implementation here took a copy, and rfind() on \r, removing as it found them, before
+        * copying a second time onto the recvq. That's ok, but involves three copies minimum (recv() to buffer,
+        * buffer to here, here to recvq) - The new method now copies twice (recv() to buffer, buffer to recvq).
+        *
+        * We use find() instead of rfind() for clarity, however unlike the old code, our scanning of the string is
+        * contiguous: as we specify a startpoint, we never see characters we have scanned previously, making this
+        * marginally faster in cases with a number of \r hidden early on in the buffer.
+        *
+        * How it works:
+        * Start at first pos of string, find first \r, append everything in the chunk (excluding \r) to recvq. Set
+        * i ahead of the \r, search for next \r, add next chunk to buffer... repeat.
+        *              -- w00t (7 may, 2008)
+        */
+       if (i == std::string::npos)
+       {
+               // no \r that we need to dance around, just add to buffer
+               recvq.append(a);
+       }
+       else
+       {
+               // While we can find the end of a chunk to add
                while (i != std::string::npos)
                {
-                       a.erase(i, 1);
-                       i = a.rfind('\r');
-               }
+                       // Append the chunk that we have
+                       recvq.append(a, start, (i - start));
 
-               if (a.length())
-                       recvq.append(a);
+                       // Start looking for the next one
+                       start = i + 1;
+                       i = a.find('\r', start);
+               }
 
-               if (this->MyClass && (recvq.length() > this->MyClass->GetRecvqMax()))
+               if (start != a.length())
                {
-                       this->SetWriteError("RecvQ exceeded");
-                       ServerInstance->SNO->WriteToSnoMask('A', "User %s RecvQ of %lu exceeds connect class maximum of %lu",this->nick,(unsigned long int)recvq.length(),this->MyClass->GetRecvqMax());
-                       return false;
+                       /*
+                        * This is here to catch a corner case when we get something like:
+                        * NICK w0
+                        * 0t\r\nU
+                        * SER ...
+                        * in successive calls to us.
+                        *
+                        * Without this conditional, the 'U' on the second case will be dropped,
+                        * which is most *certainly* not the behaviour we want!
+                        *              -- w00t
+                        */
+                       recvq.append(a, start, (a.length() - start));
                }
-
-               return true;
        }
 
-       catch (...)
+       if (this->MyClass && (recvq.length() > this->MyClass->GetRecvqMax()))
        {
-               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::AddBuffer()");
+               this->SetWriteError("RecvQ exceeded");
+               ServerInstance->SNO->WriteToSnoMask('A', "User %s RecvQ of %lu exceeds connect class maximum of %lu",this->nick.c_str(),(unsigned long int)recvq.length(),this->MyClass->GetRecvqMax());
                return false;
        }
+
+       return true;
 }
 
 bool User::BufferIsReady()
@@ -607,7 +631,7 @@ void User::AddWriteBuf(const std::string &data)
                 * to repeatedly add the text to the sendq!
                 */
                this->SetWriteError("SendQ exceeded");
-               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ of %lu exceeds connect class maximum of %lu",this->nick,(unsigned long int)sendq.length() + data.length(),this->MyClass->GetSendqMax());
+               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ of %lu exceeds connect class maximum of %lu",this->nick.c_str(),(unsigned long int)sendq.length() + data.length(),this->MyClass->GetSendqMax());
                return;
        }
 
@@ -694,13 +718,13 @@ void User::Oper(const std::string &opertype, const std::string &opername)
        try
        {
                this->modes[UM_OPERATOR] = 1;
-               this->WriteServ("MODE %s :+o", this->nick);
+               this->WriteServ("MODE %s :+o", this->nick.c_str());
                FOREACH_MOD(I_OnOper, OnOper(this, opertype));
-               ServerInstance->Logs->Log("OPER", DEFAULT, "%s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
-               strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
+               ServerInstance->Logs->Log("OPER", DEFAULT, "%s!%s@%s opered as type: %s", this->nick.c_str(), this->ident.c_str(), this->host.c_str(), opertype.c_str());
+               this->oper.assign(opertype, 0, ServerInstance->Config->Limits.NickMax);
                ServerInstance->Users->all_opers.push_back(this);
 
-               opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper);
+               opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper.c_str());
                if (iter_opertype != ServerInstance->Config->opertypes.end())
                {
 
@@ -788,11 +812,14 @@ void User::UnOper()
                        }
                }
 
-               const char* parameters[] = { this->nick, moderemove.c_str() };
-               ServerInstance->Parser->CallHandler("MODE", parameters, 2, this);
+               std::vector<std::string> parameters;
+               parameters.push_back(this->nick);
+               parameters.push_back(moderemove);
+
+               ServerInstance->Parser->CallHandler("MODE", parameters, this);
 
                /* unset their oper type (what IS_OPER checks), and remove +o */
-               *this->oper = 0;
+               this->oper.clear();
                this->modes[UM_OPERATOR] = 0;
                        
                /* remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404 */
@@ -859,6 +886,25 @@ void User::CheckClass()
        this->MaxChans = a->GetMaxChans();
 }
 
+void User::CheckLines()
+{
+       const char* check[] = { "G" , "K", NULL };
+
+       if (!this->exempt)
+       {
+               for (int n = 0; check[n]; ++n)
+               {
+                       XLine *r = ServerInstance->XLines->MatchesLine(check[n], this);
+
+                       if (r)
+                       {
+                               r->Apply(this);
+                               return;
+                       }
+               }
+       }
+}
+
 void User::FullConnect()
 {
        ServerInstance->stats->statsConnects++;
@@ -881,33 +927,16 @@ void User::FullConnect()
                return;
        }
 
-       if (!this->exempt)
-       {
-               GLine *r = (GLine *)ServerInstance->XLines->MatchesLine("G", this);
-
-               if (r)
-               {
-                       r->Apply(this);
-                       return;
-               }
-
-               KLine *n = (KLine *)ServerInstance->XLines->MatchesLine("K", this);
-
-               if (n)
-               {
-                       n->Apply(this);
-                       return;
-               }
-       }
+       CheckLines();
 
        this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",ServerInstance->Config->Network);
-       this->WriteNumeric(001, "%s :Welcome to the %s IRC Network %s!%s@%s",this->nick, ServerInstance->Config->Network, this->nick, this->ident, this->host);
-       this->WriteNumeric(002, "%s :Your host is %s, running version InspIRCd-1.2",this->nick,ServerInstance->Config->ServerName);
-       this->WriteNumeric(003, "%s :This server was created %s %s", this->nick, __TIME__, __DATE__);
-       this->WriteNumeric(004, "%s %s InspIRCd-1.2 %s %s %s", this->nick, ServerInstance->Config->ServerName, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
+       this->WriteNumeric(001, "%s :Welcome to the %s IRC Network %s!%s@%s",this->nick.c_str(), ServerInstance->Config->Network, this->nick.c_str(), this->ident.c_str(), this->host.c_str());
+       this->WriteNumeric(002, "%s :Your host is %s, running version InspIRCd-1.2",this->nick.c_str(),ServerInstance->Config->ServerName);
+       this->WriteNumeric(003, "%s :This server was created %s %s", this->nick.c_str(), __TIME__, __DATE__);
+       this->WriteNumeric(004, "%s %s InspIRCd-1.2 %s %s %s", this->nick.c_str(), ServerInstance->Config->ServerName, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
 
        ServerInstance->Config->Send005(this);
-       this->WriteNumeric(42, "%s %s :your unique ID", this->nick, this->uuid);
+       this->WriteNumeric(42, "%s %s :your unique ID", this->nick.c_str(), this->uuid.c_str());
 
 
        this->ShowMOTD();
@@ -918,9 +947,9 @@ void User::FullConnect()
 
        /* Trigger LUSERS output, give modules a chance too */
        int MOD_RESULT = 0;
-       FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", NULL, 0, this, true, "LUSERS"));
+       FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", std::vector<std::string>(), this, true, "LUSERS"));
        if (!MOD_RESULT)
-               ServerInstance->CallCommandHandler("LUSERS", NULL, 0, this);
+               ServerInstance->CallCommandHandler("LUSERS", std::vector<std::string>(), this);
 
        /*
         * We don't set REG_ALL until triggering OnUserConnect, so some module events don't spew out stuff
@@ -930,9 +959,11 @@ void User::FullConnect()
 
        this->registered = REG_ALL;
 
+       ServerInstance->PI->Introduce(this);
+
        FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
 
-       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString(), this->fullname);
+       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick.c_str(), this->ident.c_str(), this->host.c_str(), this->GetIPString(), this->fullname.c_str());
        ServerInstance->Logs->Log("BANCACHE", DEBUG, "BanCache: Adding NEGATIVE hit for %s", this->GetIPString());
        ServerInstance->BanCache->AddHit(this->GetIPString(), "", "");
 }
@@ -946,7 +977,7 @@ User* User::UpdateNickHash(const char* New)
        //user_hash::iterator newnick;
        user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
 
-       if (!strcasecmp(this->nick,New))
+       if (!irc::string(this->nick.c_str()).compare(New))
                return oldnick->second;
 
        if (oldnick == ServerInstance->Users->clientlist->end())
@@ -961,15 +992,10 @@ User* User::UpdateNickHash(const char* New)
 void User::InvalidateCache()
 {
        /* Invalidate cache */
-       if (cached_fullhost)
-               free(cached_fullhost);
-       if (cached_hostip)
-               free(cached_hostip);
-       if (cached_makehost)
-               free(cached_makehost);
-       if (cached_fullrealhost)
-               free(cached_fullrealhost);
-       cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
+       cached_fullhost.clear();
+       cached_hostip.clear();
+       cached_makehost.clear();
+       cached_fullrealhost.clear();
 }
 
 bool User::ForceNickChange(const char* newnick)
@@ -990,8 +1016,10 @@ bool User::ForceNickChange(const char* newnick)
        Command* nickhandler = ServerInstance->Parser->GetHandler("NICK");
        if (nickhandler) // wtfbbq, when would this not be here
        {
+               std::vector<std::string> parameters;
                nickhandler->HandleInternal(1, dummy);
-               bool result = (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
+               parameters.push_back(newnick);
+               bool result = (ServerInstance->Parser->CallHandler("NICK", parameters, this) == CMD_SUCCESS);
                nickhandler->HandleInternal(0, dummy);
                return result;
        }
@@ -1027,7 +1055,7 @@ void User::SetSockAddr(int protocol_family, const char* sip, int port)
                }
                break;
                default:
-                       ServerInstance->Logs->Log("USERS",DEBUG,"Uh oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
+                       ServerInstance->Logs->Log("USERS",DEBUG,"Uh oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick.c_str());
                break;
        }
 }
@@ -1239,7 +1267,7 @@ void User::WriteFrom(User *user, const std::string &text)
 {
        char tb[MAXBUF];
 
-       snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str());
+       snprintf(tb,MAXBUF,":%s %s",user->GetFullHost().c_str(),text.c_str());
 
        this->Write(std::string(tb));
 }
@@ -1309,7 +1337,7 @@ void User::WriteCommon(const std::string &text)
                InitializeAlreadySent(ServerInstance->SE);
 
        /* We dont want to be doing this n times, just once */
-       snprintf(tb,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
+       snprintf(tb,MAXBUF,":%s %s",this->GetFullHost().c_str(),text.c_str());
        std::string out = tb;
 
        for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
@@ -1366,8 +1394,8 @@ void User::WriteCommonQuit(const std::string &normal_text, const std::string &op
        if (!already_sent)
                InitializeAlreadySent(ServerInstance->SE);
 
-       snprintf(tb1,MAXBUF,":%s QUIT :%s",this->GetFullHost(),normal_text.c_str());
-       snprintf(tb2,MAXBUF,":%s QUIT :%s",this->GetFullHost(),oper_text.c_str());
+       snprintf(tb1,MAXBUF,":%s QUIT :%s",this->GetFullHost().c_str(),normal_text.c_str());
+       snprintf(tb2,MAXBUF,":%s QUIT :%s",this->GetFullHost().c_str(),oper_text.c_str());
        std::string out1 = tb1;
        std::string out2 = tb2;
 
@@ -1401,7 +1429,7 @@ void User::WriteCommonExcept(const std::string &text)
        if (!already_sent)
                InitializeAlreadySent(ServerInstance->SE);
 
-       snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
+       snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost().c_str(),text.c_str());
        out1 = tb1;
 
        for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
@@ -1484,7 +1512,7 @@ bool User::SharesChannelWith(User *other)
 
 bool User::ChangeName(const char* gecos)
 {
-       if (!strcmp(gecos, this->fullname))
+       if (!this->fullname.compare(gecos))
                return true;
 
        if (IS_LOCAL(this))
@@ -1495,14 +1523,14 @@ bool User::ChangeName(const char* gecos)
                        return false;
                FOREACH_MOD(I_OnChangeName,OnChangeName(this,gecos));
        }
-       strlcpy(this->fullname,gecos,MAXGECOS+1);
+       this->fullname.assign(gecos, 0, ServerInstance->Config->Limits.MaxGecos);
 
        return true;
 }
 
 bool User::ChangeDisplayedHost(const char* shost)
 {
-       if (!strcmp(shost, this->dhost))
+       if (dhost == shost)
                return true;
 
        if (IS_LOCAL(this))
@@ -1518,7 +1546,7 @@ bool User::ChangeDisplayedHost(const char* shost)
                this->WriteCommonExcept("QUIT :Changing hosts");
 
        /* Fix by Om: User::dhost is 65 long, this was truncating some long hosts */
-       strlcpy(this->dhost,shost,64);
+       this->dhost.assign(shost, 0, 64);
 
        this->InvalidateCache();
 
@@ -1526,28 +1554,28 @@ bool User::ChangeDisplayedHost(const char* shost)
        {
                for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
                {
-                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name);
+                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name.c_str());
                        std::string n = this->ServerInstance->Modes->ModeString(this, i->first);
                        if (n.length() > 0)
-                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name, n.c_str());
+                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name.c_str(), n.c_str());
                }
        }
 
        if (IS_LOCAL(this))
-               this->WriteNumeric(396, "%s %s :is now your displayed host",this->nick,this->dhost);
+               this->WriteNumeric(396, "%s %s :is now your displayed host",this->nick.c_str(),this->dhost.c_str());
 
        return true;
 }
 
 bool User::ChangeIdent(const char* newident)
 {
-       if (!strcmp(newident, this->ident))
+       if (!this->ident.compare(newident))
                return true;
 
        if (this->ServerInstance->Config->CycleHosts)
                this->WriteCommonExcept("%s","QUIT :Changing ident");
 
-       strlcpy(this->ident, newident, IDENTMAX+1);
+       this->ident.assign(newident, 0, ServerInstance->Config->Limits.IdentMax + 1);
 
        this->InvalidateCache();
 
@@ -1555,10 +1583,10 @@ bool User::ChangeIdent(const char* newident)
        {
                for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
                {
-                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name);
+                       i->first->WriteAllExceptSender(this, false, 0, "JOIN %s", i->first->name.c_str());
                        std::string n = this->ServerInstance->Modes->ModeString(this, i->first);
                        if (n.length() > 0)
-                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name, n.c_str());
+                               i->first->WriteAllExceptSender(this, true, 0, "MODE %s +%s", i->first->name.c_str(), n.c_str());
                }
        }
 
@@ -1575,7 +1603,7 @@ void User::SendAll(const char* command, const char* text, ...)
        vsnprintf(textbuffer, MAXBUF, text, argsPtr);
        va_end(argsPtr);
 
-       snprintf(formatbuffer,MAXBUF,":%s %s $* :%s", this->GetFullHost(), command, textbuffer);
+       snprintf(formatbuffer,MAXBUF,":%s %s $* :%s", this->GetFullHost().c_str(), command, textbuffer);
        std::string fmt = formatbuffer;
 
        for (std::vector<User*>::const_iterator i = ServerInstance->Users->local_users.begin(); i != ServerInstance->Users->local_users.end(); i++)
@@ -1661,14 +1689,20 @@ ConnectClass* User::SetClass(const std::string &explicit_name)
        if (!IS_LOCAL(this))
                return NULL;
 
+       ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Setting connect class for UID %s", this->uuid.c_str());
+
        if (!explicit_name.empty())
        {
                for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
                {
                        ConnectClass* c = *i;
 
-                       if (explicit_name == c->GetName() && !c->GetDisabled())
+                       if (c->GetDisabled())
+                               continue; // can't possibly match, removed from conf
+
+                       if (explicit_name == c->GetName())
                        {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Explicitly set to %s", explicit_name.c_str());
                                found = c;
                        }
                }
@@ -1679,37 +1713,64 @@ ConnectClass* User::SetClass(const std::string &explicit_name)
                {
                        ConnectClass* c = *i;
 
-                       if (((match(this->GetIPString(),c->GetHost().c_str(),true)) || (match(this->host,c->GetHost().c_str()))))
+                       if (c->GetType() == CC_ALLOW)
                        {
-                               if (c->GetPort())
-                               {
-                                       if (this->GetPort() == c->GetPort() && !c->GetDisabled())
-                                       {
-                                               found = c;
-                                       }
-                                       else
-                                               continue;
-                               }
-                               else
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "ALLOW %s %d %s", c->GetHost().c_str(), c->GetPort(), c->GetName().c_str());
+                       }
+                       else
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "DENY %s %d %s", c->GetHost().c_str(), c->GetPort(), c->GetName().c_str());
+                       }
+
+                       /* if it's disabled, we can't match this one. */
+                       if (c->GetDisabled())
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Class disabled");
+                               continue;
+                       }
+
+                       /* check if host matches.. */
+                       if (((!match(this->GetIPString(),c->GetHost(),true)) && (!match(this->host,c->GetHost()))))
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "No host match (for %s)", c->GetHost().c_str());
+                               continue;
+                       }
+
+                       /*
+                        * deny change if change will take class over the limit check it HERE, not after we found a matching class,
+                        * because we should attempt to find another class if this one doesn't match us. -- w00t
+                        */
+                       if (c->limit && (c->RefCount + 1 >= c->limit))
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "OOPS: Connect class limit (%lu) hit, denying", c->limit);
+                               continue;
+                       }
+
+                       /* if it requires a port ... */
+                       if (c->GetPort())
+                       {
+                               ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Requires port (%d)", c->GetPort());
+
+                               /* and our port doesn't match, fail. */
+                               if (this->GetPort() != c->GetPort())
                                {
-                                       if (!c->GetDisabled())
-                                               found = c;
+                                       ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "Port match failed (%d)", this->GetPort());
+                                       continue;
                                }
                        }
+
+                       /* we stop at the first class that meets ALL critera. */
+                       found = c;
+                       break;
                }
        }
 
-       /* ensure we don't fuck things up refcount wise, only remove them from a class if we find a new one :P */
+       /*
+        * Okay, assuming we found a class that matches.. switch us into that class, keeping refcounts up to date.
+        */
        if (found)
        {
-               /* deny change if change will take class over the limit */
-               if (found->limit && (found->RefCount + 1 >= found->limit))
-               {
-                       ServerInstance->Logs->Log("USERS", DEBUG, "OOPS: Connect class limit (%lu) hit, denying", found->limit);
-                       return this->MyClass;
-               }
-
-               /* should always be valid, but just in case .. */
+               /* only fiddle with refcounts if they are already in a class .. */
                if (this->MyClass)
                {
                        if (found == this->MyClass) // no point changing this shit :P
@@ -1778,31 +1839,31 @@ void User::ShowMOTD()
 {
        if (!ServerInstance->Config->MOTD.size())
        {
-               this->WriteNumeric(422, "%s :Message of the day file is missing.",this->nick);
+               this->WriteNumeric(422, "%s :Message of the day file is missing.",this->nick.c_str());
                return;
        }
-       this->WriteNumeric(375, "%s :%s message of the day", this->nick, ServerInstance->Config->ServerName);
+       this->WriteNumeric(375, "%s :%s message of the day", this->nick.c_str(), ServerInstance->Config->ServerName);
 
        for (file_cache::iterator i = ServerInstance->Config->MOTD.begin(); i != ServerInstance->Config->MOTD.end(); i++)
-               this->WriteNumeric(372, "%s :- %s",this->nick,i->c_str());
+               this->WriteNumeric(372, "%s :- %s",this->nick.c_str(),i->c_str());
 
-       this->WriteNumeric(376, "%s :End of message of the day.", this->nick);
+       this->WriteNumeric(376, "%s :End of message of the day.", this->nick.c_str());
 }
 
 void User::ShowRULES()
 {
        if (!ServerInstance->Config->RULES.size())
        {
-               this->WriteNumeric(434, "%s :RULES File is missing",this->nick);
+               this->WriteNumeric(434, "%s :RULES File is missing",this->nick.c_str());
                return;
        }
 
-       this->WriteNumeric(308, "%s :- %s Server Rules -",this->nick,ServerInstance->Config->ServerName);
+       this->WriteNumeric(308, "%s :- %s Server Rules -",this->nick.c_str(),ServerInstance->Config->ServerName);
 
        for (file_cache::iterator i = ServerInstance->Config->RULES.begin(); i != ServerInstance->Config->RULES.end(); i++)
-               this->WriteNumeric(232, "%s :- %s",this->nick,i->c_str());
+               this->WriteNumeric(232, "%s :- %s",this->nick.c_str(),i->c_str());
 
-       this->WriteNumeric(309, "%s :End of RULES command.",this->nick);
+       this->WriteNumeric(309, "%s :End of RULES command.",this->nick.c_str());
 }
 
 void User::HandleEvent(EventType et, int errornum)
@@ -1849,9 +1910,9 @@ void User::SetOperQuit(const std::string &oquit)
        operquitmsg = oquit;
 }
 
-const char* User::GetOperQuit()
+const std::string& User::GetOperQuit()
 {
-       return operquitmsg.c_str();
+       return operquitmsg;
 }
 
 void User::IncreasePenalty(int increase)