Fixed bug #85

[user/henk/code/inspircd.git] / src / users.cpp

diff --git a/src/users.cpp b/src/users.cpp
index 60072ed0c1c255a1ab73e20927aebdbece1699ac..1920e8dcdf9c070a7700fdf3877f8fddff412721 100644 (file)
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -18,10 +18,16 @@ using namespace std;
 
 #include "inspircd_config.h" 
 #include "channels.h"
+#include "connection.h"
 #include "users.h"
 #include "inspircd.h"
 #include <stdio.h>
+#ifdef THREADED_DNS
+#include <pthread.h>
+#include <signal.h>
+#endif
 #include "inspstring.h"
+#include "commands.h"
 #include "helperfuncs.h"
 
 extern std::stringstream config_f;
@@ -59,6 +65,10 @@ userrec::userrec()
        invites.clear();
 }
 
+userrec::~userrec()
+{
+}
+
 void userrec::CloseSocket()
 {
        shutdown(this->fd,2);
@@ -76,6 +86,7 @@ int userrec::ReadData(void* buffer, size_t size)
 {
        if (this->fd > -1)
        {
+               log(DEBUG,"userrec::ReadData on fd %d",this->fd);
                return read(this->fd, buffer, size);
        }
        else return 0;
@@ -144,36 +155,38 @@ bool userrec::HasPermission(char* command)
        char* savept;
        char* savept2;
        
+       // users on u-lined servers can completely bypass
+       // all permissions based checks.
+       //
+       // of course, if this is sent to a remote server and this
+       // server is not ulined there, then that other server
+       // silently drops the command.
+       if (is_uline(this->server))
+               return true;
+       
        // are they even an oper at all?
        if (strchr(this->modes,'o'))
        {
-               log(DEBUG,"*** HasPermission: %s is an oper",this->nick);
                for (int j =0; j < ConfValueEnum("type",&config_f); j++)
                {
                        ConfValue("type","name",j,TypeName,&config_f);
                        if (!strcmp(TypeName,this->oper))
                        {
-                               log(DEBUG,"*** HasPermission: %s is an oper of type '%s'",this->nick,this->oper);
                                ConfValue("type","classes",j,Classes,&config_f);
                                char* myclass = strtok_r(Classes," ",&savept);
                                while (myclass)
                                {
-                                       log(DEBUG,"*** HasPermission: checking classtype '%s'",myclass);
                                        for (int k =0; k < ConfValueEnum("class",&config_f); k++)
                                        {
                                                ConfValue("class","name",k,ClassName,&config_f);
                                                if (!strcmp(ClassName,myclass))
                                                {
                                                        ConfValue("class","commands",k,CommandList,&config_f);
-                                                       log(DEBUG,"*** HasPermission: found class named %s with commands: '%s'",ClassName,CommandList);
-                                                       
-                                                       
                                                        mycmd = strtok_r(CommandList," ",&savept2);
                                                        while (mycmd)
                                                        {
-                                                               if (!strcasecmp(mycmd,command))
+                                                               if ((!strcasecmp(mycmd,command)) || (*mycmd == '*'))
                                                                {
-                                                                       log(DEBUG,"*** Command %s found, returning true",command);
                                                                        return true;
                                                                }
                                                                mycmd = strtok_r(NULL," ",&savept2);
@@ -192,20 +205,20 @@ bool userrec::HasPermission(char* command)
 bool userrec::AddBuffer(std::string a)
 {
         std::string b = "";
-        for (int i = 0; i < a.length(); i++)
+        for (unsigned int i = 0; i < a.length(); i++)
                 if ((a[i] != '\r') && (a[i] != '\0') && (a[i] != 7))
                         b = b + a[i];
         std::stringstream stream(recvq);
         stream << b;
         recvq = stream.str();
-       int i = 0;
+       unsigned int i = 0;
        // count the size of the first line in the buffer.
        while (i < recvq.length())
        {
                if (recvq[i++] == '\n')
                        break;
        }
-       if (recvq.length() > this->recvqmax)
+       if (recvq.length() > (unsigned)this->recvqmax)
        {
                this->SetWriteError("RecvQ exceeded");
                WriteOpers("*** User %s RecvQ of %d exceeds connect class maximum of %d",this->nick,recvq.length(),this->recvqmax);
@@ -217,7 +230,7 @@ bool userrec::AddBuffer(std::string a)
 
 bool userrec::BufferIsReady()
 {
-        for (int i = 0; i < recvq.length(); i++)
+        for (unsigned int i = 0; i < recvq.length(); i++)
                if (recvq[i] == '\n')
                        return true;
         return false;
@@ -249,7 +262,7 @@ void userrec::AddWriteBuf(std::string data)
 {
        if (this->GetWriteError() != "")
                return;
-       if (sendq.length() + data.length() > this->sendqmax)
+       if (sendq.length() + data.length() > (unsigned)this->sendqmax)
        {
                WriteOpers("*** User %s SendQ of %d exceeds connect class maximum of %d",this->nick,sendq.length() + data.length(),this->sendqmax);
                this->SetWriteError("SendQ exceeded");