]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Fix for parameters which contain a colon (which is not the first char in the string)
[user/henk/code/inspircd.git] / src / users.cpp
index 4529a348453cb9da6973ffb12a244b80b89a3393..46f5d512bde6acc69365ccfaf11155f4c4a03a15 100644 (file)
  * ---------------------------------------------------
  */
 
-#include "inspircd_config.h"
 #include "configreader.h"
 #include "channels.h"
-#include "connection.h"
 #include "users.h"
 #include "inspircd.h"
 #include <stdarg.h>
-#include "inspstring.h"
-#include "commands.h"
-#include "helperfuncs.h"
-#include "typedefs.h"
 #include "socketengine.h"
-#include "hashcomp.h"
 #include "wildcard.h"
 #include "xline.h"
 #include "cull_list.h"
@@ -73,7 +66,7 @@ bool DoType(ServerConfig* conf, const char* tag, char** entries, void** values,
        char* Classes = (char*)values[1];
        
        opertypes[TypeName] = strdup(Classes);
-       log(DEBUG,"Read oper TYPE '%s' with classes '%s'",TypeName,Classes);
+       conf->GetInstance()->Log(DEBUG,"Read oper TYPE '%s' with classes '%s'",TypeName,Classes);
        return true;
 }
 
@@ -83,7 +76,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char** entries, void** values,
        char* CommandList = (char*)values[1];
        
        operclass[ClassName] = strdup(CommandList);
-       log(DEBUG,"Read oper CLASS '%s' with commands '%s'",ClassName,CommandList);
+       conf->GetInstance()->Log(DEBUG,"Read oper CLASS '%s' with commands '%s'",ClassName,CommandList);
        return true;
 }
 
@@ -92,45 +85,61 @@ bool DoneClassesAndTypes(ServerConfig* conf, const char* tag)
        return true;
 }
 
-bool userrec::ProcessNoticeMasks(const char *sm)
+std::string userrec::ProcessNoticeMasks(const char *sm)
 {
-       bool adding = true;
+       bool adding = true, oldadding = false;
        const char *c = sm;
+       std::string output = "";
+
+       ServerInstance->Log(DEBUG,"Process notice masks");
 
        while (c && *c)
        {
+               ServerInstance->Log(DEBUG,"Process notice mask %c",*c);
+               
                switch (*c)
                {
                        case '+':
                                adding = true;
-                               break;
+                       break;
                        case '-':
                                adding = false;
-                               break;
+                       break;
                        default:
-                               if ((*c >= 'A') && (*c <= 'z'))
-                                       this->SetNoticeMask(*c, adding);
-                               break;
+                               if ((*c >= 'A') && (*c <= 'z') && (ServerInstance->SNO->IsEnabled(*c)))
+                               {
+                                       if ((!IsNoticeMaskSet(*c) && adding) || (IsNoticeMaskSet(*c) && !adding))
+                                       {
+                                               if ((oldadding != adding) || (!output.length()))
+                                                       output += (adding ? '+' : '-');
+
+                                               this->SetNoticeMask(*c, adding);
+
+                                               output += *c;
+                                       }
+                               }
+                               oldadding = adding;
+                       break;
                }
 
                *c++;
        }
 
-       return true;
+       return output;
 }
 
 void userrec::StartDNSLookup()
 {
-       log(DEBUG,"Commencing reverse lookup");
+       ServerInstance->Log(DEBUG,"Commencing reverse lookup");
        try
        {
-               log(DEBUG,"Passing instance: %08x",this->ServerInstance);
+               ServerInstance->Log(DEBUG,"Passing instance: %08x",this->ServerInstance);
                res_reverse = new UserResolver(this->ServerInstance, this, this->GetIPString(), false);
                this->ServerInstance->AddResolver(res_reverse);
        }
        catch (ModuleException& e)
        {
-               log(DEBUG,"Error in resolver: %s",e.GetReason());
+               ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
        }
 }
 
@@ -138,26 +147,30 @@ UserResolver::UserResolver(InspIRCd* Instance, userrec* user, std::string to_res
        Resolver(Instance, to_resolve, forward ? DNS_QUERY_FORWARD : DNS_QUERY_REVERSE), bound_user(user)
 {
        this->fwd = forward;
-       this->bound_fd = user->fd;
+       this->bound_fd = user->GetFd();
 }
 
 void UserResolver::OnLookupComplete(const std::string &result)
 {
-       if ((!this->fwd) && (ServerInstance->fd_ref_table[this->bound_fd] == this->bound_user))
+       if ((!this->fwd) && (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user))
        {
-               log(DEBUG,"Commencing forward lookup");
+               ServerInstance->Log(DEBUG,"Commencing forward lookup");
                this->bound_user->stored_host = result;
                try
                {
-                       bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, true);
-                       this->ServerInstance->AddResolver(bound_user->res_forward);
+                       /* Check we didnt time out */
+                       if (this->bound_user->registered != REG_ALL)
+                       {
+                               bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, true);
+                               this->ServerInstance->AddResolver(bound_user->res_forward);
+                       }
                }
                catch (ModuleException& e)
                {
-                       log(DEBUG,"Error in resolver: %s",e.GetReason());
+                       ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
                }
        }
-       else if ((this->fwd) && (ServerInstance->fd_ref_table[this->bound_fd] == this->bound_user))
+       else if ((this->fwd) && (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user))
        {
                /* Both lookups completed */
                if (this->bound_user->GetIPString() == result)
@@ -165,14 +178,18 @@ void UserResolver::OnLookupComplete(const std::string &result)
                        std::string hostname = this->bound_user->stored_host;
                        if (hostname.length() < 65)
                        {
-                               /* Hostnames starting with : are not a good thing (tm) */
-                               if (*(hostname.c_str()) == ':')
-                                       hostname = "0" + hostname;
-
-                               this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
-                               this->bound_user->dns_done = true;
-                               strlcpy(this->bound_user->dhost, hostname.c_str(),64);
-                               strlcpy(this->bound_user->host, hostname.c_str(),64);
+                               /* Check we didnt time out */
+                               if (this->bound_user->registered != REG_ALL)
+                               {
+                                       /* Hostnames starting with : are not a good thing (tm) */
+                                       if (*(hostname.c_str()) == ':')
+                                               hostname = "0" + hostname;
+
+                                       this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
+                                       this->bound_user->dns_done = true;
+                                       strlcpy(this->bound_user->dhost, hostname.c_str(),64);
+                                       strlcpy(this->bound_user->host, hostname.c_str(),64);
+                               }
                        }
                        else
                        {
@@ -188,7 +205,7 @@ void UserResolver::OnLookupComplete(const std::string &result)
 
 void UserResolver::OnError(ResolverError e, const std::string &errormessage)
 {
-       if (ServerInstance->fd_ref_table[this->bound_fd] == this->bound_user)
+       if (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user)
        {
                /* Error message here */
                this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname, using your IP address (%s) instead.", this->bound_user->GetIPString());
@@ -249,14 +266,15 @@ const char* userrec::FormatModes()
 
 userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
 {
-       log(DEBUG,"userrec::userrec(): Instance: %08x",ServerInstance);
+       ServerInstance->Log(DEBUG,"userrec::userrec(): Instance: %08x",ServerInstance);
        // the PROPER way to do it, AVOID bzero at *ALL* costs
        *password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = 0;
        server = (char*)Instance->FindServerNamePtr(Instance->Config->ServerName);
        reset_due = ServerInstance->Time();
-       lines_in = fd = lastping = signon = idle_lastmsg = nping = registered = 0;
+       lines_in = lastping = signon = idle_lastmsg = nping = registered = 0;
        timeout = flood = bytes_in = bytes_out = cmds_in = cmds_out = 0;
        haspassed = dns_done = false;
+       fd = -1;
        recvq = "";
        sendq = "";
        WriteError = "";
@@ -266,6 +284,7 @@ userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
        invites.clear();
        chans.resize(MAXCHANS);
        memset(modes,0,sizeof(modes));
+       memset(snomasks,0,sizeof(snomasks));
        
        for (unsigned int n = 0; n < MAXCHANS; n++)
        {
@@ -401,7 +420,7 @@ void userrec::InviteTo(irc::string &channel)
 
 void userrec::RemoveInvite(irc::string &channel)
 {
-       log(DEBUG,"Removing invites");
+       ServerInstance->Log(DEBUG,"Removing invites");
        
        if (invites.size())
        {
@@ -469,22 +488,24 @@ bool userrec::HasPermission(const std::string &command)
        return false;
 }
 
-
-bool userrec::AddBuffer(const std::string &a)
+/** NOTE: We cannot pass a const reference to this method.
+ * The string is changed by the workings of the method,
+ * so that if we pass const ref, we end up copying it to
+ * something we can change anyway. Makes sense to just let
+ * the compiler do that copy for us.
+ */
+bool userrec::AddBuffer(std::string a)
 {
-       std::string b = "";
+       std::string::size_type i = a.rfind('\r');
 
-       /* NB: std::string is arsey about \r and \n and tries to translate them
-        * somehow, so we CANNOT use std::string::find() here :(
-        */
-       for (std::string::const_iterator i = a.begin(); i != a.end(); i++)
+       while (i != std::string::npos)
        {
-               if (*i != '\r')
-                       b += *i;
+               a.erase(i, 1);
+               i = a.rfind('\r');
        }
 
-       if (b.length())
-               recvq.append(b);
+       if (a.length())
+               recvq.append(a);
 
        if (recvq.length() > (unsigned)this->recvqmax)
        {
@@ -589,11 +610,11 @@ void userrec::FlushWriteBuf()
 
 void userrec::SetWriteError(const std::string &error)
 {
-       log(DEBUG,"SetWriteError: %s",error.c_str());
+       ServerInstance->Log(DEBUG,"SetWriteError: %s",error.c_str());
        // don't try to set the error twice, its already set take the first string.
        if (!this->WriteError.length())
        {
-               log(DEBUG,"Setting error string for %s to '%s'",this->nick,error.c_str());
+               ServerInstance->Log(DEBUG,"Setting error string for %s to '%s'",this->nick,error.c_str());
                this->WriteError = error;
        }
 }
@@ -608,7 +629,7 @@ void userrec::Oper(const std::string &opertype)
        this->modes[UM_OPERATOR] = 1;
        this->WriteServ("MODE %s :+o", this->nick);
        FOREACH_MOD(I_OnOper, OnOper(this, opertype));
-       log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
+       ServerInstance->Log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
        strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
        ServerInstance->all_opers.push_back(this);
        FOREACH_MOD(I_OnPostOper,OnPostOper(this, opertype));
@@ -624,7 +645,7 @@ void userrec::UnOper()
                {
                        if (*a == this)
                        {
-                               log(DEBUG,"Oper removed from optimization list");
+                               ServerInstance->Log(DEBUG,"Oper removed from optimization list");
                                ServerInstance->all_opers.erase(a);
                                return;
                        }
@@ -676,35 +697,32 @@ void userrec::QuitUser(InspIRCd* Instance, userrec *user,const std::string &quit
                        }
                        catch (ModuleException& modexcept)
                        {
-                               log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
+                               Instance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
                        }
                }
                
-               Instance->SE->DelFd(user->fd);
+               Instance->SE->DelFd(user);
                user->CloseSocket();
        }
 
        /*
-        * this must come before the ServerInstance->WriteOpers so that it doesnt try to fill their buffer with anything
-        * if they were an oper with +s.
-        *
-        * XXX -
-        * In the current implementation, we only show local quits, as we only show local connects. With 
-        * the proposed implmentation of snomasks however, this will likely change in the (near?) future.
+        * this must come before the ServerInstance->SNO->WriteToSnoMaskso that it doesnt try to fill their buffer with anything
+        * if they were an oper with +sn +qQ.
         */
        if (user->registered == REG_ALL)
        {
                if (IS_LOCAL(user))
-                       Instance->WriteOpers("*** Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason.c_str());
+                       Instance->SNO->WriteToSnoMask('q',"Client exiting: %s!%s@%s [%s]",user->nick,user->ident,user->host,reason.c_str());
+               else
+                       Instance->SNO->WriteToSnoMask('Q',"Client exiting on server %s: %s!%s@%s [%s]",user->server,user->nick,user->ident,user->host,reason.c_str());
                user->AddToWhoWas();
        }
 
        if (iter != Instance->clientlist.end())
        {
-               log(DEBUG,"deleting user hash value %lx",(unsigned long)user);
+               Instance->Log(DEBUG,"deleting user hash value %lx",(unsigned long)user);
                if (IS_LOCAL(user))
                {
-                       Instance->fd_ref_table[user->fd] = NULL;
                        if (find(Instance->local_users.begin(),Instance->local_users.end(),user) != Instance->local_users.end())
                                Instance->local_users.erase(find(Instance->local_users.begin(),Instance->local_users.end(),user));
                }
@@ -812,7 +830,7 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                Instance->clientlist.erase(iter);
        }
 
-       log(DEBUG,"AddClient: %d %d %s",socket,port,ipaddr);
+       Instance->Log(DEBUG,"AddClient: %d %d %s",socket,port,ipaddr);
        
        _new = new userrec(Instance);
        Instance->clientlist[tempnick] = _new;
@@ -827,9 +845,9 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        _new->signon = Instance->Time() + Instance->Config->dns_timeout;
        _new->lastping = 1;
 
-       log(DEBUG,"Setting socket addresses");
+       Instance->Log(DEBUG,"Setting socket addresses");
        _new->SetSockAddr(AF_FAMILY, ipaddr, port);
-       log(DEBUG,"Socket addresses set.");
+       Instance->Log(DEBUG,"Socket addresses set.");
 
        /* Smarter than your average bear^H^H^H^Hset of strlcpys. */
        for (const char* temp = _new->GetIPString(); *temp && j < 64; temp++, j++)
@@ -864,7 +882,6 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        _new->sendqmax = class_sqmax;
        _new->recvqmax = class_rqmax;
 
-       Instance->fd_ref_table[socket] = _new;
        Instance->local_users.push_back(_new);
 
        if (Instance->local_users.size() > Instance->Config->SoftLimit)
@@ -894,10 +911,10 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                userrec::QuitUser(Instance, _new,"Server is full");
                return;
        }
-       char* e = matches_exception(ipaddr);
+       char* e = Instance->XLines->matches_exception(ipaddr);
        if (!e)
        {
-               char* r = matches_zline(ipaddr);
+               char* r = Instance->XLines->matches_zline(ipaddr);
                if (r)
                {
                        char reason[MAXBUF];
@@ -909,7 +926,7 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
 
        if (socket > -1)
        {
-               if (!Instance->SE->AddFd(socket,true,X_ESTAB_CLIENT))
+               if (!Instance->SE->AddFd(_new))
                {
                        userrec::QuitUser(Instance, _new, "Internal error handling connection");
                        return;
@@ -991,11 +1008,11 @@ void userrec::FullConnect(CullList* Goners)
 
        char match_against[MAXBUF];
        snprintf(match_against,MAXBUF,"%s@%s", this->ident, this->host);
-       char* e = matches_exception(match_against);
+       char* e = ServerInstance->XLines->matches_exception(match_against);
 
        if (!e)
        {
-               char* r = matches_gline(match_against);
+               char* r = ServerInstance->XLines->matches_gline(match_against);
                
                if (r)
                {
@@ -1005,7 +1022,7 @@ void userrec::FullConnect(CullList* Goners)
                        return;
                }
                
-               r = matches_kline(match_against);
+               r = ServerInstance->XLines->matches_kline(match_against);
                
                if (r)
                {
@@ -1021,7 +1038,7 @@ void userrec::FullConnect(CullList* Goners)
        this->WriteServ("001 %s :Welcome to the %s IRC Network %s!%s@%s",this->nick, ServerInstance->Config->Network, this->nick, this->ident, this->host);
        this->WriteServ("002 %s :Your host is %s, running version %s",this->nick,ServerInstance->Config->ServerName,VERSION);
        this->WriteServ("003 %s :This server was created %s %s", this->nick, __TIME__, __DATE__);
-       this->WriteServ("004 %s %s %s %s %s %s", this->nick, ServerInstance->Config->ServerName, VERSION, ServerInstance->ModeGrok->UserModeList().c_str(), ServerInstance->ModeGrok->ChannelModeList().c_str(), ServerInstance->ModeGrok->ParaModeList().c_str());
+       this->WriteServ("004 %s %s %s %s %s %s", this->nick, ServerInstance->Config->ServerName, VERSION, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
 
        // anfl @ #ratbox, efnet reminded me that according to the RFC this cant contain more than 13 tokens per line...
        // so i'd better split it :)
@@ -1051,9 +1068,9 @@ void userrec::FullConnect(CullList* Goners)
         * changes dont go out onto the network and produce 'fake direction'.
         */
        FOREACH_MOD(I_OnUserConnect,OnUserConnect(this));
-       FOREACH_MOD(I_OnGlobalConnect,OnGlobalConnect(this));
+       FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
        this->registered = REG_ALL;
-       ServerInstance->WriteOpers("*** Client connecting on port %d: %s!%s@%s [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString());
+       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString());
 }
 
 /** userrec::UpdateNick()
@@ -1092,7 +1109,7 @@ bool userrec::ForceNickChange(const char* newnick)
                return false;
        }
        
-       if (matches_qline(newnick))
+       if (ServerInstance->XLines->matches_qline(newnick))
        {
                ServerInstance->stats->statsCollisions++;
                return false;
@@ -1119,7 +1136,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
 #ifdef SUPPORT_IP6LINKS
                case AF_INET6:
                {
-                       log(DEBUG,"Set inet6 protocol address");
+                       ServerInstance->Log(DEBUG,"Set inet6 protocol address");
                        sockaddr_in6* sin = new sockaddr_in6;
                        sin->sin6_family = AF_INET6;
                        sin->sin6_port = port;
@@ -1130,7 +1147,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
 #endif
                case AF_INET:
                {
-                       log(DEBUG,"Set inet4 protocol address");
+                       ServerInstance->Log(DEBUG,"Set inet4 protocol address");
                        sockaddr_in* sin = new sockaddr_in;
                        sin->sin_family = AF_INET;
                        sin->sin_port = port;
@@ -1139,7 +1156,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
                break;
        }
 }
@@ -1166,7 +1183,7 @@ int userrec::GetPort()
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return 0;
@@ -1184,7 +1201,6 @@ int userrec::GetProtocolFamily()
 const char* userrec::GetIPString()
 {
        static char buf[1024];
-       static char temp[1024];
 
        if (this->ip == NULL)
                return "";
@@ -1194,6 +1210,8 @@ const char* userrec::GetIPString()
 #ifdef SUPPORT_IP6LINKS
                case AF_INET6:
                {
+                       static char temp[1024];
+               
                        sockaddr_in6* sin = (sockaddr_in6*)this->ip;
                        inet_ntop(sin->sin6_family, &sin->sin6_addr, buf, sizeof(buf));
                        /* IP addresses starting with a : on irc are a Bad Thing (tm) */
@@ -1215,7 +1233,7 @@ const char* userrec::GetIPString()
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return "";
@@ -1223,8 +1241,6 @@ const char* userrec::GetIPString()
 
 const char* userrec::GetIPString(char* buf)
 {
-       static char temp[1024];
-
        if (this->ip == NULL)
        {
                *buf = 0;
@@ -1236,6 +1252,8 @@ const char* userrec::GetIPString(char* buf)
 #ifdef SUPPORT_IP6LINKS
                case AF_INET6:
                {
+                       static char temp[1024];
+               
                        sockaddr_in6* sin = (sockaddr_in6*)this->ip;
                        inet_ntop(sin->sin6_family, &sin->sin6_addr, buf, sizeof(buf));
                        /* IP addresses starting with a : on irc are a Bad Thing (tm) */
@@ -1258,37 +1276,41 @@ const char* userrec::GetIPString(char* buf)
                break;
 
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return "";
 }
 
-
-void userrec::Write(const std::string &text)
+/** NOTE: We cannot pass a const reference to this method.
+ * The string is changed by the workings of the method,
+ * so that if we pass const ref, we end up copying it to
+ * something we can change anyway. Makes sense to just let
+ * the compiler do that copy for us.
+ */
+void userrec::Write(std::string text)
 {
        if ((this->fd < 0) || (this->fd > MAX_DESCRIPTORS))
                return;
 
-       std::string crlf = text;
-       crlf.append("\r\n");
+       text.append("\r\n");
 
        if (ServerInstance->Config->GetIOHook(this->GetPort()))
        {
                try
                {
-                       ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, crlf.data(), crlf.length());
+                       ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length());
                }
                catch (ModuleException& modexcept)
                {
-                       log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
+                       ServerInstance->Log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
                }
        }
        else
        {
-               this->AddWriteBuf(crlf);
+               this->AddWriteBuf(text);
        }
-       ServerInstance->stats->statsSent += crlf.length();
+       ServerInstance->stats->statsSent += text.length();
 }
 
 /** Write()
@@ -1446,7 +1468,7 @@ void userrec::WriteCommonExcept(const char* text, ...)
 
 void userrec::WriteCommonExcept(const std::string &text)
 {
-       bool quit_munge = true;
+       bool quit_munge = false;
        char oper_quit[MAXBUF];
        char textbuffer[MAXBUF];
 
@@ -1618,14 +1640,55 @@ bool userrec::ChangeDisplayedHost(const char* host)
                        return false;
                FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,host));
        }
+       if (this->ServerInstance->Config->CycleHosts)
+               this->WriteCommonExcept("%s","QUIT :Changing hosts");
+
        strlcpy(this->dhost,host,63);
 
+       if (this->ServerInstance->Config->CycleHosts)
+       {
+               for (std::vector<ucrec*>::const_iterator i = this->chans.begin(); i != this->chans.end(); i++)
+               {
+                       if ((*i)->channel)
+                       {
+                               (*i)->channel->WriteAllExceptSender(this, 0, "JOIN %s", (*i)->channel->name);
+                               std::string n = this->ServerInstance->Modes->ModeString(this, (*i)->channel);
+                               if (n.length())
+                                       (*i)->channel->WriteChannelWithServ(this->ServerInstance->Config->ServerName, "MODE %s +%s", (*i)->channel->name, n.c_str());
+                       }
+               }
+       }
+
        if (IS_LOCAL(this))
                this->WriteServ("396 %s %s :is now your hidden host",this->nick,this->dhost);
 
        return true;
 }
 
+bool userrec::ChangeIdent(const char* newident)
+{
+       if (this->ServerInstance->Config->CycleHosts)
+               this->WriteCommonExcept("%s","QUIT :Changing ident");
+
+       strlcpy(this->ident, newident, IDENTMAX+2);
+
+       if (this->ServerInstance->Config->CycleHosts)
+       {
+               for (std::vector<ucrec*>::const_iterator i = this->chans.begin(); i != this->chans.end(); i++)
+               {
+                       if ((*i)->channel)
+                       {
+                               (*i)->channel->WriteAllExceptSender(this, 0, "JOIN %s", (*i)->channel->name);
+                               std::string n = this->ServerInstance->Modes->ModeString(this, (*i)->channel);
+                               if (n.length())
+                                       (*i)->channel->WriteChannelWithServ(this->ServerInstance->Config->ServerName, "MODE %s +%s", (*i)->channel->name, n.c_str());
+                       }
+               }
+       }
+
+       return true;
+}
+
 void userrec::NoticeAll(char* text, ...)
 {
        char textbuffer[MAXBUF];
@@ -1661,7 +1724,7 @@ std::string userrec::ChannelList(userrec* source)
                         */
                        if ((source == this) || (*source->oper && ServerInstance->Config->OperSpyWhois) || (((!rec->channel->modes[CM_PRIVATE]) && (!rec->channel->modes[CM_SECRET])) || (rec->channel->HasUser(source))))
                        {
-                               list.append(rec->channel->GetStatusChar(this)).append(rec->channel->name).append(" ");
+                               list.append(rec->channel->GetPrefixChar(this)).append(rec->channel->name).append(" ");
                        }
                }
        }
@@ -1689,12 +1752,12 @@ void userrec::SplitChanList(userrec* dest, const std::string &cl)
 
                if(pos == std::string::npos)
                {
-                       line += cl.substr(start, length - start);
+                       line.append(cl.substr(start, length - start));
                        break;
                }
                else
                {
-                       line += cl.substr(start, length - start + 1);
+                       line.append(cl.substr(start, length - start + 1));
                }
        }
 
@@ -1731,6 +1794,7 @@ void userrec::PurgeEmptyChannels()
                ucrec* uc = *f;
                if (uc->channel)
                {
+                       uc->channel->RemoveAllPrefixes(this);
                        if (uc->channel->DelUser(this) == 0)
                        {
                                /* No users left in here, mark it for deletion */
@@ -1785,3 +1849,9 @@ void userrec::ShowRULES()
        this->WriteServ("NOTICE %s :End of %s rules.",this->nick,ServerInstance->Config->ServerName);
 }
 
+void userrec::HandleEvent(EventType et)
+{
+       /* WARNING: May delete this user! */
+       ServerInstance->ProcessUser(this);
+}
+