Fix potential for duplicate SID if the SID is auto generated.

[user/henk/code/inspircd.git] / src / users.cpp

diff --git a/src/users.cpp b/src/users.cpp
index de745d32575da5fc942116c8ef49104219408d69..4856ebc388f6f2cd5d87b8b828a77d0abcae6ca5 100644 (file)
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -12,9 +12,6 @@
  */
 
 #include "inspircd.h"
-#include "configreader.h"
-#include "channels.h"
-#include "users.h"
 #include <stdarg.h>
 #include "socketengine.h"
 #include "wildcard.h"
@@ -351,8 +348,10 @@ userrec::userrec(InspIRCd* Instance, const std::string &uid) : ServerInstance(In
        else
                strlcpy(uuid, uid.c_str(), UUID_LENGTH);
 
+       ServerInstance->Log(DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
+
        user_hash::iterator finduuid = Instance->uuidlist->find(uuid);
-       if (finduuid != Instance->uuidlist->end())
+       if (finduuid == Instance->uuidlist->end())
                (*Instance->uuidlist)[uuid] = this;
        else
                throw CoreException("Duplicate UUID "+std::string(uuid)+" in userrec constructor");
@@ -874,7 +873,17 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        /* NOTE: Calling this one parameter constructor for userrec automatically
         * allocates a new UUID and places it in the hash_map.
         */
-       userrec* New = new userrec(Instance);
+       userrec* New = NULL;
+       try
+       {
+               New = new userrec(Instance);
+       }
+       catch (CoreException &e)
+       {
+               Instance->Log(DEFAULT,"*** WTF *** Duplicated UUID! -- Crack smoking monkies have been unleashed.");
+               return;
+       }
+
        int j = 0;
 
        Instance->unregistered_count++;