]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Make sure that the hostname isnt set after the timeout period
[user/henk/code/inspircd.git] / src / users.cpp
index b1378260dadfae93c2a32bd2f41c93877b7bac78..84f762640d0bee014725444234267c03cdc0cbaf 100644 (file)
@@ -23,7 +23,7 @@
 #include <stdarg.h>
 #include "inspstring.h"
 #include "commands.h"
-#include "helperfuncs.h"
+
 #include "typedefs.h"
 #include "socketengine.h"
 #include "hashcomp.h"
@@ -31,8 +31,6 @@
 #include "xline.h"
 #include "cull_list.h"
 
-extern time_t TIME;
-
 irc::whowas::whowas_users whowas;
 static unsigned long already_sent[MAX_DESCRIPTORS] = {0};
 
@@ -75,7 +73,7 @@ bool DoType(ServerConfig* conf, const char* tag, char** entries, void** values,
        char* Classes = (char*)values[1];
        
        opertypes[TypeName] = strdup(Classes);
-       log(DEBUG,"Read oper TYPE '%s' with classes '%s'",TypeName,Classes);
+       conf->GetInstance()->Log(DEBUG,"Read oper TYPE '%s' with classes '%s'",TypeName,Classes);
        return true;
 }
 
@@ -85,7 +83,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char** entries, void** values,
        char* CommandList = (char*)values[1];
        
        operclass[ClassName] = strdup(CommandList);
-       log(DEBUG,"Read oper CLASS '%s' with commands '%s'",ClassName,CommandList);
+       conf->GetInstance()->Log(DEBUG,"Read oper CLASS '%s' with commands '%s'",ClassName,CommandList);
        return true;
 }
 
@@ -123,16 +121,16 @@ bool userrec::ProcessNoticeMasks(const char *sm)
 
 void userrec::StartDNSLookup()
 {
-       log(DEBUG,"Commencing reverse lookup");
+       ServerInstance->Log(DEBUG,"Commencing reverse lookup");
        try
        {
-               log(DEBUG,"Passing instance: %08x",this->ServerInstance);
+               ServerInstance->Log(DEBUG,"Passing instance: %08x",this->ServerInstance);
                res_reverse = new UserResolver(this->ServerInstance, this, this->GetIPString(), false);
                this->ServerInstance->AddResolver(res_reverse);
        }
        catch (ModuleException& e)
        {
-               log(DEBUG,"Error in resolver: %s",e.GetReason());
+               ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
        }
 }
 
@@ -147,16 +145,20 @@ void UserResolver::OnLookupComplete(const std::string &result)
 {
        if ((!this->fwd) && (ServerInstance->fd_ref_table[this->bound_fd] == this->bound_user))
        {
-               log(DEBUG,"Commencing forward lookup");
+               ServerInstance->Log(DEBUG,"Commencing forward lookup");
                this->bound_user->stored_host = result;
                try
                {
-                       bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, true);
-                       this->ServerInstance->AddResolver(bound_user->res_forward);
+                       /* Check we didnt time out */
+                       if (this->bound_user->registered != REG_ALL)
+                       {
+                               bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, true);
+                               this->ServerInstance->AddResolver(bound_user->res_forward);
+                       }
                }
                catch (ModuleException& e)
                {
-                       log(DEBUG,"Error in resolver: %s",e.GetReason());
+                       ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
                }
        }
        else if ((this->fwd) && (ServerInstance->fd_ref_table[this->bound_fd] == this->bound_user))
@@ -167,14 +169,18 @@ void UserResolver::OnLookupComplete(const std::string &result)
                        std::string hostname = this->bound_user->stored_host;
                        if (hostname.length() < 65)
                        {
-                               /* Hostnames starting with : are not a good thing (tm) */
-                               if (*(hostname.c_str()) == ':')
-                                       hostname = "0" + hostname;
-
-                               this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
-                               this->bound_user->dns_done = true;
-                               strlcpy(this->bound_user->dhost, hostname.c_str(),64);
-                               strlcpy(this->bound_user->host, hostname.c_str(),64);
+                               /* Check we didnt time out */
+                               if (this->bound_user->registered != REG_ALL)
+                               {
+                                       /* Hostnames starting with : are not a good thing (tm) */
+                                       if (*(hostname.c_str()) == ':')
+                                               hostname = "0" + hostname;
+
+                                       this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
+                                       this->bound_user->dns_done = true;
+                                       strlcpy(this->bound_user->dhost, hostname.c_str(),64);
+                                       strlcpy(this->bound_user->host, hostname.c_str(),64);
+                               }
                        }
                        else
                        {
@@ -251,11 +257,11 @@ const char* userrec::FormatModes()
 
 userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
 {
-       log(DEBUG,"userrec::userrec(): Instance: %08x",ServerInstance);
+       ServerInstance->Log(DEBUG,"userrec::userrec(): Instance: %08x",ServerInstance);
        // the PROPER way to do it, AVOID bzero at *ALL* costs
        *password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = 0;
        server = (char*)Instance->FindServerNamePtr(Instance->Config->ServerName);
-       reset_due = TIME;
+       reset_due = ServerInstance->Time();
        lines_in = fd = lastping = signon = idle_lastmsg = nping = registered = 0;
        timeout = flood = bytes_in = bytes_out = cmds_in = cmds_out = 0;
        haspassed = dns_done = false;
@@ -403,7 +409,7 @@ void userrec::InviteTo(irc::string &channel)
 
 void userrec::RemoveInvite(irc::string &channel)
 {
-       log(DEBUG,"Removing invites");
+       ServerInstance->Log(DEBUG,"Removing invites");
        
        if (invites.size())
        {
@@ -591,11 +597,11 @@ void userrec::FlushWriteBuf()
 
 void userrec::SetWriteError(const std::string &error)
 {
-       log(DEBUG,"SetWriteError: %s",error.c_str());
+       ServerInstance->Log(DEBUG,"SetWriteError: %s",error.c_str());
        // don't try to set the error twice, its already set take the first string.
        if (!this->WriteError.length())
        {
-               log(DEBUG,"Setting error string for %s to '%s'",this->nick,error.c_str());
+               ServerInstance->Log(DEBUG,"Setting error string for %s to '%s'",this->nick,error.c_str());
                this->WriteError = error;
        }
 }
@@ -610,7 +616,7 @@ void userrec::Oper(const std::string &opertype)
        this->modes[UM_OPERATOR] = 1;
        this->WriteServ("MODE %s :+o", this->nick);
        FOREACH_MOD(I_OnOper, OnOper(this, opertype));
-       log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
+       ServerInstance->Log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
        strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
        ServerInstance->all_opers.push_back(this);
        FOREACH_MOD(I_OnPostOper,OnPostOper(this, opertype));
@@ -626,7 +632,7 @@ void userrec::UnOper()
                {
                        if (*a == this)
                        {
-                               log(DEBUG,"Oper removed from optimization list");
+                               ServerInstance->Log(DEBUG,"Oper removed from optimization list");
                                ServerInstance->all_opers.erase(a);
                                return;
                        }
@@ -678,7 +684,7 @@ void userrec::QuitUser(InspIRCd* Instance, userrec *user,const std::string &quit
                        }
                        catch (ModuleException& modexcept)
                        {
-                               log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
+                               Instance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
                        }
                }
                
@@ -703,7 +709,7 @@ void userrec::QuitUser(InspIRCd* Instance, userrec *user,const std::string &quit
 
        if (iter != Instance->clientlist.end())
        {
-               log(DEBUG,"deleting user hash value %lx",(unsigned long)user);
+               Instance->Log(DEBUG,"deleting user hash value %lx",(unsigned long)user);
                if (IS_LOCAL(user))
                {
                        Instance->fd_ref_table[user->fd] = NULL;
@@ -742,14 +748,14 @@ namespace irc
                }
 
                /* every hour, run this function which removes all entries over 3 days */
-               void MaintainWhoWas(time_t TIME)
+               void MaintainWhoWas(time_t t)
                {
                        for (whowas_users::iterator iter = ::whowas.begin(); iter != ::whowas.end(); iter++)
                        {
                                whowas_set* n = (whowas_set*)iter->second;
                                if (n->size())
                                {
-                                       while ((n->begin() != n->end()) && ((*n->begin())->signon < TIME - 259200)) // 3 days
+                                       while ((n->begin() != n->end()) && ((*n->begin())->signon < t - 259200)) // 3 days
                                        {
                                                WhoWasGroup *a = *(n->begin());
                                                DELETE(a);
@@ -814,7 +820,7 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                Instance->clientlist.erase(iter);
        }
 
-       log(DEBUG,"AddClient: %d %d %s",socket,port,ipaddr);
+       Instance->Log(DEBUG,"AddClient: %d %d %s",socket,port,ipaddr);
        
        _new = new userrec(Instance);
        Instance->clientlist[tempnick] = _new;
@@ -826,12 +832,12 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        strcpy(_new->ident, "unknown");
 
        _new->registered = REG_NONE;
-       _new->signon = TIME + Instance->Config->dns_timeout;
+       _new->signon = Instance->Time() + Instance->Config->dns_timeout;
        _new->lastping = 1;
 
-       log(DEBUG,"Setting socket addresses");
+       Instance->Log(DEBUG,"Setting socket addresses");
        _new->SetSockAddr(AF_FAMILY, ipaddr, port);
-       log(DEBUG,"Socket addresses set.");
+       Instance->Log(DEBUG,"Socket addresses set.");
 
        /* Smarter than your average bear^H^H^H^Hset of strlcpys. */
        for (const char* temp = _new->GetIPString(); *temp && j < 64; temp++, j++)
@@ -859,8 +865,8 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                }
        }
 
-       _new->nping = TIME + _new->pingmax + Instance->Config->dns_timeout;
-       _new->timeout = TIME+class_regtimeout;
+       _new->nping = Instance->Time() + _new->pingmax + Instance->Config->dns_timeout;
+       _new->timeout = Instance->Time() + class_regtimeout;
        _new->flood = class_flood;
        _new->threshold = class_threshold;
        _new->sendqmax = class_sqmax;
@@ -896,10 +902,10 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                userrec::QuitUser(Instance, _new,"Server is full");
                return;
        }
-       char* e = matches_exception(ipaddr);
+       char* e = Instance->XLines->matches_exception(ipaddr);
        if (!e)
        {
-               char* r = matches_zline(ipaddr);
+               char* r = Instance->XLines->matches_zline(ipaddr);
                if (r)
                {
                        char reason[MAXBUF];
@@ -962,7 +968,7 @@ long userrec::LocalCloneCount()
 void userrec::FullConnect(CullList* Goners)
 {
        ServerInstance->stats->statsConnects++;
-       this->idle_lastmsg = TIME;
+       this->idle_lastmsg = ServerInstance->Time();
 
        ConnectClass a = this->GetClass();
 
@@ -993,11 +999,11 @@ void userrec::FullConnect(CullList* Goners)
 
        char match_against[MAXBUF];
        snprintf(match_against,MAXBUF,"%s@%s", this->ident, this->host);
-       char* e = matches_exception(match_against);
+       char* e = ServerInstance->XLines->matches_exception(match_against);
 
        if (!e)
        {
-               char* r = matches_gline(match_against);
+               char* r = ServerInstance->XLines->matches_gline(match_against);
                
                if (r)
                {
@@ -1007,7 +1013,7 @@ void userrec::FullConnect(CullList* Goners)
                        return;
                }
                
-               r = matches_kline(match_against);
+               r = ServerInstance->XLines->matches_kline(match_against);
                
                if (r)
                {
@@ -1023,7 +1029,7 @@ void userrec::FullConnect(CullList* Goners)
        this->WriteServ("001 %s :Welcome to the %s IRC Network %s!%s@%s",this->nick, ServerInstance->Config->Network, this->nick, this->ident, this->host);
        this->WriteServ("002 %s :Your host is %s, running version %s",this->nick,ServerInstance->Config->ServerName,VERSION);
        this->WriteServ("003 %s :This server was created %s %s", this->nick, __TIME__, __DATE__);
-       this->WriteServ("004 %s %s %s %s %s %s", this->nick, ServerInstance->Config->ServerName, VERSION, ServerInstance->ModeGrok->UserModeList().c_str(), ServerInstance->ModeGrok->ChannelModeList().c_str(), ServerInstance->ModeGrok->ParaModeList().c_str());
+       this->WriteServ("004 %s %s %s %s %s %s", this->nick, ServerInstance->Config->ServerName, VERSION, ServerInstance->Modes->UserModeList().c_str(), ServerInstance->Modes->ChannelModeList().c_str(), ServerInstance->Modes->ParaModeList().c_str());
 
        // anfl @ #ratbox, efnet reminded me that according to the RFC this cant contain more than 13 tokens per line...
        // so i'd better split it :)
@@ -1094,7 +1100,7 @@ bool userrec::ForceNickChange(const char* newnick)
                return false;
        }
        
-       if (matches_qline(newnick))
+       if (ServerInstance->XLines->matches_qline(newnick))
        {
                ServerInstance->stats->statsCollisions++;
                return false;
@@ -1121,7 +1127,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
 #ifdef SUPPORT_IP6LINKS
                case AF_INET6:
                {
-                       log(DEBUG,"Set inet6 protocol address");
+                       ServerInstance->Log(DEBUG,"Set inet6 protocol address");
                        sockaddr_in6* sin = new sockaddr_in6;
                        sin->sin6_family = AF_INET6;
                        sin->sin6_port = port;
@@ -1132,7 +1138,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
 #endif
                case AF_INET:
                {
-                       log(DEBUG,"Set inet4 protocol address");
+                       ServerInstance->Log(DEBUG,"Set inet4 protocol address");
                        sockaddr_in* sin = new sockaddr_in;
                        sin->sin_family = AF_INET;
                        sin->sin_port = port;
@@ -1141,7 +1147,7 @@ void userrec::SetSockAddr(int protocol_family, const char* ip, int port)
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, I dont know protocol %d to be set on '%s'!", protocol_family, this->nick);
                break;
        }
 }
@@ -1168,7 +1174,7 @@ int userrec::GetPort()
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return 0;
@@ -1217,7 +1223,7 @@ const char* userrec::GetIPString()
                }
                break;
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return "";
@@ -1260,7 +1266,7 @@ const char* userrec::GetIPString(char* buf)
                break;
 
                default:
-                       log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
+                       ServerInstance->Log(DEBUG,"Ut oh, '%s' has an unknown protocol family!",this->nick);
                break;
        }
        return "";
@@ -1283,7 +1289,7 @@ void userrec::Write(const std::string &text)
                }
                catch (ModuleException& modexcept)
                {
-                       log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
+                       ServerInstance->Log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
                }
        }
        else