Set topic timestamp on newly created channels to a dummy value to work around bug...

[user/henk/code/inspircd.git] / src / users.cpp

diff --git a/src/users.cpp b/src/users.cpp
index fd71b07ad9a518b46a14f8461f0f110f43100751..a755c4dd7348573b8b425b7a6cc1e5387a9f87ec 100644 (file)
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -3,7 +3,7 @@
  *       +------------------------------------+
  *
  *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
@@ -483,7 +483,7 @@ bool User::HasModePermission(unsigned char mode, ModeType type)
        if (mode < 'A' || mode > ('A' + 64)) return false;
 
        return ((type == MODETYPE_USER ? AllowedUserModes : AllowedChanModes))[(mode - 'A')];
-       
+
 }
 
 bool User::HasPermission(const std::string &command)
@@ -671,10 +671,7 @@ std::string User::GetBuffer()
 
 void User::AddWriteBuf(const std::string &data)
 {
-       if (this->quitting)
-               return;
-
-       if (this->MyClass && !this->HasPrivPermission("users/flood/increased-buffers") && sendq.length() + data.length() > this->MyClass->GetSendqMax())
+       if (!this->quitting && this->MyClass && !this->HasPrivPermission("users/flood/increased-buffers") && sendq.length() + data.length() > this->MyClass->GetSendqMax())
        {
                /*
                 * Fix by brain - Set the error text BEFORE calling, because
@@ -686,6 +683,9 @@ void User::AddWriteBuf(const std::string &data)
                return;
        }
 
+       // We still want to append data to the sendq of a quitting user,
+       // e.g. their ERROR message that says 'closing link'
+
        if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
                sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
        else
@@ -918,7 +918,7 @@ void User::CheckClass()
 bool User::CheckLines(bool doZline)
 {
        const char* check[] = { "G" , "K", (doZline) ? "Z" : NULL, NULL };
-       
+
        if (!this->exempt)
        {
                for (int n = 0; check[n]; ++n)
@@ -948,7 +948,7 @@ void User::FullConnect()
         * Don't remove this! -- w00t
         */
        this->SetClass();
-       
+
        /* Check the password, if one is required by the user's connect class.
         * This CANNOT be in CheckClass(), because that is called prior to PASS as well!
         */
@@ -1057,7 +1057,9 @@ bool User::ForceNickChange(const char* newnick)
                std::vector<std::string> parameters;
                nickhandler->HandleInternal(1, dummy);
                parameters.push_back(newnick);
+               this->Extend("NICKForced", "Enabled");
                bool result = (ServerInstance->Parser->CallHandler("NICK", parameters, this) == CMD_SUCCESS);
+               this->Shrink("NICKForced");
                nickhandler->HandleInternal(0, dummy);
                return result;
        }
@@ -1158,7 +1160,7 @@ const char* User::GetCIDRMask(int range)
                        sockaddr_in6* sin;
                        int i, bytestozero, extrabits;
                        char buffer[40];
-                       
+
                        if(range > 128)
                                throw "CIDR mask width greater than address width (IPv6, 128 bit)";
 
@@ -1171,12 +1173,12 @@ const char* User::GetCIDRMask(int range)
                         * which must be set to zero.
                         */
                        bytestozero = (128 - range) / 8;
-                       
+
                        /* Some of the least significant bits of the next most significant byte may also have to
                         * be zeroed. The number of bits is the remainder of the above division.
                         */
                        extrabits = (128 - range) % 8;
-                       
+
                        /* Populate our working struct with the parts of the user's IP which are required in the
                         * final CIDR mask. Set all the subsequent bytes to zero.
                         * (16 - bytestozero) is the number of bytes which must be populated with actual IP data.
@@ -1185,13 +1187,13 @@ const char* User::GetCIDRMask(int range)
                        {
                                v6.s6_addr[i] = sin->sin6_addr.s6_addr[i];
                        }
-                       
+
                        /* And zero all the remaining bytes in the IP. */
                        for(; i < 16; i++)
                        {
                                v6.s6_addr[i] = 0;
                        }
-                                       
+
                        /* And finally, zero the extra bits required. */
                        v6.s6_addr[15 - bytestozero] = (v6.s6_addr[15 - bytestozero] >> extrabits) << extrabits;
 
@@ -1268,7 +1270,7 @@ const char* User::GetIPString()
                                this->cachedip = temp;
                                return temp;
                        }
-                       
+
                        this->cachedip = buf;
                        return buf;
                }
@@ -1285,7 +1287,7 @@ const char* User::GetIPString()
                default:
                break;
        }
-       
+
        // Unreachable, probably
        return "";
 }
@@ -1587,9 +1589,6 @@ void User::WriteCommonExcept(const std::string &text)
 
 void User::WriteWallOps(const std::string &text)
 {
-       if (!IS_LOCAL(this))
-               return;
-
        std::string wallop("WALLOPS :");
        wallop.append(text);
 
@@ -1866,7 +1865,7 @@ ConnectClass* User::SetClass(const std::string &explicit_name)
                        }
 
                        /* check if host matches.. */
-                       if (!InspIRCd::MatchCIDR(this->GetIPString(), c->GetHost(), NULL) && 
+                       if (!InspIRCd::MatchCIDR(this->GetIPString(), c->GetHost(), NULL) &&
                            !InspIRCd::MatchCIDR(this->host, c->GetHost(), NULL))
                        {
                                ServerInstance->Logs->Log("CONNECTCLASS", DEBUG, "No host match (for %s)", c->GetHost().c_str());
@@ -1962,6 +1961,10 @@ void User::PurgeEmptyChannels()
                chan_hash::iterator i2 = ServerInstance->chanlist->find(thischan->name);
                if (i2 != ServerInstance->chanlist->end())
                {
+                       int MOD_RESULT = 0;
+                       FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(i2->second));
+                       if (MOD_RESULT == 1)
+                               continue; // delete halted by module
                        FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(i2->second));
                        delete i2->second;
                        ServerInstance->chanlist->erase(i2);
@@ -2054,4 +2057,3 @@ bool VisData::VisibleTo(User* user)
 {
        return true;
 }
-