]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Get rid of Server::GetUsers(chanrec) - a throwback to before chanrec could do this...
[user/henk/code/inspircd.git] / src / users.cpp
index 61600bd0448580955a7c411c4689dd04ac50a1d4..bb3ef18e90e88768dbea368188397332f1104ce9 100644 (file)
@@ -3,13 +3,13 @@
  *       +------------------------------------+
  *
  *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                       E-mail:
- *                <brain@chatspike.net>
- *               <Craig@chatspike.net>
+ *                    E-mail:
+ *             <brain@chatspike.net>
+ *               <Craig@chatspike.net>
  *     
  * Written by Craig Edwards, Craig McLure, and others.
  * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ *         the file COPYING for details.
  *
  * ---------------------------------------------------
  */
@@ -20,7 +20,7 @@
 #include "connection.h"
 #include "users.h"
 #include "inspircd.h"
-#include <stdio.h>
+#include <stdarg.h>
 #include "inspstring.h"
 #include "commands.h"
 #include "helperfuncs.h"
@@ -45,11 +45,10 @@ extern userrec* fd_ref_table[MAX_DESCRIPTORS];
 extern ServerConfig *Config;
 extern user_hash clientlist;
 extern Server* MyServer;
-
-whowas_users whowas;
-
 extern std::vector<userrec*> local_users;
 
+irc::whowas::whowas_users whowas;
+static unsigned long already_sent[MAX_DESCRIPTORS] = {0};
 std::vector<userrec*> all_opers;
 
 typedef std::map<irc::string,char*> opertype_t;
@@ -58,6 +57,9 @@ typedef opertype_t operclass_t;
 opertype_t opertypes;
 operclass_t operclass;
 
+/* XXX: Used for speeding up WriteCommon operations */
+unsigned long uniq_id = 0;
+
 bool InitTypes(const char* tag)
 {
        for (opertype_t::iterator n = opertypes.begin(); n != opertypes.end(); n++)
@@ -182,19 +184,19 @@ void UserResolver::OnLookupComplete(const std::string &result)
                                if (*(hostname.c_str()) == ':')
                                        hostname = "0" + hostname;
 
-                               WriteServ(this->bound_fd, "NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
+                               this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)", hostname.c_str());
                                this->bound_user->dns_done = true;
                                strlcpy(this->bound_user->dhost, hostname.c_str(),64);
                                strlcpy(this->bound_user->host, hostname.c_str(),64);
                        }
                        else
                        {
-                               WriteServ(this->bound_fd, "NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                               this->bound_user->WriteServ("NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
                        }
                }
                else
                {
-                       WriteServ(this->bound_fd, "NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                       this->bound_user->WriteServ("NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
                }
        }
 }
@@ -204,7 +206,7 @@ void UserResolver::OnError(ResolverError e, const std::string &errormessage)
        if (fd_ref_table[this->bound_fd] == this->bound_user)
        {
                /* Error message here */
-               WriteServ(this->bound_fd, "NOTICE Auth :*** Could not resolve your hostname, using your IP address (%s) instead.", this->bound_user->GetIPString());
+               this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname, using your IP address (%s) instead.", this->bound_user->GetIPString());
                this->bound_user->dns_done = true;
        }
 }
@@ -618,7 +620,7 @@ const char* userrec::GetWriteError()
 void userrec::Oper(const std::string &opertype)
 {
        this->modes[UM_OPERATOR] = 1;
-       WriteServ(this->fd, "MODE %s :+o", this->nick);
+       this->WriteServ("MODE %s :+o", this->nick);
        FOREACH_MOD(I_OnOper, OnOper(this, opertype));
        log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
        strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
@@ -664,13 +666,13 @@ void userrec::QuitUser(userrec *user,const std::string &quitreason)
                reason.resize(MAXQUIT - 1);
        
        if (IS_LOCAL(user))
-               Write(user->fd,"ERROR :Closing link (%s@%s) [%s]",user->ident,user->host,reason.c_str());
+               user->Write("ERROR :Closing link (%s@%s) [%s]",user->ident,user->host,reason.c_str());
 
        if (user->registered == REG_ALL)
        {
                purge_empty_chans(user);
                FOREACH_MOD(I_OnUserQuit,OnUserQuit(user,reason));
-               WriteCommonExcept(user,"QUIT :%s",reason.c_str());
+               user->WriteCommonExcept("QUIT :%s",reason.c_str());
        }
 
        if (IS_LOCAL(user))
@@ -725,75 +727,82 @@ void userrec::QuitUser(userrec *user,const std::string &quitreason)
        }
 }
 
-WhoWasGroup::WhoWasGroup(userrec* user) : host(NULL), dhost(NULL), ident(NULL), server(NULL), gecos(NULL), signon(user->signon)
+namespace irc
 {
-       this->host = strdup(user->host);
-       this->dhost = strdup(user->dhost);
-       this->ident = strdup(user->ident);
-       this->server = user->server;
-       this->gecos = strdup(user->fullname);
-}
+       namespace whowas
+       {
 
-WhoWasGroup::~WhoWasGroup()
-{
-       if (host)
-               free(host);
-       if (dhost)
-               free(dhost);
-       if (ident)
-               free(ident);
-       if (gecos)
-               free(gecos);
-}
+               WhoWasGroup::WhoWasGroup(userrec* user) : host(NULL), dhost(NULL), ident(NULL), server(NULL), gecos(NULL), signon(user->signon)
+               {
+                       this->host = strdup(user->host);
+                       this->dhost = strdup(user->dhost);
+                       this->ident = strdup(user->ident);
+                       this->server = user->server;
+                       this->gecos = strdup(user->fullname);
+               }
+
+               WhoWasGroup::~WhoWasGroup()
+               {
+                       if (host)
+                               free(host);
+                       if (dhost)
+                               free(dhost);
+                       if (ident)
+                               free(ident);
+                       if (gecos)
+                               free(gecos);
+               }
+
+               /* every hour, run this function which removes all entries over 3 days */
+               void MaintainWhoWas(time_t TIME)
+               {
+                       for (whowas_users::iterator iter = ::whowas.begin(); iter != ::whowas.end(); iter++)
+                       {
+                               whowas_set* n = (whowas_set*)iter->second;
+                               if (n->size())
+                               {
+                                       while ((n->begin() != n->end()) && ((*n->begin())->signon < TIME - 259200)) // 3 days
+                                       {
+                                               WhoWasGroup *a = *(n->begin());
+                                               DELETE(a);
+                                               n->erase(n->begin());
+                                       }
+                               }
+                       }
+               }
+       };
+};
 
 /* adds or updates an entry in the whowas list */
 void userrec::AddToWhoWas()
 {
-       whowas_users::iterator iter = whowas.find(this->nick);
+       irc::whowas::whowas_users::iterator iter = whowas.find(this->nick);
 
        if (iter == whowas.end())
        {
-               whowas_set* n = new whowas_set;
-               WhoWasGroup *a = new WhoWasGroup(this);
+               irc::whowas::whowas_set* n = new irc::whowas::whowas_set;
+               irc::whowas::WhoWasGroup *a = new irc::whowas::WhoWasGroup(this);
                n->push_back(a);
                whowas[this->nick] = n;
        }
        else
        {
-               whowas_set* group = (whowas_set*)iter->second;
+               irc::whowas::whowas_set* group = (irc::whowas::whowas_set*)iter->second;
 
                if (group->size() > 10)
                {
-                       WhoWasGroup *a = (WhoWasGroup*)*(group->begin());
+                       irc::whowas::WhoWasGroup *a = (irc::whowas::WhoWasGroup*)*(group->begin());
                        DELETE(a);
                        group->pop_front();
                }
 
-               WhoWasGroup *a = new WhoWasGroup(this);
+               irc::whowas::WhoWasGroup *a = new irc::whowas::WhoWasGroup(this);
                group->push_back(a);
        }
 }
 
-/* every hour, run this function which removes all entries over 3 days */
-void MaintainWhoWas(time_t TIME)
-{
-       for (whowas_users::iterator iter = whowas.begin(); iter != whowas.end(); iter++)
-       {
-               whowas_set* n = (whowas_set*)iter->second;
-               if (n->size())
-               {
-                       while ((n->begin() != n->end()) && ((*n->begin())->signon < TIME - 259200)) // 3 days
-                       {
-                               WhoWasGroup *a = *(n->begin());
-                               DELETE(a);
-                               n->erase(n->begin());
-                       }
-               }
-       }
-}
-
 /* add a client connection to the sockets list */
-void AddClient(int socket, int port, bool iscached, insp_inaddr ip)
+void userrec::AddClient(int socket, int port, bool iscached, insp_inaddr ip)
 {
        std::string tempnick = ConvToStr(socket) + "-unknown";
        user_hash::iterator iter = clientlist.find(tempnick);
@@ -837,7 +846,7 @@ void AddClient(int socket, int port, bool iscached, insp_inaddr ip)
        log(DEBUG,"Socket addresses set.");
 
        /* Smarter than your average bear^H^H^H^Hset of strlcpys. */
-        for (const char* temp = _new->GetIPString(); *temp && j < 64; temp++, j++)
+       for (const char* temp = _new->GetIPString(); *temp && j < 64; temp++, j++)
                _new->dhost[j] = _new->host[j] = *temp;
        _new->dhost[j] = _new->host[j] = 0;
                        
@@ -921,10 +930,10 @@ void AddClient(int socket, int port, bool iscached, insp_inaddr ip)
                }
        }
 
-       WriteServ(_new->fd,"NOTICE Auth :*** Looking up your hostname...");
+       _new->WriteServ("NOTICE Auth :*** Looking up your hostname...");
 }
 
-long FindMatchingGlobal(userrec* user)
+long userrec::GlobalCloneCount()
 {
        char u1[1024];
        char u2[1024];
@@ -934,13 +943,13 @@ long FindMatchingGlobal(userrec* user)
                /* We have to match ip's as strings - we don't know what protocol
                 * a remote user may be using
                 */
-               if (!strcasecmp(a->second->GetIPString(u1), user->GetIPString(u2)))
+               if (!strcasecmp(a->second->GetIPString(u1), this->GetIPString(u2)))
                                x++;
        }
        return x;
 }
 
-long FindMatchingLocal(userrec* user)
+long userrec::LocalCloneCount()
 {
        long x = 0;
        for (std::vector<userrec*>::const_iterator a = local_users.begin(); a != local_users.end(); a++)
@@ -949,12 +958,12 @@ long FindMatchingLocal(userrec* user)
 #ifdef IPV6
                /* I dont think theres any faster way of matching two ipv6 addresses than memcmp */
                in6_addr* s1 = &(((sockaddr_in6*)comp->ip)->sin6_addr);
-               in6_addr* s2 = &(((sockaddr_in6*)user->ip)->sin6_addr);
+               in6_addr* s2 = &(((sockaddr_in6*)this->ip)->sin6_addr);
                if (!memcmp(s1->s6_addr, s2->s6_addr, sizeof(in6_addr)))
                        x++;
 #else
                in_addr* s1 = &((sockaddr_in*)comp->ip)->sin_addr;
-               in_addr* s2 = &((sockaddr_in*)user->ip)->sin_addr;
+               in_addr* s2 = &((sockaddr_in*)this->ip)->sin_addr;
                if (s1->s_addr == s2->s_addr)
                        x++;
 #endif
@@ -981,13 +990,13 @@ void userrec::FullConnect(CullList* Goners)
                return;
        }
        
-       if (FindMatchingLocal(this) > a.maxlocal)
+       if (this->LocalCloneCount() > a.maxlocal)
        {
                Goners->AddItem(this, "No more connections allowed from your host via this connect class (local)");
                WriteOpers("*** WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a.maxlocal, this->GetIPString());
                return;
        }
-       else if (FindMatchingGlobal(this) > a.maxglobal)
+       else if (this->GlobalCloneCount() > a.maxglobal)
        {
                Goners->AddItem(this, "No more connections allowed from your host via this connect class (global)");
                WriteOpers("*** WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s",a.maxglobal, this->GetIPString());
@@ -1022,11 +1031,11 @@ void userrec::FullConnect(CullList* Goners)
        }
 
 
-       WriteServ(this->fd,"NOTICE Auth :Welcome to \002%s\002!",Config->Network);
-       WriteServ(this->fd,"001 %s :Welcome to the %s IRC Network %s!%s@%s",this->nick, Config->Network, this->nick, this->ident, this->host);
-       WriteServ(this->fd,"002 %s :Your host is %s, running version %s",this->nick,Config->ServerName,VERSION);
-       WriteServ(this->fd,"003 %s :This server was created %s %s", this->nick, __TIME__, __DATE__);
-       WriteServ(this->fd,"004 %s %s %s %s %s %s", this->nick, Config->ServerName, VERSION, ServerInstance->ModeGrok->UserModeList().c_str(), ServerInstance->ModeGrok->ChannelModeList().c_str(), ServerInstance->ModeGrok->ParaModeList().c_str());
+       this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",Config->Network);
+       this->WriteServ("001 %s :Welcome to the %s IRC Network %s!%s@%s",this->nick, Config->Network, this->nick, this->ident, this->host);
+       this->WriteServ("002 %s :Your host is %s, running version %s",this->nick,Config->ServerName,VERSION);
+       this->WriteServ("003 %s :This server was created %s %s", this->nick, __TIME__, __DATE__);
+       this->WriteServ("004 %s %s %s %s %s %s", this->nick, Config->ServerName, VERSION, ServerInstance->ModeGrok->UserModeList().c_str(), ServerInstance->ModeGrok->ChannelModeList().c_str(), ServerInstance->ModeGrok->ParaModeList().c_str());
 
        // anfl @ #ratbox, efnet reminded me that according to the RFC this cant contain more than 13 tokens per line...
        // so i'd better split it :)
@@ -1043,7 +1052,7 @@ void userrec::FullConnect(CullList* Goners)
                
                if ((token_counter >= 13) || (out.eof() == true))
                {
-                       WriteServ(this->fd,"005 %s %s:are supported by this server", this->nick, line5.c_str());
+                       this->WriteServ("005 %s %s:are supported by this server", this->nick, line5.c_str());
                        line5 = "";
                        token_counter = 0;
                }
@@ -1269,3 +1278,365 @@ const char* userrec::GetIPString(char* buf)
        return "";
 }
 
+
+void userrec::Write(const std::string &text)
+{
+       if ((this->fd < 0) || (this->fd > MAX_DESCRIPTORS))
+               return;
+
+       std::string crlf = text;
+       crlf.append("\r\n");
+
+       if (Config->GetIOHook(this->GetPort()))
+       {
+               try
+               {
+                       Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, crlf.data(), crlf.length());
+               }
+               catch (ModuleException& modexcept)
+               {
+                       log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
+               }
+       }
+       else
+       {
+               this->AddWriteBuf(crlf);
+       }
+       ServerInstance->stats->statsSent += crlf.length();
+}
+
+/** Write()
+ */
+void userrec::Write(const char *text, ...)
+{
+       va_list argsPtr;
+       char textbuffer[MAXBUF];
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->Write(std::string(textbuffer));
+}
+
+void userrec::WriteServ(const std::string& text)
+{
+       char textbuffer[MAXBUF];
+
+       snprintf(textbuffer,MAXBUF,":%s %s",Config->ServerName,text.c_str());
+       this->Write(std::string(textbuffer));
+}
+
+/** WriteServ()
+ *  Same as Write(), except `text' is prefixed with `:server.name '.
+ */
+void userrec::WriteServ(const char* text, ...)
+{
+       va_list argsPtr;
+       char textbuffer[MAXBUF];
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteServ(std::string(textbuffer));
+}
+
+
+void userrec::WriteFrom(userrec *user, const std::string &text)
+{
+       char tb[MAXBUF];
+
+       snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str());
+       
+       this->Write(std::string(tb));
+}
+
+
+/* write text from an originating user to originating user */
+
+void userrec::WriteFrom(userrec *user, const char* text, ...)
+{
+       va_list argsPtr;
+       char textbuffer[MAXBUF];
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteFrom(user, std::string(textbuffer));
+}
+
+
+/* write text to an destination user from a source user (e.g. user privmsg) */
+
+void userrec::WriteTo(userrec *dest, const char *data, ...)
+{
+       char textbuffer[MAXBUF];
+       va_list argsPtr;
+
+       va_start(argsPtr, data);
+       vsnprintf(textbuffer, MAXBUF, data, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteTo(dest, std::string(textbuffer));
+}
+
+void userrec::WriteTo(userrec *dest, const std::string &data)
+{
+       dest->WriteFrom(this, data);
+}
+
+
+void userrec::WriteCommon(const char* text, ...)
+{
+       char textbuffer[MAXBUF];
+       va_list argsPtr;
+
+       if (this->registered != REG_ALL)
+               return;
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteCommon(std::string(textbuffer));
+}
+
+void userrec::WriteCommon(const std::string &text)
+{
+       bool sent_to_at_least_one = false;
+
+       if (this->registered != REG_ALL)
+               return;
+
+       uniq_id++;
+
+       for (std::vector<ucrec*>::const_iterator v = this->chans.begin(); v != this->chans.end(); v++)
+       {
+               ucrec *n = *v;
+               if (n->channel)
+               {
+                       CUList *ulist= n->channel->GetUsers();
+
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       {
+                               if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+                               {
+                                       already_sent[i->second->fd] = uniq_id;
+                                       i->second->WriteFrom(this, std::string(text));
+                                       sent_to_at_least_one = true;
+                               }
+                       }
+               }
+       }
+
+       /*
+        * if the user was not in any channels, no users will receive the text. Make sure the user
+        * receives their OWN message for WriteCommon
+        */
+       if (!sent_to_at_least_one)
+       {
+               this->WriteFrom(this,std::string(text));
+       }
+}
+
+
+/* write a formatted string to all users who share at least one common
+ * channel, NOT including the source user e.g. for use in QUIT
+ */
+
+void userrec::WriteCommonExcept(const char* text, ...)
+{
+       char textbuffer[MAXBUF];
+       va_list argsPtr;
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);
+
+       this->WriteCommonExcept(std::string(textbuffer));
+}
+
+void userrec::WriteCommonExcept(const std::string &text)
+{
+       bool quit_munge = true;
+       char oper_quit[MAXBUF];
+       char textbuffer[MAXBUF];
+
+       strlcpy(textbuffer, text.c_str(), MAXBUF);
+
+       if (this->registered != REG_ALL)
+               return;
+
+       uniq_id++;
+
+       /* TODO: We need some form of WriteCommonExcept that will send two lines, one line to
+        * opers and the other line to non-opers, then all this hidebans and hidesplits gunk
+        * can go byebye.
+        */
+       if (Config->HideSplits)
+       {
+               char* check = textbuffer + 6;
+
+               if (!strncasecmp(textbuffer, "QUIT :",6))
+               {
+                       std::stringstream split(check);
+                       std::string server_one;
+                       std::string server_two;
+
+                       split >> server_one;
+                       split >> server_two;
+
+                       if ((FindServerName(server_one)) && (FindServerName(server_two)))
+                       {
+                               strlcpy(oper_quit,textbuffer,MAXQUIT);
+                               strlcpy(check,"*.net *.split",MAXQUIT);
+                               quit_munge = true;
+                       }
+               }
+       }
+
+       if ((Config->HideBans) && (!quit_munge))
+       {
+               if ((!strncasecmp(textbuffer, "QUIT :G-Lined:",14)) || (!strncasecmp(textbuffer, "QUIT :K-Lined:",14))
+               || (!strncasecmp(textbuffer, "QUIT :Q-Lined:",14)) || (!strncasecmp(textbuffer, "QUIT :Z-Lined:",14)))
+               {
+                       char* check = textbuffer + 13;
+                       strlcpy(oper_quit,textbuffer,MAXQUIT);
+                       *check = 0;  // We don't need to strlcpy, we just chop it from the :
+                       quit_munge = true;
+               }
+       }
+
+       for (std::vector<ucrec*>::const_iterator v = this->chans.begin(); v != this->chans.end(); v++)
+       {
+               ucrec* n = *v;
+               if (n->channel)
+               {
+                       CUList *ulist= n->channel->GetUsers();
+
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       {
+                               if (this != i->second)
+                               {
+                                       if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+                                       {
+                                               already_sent[i->second->fd] = uniq_id;
+                                               if (quit_munge)
+                                                       i->second->WriteFrom(this, *i->second->oper ? std::string(oper_quit) : std::string(textbuffer));
+                                               else
+                                                       i->second->WriteFrom(this, std::string(textbuffer));
+                                       }
+                               }
+                       }
+               }
+       }
+
+}
+
+void userrec::WriteWallOps(const std::string &text)
+{
+       /* Does nothing if theyre not opered */
+       if ((!*this->oper) && (IS_LOCAL(this)))
+               return;
+
+       std::string wallop = "WALLOPS :";
+       wallop.append(text);
+
+       for (std::vector<userrec*>::const_iterator i = local_users.begin(); i != local_users.end(); i++)
+       {
+               userrec* t = *i;
+               if ((IS_LOCAL(t)) && (t->modes[UM_WALLOPS]))
+                       this->WriteTo(t,wallop);
+       }
+}
+
+void userrec::WriteWallOps(const char* text, ...)
+{       
+       char textbuffer[MAXBUF];
+       va_list argsPtr;
+
+       va_start(argsPtr, text);
+       vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+       va_end(argsPtr);                
+                                       
+       this->WriteWallOps(std::string(textbuffer));
+}                                     
+
+/* return 0 or 1 depending if users u and u2 share one or more common channels
+ * (used by QUIT, NICK etc which arent channel specific notices)
+ *
+ * The old algorithm in 1.0 for this was relatively inefficient, iterating over
+ * the first users channels then the second users channels within the outer loop,
+ * therefore it was a maximum of x*y iterations (upon returning 0 and checking
+ * all possible iterations). However this new function instead checks against the
+ * channel's userlist in the inner loop which is a std::map<userrec*,userrec*>
+ * and saves us time as we already know what pointer value we are after.
+ * Don't quote me on the maths as i am not a mathematician or computer scientist,
+ * but i believe this algorithm is now x+(log y) maximum iterations instead.
+ */
+bool userrec::SharesChannelWith(userrec *other)
+{
+       if ((!other) || (this->registered != REG_ALL) || (other->registered != REG_ALL))
+               return false;
+
+       /* Outer loop */
+       for (std::vector<ucrec*>::const_iterator i = this->chans.begin(); i != this->chans.end(); i++)
+       {
+               /* Fetch the channel from the user */
+               ucrec* user_channel = *i;
+
+               if (user_channel->channel)
+               {
+                       /* Eliminate the inner loop (which used to be ~equal in size to the outer loop)
+                        * by replacing it with a map::find which *should* be more efficient
+                        */
+                       if (user_channel->channel->HasUser(other))
+                               return true;
+               }
+       }
+       return false;
+}
+
+int userrec::CountChannels()
+{
+       int z = 0;
+       for (std::vector<ucrec*>::const_iterator i = this->chans.begin(); i != this->chans.end(); i++)
+               if ((*i)->channel)
+                       z++;
+       return z;
+}
+
+bool userrec::ChangeName(const char* gecos)
+{
+       if (IS_LOCAL(this))
+       {
+               int MOD_RESULT = 0;
+               FOREACH_RESULT(I_OnChangeLocalUserGECOS,OnChangeLocalUserGECOS(this,gecos));
+               if (MOD_RESULT)
+                       return false;
+               FOREACH_MOD(I_OnChangeName,OnChangeName(this,gecos));
+       }
+       strlcpy(this->fullname,gecos,MAXGECOS+1);
+       return true;
+}
+
+bool userrec::ChangeDisplayedHost(const char* host)
+{
+       if (IS_LOCAL(this))
+       {
+               int MOD_RESULT = 0;
+               FOREACH_RESULT(I_OnChangeLocalUserHost,OnChangeLocalUserHost(this,host));
+               if (MOD_RESULT)
+                       return false;
+               FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,host));
+       }
+       strlcpy(this->dhost,host,63);
+
+       if (IS_LOCAL(this))
+               this->WriteServ("396 %s %s :is now your hidden host",this->nick,this->dhost);
+
+       return true;
+}
+