]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
Changed m_messageflood to use PreMessage and PreNotice, because it may kick the user
[user/henk/code/inspircd.git] / src / users.cpp
index 48260bd1fff8b88caaad5d641f3ad9d7e4119c6a..cbf9de0cdcc8a038c0331b7ab08a9317f952e747 100644 (file)
  * ---------------------------------------------------
  */
 
+#include "inspircd.h"
 #include "configreader.h"
 #include "channels.h"
 #include "users.h"
-#include "inspircd.h"
 #include <stdarg.h>
 #include "socketengine.h"
 #include "wildcard.h"
@@ -61,7 +61,7 @@ bool DoType(ServerConfig* conf, const char* tag, char** entries, ValueList &valu
        const char* TypeName = values[0].GetString();
        const char* Classes = values[1].GetString();
 
-       conf->opertypes[TypeName] = strdup(Classes);
+       conf->opertypes[TypeName] = strnewdup(Classes);
        return true;
 }
 
@@ -70,7 +70,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char** entries, ValueList &val
        const char* ClassName = values[0].GetString();
        const char* CommandList = values[1].GetString();
 
-       conf->operclass[ClassName] = strdup(CommandList);
+       conf->operclass[ClassName] = strnewdup(CommandList);
        return true;
 }
 
@@ -183,14 +183,10 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
                                        bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, (!strncmp(ip, "0::ffff:", 8) ? DNS_QUERY_A : DNS_QUERY_AAAA), cached);
                                }
                                else
-                               {
                                        /* IPV4 lookup (mixed protocol mode) */
-                                       bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, DNS_QUERY_A, cached);
-                               }
-#else
+#endif
                                /* IPV4 lookup (ipv4 only mode) */
                                bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, DNS_QUERY_A, cached);
-#endif
                                this->ServerInstance->AddResolver(bound_user->res_forward, cached);
                        }
                }
@@ -202,7 +198,7 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
        else if ((this->fwd) && (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user))
        {
                /* Both lookups completed */
-               std::string result2 = "0::ffff:";
+               std::string result2("0::ffff:");
                result2.append(result);
                if (this->bound_user->GetIPString() == result || this->bound_user->GetIPString() == result2)
                {
@@ -210,11 +206,11 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
                        if (hostname.length() < 65)
                        {
                                /* Check we didnt time out */
-                               if (this->bound_user->registered != REG_ALL)
+                               if ((this->bound_user->registered != REG_ALL) && (!this->bound_user->dns_done))
                                {
                                        /* Hostnames starting with : are not a good thing (tm) */
                                        if (*(hostname.c_str()) == ':')
-                                               hostname = "0" + hostname;
+                                               hostname.insert(0, "0");
 
                                        this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)%s", hostname.c_str(), (cached ? " -- cached" : ""));
                                        this->bound_user->dns_done = true;
@@ -226,12 +222,20 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
                        }
                        else
                        {
-                               this->bound_user->WriteServ("NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                               if (!this->bound_user->dns_done)
+                               {
+                                       this->bound_user->WriteServ("NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                                       this->bound_user->dns_done = true;
+                               }
                        }
                }
                else
                {
-                       this->bound_user->WriteServ("NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                       if (!this->bound_user->dns_done)
+                       {
+                               this->bound_user->WriteServ("NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
+                               this->bound_user->dns_done = true;
+                       }
                }
        }
 }
@@ -240,9 +244,14 @@ void UserResolver::OnError(ResolverError e, const std::string &errormessage)
 {
        if (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user)
        {
-               /* Error message here */
-               this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname: %s; using your IP address (%s) instead.", errormessage.c_str(), this->bound_user->GetIPString());
-               this->bound_user->dns_done = true;
+               /* Since dns timeout is implemented outside of the resolver, this was a race condition that could result in this message being sent *after*
+                * the user was fully connected. This check fixes that issue  - Special */
+               if (!this->bound_user->dns_done)
+               {
+                       /* Error message here */
+                       this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname: %s; using your IP address (%s) instead.", errormessage.c_str(), this->bound_user->GetIPString());
+                       this->bound_user->dns_done = true;
+               }
        }
 }
 
@@ -321,10 +330,11 @@ userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
        ChannelCount = timeout = flood = bytes_in = bytes_out = cmds_in = cmds_out = 0;
        muted = exempt = haspassed = dns_done = false;
        fd = -1;
-       recvq = "";
-       sendq = "";
-       WriteError = "";
+       recvq.clear();
+       sendq.clear();
+       WriteError.clear();
        res_forward = res_reverse = NULL;
+       Visibility = NULL;
        ip = NULL;
        chans.clear();
        invites.clear();
@@ -334,6 +344,29 @@ userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
        operquit = cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
 }
 
+void userrec::RemoveCloneCounts()
+{
+       clonemap::iterator x = ServerInstance->local_clones.find(this->GetIPString());
+       if (x != ServerInstance->local_clones.end())
+       {
+               x->second--;
+               if (!x->second)
+               {
+                       ServerInstance->local_clones.erase(x);
+               }
+       }
+       
+       clonemap::iterator y = ServerInstance->global_clones.find(this->GetIPString());
+       if (y != ServerInstance->global_clones.end())
+       {
+               y->second--;
+               if (!y->second)
+               {
+                       ServerInstance->global_clones.erase(y);
+               }
+       }
+}
+
 userrec::~userrec()
 {
        this->InvalidateCache();
@@ -342,25 +375,7 @@ userrec::~userrec()
                free(operquit);
        if (ip)
        {
-               clonemap::iterator x = ServerInstance->local_clones.find(this->GetIPString());
-               if (x != ServerInstance->local_clones.end())
-               {
-                       x->second--;
-                       if (!x->second)
-                       {
-                               ServerInstance->local_clones.erase(x);
-                       }
-               }
-
-               clonemap::iterator y = ServerInstance->global_clones.find(this->GetIPString());
-               if (y != ServerInstance->global_clones.end())
-               {
-                       y->second--;
-                       if (!y->second)
-                       {
-                               ServerInstance->global_clones.erase(y);
-                       }
-               }
+               this->RemoveCloneCounts();
 
                if (this->GetProtocolFamily() == AF_INET)
                {
@@ -459,7 +474,11 @@ int userrec::ReadData(void* buffer, size_t size)
 {
        if (IS_LOCAL(this))
        {
+#ifndef WIN32
                return read(this->fd, buffer, size);
+#else
+               return recv(this->fd, (char*)buffer, size, 0);
+#endif
        }
        else
                return 0;
@@ -539,7 +558,7 @@ bool userrec::HasPermission(const std::string &command)
                return true;
 
        // are they even an oper at all?
-       if (*this->oper)
+       if (IS_OPER(this))
        {
                opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper);
                if (iter_opertype != ServerInstance->Config->opertypes.end())
@@ -618,7 +637,7 @@ bool userrec::BufferIsReady()
 
 void userrec::ClearBuffer()
 {
-       recvq = "";
+       recvq.clear();
 }
 
 std::string userrec::GetBuffer()
@@ -632,8 +651,12 @@ std::string userrec::GetBuffer()
                 * Usually there are only one or two of these,
                 * so its is computationally cheap to do.
                 */
-               while ((*recvq.begin() == '\r') || (*recvq.begin() == '\n'))
-                       recvq.erase(recvq.begin());
+               std::string::iterator t = recvq.begin();
+               while (t != recvq.end() && (*t == '\r' || *t == '\n'))
+               {
+                       recvq.erase(t);
+                       t = recvq.begin();
+               }
 
                for (std::string::iterator x = recvq.begin(); x != recvq.end(); x++)
                {
@@ -676,8 +699,8 @@ void userrec::AddWriteBuf(const std::string &data)
 
        try
        {
-               if (data.length() > 512)
-                       sendq.append(data.substr(0,510)).append("\r\n");
+               if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
+                       sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
                else
                        sendq.append(data);
        }
@@ -695,12 +718,16 @@ void userrec::FlushWriteBuf()
        {
                if ((this->fd == FD_MAGIC_NUMBER) || (*this->GetWriteError()))
                {
-                       sendq = "";
+                       sendq.clear();
                }
                if ((sendq.length()) && (this->fd != FD_MAGIC_NUMBER))
                {
                        int old_sendq_length = sendq.length();
-                       int n_sent = write(this->fd, this->sendq.data(), this->sendq.length());
+#ifndef WIN32
+               int n_sent = write(this->fd, this->sendq.data(), this->sendq.length());
+#else
+               int n_sent = send(this->fd, (const char*)this->sendq.data(), this->sendq.length(), 0);
+#endif
                        if (n_sent == -1)
                        {
                                if (errno == EAGAIN)
@@ -714,7 +741,7 @@ void userrec::FlushWriteBuf()
                                {
                                        /* Fatal error, set write error and bail
                                         */
-                                       this->SetWriteError(strerror(errno));
+                                       this->SetWriteError(errno ? strerror(errno) : "EOF from client");
                                        return;
                                }
                        }
@@ -786,10 +813,13 @@ void userrec::UnOper()
 {
        try
        {
-               if (*this->oper)
+               if (IS_OPER(this))
                {
+                       // unset their oper type (what IS_OPER checks), and remove +o
                        *this->oper = 0;
                        this->modes[UM_OPERATOR] = 0;
+
+                       // remove them from the opers list.
                        for (std::vector<userrec*>::iterator a = ServerInstance->all_opers.begin(); a < ServerInstance->all_opers.end(); a++)
                        {
                                if (*a == this)
@@ -835,10 +865,8 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        if (socketfamily == AF_INET6)
                inet_ntop(AF_INET6, &((const sockaddr_in6*)ip)->sin6_addr, ipaddr, sizeof(ipaddr));
        else
-               inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
-#else
-       inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
 #endif
+       inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
        userrec* New;
        int j = 0;
 
@@ -883,21 +911,23 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
        Instance->AddLocalClone(New);
        Instance->AddGlobalClone(New);
 
+       /*
+        * First class check. We do this again in FullConnect after DNS is done, and NICK/USER is recieved.
+        * See my note down there for why this is required. DO NOT REMOVE. :) -- w00t
+        */
        ConnectClass* i = New->GetClass();
 
-       if ((!i) || (i->GetType() == CC_DENY))
+       if (!i)
        {
-               userrec::QuitUser(Instance, New,"Unauthorised connection");
+               userrec::QuitUser(Instance, New, "Access denied by configuration");
                return;
        }
 
-       New->pingmax = i->GetPingTime();
-       New->nping = Instance->Time() + i->GetPingTime() + Instance->Config->dns_timeout;
-       New->timeout = Instance->Time() + i->GetRegTimeout();
-       New->flood = i->GetFlood();
-       New->threshold = i->GetThreshold();
-       New->sendqmax = i->GetSendqMax();
-       New->recvqmax = i->GetRecvqMax();
+       /*
+        * Check connect class settings and initialise settings into userrec.
+        * This will be done again after DNS resolution. -- w00t
+        */
+       New->CheckClass();
 
        Instance->local_users.push_back(New);
 
@@ -918,11 +948,13 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
         * which for the time being is a physical impossibility (even the largest networks dont have more
         * than about 10,000 users on ONE server!)
         */
+#ifndef WINDOWS
        if ((unsigned int)socket >= MAX_DESCRIPTORS)
        {
                userrec::QuitUser(Instance, New, "Server is full");
                return;
        }
+#endif
 
        New->exempt = (Instance->XLines->matches_exception(New) != NULL);
        if (!New->exempt)
@@ -931,6 +963,8 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
                if (r)
                {
                        char reason[MAXBUF];
+                       if (*Instance->Config->MoronBanner)
+                               New->WriteServ("NOTICE %s :*** %s", New->nick, Instance->Config->MoronBanner);
                        snprintf(reason,MAXBUF,"Z-Lined: %s",r->reason);
                        userrec::QuitUser(Instance, New, reason);
                        return;
@@ -970,42 +1004,62 @@ unsigned long userrec::LocalCloneCount()
                return 0;
 }
 
-void userrec::FullConnect()
+/*
+ * Check class restrictions
+ */
+void userrec::CheckClass()
 {
-       ServerInstance->stats->statsConnects++;
-       this->idle_lastmsg = ServerInstance->Time();
-
        ConnectClass* a = this->GetClass();
 
        if ((!a) || (a->GetType() == CC_DENY))
        {
-               this->muted = true;
-               ServerInstance->GlobalCulls.AddItem(this,"Unauthorised connection");
+               userrec::QuitUser(ServerInstance, this, "Unauthorised connection");
                return;
        }
-
-       if ((!a->GetPass().empty()) && (!this->haspassed))
+       else if ((a->GetMaxLocal()) && (this->LocalCloneCount() > a->GetMaxLocal()))
        {
-               this->muted = true;
-               ServerInstance->GlobalCulls.AddItem(this,"Invalid password");
+               userrec::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (local)");
+               ServerInstance->WriteOpers("*** WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a->GetMaxLocal(), this->GetIPString());
                return;
        }
-
-       if (this->LocalCloneCount() > a->GetMaxLocal())
+       else if ((a->GetMaxGlobal()) && (this->GlobalCloneCount() > a->GetMaxGlobal()))
        {
-               this->muted = true;
-               ServerInstance->GlobalCulls.AddItem(this, "No more connections allowed from your host via this connect class (local)");
-               ServerInstance->WriteOpers("*** WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a->GetMaxLocal(), this->GetIPString());
+               userrec::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (global)");
+               ServerInstance->WriteOpers("*** WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s", a->GetMaxGlobal(), this->GetIPString());
                return;
        }
-       else if (this->GlobalCloneCount() > a->GetMaxGlobal())
+
+       this->pingmax = a->GetPingTime();
+       this->nping = ServerInstance->Time() + a->GetPingTime() + ServerInstance->Config->dns_timeout;
+       this->timeout = ServerInstance->Time() + a->GetRegTimeout();
+       this->flood = a->GetFlood();
+       this->threshold = a->GetThreshold();
+       this->sendqmax = a->GetSendqMax();
+       this->recvqmax = a->GetRecvqMax();
+}
+
+void userrec::FullConnect()
+{
+       ServerInstance->stats->statsConnects++;
+       this->idle_lastmsg = ServerInstance->Time();
+
+       /*
+        * You may be thinking "wtf, we checked this in userrec::AddClient!" - and yes, we did, BUT.
+        * At the time AddClient is called, we don't have a resolved host, by here we probably do - which
+        * may put the user into a totally seperate class with different restrictions! so we *must* check again.
+        * Don't remove this! -- w00t
+        */
+       this->CheckClass();
+       
+       /* Check the password, if one is required by the user's connect class.
+        * This CANNOT be in CheckClass(), because that is called prior to PASS as well!
+        */
+       if ((!this->GetClass()->GetPass().empty()) && (!this->haspassed))
        {
-               this->muted = true;
-               ServerInstance->GlobalCulls.AddItem(this, "No more connections allowed from your host via this connect class (global)");
-               ServerInstance->WriteOpers("*** WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s",a->GetMaxGlobal(), this->GetIPString());
+               userrec::QuitUser(ServerInstance, this, "Invalid password");
                return;
        }
-
+       
        if (!this->exempt)
        {
                GLine* r = ServerInstance->XLines->matches_gline(this);
@@ -1014,8 +1068,10 @@ void userrec::FullConnect()
                {
                        this->muted = true;
                        char reason[MAXBUF];
+                       if (*ServerInstance->Config->MoronBanner)
+                               this->WriteServ("NOTICE %s :*** %s", this->nick, ServerInstance->Config->MoronBanner);
                        snprintf(reason,MAXBUF,"G-Lined: %s",r->reason);
-                       ServerInstance->GlobalCulls.AddItem(this, reason);
+                       userrec::QuitUser(ServerInstance, this, reason);
                        return;
                }
 
@@ -1025,11 +1081,12 @@ void userrec::FullConnect()
                {
                        this->muted = true;
                        char reason[MAXBUF];
+                       if (*ServerInstance->Config->MoronBanner)
+                               this->WriteServ("NOTICE %s :*** %s", this, ServerInstance->Config->MoronBanner);
                        snprintf(reason,MAXBUF,"K-Lined: %s",n->reason);
-                       ServerInstance->GlobalCulls.AddItem(this, reason);
+                       userrec::QuitUser(ServerInstance, this, reason);
                        return;
                }
-
        }
 
        this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",ServerInstance->Config->Network);
@@ -1046,6 +1103,12 @@ void userrec::FullConnect()
        if (ServerInstance->unregistered_count)
                ServerInstance->unregistered_count--;
 
+       /* Trigger LUSERS output, give modules a chance too */
+       int MOD_RESULT = 0;
+       FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", NULL, 0, this, true, "LUSERS"));
+       if (!MOD_RESULT)
+               ServerInstance->CallCommandHandler("LUSERS", NULL, 0, this);
+
        /*
         * fix 3 by brain, move registered = 7 below these so that spurious modes and host
         * changes dont go out onto the network and produce 'fake direction'.
@@ -1056,7 +1119,7 @@ void userrec::FullConnect()
 
        FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
 
-       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString());
+       ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString(), this->fullname);
 }
 
 /** userrec::UpdateNick()
@@ -1127,10 +1190,7 @@ bool userrec::ForceNickChange(const char* newnick)
 
                if (this->registered == REG_ALL)
                {
-                       const char* pars[1];
-                       pars[0] = newnick;
-                       std::string cmd = "NICK";
-                       return (ServerInstance->Parser->CallHandler(cmd, pars, 1, this) == CMD_SUCCESS);
+                       return (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
                }
                return false;
        }
@@ -1298,12 +1358,12 @@ const char* userrec::GetIPString(char* buf)
  */
 void userrec::Write(std::string text)
 {
-       if ((this->fd < 0) || (this->fd > MAX_DESCRIPTORS))
+       if (!ServerInstance->SE->BoundsCheckFd(this))
                return;
 
        try
        {
-               /* ServerInstance->Log(DEBUG,"<- %s", text.c_str());
+               /* ServerInstance->Log(DEBUG,"C[%d] <- %s", this->GetFd(), text.c_str());
                 * WARNING: The above debug line is VERY loud, do NOT
                 * enable it till we have a good way of filtering it
                 * out of the logs (e.g. 1.2 would be good).
@@ -1320,6 +1380,9 @@ void userrec::Write(std::string text)
        {
                try
                {
+                       /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
+                        * implement their own buffering mechanisms
+                        */
                        ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length());
                }
                catch (CoreException& modexcept)
@@ -1454,10 +1517,10 @@ void userrec::WriteCommon(const std::string &text)
                        CUList* ulist = v->first->GetUsers();
                        for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                        {
-                               if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+                               if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
                                {
-                                       already_sent[i->second->fd] = uniq_id;
-                                       i->second->Write(out);
+                                       already_sent[i->first->fd] = uniq_id;
+                                       i->first->Write(out);
                                        sent_to_at_least_one = true;
                                }
                        }
@@ -1515,12 +1578,12 @@ void userrec::WriteCommonQuit(const std::string &normal_text, const std::string
                CUList *ulist = v->first->GetUsers();
                for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                {
-                       if (this != i->second)
+                       if (this != i->first)
                        {
-                               if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+                               if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
                                {
-                                       already_sent[i->second->fd] = uniq_id;
-                                       i->second->Write(*i->second->oper ? out2 : out1);
+                                       already_sent[i->first->fd] = uniq_id;
+                                       i->first->Write(IS_OPER(i->first) ? out2 : out1);
                                }
                        }
                }
@@ -1544,12 +1607,12 @@ void userrec::WriteCommonExcept(const std::string &text)
                CUList *ulist = v->first->GetUsers();
                for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                {
-                       if (this != i->second)
+                       if (this != i->first)
                        {
-                               if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+                               if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
                                {
-                                       already_sent[i->second->fd] = uniq_id;
-                                       i->second->Write(out1);
+                                       already_sent[i->first->fd] = uniq_id;
+                                       i->first->Write(out1);
                                }
                        }
                }
@@ -1559,26 +1622,16 @@ void userrec::WriteCommonExcept(const std::string &text)
 
 void userrec::WriteWallOps(const std::string &text)
 {
-       /* Does nothing if theyre not opered */
-       if ((!*this->oper) && (IS_LOCAL(this)))
+       if (!IS_OPER(this) && IS_LOCAL(this))
                return;
 
-       std::string wallop = "WALLOPS :";
-
-       try
-       {
-               wallop.append(text);
-       }
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in userrec::Write() std::string::append");
-               return;
-       }
+       std::string wallop("WALLOPS :");
+       wallop.append(text);
 
        for (std::vector<userrec*>::const_iterator i = ServerInstance->local_users.begin(); i != ServerInstance->local_users.end(); i++)
        {
                userrec* t = *i;
-               if ((IS_LOCAL(t)) && (t->modes[UM_WALLOPS]))
+               if (t->IsModeSet('w'))
                        this->WriteTo(t,wallop);
        }
 }
@@ -1737,7 +1790,7 @@ std::string userrec::ChannelList(userrec* source)
                         * If the channel is NOT private/secret OR the user shares a common channel
                         * If the user is an oper, and the <options:operspywhois> option is set.
                         */
-                       if ((source == this) || (*source->oper && ServerInstance->Config->OperSpyWhois) || (((!i->first->modes[CM_PRIVATE]) && (!i->first->modes[CM_SECRET])) || (i->first->HasUser(source))))
+                       if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
                        {
                                list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
                        }
@@ -1806,8 +1859,18 @@ ConnectClass* userrec::GetClass()
 {
        for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
        {
-               if ((match(this->GetIPString(),i->GetHost().c_str(),true)) || (match(this->host,i->GetHost().c_str())))
-                       return &(*i);
+               if (((match(this->GetIPString(),i->GetHost().c_str(),true)) || (match(this->host,i->GetHost().c_str()))))
+               {
+                       if (i->GetPort())
+                       {
+                               if (this->GetPort() == i->GetPort())
+                                       return &(*i);
+                               else
+                                       continue;
+                       }
+                       else
+                               return &(*i);
+               }
        }
        return NULL;
 }
@@ -1869,15 +1932,16 @@ void userrec::ShowRULES()
 {
        if (!ServerInstance->Config->RULES.size())
        {
-               this->WriteServ("NOTICE %s :Rules file is missing.",this->nick);
+               this->WriteServ("434 %s :RULES File is missing",this->nick);
                return;
        }
-       this->WriteServ("NOTICE %s :%s rules",this->nick,ServerInstance->Config->ServerName);
+
+       this->WriteServ("308 %s :- %s Server Rules -",this->nick,ServerInstance->Config->ServerName);
 
        for (file_cache::iterator i = ServerInstance->Config->RULES.begin(); i != ServerInstance->Config->RULES.end(); i++)
-               this->WriteServ("NOTICE %s :%s",this->nick,i->c_str());
+               this->WriteServ("232 %s :- %s",this->nick,i->c_str());
 
-       this->WriteServ("NOTICE %s :End of %s rules.",this->nick,ServerInstance->Config->ServerName);
+       this->WriteServ("309 %s :End of RULES command.",this->nick);
 }
 
 void userrec::HandleEvent(EventType et, int errornum)
@@ -1929,4 +1993,16 @@ const char* userrec::GetOperQuit()
        return operquit ? operquit : "";
 }
 
+VisData::VisData()
+{
+}
+
+VisData::~VisData()
+{
+}
+
+bool VisData::VisibleTo(userrec* user)
+{
+       return true;
+}