]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/users.cpp
The issue from stable does not exist here, because we initialize userrec::quietquit...
[user/henk/code/inspircd.git] / src / users.cpp
index edcc54be56b7f9c5a2f7ae84f68a2c8834cb7100..f6ef92af336e40fcca24c991fecd0dfb40119275 100644 (file)
@@ -88,19 +88,19 @@ void User::StartDNSLookup()
        try
        {
                bool cached;
-               const char* ip = this->GetIPString();
+               const char* sip = this->GetIPString();
 
                /* Special case for 4in6 (Have i mentioned i HATE 4in6?) */
-               if (!strncmp(ip, "0::ffff:", 8))
-                       res_reverse = new UserResolver(this->ServerInstance, this, ip + 8, DNS_QUERY_PTR4, cached);
+               if (!strncmp(sip, "0::ffff:", 8))
+                       res_reverse = new UserResolver(this->ServerInstance, this, sip + 8, DNS_QUERY_PTR4, cached);
                else
-                       res_reverse = new UserResolver(this->ServerInstance, this, ip, this->GetProtocolFamily() == AF_INET ? DNS_QUERY_PTR4 : DNS_QUERY_PTR6, cached);
+                       res_reverse = new UserResolver(this->ServerInstance, this, sip, this->GetProtocolFamily() == AF_INET ? DNS_QUERY_PTR4 : DNS_QUERY_PTR6, cached);
 
                this->ServerInstance->AddResolver(res_reverse, cached);
        }
        catch (CoreException& e)
        {
-               ServerInstance->Log(DEBUG,"Error in resolver: %s",e.GetReason());
+               ServerInstance->Logs->Log("USERS", DEBUG,"Error in resolver: %s",e.GetReason());
        }
 }
 
@@ -156,16 +156,16 @@ const char* User::FormatModes()
 
 void User::DecrementModes()
 {
-       ServerInstance->Log(DEBUG,"DecrementModes()");
+       ServerInstance->Logs->Log("USERS", DEBUG, "DecrementModes()");
        for (unsigned char n = 'A'; n <= 'z'; n++)
        {
                if (modes[n-65])
                {
-                       ServerInstance->Log(DEBUG,"DecrementModes() found mode %c", n);
+                       ServerInstance->Logs->Log("USERS", DEBUG,"DecrementModes() found mode %c", n);
                        ModeHandler* mh = ServerInstance->Modes->FindMode(n, MODETYPE_USER);
                        if (mh)
                        {
-                               ServerInstance->Log(DEBUG,"Found handler %c and call ChangeCount", n);
+                               ServerInstance->Logs->Log("USERS", DEBUG,"Found handler %c and call ChangeCount", n);
                                mh->ChangeCount(-1);
                        }
                }
@@ -181,7 +181,7 @@ User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance
        Penalty = 0;
        lines_in = lastping = signon = idle_lastmsg = nping = registered = 0;
        ChannelCount = timeout = bytes_in = bytes_out = cmds_in = cmds_out = 0;
-       OverPenalty = ExemptFromPenalty = quitting = exempt = haspassed = dns_done = false;
+       quietquit = OverPenalty = ExemptFromPenalty = quitting = exempt = haspassed = dns_done = false;
        fd = -1;
        recvq.clear();
        sendq.clear();
@@ -203,7 +203,7 @@ User::User(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance
        else
                strlcpy(uuid, uid.c_str(), UUID_LENGTH);
 
-       ServerInstance->Log(DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
+       ServerInstance->Logs->Log("USERS", DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
 
        user_hash::iterator finduuid = Instance->Users->uuidlist->find(uuid);
        if (finduuid == Instance->Users->uuidlist->end())
@@ -218,7 +218,7 @@ User::~User()
        if (this->MyClass)
        {
                this->MyClass->RefCount--;
-               ServerInstance->Log(DEBUG, "User destructor -- connect refcount now: %u", this->MyClass->RefCount);
+               ServerInstance->Logs->Log("USERS", DEBUG, "User destructor -- connect refcount now: %u", this->MyClass->RefCount);
        }
        if (this->AllowedOperCommands)
        {
@@ -367,10 +367,20 @@ char* User::GetFullRealHost()
 
 bool User::IsInvited(const irc::string &channel)
 {
-       for (InvitedList::iterator i = invites.begin(); i != invites.end(); i++)
+       time_t now = time(NULL);
+       InvitedList::iterator safei;
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
        {
-               if (channel == *i)
+               if (channel == i->first)
                {
+                       if (i->second != 0 && now > i->second)
+                       {
+                               /* Expired invite, remove it. */
+                               safei = i;
+                               --i;
+                               invites.erase(safei);
+                               continue;
+                       }
                        return true;
                }
        }
@@ -379,19 +389,44 @@ bool User::IsInvited(const irc::string &channel)
 
 InvitedList* User::GetInviteList()
 {
+       time_t now = time(NULL);
+       /* Weed out expired invites here. */
+       InvitedList::iterator safei;
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
+       {
+               if (i->second != 0 && now > i->second)
+               {
+                       /* Expired invite, remove it. */
+                       safei = i;
+                       --i;
+                       invites.erase(safei);
+               }
+       }
        return &invites;
 }
 
-void User::InviteTo(const irc::string &channel)
+void User::InviteTo(const irc::string &channel, time_t invtimeout)
 {
-       invites.push_back(channel);
+       time_t now = time(NULL);
+       if (invtimeout != 0 && now > invtimeout) return; /* Don't add invites that are expired from the get-go. */
+       for (InvitedList::iterator i = invites.begin(); i != invites.end(); ++i)
+       {
+               if (channel == i->first)
+               {
+                       if (i->second != 0 && invtimeout > i->second)
+                       {
+                               i->second = invtimeout;
+                       }
+               }
+       }
+       invites.push_back(std::make_pair(channel, invtimeout));
 }
 
 void User::RemoveInvite(const irc::string &channel)
 {
        for (InvitedList::iterator i = invites.begin(); i != invites.end(); i++)
        {
-               if (channel == *i)
+               if (channel == i->first)
                {
                        invites.erase(i);
                        return;
@@ -461,7 +496,7 @@ bool User::AddBuffer(std::string a)
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::AddBuffer()");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::AddBuffer()");
                return false;
        }
 }
@@ -511,7 +546,7 @@ std::string User::GetBuffer()
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::GetBuffer()");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::GetBuffer()");
                return "";
        }
 }
@@ -533,18 +568,10 @@ void User::AddWriteBuf(const std::string &data)
                return;
        }
 
-       try
-       {
-               if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
-                       sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
-               else
-                       sendq.append(data);
-       }
-       catch (...)
-       {
-               this->SetWriteError("SendQ exceeded");
-               ServerInstance->SNO->WriteToSnoMask('A', "User %s SendQ got an exception",this->nick);
-       }
+       if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
+               sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
+       else
+               sendq.append(data);
 }
 
 // send AS MUCH OF THE USERS SENDQ as we are able to (might not be all of it)
@@ -594,7 +621,7 @@ void User::FlushWriteBuf()
 
        catch (...)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::FlushWriteBuf()");
+               ServerInstance->Logs->Log("USERS", DEBUG,"Exception in User::FlushWriteBuf()");
        }
 
        if (this->sendq.empty())
@@ -605,17 +632,9 @@ void User::FlushWriteBuf()
 
 void User::SetWriteError(const std::string &error)
 {
-       try
-       {
-               // don't try to set the error twice, its already set take the first string.
-               if (this->WriteError.empty())
-                       this->WriteError = error;
-       }
-
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::SetWriteError()");
-       }
+       // don't try to set the error twice, its already set take the first string.
+       if (this->WriteError.empty())
+               this->WriteError = error;
 }
 
 const char* User::GetWriteError()
@@ -634,7 +653,7 @@ void User::Oper(const std::string &opertype, const std::string &opername)
                this->modes[UM_OPERATOR] = 1;
                this->WriteServ("MODE %s :+o", this->nick);
                FOREACH_MOD(I_OnOper, OnOper(this, opertype));
-               ServerInstance->Log(DEFAULT,"OPER: %s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
+               ServerInstance->Logs->Log("OPER", DEFAULT, "%s!%s@%s opered as type: %s", this->nick, this->ident, this->host, opertype.c_str());
                strlcpy(this->oper, opertype.c_str(), NICKMAX - 1);
                ServerInstance->Users->all_opers.push_back(this);
 
@@ -679,38 +698,35 @@ void User::Oper(const std::string &opertype, const std::string &opername)
 
 void User::UnOper()
 {
-       try
+       if (IS_OPER(this))
        {
-               if (IS_OPER(this))
-               {
-                       // unset their oper type (what IS_OPER checks), and remove +o
-                       *this->oper = 0;
-                       this->modes[UM_OPERATOR] = 0;
+               // unset their oper type (what IS_OPER checks), and remove +o
+               *this->oper = 0;
+               this->modes[UM_OPERATOR] = 0;
                        
-                       // remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404
-                       ServerInstance->Users->all_opers.remove(this);
+               // remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404
+               ServerInstance->Users->all_opers.remove(this);
 
-                       if (AllowedOperCommands)
-                       {
-                               delete AllowedOperCommands;
-                               AllowedOperCommands = NULL;
-                       }
+               if (AllowedOperCommands)
+               {
+                       delete AllowedOperCommands;
+                       AllowedOperCommands = NULL;
                }
        }
-
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::UnOper()");
-       }
 }
 
 void User::QuitUser(InspIRCd* Instance, User *user, const std::string &quitreason, const char* operreason)
 {
-       Instance->Log(DEBUG,"QuitUser: %s '%s'", user->nick, quitreason.c_str());
+       Instance->Logs->Log("USERS", DEBUG,"QuitUser: %s '%s'", user->nick, quitreason.c_str());
        user->Write("ERROR :Closing link (%s@%s) [%s]", user->ident, user->host, *operreason ? operreason : quitreason.c_str());
        user->quietquit = false;
        user->quitmsg = quitreason;
-       user->operquitmsg = operreason;
+
+       if (!*operreason)
+               user->operquitmsg = quitreason;
+       else
+               user->operquitmsg = operreason;
+
        Instance->GlobalCulls.AddItem(user);
 }
 
@@ -831,8 +847,7 @@ void User::FullConnect()
        FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
 
        ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString(), this->fullname);
-
-       ServerInstance->Log(DEBUG, "BanCache: Adding NEGATIVE hit for %s", this->GetIPString());
+       ServerInstance->Logs->Log("BANCACHE", DEBUG, "BanCache: Adding NEGATIVE hit for %s", this->GetIPString());
        ServerInstance->BanCache->AddHit(this->GetIPString(), "", "");
 }
 
@@ -842,28 +857,19 @@ void User::FullConnect()
  */
 User* User::UpdateNickHash(const char* New)
 {
-       try
-       {
-               //user_hash::iterator newnick;
-               user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
-
-               if (!strcasecmp(this->nick,New))
-                       return oldnick->second;
+       //user_hash::iterator newnick;
+       user_hash::iterator oldnick = ServerInstance->Users->clientlist->find(this->nick);
 
-               if (oldnick == ServerInstance->Users->clientlist->end())
-                       return NULL; /* doesnt exist */
+       if (!strcasecmp(this->nick,New))
+               return oldnick->second;
 
-               User* olduser = oldnick->second;
-               (*(ServerInstance->Users->clientlist))[New] = olduser;
-               ServerInstance->Users->clientlist->erase(oldnick);
-               return olduser;
-       }
+       if (oldnick == ServerInstance->Users->clientlist->end())
+               return NULL; /* doesnt exist */
 
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::UpdateNickHash()");
-               return NULL;
-       }
+       User* olduser = oldnick->second;
+       (*(ServerInstance->Users->clientlist))[New] = olduser;
+       ServerInstance->Users->clientlist->erase(oldnick);
+       return olduser;
 }
 
 void User::InvalidateCache()
@@ -882,57 +888,50 @@ void User::InvalidateCache()
 
 bool User::ForceNickChange(const char* newnick)
 {
-       try
+       /*
+        * XXX this makes no sense..
+        * why do we do nothing for change on users not REG_ALL?
+        * why do we trigger events twice for everyone previously (and just them now)
+        * i think the first if () needs removing totally, or? -- w00t
+        */
+       if (this->registered != REG_ALL)
        {
-               /*
-                * XXX this makes no sense..
-                * why do we do nothing for change on users not REG_ALL?
-                * why do we trigger events twice for everyone previously (and just them now)
-                * i think the first if () needs removing totally, or? -- w00t
-                */
-               if (this->registered != REG_ALL)
-               {
-                       int MOD_RESULT = 0;
+               int MOD_RESULT = 0;
 
-                       this->InvalidateCache();
+               this->InvalidateCache();
 
-                       FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(this, newnick));
+               FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(this, newnick));
 
-                       if (MOD_RESULT)
-                       {
-                               ServerInstance->stats->statsCollisions++;
-                               return false;
-                       }
-
-                       if (ServerInstance->XLines->MatchesLine("Q",newnick))
-                       {
-                               ServerInstance->stats->statsCollisions++;
-                               return false;
-                       }
+               if (MOD_RESULT)
+               {
+                       ServerInstance->stats->statsCollisions++;
+                       return false;
                }
-               else
+
+               if (ServerInstance->XLines->MatchesLine("Q",newnick))
                {
-                       std::deque<classbase*> dummy;
-                       Command* nickhandler = ServerInstance->Parser->GetHandler("NICK");
-                       if (nickhandler)
-                       {
-                               nickhandler->HandleInternal(1, dummy);
-                               bool result = (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
-                               nickhandler->HandleInternal(0, dummy);
-                               return result;
-                       }
+                       ServerInstance->stats->statsCollisions++;
+                       return false;
                }
-               return false;
        }
-
-       catch (...)
+       else
        {
-               ServerInstance->Log(DEBUG,"Exception in User::ForceNickChange()");
-               return false;
+               std::deque<classbase*> dummy;
+               Command* nickhandler = ServerInstance->Parser->GetHandler("NICK");
+               if (nickhandler) // wtfbbq, when would this not be here
+               {
+                       nickhandler->HandleInternal(1, dummy);
+                       bool result = (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
+                       nickhandler->HandleInternal(0, dummy);
+                       return result;
+               }
        }
+
+       // Unreachable.
+       return false;
 }
 
-void User::SetSockAddr(int protocol_family, const char* ip, int port)
+void User::SetSockAddr(int protocol_family, const char* sip, int port)
 {
        this->cachedip = "";
 
@@ -944,7 +943,7 @@ void User::SetSockAddr(int protocol_family, const char* ip, int port)
                        sockaddr_in6* sin = new sockaddr_in6;
                        sin->sin6_family = AF_INET6;
                        sin->sin6_port = port;
-                       inet_pton(AF_INET6, ip, &sin->sin6_addr);
+                       inet_pton(AF_INET6, sip, &sin->sin6_addr);
                        this->ip = (sockaddr*)sin;
                }
                break;
@@ -954,7 +953,7 @@ void User::SetSockAddr(int protocol_family, const char* ip, int port)
                        sockaddr_in* sin = new sockaddr_in;
                        sin->sin_family = AF_INET;
                        sin->sin_port = port;
-                       inet_pton(AF_INET, ip, &sin->sin_addr);
+                       inet_pton(AF_INET, sip, &sin->sin_addr);
                        this->ip = (sockaddr*)sin;
                }
                break;
@@ -1066,11 +1065,7 @@ void User::Write(std::string text)
 
        try
        {
-               /* ServerInstance->Log(DEBUG,"C[%d] O %s", this->GetFd(), text.c_str());
-                * WARNING: The above debug line is VERY loud, do NOT
-                * enable it till we have a good way of filtering it
-                * out of the logs (e.g. 1.2 would be good).
-                */
+               ServerInstance->Logs->Log("USEROUTPUT", DEBUG,"C[%d] O %s", this->GetFd(), text.c_str());
                text.append("\r\n");
        }
        catch (...)
@@ -1081,11 +1076,11 @@ void User::Write(std::string text)
 
        if (ServerInstance->Config->GetIOHook(this->GetPort()))
        {
+               /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
+                * implement their own buffering mechanisms
+                */
                try
                {
-                       /* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
-                        * implement their own buffering mechanisms
-                        */
                        ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length());
                }
                catch (CoreException& modexcept)
@@ -1201,47 +1196,39 @@ void User::WriteCommon(const char* text, ...)
 
 void User::WriteCommon(const std::string &text)
 {
-       try
-       {
-               bool sent_to_at_least_one = false;
-               char tb[MAXBUF];
+       bool sent_to_at_least_one = false;
+       char tb[MAXBUF];
 
-               if (this->registered != REG_ALL)
-                       return;
+       if (this->registered != REG_ALL)
+               return;
 
-               uniq_id++;
+       uniq_id++;
 
-               /* We dont want to be doing this n times, just once */
-               snprintf(tb,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
-               std::string out = tb;
+       /* We dont want to be doing this n times, just once */
+       snprintf(tb,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
+       std::string out = tb;
 
-               for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
+       for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
+       {
+               CUList* ulist = v->first->GetUsers();
+               for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                {
-                       CUList* ulist = v->first->GetUsers();
-                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
                        {
-                               if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
-                               {
-                                       already_sent[i->first->fd] = uniq_id;
-                                       i->first->Write(out);
-                                       sent_to_at_least_one = true;
-                               }
+                               already_sent[i->first->fd] = uniq_id;
+                               i->first->Write(out);
+                               sent_to_at_least_one = true;
                        }
                }
-
-               /*
-                * if the user was not in any channels, no users will receive the text. Make sure the user
-                * receives their OWN message for WriteCommon
-                */
-               if (!sent_to_at_least_one)
-               {
-                       this->Write(std::string(tb));
-               }
        }
 
-       catch (...)
+       /*
+        * if the user was not in any channels, no users will receive the text. Make sure the user
+        * receives their OWN message for WriteCommon
+        */
+       if (!sent_to_at_least_one)
        {
-               ServerInstance->Log(DEBUG,"Exception in User::WriteCommon()");
+               this->Write(std::string(tb));
        }
 }
 
@@ -1398,24 +1385,25 @@ bool User::ChangeName(const char* gecos)
        return true;
 }
 
-bool User::ChangeDisplayedHost(const char* host)
+bool User::ChangeDisplayedHost(const char* shost)
 {
-       if (!strcmp(host, this->dhost))
+       if (!strcmp(shost, this->dhost))
                return true;
 
        if (IS_LOCAL(this))
        {
                int MOD_RESULT = 0;
-               FOREACH_RESULT(I_OnChangeLocalUserHost,OnChangeLocalUserHost(this,host));
+               FOREACH_RESULT(I_OnChangeLocalUserHost,OnChangeLocalUserHost(this,shost));
                if (MOD_RESULT)
                        return false;
-               FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,host));
+               FOREACH_MOD(I_OnChangeHost,OnChangeHost(this,shost));
        }
+
        if (this->ServerInstance->Config->CycleHosts)
                this->WriteCommonExcept("QUIT :Changing hosts");
 
        /* Fix by Om: User::dhost is 65 long, this was truncating some long hosts */
-       strlcpy(this->dhost,host,64);
+       strlcpy(this->dhost,shost,64);
 
        this->InvalidateCache();
 
@@ -1444,7 +1432,7 @@ bool User::ChangeIdent(const char* newident)
        if (this->ServerInstance->Config->CycleHosts)
                this->WriteCommonExcept("%s","QUIT :Changing ident");
 
-       strlcpy(this->ident, newident, IDENTMAX+2);
+       strlcpy(this->ident, newident, IDENTMAX+1);
 
        this->InvalidateCache();
 
@@ -1462,7 +1450,7 @@ bool User::ChangeIdent(const char* newident)
        return true;
 }
 
-void User::SendAll(const char* command, char* text, ...)
+void User::SendAll(const char* command, const char* text, ...)
 {
        char textbuffer[MAXBUF];
        char formatbuffer[MAXBUF];
@@ -1484,27 +1472,21 @@ void User::SendAll(const char* command, char* text, ...)
 
 std::string User::ChannelList(User* source)
 {
-       try
+       std::string list;
+
+       for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
        {
-               std::string list;
-               for (UCListIter i = this->chans.begin(); i != this->chans.end(); i++)
+               /* If the target is the same as the sender, let them see all their channels.
+                * If the channel is NOT private/secret OR the user shares a common channel
+                * If the user is an oper, and the <options:operspywhois> option is set.
+                */
+               if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
                {
-                       /* If the target is the same as the sender, let them see all their channels.
-                        * If the channel is NOT private/secret OR the user shares a common channel
-                        * If the user is an oper, and the <options:operspywhois> option is set.
-                        */
-                       if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
-                       {
-                               list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
-                       }
+                       list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
                }
-               return list;
-       }
-       catch (...)
-       {
-               ServerInstance->Log(DEBUG,"Exception in User::ChannelList()");
-               return "";
        }
+
+       return list;
 }
 
 void User::SplitChanList(User* dest, const std::string &cl)
@@ -1513,42 +1495,34 @@ void User::SplitChanList(User* dest, const std::string &cl)
        std::ostringstream prefix;
        std::string::size_type start, pos, length;
 
-       try
+       prefix << this->nick << " " << dest->nick << " :";
+       line = prefix.str();
+       int namelen = strlen(ServerInstance->Config->ServerName) + 6;
+
+       for (start = 0; (pos = cl.find(' ', start)) != std::string::npos; start = pos+1)
        {
-               prefix << this->nick << " " << dest->nick << " :";
-               line = prefix.str();
-               int namelen = strlen(ServerInstance->Config->ServerName) + 6;
+               length = (pos == std::string::npos) ? cl.length() : pos;
 
-               for (start = 0; (pos = cl.find(' ', start)) != std::string::npos; start = pos+1)
+               if (line.length() + namelen + length - start > 510)
                {
-                       length = (pos == std::string::npos) ? cl.length() : pos;
-
-                       if (line.length() + namelen + length - start > 510)
-                       {
-                               ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
-                               line = prefix.str();
-                       }
-
-                       if(pos == std::string::npos)
-                       {
-                               line.append(cl.substr(start, length - start));
-                               break;
-                       }
-                       else
-                       {
-                               line.append(cl.substr(start, length - start + 1));
-                       }
+                       ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
+                       line = prefix.str();
                }
 
-               if (line.length())
+               if(pos == std::string::npos)
                {
-                       ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
+                       line.append(cl.substr(start, length - start));
+                       break;
+               }
+               else
+               {
+                       line.append(cl.substr(start, length - start + 1));
                }
        }
 
-       catch (...)
+       if (line.length())
        {
-               ServerInstance->Log(DEBUG,"Exception in User::SplitChanList()");
+               ServerInstance->SendWhoisLine(this, dest, 319, "%s", line.c_str());
        }
 }