Debug to try figure this out ..

[user/henk/code/inspircd.git] / src / xline.cpp

diff --git a/src/xline.cpp b/src/xline.cpp
index 1996925de12b4f84065d8a56674e081157d4ce4a..a28e61766f40b85182c5e239b83ee524a4fd6d4a 100644 (file)
--- a/src/xline.cpp
+++ b/src/xline.cpp
@@ -12,8 +12,6 @@
  */
 
 #include "inspircd.h"
-#include "users.h"
-#include "modules.h"
 #include "wildcard.h"
 #include "xline.h"
 
@@ -109,9 +107,9 @@ IdentHostPair XLineManager::IdentSplit(const std::string &ident_and_host)
                n.second = ident_and_host.substr(x + 1,ident_and_host.length());
                n.first = ident_and_host.substr(0, x);
                if (!n.first.length())
-                       n.first = "*";
+                       n.first.assign("*");
                if (!n.second.length())
-                       n.second = "*";
+                       n.second.assign("*");
        }
        else
        {
@@ -127,7 +125,8 @@ bool XLineManager::add_gline(long duration, const char* source,const char* reaso
 {
        IdentHostPair ih = IdentSplit(hostmask);
 
-       bool ret = del_gline(hostmask);
+       if (del_gline(hostmask, true))
+               return false;
 
        GLine* item = new GLine(ServerInstance->Time(), duration, source, reason, ih.first.c_str(), ih.second.c_str());
 
@@ -141,7 +140,7 @@ bool XLineManager::add_gline(long duration, const char* source,const char* reaso
                pglines.push_back(item);
        }
 
-       return !ret;
+       return true;
 }
 
 // adds an e:line (exception to bans)
@@ -150,7 +149,8 @@ bool XLineManager::add_eline(long duration, const char* source, const char* reas
 {
        IdentHostPair ih = IdentSplit(hostmask);
 
-       bool ret = del_eline(hostmask);
+       if (del_eline(hostmask, true))
+               return false;
 
        ELine* item = new ELine(ServerInstance->Time(), duration, source, reason, ih.first.c_str(), ih.second.c_str());
 
@@ -163,14 +163,16 @@ bool XLineManager::add_eline(long duration, const char* source, const char* reas
        {
                pelines.push_back(item);
        }
-       return !ret;
+       return true;
 }
 
 // adds a q:line
 
 bool XLineManager::add_qline(long duration, const char* source, const char* reason, const char* nickname)
 {
-       bool ret = del_qline(nickname);
+       if (del_qline(nickname, true))
+               return false;
+
        QLine* item = new QLine(ServerInstance->Time(), duration, source, reason, nickname);
 
        if (duration)
@@ -182,15 +184,13 @@ bool XLineManager::add_qline(long duration, const char* source, const char* reas
        {
                pqlines.push_back(item);
        }
-       return !ret;
+       return true;
 }
 
 // adds a z:line
 
 bool XLineManager::add_zline(long duration, const char* source, const char* reason, const char* ipaddr)
 {
-       bool ret = del_zline(ipaddr);
-
        if (strchr(ipaddr,'@'))
        {
                while (*ipaddr != '@')
@@ -198,6 +198,9 @@ bool XLineManager::add_zline(long duration, const char* source, const char* reas
                ipaddr++;
        }
 
+       if (del_zline(ipaddr, true))
+               return false;
+
        ZLine* item = new ZLine(ServerInstance->Time(), duration, source, reason, ipaddr);
 
        if (duration)
@@ -209,7 +212,7 @@ bool XLineManager::add_zline(long duration, const char* source, const char* reas
        {
                pzlines.push_back(item);
        }
-       return !ret;
+       return true;
 }
 
 // adds a k:line
@@ -218,7 +221,8 @@ bool XLineManager::add_kline(long duration, const char* source, const char* reas
 {
        IdentHostPair ih = IdentSplit(hostmask);
 
-       bool ret = del_kline(hostmask);
+       if (del_kline(hostmask, true))
+               return false;
 
        KLine* item = new KLine(ServerInstance->Time(), duration, source, reason, ih.first.c_str(), ih.second.c_str());
 
@@ -231,20 +235,23 @@ bool XLineManager::add_kline(long duration, const char* source, const char* reas
        {
                pklines.push_back(item);
        }
-       return !ret;
+       return true;
 }
 
 // deletes a g:line, returns true if the line existed and was removed
 
-bool XLineManager::del_gline(const char* hostmask)
+bool XLineManager::del_gline(const char* hostmask, bool simulate)
 {
        IdentHostPair ih = IdentSplit(hostmask);
        for (std::vector<GLine*>::iterator i = glines.begin(); i != glines.end(); i++)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       glines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               glines.erase(i);
+                       }
                        return true;
                }
        }
@@ -252,8 +259,11 @@ bool XLineManager::del_gline(const char* hostmask)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       pglines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               pglines.erase(i);
+                       }
                        return true;
                }
        }
@@ -262,15 +272,18 @@ bool XLineManager::del_gline(const char* hostmask)
 
 // deletes a e:line, returns true if the line existed and was removed
 
-bool XLineManager::del_eline(const char* hostmask)
+bool XLineManager::del_eline(const char* hostmask, bool simulate)
 {
        IdentHostPair ih = IdentSplit(hostmask);
        for (std::vector<ELine*>::iterator i = elines.begin(); i != elines.end(); i++)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       elines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               elines.erase(i);
+                       }
                        return true;
                }
        }
@@ -278,8 +291,11 @@ bool XLineManager::del_eline(const char* hostmask)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       pelines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               pelines.erase(i);
+                       }
                        return true;
                }
        }
@@ -288,14 +304,17 @@ bool XLineManager::del_eline(const char* hostmask)
 
 // deletes a q:line, returns true if the line existed and was removed
 
-bool XLineManager::del_qline(const char* nickname)
+bool XLineManager::del_qline(const char* nickname, bool simulate)
 {
        for (std::vector<QLine*>::iterator i = qlines.begin(); i != qlines.end(); i++)
        {
                if (!strcasecmp(nickname,(*i)->nick))
                {
-                       delete *i;
-                       qlines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               qlines.erase(i);
+                       }
                        return true;
                }
        }
@@ -303,8 +322,11 @@ bool XLineManager::del_qline(const char* nickname)
        {
                if (!strcasecmp(nickname,(*i)->nick))
                {
-                       delete *i;
-                       pqlines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               pqlines.erase(i);
+                       }
                        return true;
                }
        }
@@ -313,14 +335,17 @@ bool XLineManager::del_qline(const char* nickname)
 
 // deletes a z:line, returns true if the line existed and was removed
 
-bool XLineManager::del_zline(const char* ipaddr)
+bool XLineManager::del_zline(const char* ipaddr, bool simulate)
 {
        for (std::vector<ZLine*>::iterator i = zlines.begin(); i != zlines.end(); i++)
        {
                if (!strcasecmp(ipaddr,(*i)->ipaddr))
                {
-                       delete *i;
-                       zlines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               zlines.erase(i);
+                       }
                        return true;
                }
        }
@@ -328,8 +353,11 @@ bool XLineManager::del_zline(const char* ipaddr)
        {
                if (!strcasecmp(ipaddr,(*i)->ipaddr))
                {
-                       delete *i;
-                       pzlines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               pzlines.erase(i);
+                       }
                        return true;
                }
        }
@@ -338,15 +366,18 @@ bool XLineManager::del_zline(const char* ipaddr)
 
 // deletes a k:line, returns true if the line existed and was removed
 
-bool XLineManager::del_kline(const char* hostmask)
+bool XLineManager::del_kline(const char* hostmask, bool simulate)
 {
        IdentHostPair ih = IdentSplit(hostmask);
        for (std::vector<KLine*>::iterator i = klines.begin(); i != klines.end(); i++)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       klines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               klines.erase(i);
+                       }
                        return true;
                }
        }
@@ -354,8 +385,11 @@ bool XLineManager::del_kline(const char* hostmask)
        {
                if (!strcasecmp(ih.first.c_str(),(*i)->identmask) && !strcasecmp(ih.second.c_str(),(*i)->hostmask))
                {
-                       delete *i;
-                       pklines.erase(i);
+                       if (!simulate)
+                       {
+                               delete *i;
+                               pklines.erase(i);
+                       }
                        return true;
                }
        }
@@ -684,7 +718,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_gline(u,true)))
                                {
                                        snprintf(reason,MAXBUF,"G-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "G-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
 
@@ -693,7 +732,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_kline(u,true)))
                                {
                                        snprintf(reason,MAXBUF,"K-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "K-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
 
@@ -702,7 +746,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_qline(u->nick,true)))
                                {
                                        snprintf(reason,MAXBUF,"Q-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "Q-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
 
@@ -711,7 +760,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_zline(u->GetIPString(),true)))
                                {
                                        snprintf(reason,MAXBUF,"Z-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "Z-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
                }
@@ -740,7 +794,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_gline(u)))
                                {
                                        snprintf(reason,MAXBUF,"G-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "G-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
                        if ((What & APPLY_KLINES) && (klines.size() || pklines.size()))
@@ -748,7 +807,12 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_kline(u)))
                                {
                                        snprintf(reason,MAXBUF,"K-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "K-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
                        if ((What & APPLY_QLINES) && (qlines.size() || pqlines.size()))
@@ -756,15 +820,25 @@ void XLineManager::apply_lines(const int What)
                                if ((check = matches_qline(u->nick)))
                                {
                                        snprintf(reason,MAXBUF,"Q-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "Q-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
                        if ((What & APPLY_ZLINES) && (zlines.size() || pzlines.size()))
                        {
                                if ((check = matches_zline(u->GetIPString())))
                                {
-                                       snprintf(reason,MAXBUF,"Z-Lined: %s",check->reason);
-                                       ServerInstance->GlobalCulls.AddItem(u,reason);
+                                       snprintf(reason,MAXBUF,"Z-Lined: %s", check->reason);
+                                       if (*ServerInstance->Config->MoronBanner)
+                                               u->WriteServ("NOTICE %s :*** %s", u->nick, ServerInstance->Config->MoronBanner);
+                                       if (ServerInstance->Config->HideBans)
+                                               userrec::QuitUser(ServerInstance, u, "Z-Lined", reason);
+                                       else
+                                               userrec::QuitUser(ServerInstance, u, reason);
                                }
                        }
                }