X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;ds=sidebyside;f=src%2Fusers.cpp;h=31244f98706b5bf28344a44c762a3f36c04a7ca2;hb=f087d825a88760d251b8f80b5d50bc98b40fa2ae;hp=c3e52c80d09c6cdc5b2b3f07d3764e5a40154b7b;hpb=0234afda2c9899eb8f378b6710ce12c28c546c9c;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/users.cpp b/src/users.cpp
index c3e52c80d..31244f987 100644
--- a/src/users.cpp
+++ b/src/users.cpp
@@ -11,9 +11,6 @@
  * ---------------------------------------------------
  */
 
-#include "configreader.h"
-#include "channels.h"
-#include "users.h"
 #include "inspircd.h"
 #include <stdarg.h>
 #include "socketengine.h"
@@ -61,7 +58,7 @@ bool DoType(ServerConfig* conf, const char* tag, char** entries, ValueList &valu
 	const char* TypeName = values[0].GetString();
 	const char* Classes = values[1].GetString();
 
-	conf->opertypes[TypeName] = strdup(Classes);
+	conf->opertypes[TypeName] = strnewdup(Classes);
 	return true;
 }
 
@@ -70,7 +67,7 @@ bool DoClass(ServerConfig* conf, const char* tag, char** entries, ValueList &val
 	const char* ClassName = values[0].GetString();
 	const char* CommandList = values[1].GetString();
 
-	conf->operclass[ClassName] = strdup(CommandList);
+	conf->operclass[ClassName] = strnewdup(CommandList);
 	return true;
 }
 
@@ -141,7 +138,14 @@ void userrec::StartDNSLookup()
 	try
 	{
 		bool cached;
-		res_reverse = new UserResolver(this->ServerInstance, this, this->GetIPString(), DNS_QUERY_REVERSE, cached);
+		const char* ip = this->GetIPString();
+
+		/* Special case for 4in6 (Have i mentioned i HATE 4in6?) */
+		if (!strncmp(ip, "0::ffff:", 8))
+			res_reverse = new UserResolver(this->ServerInstance, this, ip + 8, DNS_QUERY_PTR4, cached);
+		else
+			res_reverse = new UserResolver(this->ServerInstance, this, ip, this->GetProtocolFamily() == AF_INET ? DNS_QUERY_PTR4 : DNS_QUERY_PTR6, cached);
+
 		this->ServerInstance->AddResolver(res_reverse, cached);
 	}
 	catch (CoreException& e)
@@ -157,8 +161,12 @@ UserResolver::UserResolver(InspIRCd* Instance, userrec* user, std::string to_res
 	this->bound_fd = user->GetFd();
 }
 
-void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl, bool cached)
+void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl, bool cached, int resultnum)
 {
+	/* We are only interested in the first matching result */
+	if (resultnum)
+		return;
+
 	if ((!this->fwd) && (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user))
 	{
 		this->bound_user->stored_host = result;
@@ -169,11 +177,17 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
 			{
 				bool cached;
 #ifdef IPV6
-				const char *ip = this->bound_user->GetIPString();
-				bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, (strstr(ip,"0::ffff:") == ip ? DNS_QUERY_A : DNS_QUERY_AAAA), cached);
-#else
-				bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, DNS_QUERY_A, cached);
+				if (this->bound_user->GetProtocolFamily() == AF_INET6)
+				{
+					/* IPV6 forward lookup (with possibility of 4in6) */
+					const char* ip = this->bound_user->GetIPString();
+					bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, (!strncmp(ip, "0::ffff:", 8) ? DNS_QUERY_A : DNS_QUERY_AAAA), cached);
+				}
+				else
+					/* IPV4 lookup (mixed protocol mode) */
 #endif
+				/* IPV4 lookup (ipv4 only mode) */
+				bound_user->res_forward = new UserResolver(this->ServerInstance, this->bound_user, result, DNS_QUERY_A, cached);
 				this->ServerInstance->AddResolver(bound_user->res_forward, cached);
 			}
 		}
@@ -185,7 +199,7 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
 	else if ((this->fwd) && (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user))
 	{
 		/* Both lookups completed */
-		std::string result2 = "0::ffff:";
+		std::string result2("0::ffff:");
 		result2.append(result);
 		if (this->bound_user->GetIPString() == result || this->bound_user->GetIPString() == result2)
 		{
@@ -193,11 +207,11 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
 			if (hostname.length() < 65)
 			{
 				/* Check we didnt time out */
-				if (this->bound_user->registered != REG_ALL)
+				if ((this->bound_user->registered != REG_ALL) && (!this->bound_user->dns_done))
 				{
 					/* Hostnames starting with : are not a good thing (tm) */
 					if (*(hostname.c_str()) == ':')
-						hostname = "0" + hostname;
+						hostname.insert(0, "0");
 
 					this->bound_user->WriteServ("NOTICE Auth :*** Found your hostname (%s)%s", hostname.c_str(), (cached ? " -- cached" : ""));
 					this->bound_user->dns_done = true;
@@ -209,12 +223,20 @@ void UserResolver::OnLookupComplete(const std::string &result, unsigned int ttl,
 			}
 			else
 			{
-				this->bound_user->WriteServ("NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
+				if (!this->bound_user->dns_done)
+				{
+					this->bound_user->WriteServ("NOTICE Auth :*** Your hostname is longer than the maximum of 64 characters, using your IP address (%s) instead.", this->bound_user->GetIPString());
+					this->bound_user->dns_done = true;
+				}
 			}
 		}
 		else
 		{
-			this->bound_user->WriteServ("NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
+			if (!this->bound_user->dns_done)
+			{
+				this->bound_user->WriteServ("NOTICE Auth :*** Your hostname does not match up with your IP address. Sorry, using your IP address (%s) instead.", this->bound_user->GetIPString());
+				this->bound_user->dns_done = true;
+			}
 		}
 	}
 }
@@ -223,9 +245,14 @@ void UserResolver::OnError(ResolverError e, const std::string &errormessage)
 {
 	if (ServerInstance->SE->GetRef(this->bound_fd) == this->bound_user)
 	{
-		/* Error message here */
-		this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname: %s; using your IP address (%s) instead.", errormessage.c_str(), this->bound_user->GetIPString());
-		this->bound_user->dns_done = true;
+		/* Since dns timeout is implemented outside of the resolver, this was a race condition that could result in this message being sent *after*
+		 * the user was fully connected. This check fixes that issue  - Special */
+		if (!this->bound_user->dns_done)
+		{
+			/* Error message here */
+			this->bound_user->WriteServ("NOTICE Auth :*** Could not resolve your hostname: %s; using your IP address (%s) instead.", errormessage.c_str(), this->bound_user->GetIPString());
+			this->bound_user->dns_done = true;
+		}
 	}
 }
 
@@ -282,66 +309,91 @@ const char* userrec::FormatModes()
 
 void userrec::DecrementModes()
 {
-	for (int n = 0; n < 64; n++)
+	ServerInstance->Log(DEBUG,"DecrementModes()");
+	for (unsigned char n = 'A'; n <= 'z'; n++)
 	{
-		if (modes[n])
+		if (modes[n-65])
 		{
-			ModeHandler* mh = ServerInstance->Modes->FindMode(n+65, MODETYPE_USER);
+			ServerInstance->Log(DEBUG,"DecrementModes() found mode %c", n);
+			ModeHandler* mh = ServerInstance->Modes->FindMode(n, MODETYPE_USER);
 			if (mh)
+			{
+				ServerInstance->Log(DEBUG,"Found handler %c and call ChangeCount", n);
 				mh->ChangeCount(-1);
+			}
 		}
 	}
 }
 
-userrec::userrec(InspIRCd* Instance) : ServerInstance(Instance)
+userrec::userrec(InspIRCd* Instance, const std::string &uid) : ServerInstance(Instance)
 {
-	// the PROPER way to do it, AVOID bzero at *ALL* costs
-	*password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = 0;
+	*password = *nick = *ident = *host = *dhost = *fullname = *awaymsg = *oper = *uuid = 0;
 	server = (char*)Instance->FindServerNamePtr(Instance->Config->ServerName);
 	reset_due = ServerInstance->Time();
 	age = ServerInstance->Time(true);
 	lines_in = lastping = signon = idle_lastmsg = nping = registered = 0;
 	ChannelCount = timeout = flood = bytes_in = bytes_out = cmds_in = cmds_out = 0;
-	exempt = haspassed = dns_done = false;
+	muted = exempt = haspassed = dns_done = false;
 	fd = -1;
-	recvq = "";
-	sendq = "";
-	WriteError = "";
+	recvq.clear();
+	sendq.clear();
+	WriteError.clear();
 	res_forward = res_reverse = NULL;
+	Visibility = NULL;
 	ip = NULL;
 	chans.clear();
 	invites.clear();
 	memset(modes,0,sizeof(modes));
 	memset(snomasks,0,sizeof(snomasks));
 	/* Invalidate cache */
-	cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
+	operquit = cached_fullhost = cached_hostip = cached_makehost = cached_fullrealhost = NULL;
+
+	if (uid.empty())
+		strlcpy(uuid, Instance->GetUID().c_str(), UUID_LENGTH);
+	else
+		strlcpy(uuid, uid.c_str(), UUID_LENGTH);
+
+	ServerInstance->Log(DEBUG,"New UUID for user: %s (%s)", uuid, uid.empty() ? "allocated new" : "used remote");
+
+	user_hash::iterator finduuid = Instance->uuidlist->find(uuid);
+	if (finduuid == Instance->uuidlist->end())
+		(*Instance->uuidlist)[uuid] = this;
+	else
+		throw CoreException("Duplicate UUID "+std::string(uuid)+" in userrec constructor");
 }
 
-userrec::~userrec()
+void userrec::RemoveCloneCounts()
 {
-	this->InvalidateCache();
-	this->DecrementModes();
-	if (ip)
+	clonemap::iterator x = ServerInstance->local_clones.find(this->GetIPString());
+	if (x != ServerInstance->local_clones.end())
 	{
-		clonemap::iterator x = ServerInstance->local_clones.find(this->GetIPString());
-		if (x != ServerInstance->local_clones.end())
+		x->second--;
+		if (!x->second)
 		{
-			x->second--;
-			if (!x->second)
-			{
-				ServerInstance->local_clones.erase(x);
-			}
+			ServerInstance->local_clones.erase(x);
 		}
-
-		clonemap::iterator y = ServerInstance->global_clones.find(this->GetIPString());
-		if (y != ServerInstance->global_clones.end())
+	}
+	
+	clonemap::iterator y = ServerInstance->global_clones.find(this->GetIPString());
+	if (y != ServerInstance->global_clones.end())
+	{
+		y->second--;
+		if (!y->second)
 		{
-			y->second--;
-			if (!y->second)
-			{
-				ServerInstance->global_clones.erase(y);
-			}
+			ServerInstance->global_clones.erase(y);
 		}
+	}
+}
+
+userrec::~userrec()
+{
+	this->InvalidateCache();
+	this->DecrementModes();
+	if (operquit)
+		free(operquit);
+	if (ip)
+	{
+		this->RemoveCloneCounts();
 
 		if (this->GetProtocolFamily() == AF_INET)
 		{
@@ -354,6 +406,8 @@ userrec::~userrec()
 		}
 #endif
 	}
+
+	ServerInstance->uuidlist->erase(uuid);
 }
 
 char* userrec::MakeHost()
@@ -398,8 +452,8 @@ char* userrec::MakeHostIP()
 
 void userrec::CloseSocket()
 {
-	shutdown(this->fd,2);
-	close(this->fd);
+	ServerInstance->SE->Shutdown(this, 2);
+	ServerInstance->SE->Close(this);
 }
 
 char* userrec::GetFullHost()
@@ -440,7 +494,11 @@ int userrec::ReadData(void* buffer, size_t size)
 {
 	if (IS_LOCAL(this))
 	{
+#ifndef WIN32
 		return read(this->fd, buffer, size);
+#else
+		return recv(this->fd, (char*)buffer, size, 0);
+#endif
 	}
 	else
 		return 0;
@@ -520,7 +578,7 @@ bool userrec::HasPermission(const std::string &command)
 		return true;
 
 	// are they even an oper at all?
-	if (*this->oper)
+	if (IS_OPER(this))
 	{
 		opertype_t::iterator iter_opertype = ServerInstance->Config->opertypes.find(this->oper);
 		if (iter_opertype != ServerInstance->Config->opertypes.end())
@@ -599,7 +657,7 @@ bool userrec::BufferIsReady()
 
 void userrec::ClearBuffer()
 {
-	recvq = "";
+	recvq.clear();
 }
 
 std::string userrec::GetBuffer()
@@ -613,8 +671,12 @@ std::string userrec::GetBuffer()
 		 * Usually there are only one or two of these,
 		 * so its is computationally cheap to do.
 		 */
-		while ((*recvq.begin() == '\r') || (*recvq.begin() == '\n'))
-			recvq.erase(recvq.begin());
+		std::string::iterator t = recvq.begin();
+		while (t != recvq.end() && (*t == '\r' || *t == '\n'))
+		{
+			recvq.erase(t);
+			t = recvq.begin();
+		}
 
 		for (std::string::iterator x = recvq.begin(); x != recvq.end(); x++)
 		{
@@ -657,8 +719,8 @@ void userrec::AddWriteBuf(const std::string &data)
 
 	try
 	{
-		if (data.length() > 512)
-			sendq.append(data.substr(0,510)).append("\r\n");
+		if (data.length() > MAXBUF - 2) /* MAXBUF has a value of 514, to account for line terminators */
+			sendq.append(data.substr(0,MAXBUF - 4)).append("\r\n"); /* MAXBUF-4 = 510 */
 		else
 			sendq.append(data);
 	}
@@ -676,12 +738,13 @@ void userrec::FlushWriteBuf()
 	{
 		if ((this->fd == FD_MAGIC_NUMBER) || (*this->GetWriteError()))
 		{
-			sendq = "";
+			sendq.clear();
 		}
 		if ((sendq.length()) && (this->fd != FD_MAGIC_NUMBER))
 		{
 			int old_sendq_length = sendq.length();
-			int n_sent = write(this->fd, this->sendq.data(), this->sendq.length());
+			int n_sent = ServerInstance->SE->Send(this, this->sendq.data(), this->sendq.length(), 0);
+
 			if (n_sent == -1)
 			{
 				if (errno == EAGAIN)
@@ -695,7 +758,7 @@ void userrec::FlushWriteBuf()
 				{
 					/* Fatal error, set write error and bail
 					 */
-					this->SetWriteError(strerror(errno));
+					this->SetWriteError(errno ? strerror(errno) : "EOF from client");
 					return;
 				}
 			}
@@ -717,6 +780,11 @@ void userrec::FlushWriteBuf()
 	{
 		ServerInstance->Log(DEBUG,"Exception in userrec::FlushWriteBuf()");
 	}
+
+	if (this->sendq.empty())
+	{
+		FOREACH_MOD(I_OnBufferFlushed,OnBufferFlushed(this));
+	}
 }
 
 void userrec::SetWriteError(const std::string &error)
@@ -762,18 +830,14 @@ void userrec::UnOper()
 {
 	try
 	{
-		if (*this->oper)
+		if (IS_OPER(this))
 		{
+			// unset their oper type (what IS_OPER checks), and remove +o
 			*this->oper = 0;
 			this->modes[UM_OPERATOR] = 0;
-			for (std::vector<userrec*>::iterator a = ServerInstance->all_opers.begin(); a < ServerInstance->all_opers.end(); a++)
-			{
-				if (*a == this)
-				{
-					ServerInstance->all_opers.erase(a);
-					return;
-				}
-			}
+			
+			// remove the user from the oper list. Will remove multiple entries as a safeguard against bug #404
+			ServerInstance->all_opers.remove(this);
 		}
 	}
 
@@ -783,12 +847,13 @@ void userrec::UnOper()
 	}
 }
 
-void userrec::QuitUser(InspIRCd* Instance, userrec *user, const std::string &quitreason)
+void userrec::QuitUser(InspIRCd* Instance, userrec *user, const std::string &quitreason, const char* operreason)
 {
-	Instance->GlobalCulls.AddItem(user, quitreason.c_str());
+	user->Write("ERROR :Closing link (%s@%s) [%s]", user->ident, user->host, operreason);
+	user->muted = true;
+	Instance->GlobalCulls.AddItem(user, quitreason.c_str(), operreason);
 }
 
-
 /* adds or updates an entry in the whowas list */
 void userrec::AddToWhoWas()
 {
@@ -804,42 +869,38 @@ void userrec::AddToWhoWas()
 /* add a client connection to the sockets list */
 void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached, int socketfamily, sockaddr* ip)
 {
-	std::string tempnick = ConvToStr(socket) + "-unknown";
-	user_hash::iterator iter = Instance->clientlist->find(tempnick);
+	/* NOTE: Calling this one parameter constructor for userrec automatically
+	 * allocates a new UUID and places it in the hash_map.
+	 */
+	userrec* New = NULL;
+	try
+	{
+		New = new userrec(Instance);
+	}
+	catch (...)
+	{
+		Instance->Log(DEFAULT,"*** WTF *** Duplicated UUID! -- Crack smoking monkies have been unleashed.");
+		Instance->WriteOpers("*** WARNING *** Duplicate UUID allocated!");
+		return;
+	}
+
+	int j = 0;
+
+	Instance->unregistered_count++;
+
 	char ipaddr[MAXBUF];
 #ifdef IPV6
 	if (socketfamily == AF_INET6)
 		inet_ntop(AF_INET6, &((const sockaddr_in6*)ip)->sin6_addr, ipaddr, sizeof(ipaddr));
 	else
-		inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
-#else
-	inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
 #endif
-	userrec* New;
-	int j = 0;
-
-	Instance->unregistered_count++;
+	inet_ntop(AF_INET, &((const sockaddr_in*)ip)->sin_addr, ipaddr, sizeof(ipaddr));
 
-	/*
-	 * fix by brain.
-	 * as these nicknames are 'RFC impossible', we can be sure nobody is going to be
-	 * using one as a registered connection. As they are per fd, we can also safely assume
-	 * that we wont have collisions. Therefore, if the nick exists in the list, its only
-	 * used by a dead socket, erase the iterator so that the new client may reclaim it.
-	 * this was probably the cause of 'server ignores me when i hammer it with reconnects'
-	 * issue in earlier alphas/betas
-	 */
-	if (iter != Instance->clientlist->end())
-	{
-		userrec* goner = iter->second;
-		DELETE(goner);
-		Instance->clientlist->erase(iter);
-	}
+	(*(Instance->clientlist))[New->uuid] = New;
+	New->SetFd(socket);
 
-	New = new userrec(Instance);
-	(*(Instance->clientlist))[tempnick] = New;
-	New->fd = socket;
-	strlcpy(New->nick,tempnick.c_str(),NICKMAX-1);
+	/* The users default nick is their UUID */
+	strlcpy(New->nick, New->uuid, NICKMAX - 1);
 
 	New->server = Instance->FindServerNamePtr(Instance->Config->ServerName);
 	/* We don't need range checking here, we KNOW 'unknown\0' will fit into the ident field. */
@@ -856,24 +917,38 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
 		New->dhost[j] = New->host[j] = *temp;
 	New->dhost[j] = New->host[j] = 0;
 
+        if (socket > -1)
+        {
+                if (!Instance->SE->AddFd(New))
+                {
+                        Instance->Log(DEBUG,"ERROR: Could not add new user %s!%s@%s to the socket engine!!!", New->nick, New->ident, New->host);
+                        close(socket);
+                        shutdown(socket,2);
+                        delete New;
+                        return;
+                }
+        }
+
 	Instance->AddLocalClone(New);
 	Instance->AddGlobalClone(New);
 
+	/*
+	 * First class check. We do this again in FullConnect after DNS is done, and NICK/USER is recieved.
+	 * See my note down there for why this is required. DO NOT REMOVE. :) -- w00t
+	 */
 	ConnectClass* i = New->GetClass();
 
-	if ((!i) || (i->GetType() == CC_DENY))
+	if (!i)
 	{
-		userrec::QuitUser(Instance, New,"Unauthorised connection");
+		userrec::QuitUser(Instance, New, "Access denied by configuration");
 		return;
 	}
 
-	New->pingmax = i->GetPingTime();
-	New->nping = Instance->Time() + i->GetPingTime() + Instance->Config->dns_timeout;
-	New->timeout = Instance->Time() + i->GetRegTimeout();
-	New->flood = i->GetFlood();
-	New->threshold = i->GetThreshold();
-	New->sendqmax = i->GetSendqMax();
-	New->recvqmax = i->GetRecvqMax();
+	/*
+	 * Check connect class settings and initialise settings into userrec.
+	 * This will be done again after DNS resolution. -- w00t
+	 */
+	New->CheckClass();
 
 	Instance->local_users.push_back(New);
 
@@ -894,11 +969,13 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
 	 * which for the time being is a physical impossibility (even the largest networks dont have more
 	 * than about 10,000 users on ONE server!)
 	 */
+#ifndef WINDOWS
 	if ((unsigned int)socket >= MAX_DESCRIPTORS)
 	{
 		userrec::QuitUser(Instance, New, "Server is full");
 		return;
 	}
+#endif
 
 	New->exempt = (Instance->XLines->matches_exception(New) != NULL);
 	if (!New->exempt)
@@ -907,21 +984,14 @@ void userrec::AddClient(InspIRCd* Instance, int socket, int port, bool iscached,
 		if (r)
 		{
 			char reason[MAXBUF];
+			if (*Instance->Config->MoronBanner)
+				New->WriteServ("NOTICE %s :*** %s", New->nick, Instance->Config->MoronBanner);
 			snprintf(reason,MAXBUF,"Z-Lined: %s",r->reason);
 			userrec::QuitUser(Instance, New, reason);
 			return;
 		}
 	}
 
-	if (socket > -1)
-	{
-		if (!Instance->SE->AddFd(New))
-		{
-			userrec::QuitUser(Instance, New, "Internal error handling connection");
-			return;
-		}
-	}
-
 	/* NOTE: even if dns lookups are *off*, we still need to display this.
 	 * BOPM and other stuff requires it.
 	 */
@@ -946,47 +1016,75 @@ unsigned long userrec::LocalCloneCount()
 		return 0;
 }
 
-void userrec::FullConnect()
+/*
+ * Check class restrictions
+ */
+void userrec::CheckClass(const std::string &explicit_class)
 {
-	ServerInstance->stats->statsConnects++;
-	this->idle_lastmsg = ServerInstance->Time();
-
-	ConnectClass* a = this->GetClass();
+	ConnectClass* a = this->GetClass(explicit_class);
 
 	if ((!a) || (a->GetType() == CC_DENY))
 	{
-		ServerInstance->GlobalCulls.AddItem(this,"Unauthorised connection");
+		userrec::QuitUser(ServerInstance, this, "Unauthorised connection");
 		return;
 	}
-
-	if ((!a->GetPass().empty()) && (!this->haspassed))
+	else if ((a->GetMaxLocal()) && (this->LocalCloneCount() > a->GetMaxLocal()))
 	{
-		ServerInstance->GlobalCulls.AddItem(this,"Invalid password");
+		userrec::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (local)");
+		ServerInstance->WriteOpers("*** WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a->GetMaxLocal(), this->GetIPString());
 		return;
 	}
-
-	if (this->LocalCloneCount() > a->GetMaxLocal())
+	else if ((a->GetMaxGlobal()) && (this->GlobalCloneCount() > a->GetMaxGlobal()))
 	{
-		ServerInstance->GlobalCulls.AddItem(this, "No more connections allowed from your host via this connect class (local)");
-		ServerInstance->WriteOpers("*** WARNING: maximum LOCAL connections (%ld) exceeded for IP %s", a->GetMaxLocal(), this->GetIPString());
+		userrec::QuitUser(ServerInstance, this, "No more connections allowed from your host via this connect class (global)");
+		ServerInstance->WriteOpers("*** WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s", a->GetMaxGlobal(), this->GetIPString());
 		return;
 	}
-	else if (this->GlobalCloneCount() > a->GetMaxGlobal())
+
+	this->pingmax = a->GetPingTime();
+	this->nping = ServerInstance->Time() + a->GetPingTime() + ServerInstance->Config->dns_timeout;
+	this->timeout = ServerInstance->Time() + a->GetRegTimeout();
+	this->flood = a->GetFlood();
+	this->threshold = a->GetThreshold();
+	this->sendqmax = a->GetSendqMax();
+	this->recvqmax = a->GetRecvqMax();
+	this->MaxChans = a->GetMaxChans();
+}
+
+void userrec::FullConnect()
+{
+	ServerInstance->stats->statsConnects++;
+	this->idle_lastmsg = ServerInstance->Time();
+
+	/*
+	 * You may be thinking "wtf, we checked this in userrec::AddClient!" - and yes, we did, BUT.
+	 * At the time AddClient is called, we don't have a resolved host, by here we probably do - which
+	 * may put the user into a totally seperate class with different restrictions! so we *must* check again.
+	 * Don't remove this! -- w00t
+	 */
+	this->CheckClass();
+	
+	/* Check the password, if one is required by the user's connect class.
+	 * This CANNOT be in CheckClass(), because that is called prior to PASS as well!
+	 */
+	if ((!this->GetClass()->GetPass().empty()) && (!this->haspassed))
 	{
-		ServerInstance->GlobalCulls.AddItem(this, "No more connections allowed from your host via this connect class (global)");
-		ServerInstance->WriteOpers("*** WARNING: maximum GLOBAL connections (%ld) exceeded for IP %s",a->GetMaxGlobal(), this->GetIPString());
+		userrec::QuitUser(ServerInstance, this, "Invalid password");
 		return;
 	}
-
+	
 	if (!this->exempt)
 	{
 		GLine* r = ServerInstance->XLines->matches_gline(this);
 
 		if (r)
 		{
+			this->muted = true;
 			char reason[MAXBUF];
+			if (*ServerInstance->Config->MoronBanner)
+				this->WriteServ("NOTICE %s :*** %s", this->nick, ServerInstance->Config->MoronBanner);
 			snprintf(reason,MAXBUF,"G-Lined: %s",r->reason);
-			ServerInstance->GlobalCulls.AddItem(this, reason);
+			userrec::QuitUser(ServerInstance, this, reason);
 			return;
 		}
 
@@ -994,12 +1092,14 @@ void userrec::FullConnect()
 
 		if (n)
 		{
+			this->muted = true;
 			char reason[MAXBUF];
+			if (*ServerInstance->Config->MoronBanner)
+				this->WriteServ("NOTICE %s :*** %s", this, ServerInstance->Config->MoronBanner);
 			snprintf(reason,MAXBUF,"K-Lined: %s",n->reason);
-			ServerInstance->GlobalCulls.AddItem(this, reason);
+			userrec::QuitUser(ServerInstance, this, reason);
 			return;
 		}
-
 	}
 
 	this->WriteServ("NOTICE Auth :Welcome to \002%s\002!",ServerInstance->Config->Network);
@@ -1010,12 +1110,21 @@ void userrec::FullConnect()
 
 	ServerInstance->Config->Send005(this);
 
+	this->WriteServ("042 %s %s :your unique ID", this->nick, this->uuid);
+
+
 	this->ShowMOTD();
 
 	/* Now registered */
 	if (ServerInstance->unregistered_count)
 		ServerInstance->unregistered_count--;
 
+	/* Trigger LUSERS output, give modules a chance too */
+	int MOD_RESULT = 0;
+	FOREACH_RESULT(I_OnPreCommand, OnPreCommand("LUSERS", NULL, 0, this, true, "LUSERS"));
+	if (!MOD_RESULT)
+		ServerInstance->CallCommandHandler("LUSERS", NULL, 0, this);
+
 	/*
 	 * fix 3 by brain, move registered = 7 below these so that spurious modes and host
 	 * changes dont go out onto the network and produce 'fake direction'.
@@ -1026,7 +1135,7 @@ void userrec::FullConnect()
 
 	FOREACH_MOD(I_OnPostConnect,OnPostConnect(this));
 
-	ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString());
+	ServerInstance->SNO->WriteToSnoMask('c',"Client connecting on port %d: %s!%s@%s [%s] [%s]", this->GetPort(), this->nick, this->ident, this->host, this->GetIPString(), this->fullname);
 }
 
 /** userrec::UpdateNick()
@@ -1097,10 +1206,15 @@ bool userrec::ForceNickChange(const char* newnick)
 
 		if (this->registered == REG_ALL)
 		{
-			const char* pars[1];
-			pars[0] = newnick;
-			std::string cmd = "NICK";
-			return (ServerInstance->Parser->CallHandler(cmd, pars, 1, this) == CMD_SUCCESS);
+			std::deque<classbase*> dummy;
+			command_t* nickhandler = ServerInstance->Parser->GetHandler("NICK");
+			if (nickhandler)
+			{
+				nickhandler->HandleInternal(1, dummy);
+				bool result = (ServerInstance->Parser->CallHandler("NICK", &newnick, 1, this) == CMD_SUCCESS);
+				nickhandler->HandleInternal(0, dummy);
+				return result;
+			}
 		}
 		return false;
 	}
@@ -1268,12 +1382,12 @@ const char* userrec::GetIPString(char* buf)
  */
 void userrec::Write(std::string text)
 {
-	if ((this->fd < 0) || (this->fd > MAX_DESCRIPTORS))
+	if (!ServerInstance->SE->BoundsCheckFd(this))
 		return;
 
 	try
 	{
-		/* ServerInstance->Log(DEBUG,"<- %s", text.c_str());
+		/* ServerInstance->Log(DEBUG,"C[%d] O %s", this->GetFd(), text.c_str());
 		 * WARNING: The above debug line is VERY loud, do NOT
 		 * enable it till we have a good way of filtering it
 		 * out of the logs (e.g. 1.2 would be good).
@@ -1290,6 +1404,9 @@ void userrec::Write(std::string text)
 	{
 		try
 		{
+			/* XXX: The lack of buffering here is NOT a bug, modules implementing this interface have to
+			 * implement their own buffering mechanisms
+			 */
 			ServerInstance->Config->GetIOHook(this->GetPort())->OnRawSocketWrite(this->fd, text.data(), text.length());
 		}
 		catch (CoreException& modexcept)
@@ -1424,10 +1541,10 @@ void userrec::WriteCommon(const std::string &text)
 			CUList* ulist = v->first->GetUsers();
 			for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 			{
-				if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+				if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
 				{
-					already_sent[i->second->fd] = uniq_id;
-					i->second->Write(out);
+					already_sent[i->first->fd] = uniq_id;
+					i->first->Write(out);
 					sent_to_at_least_one = true;
 				}
 			}
@@ -1466,67 +1583,47 @@ void userrec::WriteCommonExcept(const char* text, ...)
 	this->WriteCommonExcept(std::string(textbuffer));
 }
 
-void userrec::WriteCommonExcept(const std::string &text)
+void userrec::WriteCommonQuit(const std::string &normal_text, const std::string &oper_text)
 {
-	bool quit_munge = false;
-	char oper_quit[MAXBUF];
-	char textbuffer[MAXBUF];
 	char tb1[MAXBUF];
 	char tb2[MAXBUF];
-	std::string out1;
-	std::string out2;
-
-	strlcpy(textbuffer, text.c_str(), MAXBUF);
 
 	if (this->registered != REG_ALL)
 		return;
 
 	uniq_id++;
+	snprintf(tb1,MAXBUF,":%s QUIT :%s",this->GetFullHost(),normal_text.c_str());
+	snprintf(tb2,MAXBUF,":%s QUIT :%s",this->GetFullHost(),oper_text.c_str());
+	std::string out1 = tb1;
+	std::string out2 = tb2;
 
-	snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost(),textbuffer);
-
-	/* TODO: We need some form of WriteCommonExcept that will send two lines, one line to
-	 * opers and the other line to non-opers, then all this hidebans and hidesplits gunk
-	 * can go byebye.
-	 */
-	if (ServerInstance->Config->HideSplits)
+	for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
 	{
-		char* check = textbuffer + 6;
-
-		if (!strncasecmp(textbuffer, "QUIT :",6))
+		CUList *ulist = v->first->GetUsers();
+		for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 		{
-			std::stringstream split(check);
-			std::string server_one;
-			std::string server_two;
-
-			split >> server_one;
-			split >> server_two;
-
-			if ((ServerInstance->FindServerName(server_one)) && (ServerInstance->FindServerName(server_two)))
+			if (this != i->first)
 			{
-				strlcpy(oper_quit,textbuffer,MAXQUIT);
-				strlcpy(check,"*.net *.split",MAXQUIT);
-				quit_munge = true;
-				snprintf(tb2,MAXBUF,":%s %s",this->GetFullHost(),oper_quit);
-				out2 = tb2;
+				if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
+				{
+					already_sent[i->first->fd] = uniq_id;
+					i->first->Write(IS_OPER(i->first) ? out2 : out1);
+				}
 			}
 		}
 	}
+}
 
-	if ((ServerInstance->Config->HideBans) && (!quit_munge))
-	{
-		if ((!strncasecmp(textbuffer, "QUIT :G-Lined:",14)) || (!strncasecmp(textbuffer, "QUIT :K-Lined:",14))
-		|| (!strncasecmp(textbuffer, "QUIT :Q-Lined:",14)) || (!strncasecmp(textbuffer, "QUIT :Z-Lined:",14)))
-		{
-			char* check = textbuffer + 13;
-			strlcpy(oper_quit,textbuffer,MAXQUIT);
-			*check = 0;  // We don't need to strlcpy, we just chop it from the :
-			quit_munge = true;
-			snprintf(tb2,MAXBUF,":%s %s",this->GetFullHost(),oper_quit);
-			out2 = tb2;
-		}
-	}
+void userrec::WriteCommonExcept(const std::string &text)
+{
+	char tb1[MAXBUF];
+	std::string out1;
+
+	if (this->registered != REG_ALL)
+		return;
 
+	uniq_id++;
+	snprintf(tb1,MAXBUF,":%s %s",this->GetFullHost(),text.c_str());
 	out1 = tb1;
 
 	for (UCListIter v = this->chans.begin(); v != this->chans.end(); v++)
@@ -1534,15 +1631,12 @@ void userrec::WriteCommonExcept(const std::string &text)
 		CUList *ulist = v->first->GetUsers();
 		for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 		{
-			if (this != i->second)
+			if (this != i->first)
 			{
-				if ((IS_LOCAL(i->second)) && (already_sent[i->second->fd] != uniq_id))
+				if ((IS_LOCAL(i->first)) && (already_sent[i->first->fd] != uniq_id))
 				{
-					already_sent[i->second->fd] = uniq_id;
-					if (quit_munge)
-						i->second->Write(*i->second->oper ? out2 : out1);
-					else
-						i->second->Write(out1);
+					already_sent[i->first->fd] = uniq_id;
+					i->first->Write(out1);
 				}
 			}
 		}
@@ -1552,26 +1646,16 @@ void userrec::WriteCommonExcept(const std::string &text)
 
 void userrec::WriteWallOps(const std::string &text)
 {
-	/* Does nothing if theyre not opered */
-	if ((!*this->oper) && (IS_LOCAL(this)))
+	if (!IS_OPER(this) && IS_LOCAL(this))
 		return;
 
-	std::string wallop = "WALLOPS :";
-
-	try
-	{
-		wallop.append(text);
-	}
-	catch (...)
-	{
-		ServerInstance->Log(DEBUG,"Exception in userrec::Write() std::string::append");
-		return;
-	}
+	std::string wallop("WALLOPS :");
+	wallop.append(text);
 
 	for (std::vector<userrec*>::const_iterator i = ServerInstance->local_users.begin(); i != ServerInstance->local_users.end(); i++)
 	{
 		userrec* t = *i;
-		if ((IS_LOCAL(t)) && (t->modes[UM_WALLOPS]))
+		if (t->IsModeSet('w'))
 			this->WriteTo(t,wallop);
 	}
 }
@@ -1668,7 +1752,7 @@ bool userrec::ChangeDisplayedHost(const char* host)
 	}
 
 	if (IS_LOCAL(this))
-		this->WriteServ("396 %s %s :is now your hidden host",this->nick,this->dhost);
+		this->WriteServ("396 %s %s :is now your displayed host",this->nick,this->dhost);
 
 	return true;
 }
@@ -1699,7 +1783,7 @@ bool userrec::ChangeIdent(const char* newident)
 	return true;
 }
 
-void userrec::NoticeAll(char* text, ...)
+void userrec::SendAll(const char* command, char* text, ...)
 {
 	char textbuffer[MAXBUF];
 	char formatbuffer[MAXBUF];
@@ -1709,7 +1793,7 @@ void userrec::NoticeAll(char* text, ...)
 	vsnprintf(textbuffer, MAXBUF, text, argsPtr);
 	va_end(argsPtr);
 
-	snprintf(formatbuffer,MAXBUF,":%s NOTICE $* :%s", this->GetFullHost(), textbuffer);
+	snprintf(formatbuffer,MAXBUF,":%s %s $* :%s", this->GetFullHost(), command, textbuffer);
 	std::string fmt = formatbuffer;
 
 	for (std::vector<userrec*>::const_iterator i = ServerInstance->local_users.begin(); i != ServerInstance->local_users.end(); i++)
@@ -1730,7 +1814,7 @@ std::string userrec::ChannelList(userrec* source)
 			 * If the channel is NOT private/secret OR the user shares a common channel
 			 * If the user is an oper, and the <options:operspywhois> option is set.
 			 */
-			if ((source == this) || (*source->oper && ServerInstance->Config->OperSpyWhois) || (((!i->first->modes[CM_PRIVATE]) && (!i->first->modes[CM_SECRET])) || (i->first->HasUser(source))))
+			if ((source == this) || (IS_OPER(source) && ServerInstance->Config->OperSpyWhois) || (((!i->first->IsModeSet('p')) && (!i->first->IsModeSet('s'))) || (i->first->HasUser(source))))
 			{
 				list.append(i->first->GetPrefixChar(this)).append(i->first->name).append(" ");
 			}
@@ -1789,18 +1873,43 @@ void userrec::SplitChanList(userrec* dest, const std::string &cl)
 	}
 }
 
+unsigned int userrec::GetMaxChans()
+{
+	return this->MaxChans;
+}
 
 /* looks up a users password for their connection class (<ALLOW>/<DENY> tags)
  * NOTE: If the <ALLOW> or <DENY> tag specifies an ip, and this user resolves,
  * then their ip will be taken as 'priority' anyway, so for example,
  * <connect allow="127.0.0.1"> will match joe!bloggs@localhost
  */
-ConnectClass* userrec::GetClass()
+ConnectClass* userrec::GetClass(const std::string &explicit_name)
 {
-	for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
+	if (!explicit_name.empty())
 	{
-		if ((match(this->GetIPString(),i->GetHost().c_str(),true)) || (match(this->host,i->GetHost().c_str())))
-			return &(*i);
+		for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
+		{
+			if (explicit_name == i->GetName())
+				return &(*i);
+		}
+	}
+	else
+	{
+		for (ClassVector::iterator i = ServerInstance->Config->Classes.begin(); i != ServerInstance->Config->Classes.end(); i++)
+		{
+			if (((match(this->GetIPString(),i->GetHost().c_str(),true)) || (match(this->host,i->GetHost().c_str()))))
+			{
+				if (i->GetPort())
+				{
+					if (this->GetPort() == i->GetPort())
+						return &(*i);
+					else
+						continue;
+				}
+				else
+					return &(*i);
+			}
+		}
 	}
 	return NULL;
 }
@@ -1862,15 +1971,16 @@ void userrec::ShowRULES()
 {
 	if (!ServerInstance->Config->RULES.size())
 	{
-		this->WriteServ("NOTICE %s :Rules file is missing.",this->nick);
+		this->WriteServ("434 %s :RULES File is missing",this->nick);
 		return;
 	}
-	this->WriteServ("NOTICE %s :%s rules",this->nick,ServerInstance->Config->ServerName);
+
+	this->WriteServ("308 %s :- %s Server Rules -",this->nick,ServerInstance->Config->ServerName);
 
 	for (file_cache::iterator i = ServerInstance->Config->RULES.begin(); i != ServerInstance->Config->RULES.end(); i++)
-		this->WriteServ("NOTICE %s :%s",this->nick,i->c_str());
+		this->WriteServ("232 %s :- %s",this->nick,i->c_str());
 
-	this->WriteServ("NOTICE %s :End of %s rules.",this->nick,ServerInstance->Config->ServerName);
+	this->WriteServ("309 %s :End of RULES command.",this->nick);
 }
 
 void userrec::HandleEvent(EventType et, int errornum)
@@ -1909,3 +2019,29 @@ void userrec::HandleEvent(EventType et, int errornum)
 	}
 }
 
+void userrec::SetOperQuit(const std::string &oquit)
+{
+	if (operquit)
+		return;
+
+	operquit = strdup(oquit.c_str());
+}
+
+const char* userrec::GetOperQuit()
+{
+	return operquit ? operquit : "";
+}
+
+VisData::VisData()
+{
+}
+
+VisData::~VisData()
+{
+}
+
+bool VisData::VisibleTo(userrec* user)
+{
+	return true;
+}
+