X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=data%2Frbot%2Fplugins%2Ftranslator.rb;h=6bd4dc226018ac9650ae2d40e5513a8f22e29164;hb=24bb60775741d3731400f1e430ef6bf3a2e1b933;hp=6a84275475f46e4388f47720c836fe3898dca10b;hpb=6f5528a63b44e610a3d25d7fe583399163d7d2da;p=user%2Fhenk%2Fcode%2Fruby%2Frbot.git

diff --git a/data/rbot/plugins/translator.rb b/data/rbot/plugins/translator.rb
index 6a842754..6bd4dc22 100644
--- a/data/rbot/plugins/translator.rb
+++ b/data/rbot/plugins/translator.rb
@@ -8,6 +8,11 @@
 # License:: GPLv2
 #
 # This plugin allows using rbot to translate text on a few translation services
+#
+# TODO
+#
+# * Configuration for whether to show translation engine
+# * Optionally sync default translators with karma.rb ranking
 
 require 'set'
 require 'timeout'
@@ -288,9 +293,10 @@ class TranslatorPlugin < Plugin
   end
 
   def help(plugin, topic=nil)
-    if @translators.has_key?(topic)
-      translator = @translators[topic]
-      _('%{info}, supported directions of translation: %{directions}') % {
+    if @translators.has_key?(plugin)
+      translator = @translators[plugin]
+      _('%{translator} <from> <to> <phrase> => Look up phrase using %{info}, supported from -> to languages: %{directions}') % {
+        :translator => plugin,
         :info => translator.class::INFO,
         :directions => translator.directions.map do |source, targets|
                          _('%{source} -> %{targets}') %
@@ -298,7 +304,7 @@ class TranslatorPlugin < Plugin
                        end.join(' | ')
       }
     else
-      _('Command: <translator> <from> <to> <phrase>, where <translator> is one of: %{translators}. If "translator" is used in place of the translator name, the first translator in translator.default_list which supports the specified direction will be picked automatically. Use "help translator <translator>" to look up supported from and to languages') %
+      _('Command: <translator> <from> <to> <phrase>, where <translator> is one of: %{translators}. If "translator" is used in place of the translator name, the first translator in translator.default_list which supports the specified direction will be picked automatically. Use "help <translator>" to look up supported from and to languages') %
         {:translators => @translators.keys.join(', ')}
     end
   end
@@ -311,7 +317,7 @@ class TranslatorPlugin < Plugin
     from, to = params[:from], params[:to]
     translator = @default_translators.find {|t| @translators[t].support?(from, to)}
     if translator
-      cmd_translate m, params.merge({:translator => translator})
+      cmd_translate m, params.merge({:translator => translator, :show_provider => true})
     else
       m.reply _('None of the default translators (translator.default_list) supports translating from %{source} to %{target}') % {:source => from, :target => to}
     end
@@ -327,7 +333,13 @@ class TranslatorPlugin < Plugin
         translation = Timeout.timeout(@bot.config['translator.timeout']) do
           translator.translate(phrase, from, to)
         end
-        m.reply translation
+        m.reply(if params[:show_provider]
+                  _('%{translation} (provided by %{translator})') %
+                    {:translation => translation, :translator => tname}
+                else
+                  translation
+                end)
+
       rescue Translator::UnsupportedDirectionError
         m.reply _("%{translator} doesn't support translating from %{source} to %{target}") %
                 {:translator => tname, :source => from, :target => to}
@@ -345,4 +357,4 @@ end
 
 plugin = TranslatorPlugin.new
 plugin.map 'translator :from :to *phrase',
-  :action => :cmd_translator, :thread => true
+           :action => :cmd_translator, :thread => true