X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=data%2Frbot%2Fplugins%2Ftranslator.rb;h=933969a1a7f1aa62ffb388fefcf41f5a96443309;hb=052217de30c59206d7025b582d4604557a747470;hp=c0b27bc7b9d271f945e9173f6fcabf35be5c4578;hpb=868c594b7ce5d8e31524109af1ecb493699ee31f;p=user%2Fhenk%2Fcode%2Fruby%2Frbot.git diff --git a/data/rbot/plugins/translator.rb b/data/rbot/plugins/translator.rb index c0b27bc7..933969a1 100644 --- a/data/rbot/plugins/translator.rb +++ b/data/rbot/plugins/translator.rb @@ -39,6 +39,14 @@ class Translator @cache = cache end + # Many translators use Mechanize, which changed namespace around version 1.0 + # To support both pre-1.0 and post-1.0 namespaces, we use these auxiliary + # method. The translator still needs to require 'mechanize' on initialization + # if it needs it. + def mechanize + return Mechanize if defined? Mechanize + return WWW::Mechanize + end # whether the translator supports this direction def support?(from, to) @@ -110,12 +118,12 @@ class NiftyTranslator < Translator def initialize(cache={}) require 'mechanize' super(Translator::Direction.all_from_to(%w[ja en zh_CN ko], %w[ja]), cache) - @form = WWW::Mechanize.new. - get('http://nifty.amikai.com/amitext/indexUTF8.jsp'). - forms_with(:name => 'translateForm').last end def do_translate(text, from, to) + @form ||= mechanize.new. + get('http://nifty.amikai.com/amitext/indexUTF8.jsp'). + forms_with(:name => 'translateForm').last @radio = @form.radiobuttons_with(:name => 'langpair').first @radio.value = "#{from},#{to}".upcase @radio.check @@ -150,7 +158,7 @@ class ExciteTranslator < Translator end def open_form(name) - WWW::Mechanize.new.get("http://www.excite.co.jp/world/#{name}"). + mechanize.new.get("http://www.excite.co.jp/world/#{name}"). forms_with(:name => 'world').first end @@ -215,16 +223,24 @@ class BabelfishTranslator < Translator def initialize(cache) require 'mechanize' - - @form = WWW::Mechanize.new.get('http://babelfish.altavista.com/babelfish/'). - forms_with(:name => 'frmTrText').first - @lang_list = @form.fields_with(:name => 'lp').first - language_pairs = @lang_list.options.map {|o| o.value.split('_')}. - reject {|p| p.empty?} + (_, lang_list) = parse_page + language_pairs = lang_list.options.map {|o| o.value.split('_')}. + reject {|p| p.empty?} super(Translator::Direction.pairs(language_pairs), cache) end + def parse_page + form = mechanize.new.get('http://babelfish.altavista.com/babelfish/'). + forms_with(:name => 'frmTrText').first + lang_list = form.fields_with(:name => 'lp').first + [form, lang_list] + end + def do_translate(text, from, to) + unless @form && @lang_list + @form, @lang_list = parse_page + end + if @form.fields_with(:name => 'trtext').empty? @form.add_field!('trtext', text) else @@ -278,17 +294,10 @@ class TranslatorPlugin < Plugin @failed_translators = [] @translators = {} TRANSLATORS.each_pair do |name, c| - begin + watch_for_fail(name) do @translators[name] = c.new(@registry.sub_registry(name)) map "#{name} :from :to *phrase", :action => :cmd_translate, :thread => true - rescue Exception - @failed_translators << { :name => name, :reason => $!.to_s } - - warning _("Translator %{name} cannot be used: %{reason}") % - {:name => name, :reason => $!} - map "#{name} [*args]", :action => :failed_translator, - :defaults => {:name => name, :reason => $!} end end @@ -300,6 +309,19 @@ class TranslatorPlugin < Plugin update_default end + def watch_for_fail(name, &block) + begin + yield + rescue Exception + @failed_translators << { :name => name, :reason => $!.to_s } + + warning _("Translator %{name} cannot be used: %{reason}") % + {:name => name, :reason => $!} + map "#{name} [*args]", :action => :failed_translator, + :defaults => {:name => name, :reason => $!} + end + end + def failed_translator(m, params) m.reply _("Translator %{name} cannot be used: %{reason}") % {:name => params[:name], :reason => params[:reason]} @@ -360,9 +382,22 @@ class TranslatorPlugin < Plugin translator = @default_translators.find {|t| @translators[t].support?(params[:from], params[:to])} if translator - cmd_translate m, params.merge({:translator => translator, :show_provider => true}) + cmd_translate m, params.merge({:translator => translator, :show_provider => false}) else - m.reply _('None of the default translators (translator.default_list) supports translating from %{source} to %{target}') % {:source => params[:from], :target => params[:to]} + # When translate command is used without source language, "auto" as source + # language is assumed. It means that google translator is used and we let google + # figure out what the source language is. + # + # Problem is that the google translator will fail if the system that the bot is + # running on does not have the json gem installed. + if params[:from] == 'auto' + m.reply _("Unable to auto-detect source language due to broken google translator, see %{reverse}%{prefix}help translate failed%{reverse} for details") % { + :reverse => Reverse, + :prefix => @bot.config['core.address_prefix'].first + } + else + m.reply _('None of the default translators (translator.default_list) supports translating from %{source} to %{target}') % {:source => params[:from], :target => params[:to]} + end end end @@ -372,35 +407,56 @@ class TranslatorPlugin < Plugin translator = @translators[tname] from, to, phrase = params[:from], params[:to], params[:phrase].to_s if translator - begin - translation = Timeout.timeout(@bot.config['translator.timeout']) do - translator.translate(phrase, from, to) + watch_for_fail(tname) do + begin + translation = Timeout.timeout(@bot.config['translator.timeout']) do + translator.translate(phrase, from, to) + end + m.reply(if params[:show_provider] + _('%{translation} (provided by %{translator})') % + {:translation => translation, :translator => tname.gsub("_", " ")} + else + translation + end) + + rescue Translator::UnsupportedDirectionError + m.reply _("%{translator} doesn't support translating from %{source} to %{target}") % + {:translator => tname, :source => from, :target => to} + rescue Translator::NoTranslationError + m.reply _('%{translator} failed to provide a translation') % + {:translator => tname} + rescue Timeout::Error + m.reply _('The translator timed out') end - m.reply(if params[:show_provider] - _('%{translation} (provided by %{translator})') % - {:translation => translation, :translator => tname.gsub("_", " ")} - else - translation - end) - - rescue Translator::UnsupportedDirectionError - m.reply _("%{translator} doesn't support translating from %{source} to %{target}") % - {:translator => tname, :source => from, :target => to} - rescue Translator::NoTranslationError - m.reply _('%{translator} failed to provide a translation') % - {:translator => tname} - rescue Timeout::Error - m.reply _('The translator timed out') end else m.reply _('No translator called %{name}') % {:name => tname} end end + + # URL translation has nothing to do with Translators so let's make it + # separate, and Google exclusive for now + def cmd_translate_url(m, params) + params[:to] = @bot.config['translator.destination'] if params[:to].nil? + params[:from] ||= 'auto' + + translate_url = "http://translate.google.com/translate?sl=%{from}&tl=%{to}&u=%{url}" % { + :from => params[:from], + :to => params[:to], + :url => CGI.escape(params[:url].to_s) + } + + m.reply(translate_url) + end end plugin = TranslatorPlugin.new req = Hash[*%w(from to).map { |e| [e.to_sym, /#{plugin.languages.join("|")}/] }.flatten] +plugin.map 'translate [:from] [:to] :url', + :action => :cmd_translate_url, :requirements => req.merge(:url => %r{^https?://[^\s]*}) +plugin.map 'translator [:from] [:to] :url', + :action => :cmd_translate_url, :requirements => req.merge(:url => %r{^https?://[^\s]*}) plugin.map 'translate [:from] [:to] *phrase', :action => :cmd_translator, :thread => true, :requirements => req plugin.map 'translator [:from] [:to] *phrase',