X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fchannels.cpp;h=8e7d4af06cc5426e1d76f231587c29e350cd7462;hb=4fb31d6a3494a99819225fe36da75c5991461dc6;hp=532953db3489e47a19089feb61f0373035298019;hpb=e27f3380733a4412007a3f023069615d1218ab96;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/channels.cpp b/src/channels.cpp
index 532953db3..8e7d4af06 100644
--- a/src/channels.cpp
+++ b/src/channels.cpp
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
  * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
@@ -17,10 +17,10 @@
 #include <cstdarg>
 #include "mode.h"
 
-Channel::Channel(InspIRCd* Instance, const std::string &cname, time_t ts) : ServerInstance(Instance)
+Channel::Channel(const std::string &cname, time_t ts)
 {
 	chan_hash::iterator findchan = ServerInstance->chanlist->find(cname);
-	if (findchan != Instance->chanlist->end())
+	if (findchan != ServerInstance->chanlist->end())
 		throw CoreException("Cannot create duplicate channel " + cname);
 
 	(*(ServerInstance->chanlist))[cname.c_str()] = this;
@@ -36,7 +36,12 @@ void Channel::SetMode(char mode,bool mode_on)
 	modes[mode-65] = mode_on;
 }
 
-void Channel::SetModeParam(char mode, std::string parameter)
+void Channel::SetMode(ModeHandler* mh, bool on)
+{
+	modes[mh->GetModeChar() - 65] = on;
+}
+
+void Channel::SetModeParam(char mode, const std::string& parameter)
 {
 	CustomModeList::iterator n = custom_mode_params.find(mode);
 	// always erase, even if changing, so that the map gets the new value
@@ -53,9 +58,9 @@ void Channel::SetModeParam(char mode, std::string parameter)
 	}
 }
 
-bool Channel::IsModeSet(char mode)
+void Channel::SetModeParam(ModeHandler* mode, const std::string& parameter)
 {
-	return modes[mode-65];
+	SetModeParam(mode->GetModeChar(), parameter);
 }
 
 std::string Channel::GetModeParameter(char mode)
@@ -66,31 +71,36 @@ std::string Channel::GetModeParameter(char mode)
 	return "";
 }
 
+std::string Channel::GetModeParameter(ModeHandler* mode)
+{
+	CustomModeList::iterator n = custom_mode_params.find(mode->GetModeChar());
+	if (n != custom_mode_params.end())
+		return n->second;
+	return "";
+}
+
 int Channel::SetTopic(User *u, std::string &ntopic, bool forceset)
 {
-	if (u && IS_LOCAL(u))
+	if (!u)
+		u = ServerInstance->FakeClient;
+	if (IS_LOCAL(u) && !forceset)
 	{
-		if(!forceset)
-		{
-			int MOD_RESULT = 0;
-			/* 0: check status, 1: don't, -1: disallow change silently */
-
-			FOREACH_RESULT(I_OnLocalTopicChange,OnLocalTopicChange(u,this,ntopic));
+		ModResult res;
+		FIRST_MOD_RESULT(OnPreTopicChange, res, (u,this,ntopic));
 
-			if (MOD_RESULT == 1)
+		if (res == MOD_RES_DENY)
+			return CMD_FAILURE;
+		if (res != MOD_RES_ALLOW)
+		{
+			if (!this->HasUser(u))
+			{
+				u->WriteNumeric(442, "%s %s :You're not on that channel!",u->nick.c_str(), this->name.c_str());
 				return CMD_FAILURE;
-			else if (MOD_RESULT == 0)
+			}
+			if (IsModeSet('t') && !ServerInstance->OnCheckExemption(u,this,"topiclock").check(GetPrefixValue(u) >= HALFOP_VALUE))
 			{
-				if (!this->HasUser(u))
-				{
-					u->WriteNumeric(442, "%s %s :You're not on that channel!",u->nick.c_str(), this->name.c_str());
-					return CMD_FAILURE;
-				}
-				if ((this->IsModeSet('t')) && (this->GetStatus(u) < STATUS_HOP))
-				{
-					u->WriteNumeric(482, "%s %s :You must be at least a half-operator to change the topic on this channel", u->nick.c_str(), this->name.c_str());
-					return CMD_FAILURE;
-				}
+				u->WriteNumeric(482, "%s %s :You do not have access to change the topic on this channel", u->nick.c_str(), this->name.c_str());
+				return CMD_FAILURE;
 			}
 		}
 	}
@@ -109,113 +119,73 @@ int Channel::SetTopic(User *u, std::string &ntopic, bool forceset)
 
 	this->topicset = ServerInstance->Time();
 
-	if (u && IS_LOCAL(u))
-	{
-		FOREACH_MOD(I_OnPostLocalTopicChange,OnPostLocalTopicChange(u, this, this->topic));
-	}
+	FOREACH_MOD(I_OnPostTopicChange,OnPostTopicChange(u, this, this->topic));
 
 	return CMD_SUCCESS;
 }
 
 long Channel::GetUserCounter()
 {
-	return (this->internal_userlist.size());
-}
-
-void Channel::AddUser(User* user)
-{
-	internal_userlist[user] = user->nick;
-}
-
-unsigned long Channel::DelUser(User* user)
-{
-	CUListIter a = internal_userlist.find(user);
-
-	if (a != internal_userlist.end())
-	{
-		internal_userlist.erase(a);
-		/* And tidy any others... */
-		DelOppedUser(user);
-		DelHalfoppedUser(user);
-		DelVoicedUser(user);
-	}
-
-	return internal_userlist.size();
-}
-
-bool Channel::HasUser(User* user)
-{
-	return (internal_userlist.find(user) != internal_userlist.end());
-}
-
-void Channel::AddOppedUser(User* user)
-{
-	internal_op_userlist[user] = user->nick;
-}
-
-void Channel::DelOppedUser(User* user)
-{
-	CUListIter a = internal_op_userlist.find(user);
-	if (a != internal_op_userlist.end())
-	{
-		internal_op_userlist.erase(a);
-		return;
-	}
+	return userlist.size();
 }
 
-void Channel::AddHalfoppedUser(User* user)
+Membership* Channel::AddUser(User* user)
 {
-	internal_halfop_userlist[user] = user->nick;
+	Membership* memb = new Membership(user, this);
+	userlist[user] = memb;
+	return memb;
 }
 
-void Channel::DelHalfoppedUser(User* user)
+void Channel::DelUser(User* user)
 {
-	CUListIter a = internal_halfop_userlist.find(user);
+	UserMembIter a = userlist.find(user);
 
-	if (a != internal_halfop_userlist.end())
+	if (a != userlist.end())
 	{
-		internal_halfop_userlist.erase(a);
+		a->second->cull();
+		delete a->second;
+		userlist.erase(a);
 	}
-}
-
-void Channel::AddVoicedUser(User* user)
-{
-	internal_voice_userlist[user] = user->nick;
-}
-
-void Channel::DelVoicedUser(User* user)
-{
-	CUListIter a = internal_voice_userlist.find(user);
 
-	if (a != internal_voice_userlist.end())
+	if (userlist.empty())
 	{
-		internal_voice_userlist.erase(a);
+		ModResult res;
+		FIRST_MOD_RESULT(OnChannelPreDelete, res, (this));
+		if (res == MOD_RES_DENY)
+			return;
+		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
+		/* kill the record */
+		if (iter != ServerInstance->chanlist->end())
+		{
+			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
+			ServerInstance->chanlist->erase(iter);
+		}
+		ServerInstance->GlobalCulls.AddItem(this);
 	}
 }
 
-CUList* Channel::GetUsers()
-{
-	return &internal_userlist;
-}
-
-CUList* Channel::GetOppedUsers()
+bool Channel::HasUser(User* user)
 {
-	return &internal_op_userlist;
+	return (userlist.find(user) != userlist.end());
 }
 
-CUList* Channel::GetHalfoppedUsers()
+Membership* Channel::GetUser(User* user)
 {
-	return &internal_halfop_userlist;
+	UserMembIter i = userlist.find(user);
+	if (i == userlist.end())
+		return NULL;
+	return i->second;
 }
 
-CUList* Channel::GetVoicedUsers()
+const UserMembList* Channel::GetUsers()
 {
-	return &internal_voice_userlist;
+	return &userlist;
 }
 
 void Channel::SetDefaultModes()
 {
-	ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s", ServerInstance->Config->DefaultModes);
+	ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s",
+		ServerInstance->Config->DefaultModes.c_str());
 	irc::spacesepstream list(ServerInstance->Config->DefaultModes);
 	std::string modeseq;
 	std::string parameter;
@@ -241,14 +211,13 @@ void Channel::SetDefaultModes()
  * add a channel to a user, creating the record for it if needed and linking
  * it to the user record
  */
-Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS)
+Channel* Channel::JoinUser(User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS)
 {
 	// Fix: unregistered users could be joined using /SAJOIN
 	if (!user || !cn || user->registered != REG_ALL)
 		return NULL;
 
 	char cname[MAXBUF];
-	int MOD_RESULT = 0;
 	std::string privs;
 	Channel *Ptr;
 
@@ -260,30 +229,29 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 	 */
 	if (IS_LOCAL(user) && !override)
 	{
-		// Checking MyClass exists because we *may* get here with NULL, not 100% sure.
-		if (user->MyClass && user->MyClass->maxchans)
+		if (user->HasPrivPermission("channels/high-join-limit"))
 		{
-			if (user->HasPrivPermission("channels/high-join-limit"))
+			if (user->chans.size() >= ServerInstance->Config->OperMaxChans)
 			{
-				if (user->chans.size() >= Instance->Config->OperMaxChans)
-				{
-					user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
-					return NULL;
-				}
+				user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
+				return NULL;
 			}
-			else
+		}
+		else
+		{
+			unsigned int maxchans = user->GetClass()->maxchans;
+			if (!maxchans)
+				maxchans = ServerInstance->Config->MaxChans;
+			if (user->chans.size() >= maxchans)
 			{
-				if (user->chans.size() >= user->MyClass->maxchans)
-				{
-					user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
-					return NULL;
-				}
+				user->WriteNumeric(ERR_TOOMANYCHANNELS, "%s %s :You are on too many channels",user->nick.c_str(), cn);
+				return NULL;
 			}
 		}
 	}
 
-	strlcpy(cname, cn, Instance->Config->Limits.ChanMax);
-	Ptr = Instance->FindChan(cname);
+	strlcpy(cname, cn, ServerInstance->Config->Limits.ChanMax);
+	Ptr = ServerInstance->FindChan(cname);
 	bool created_by_local = false;
 
 	if (!Ptr)
@@ -294,23 +262,23 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 		if (!IS_LOCAL(user))
 		{
 			if (!TS)
-				Instance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick.c_str(), cn);
+				ServerInstance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick.c_str(), cn);
 		}
 		else
 		{
-			privs = "@";
+			privs = "o";
 			created_by_local = true;
 		}
 
 		if (IS_LOCAL(user) && override == false)
 		{
-			MOD_RESULT = 0;
-			FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, NULL, cname, privs, key ? key : ""));
-			if (MOD_RESULT == 1)
+			ModResult MOD_RESULT;
+			FIRST_MOD_RESULT(OnUserPreJoin, MOD_RESULT, (user, NULL, cname, privs, key ? key : ""));
+			if (MOD_RESULT == MOD_RES_DENY)
 				return NULL;
 		}
 
-		Ptr = new Channel(Instance, cname, TS);
+		Ptr = new Channel(cname, TS);
 	}
 	else
 	{
@@ -324,60 +292,47 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 		 */
 		if (IS_LOCAL(user) && override == false)
 		{
-			MOD_RESULT = 0;
-			FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, Ptr, cname, privs, key ? key : ""));
-			if (MOD_RESULT == 1)
+			ModResult MOD_RESULT;
+			FIRST_MOD_RESULT(OnUserPreJoin, MOD_RESULT, (user, Ptr, cname, privs, key ? key : ""));
+			if (MOD_RESULT == MOD_RES_DENY)
 			{
 				return NULL;
 			}
-			else if (MOD_RESULT == 0)
+			else if (MOD_RESULT == MOD_RES_PASSTHRU)
 			{
 				std::string ckey = Ptr->GetModeParameter('k');
-				bool invited = user->IsInvited(Ptr->name.c_str());
-				bool can_bypass = Instance->Config->InvBypassModes && invited;
+				bool invited = IS_LOCAL(user)->IsInvited(Ptr->name.c_str());
+				bool can_bypass = ServerInstance->Config->InvBypassModes && invited;
 
 				if (!ckey.empty())
 				{
-					MOD_RESULT = 0;
-					FOREACH_RESULT_I(Instance, I_OnCheckKey, OnCheckKey(user, Ptr, key ? key : ""));
-					if (!MOD_RESULT)
+					FIRST_MOD_RESULT(OnCheckKey, MOD_RESULT, (user, Ptr, key ? key : ""));
+					if (!MOD_RESULT.check((key && ckey == key) || can_bypass))
 					{
 						// If no key provided, or key is not the right one, and can't bypass +k (not invited or option not enabled)
-						if ((!key || ckey != key) && !can_bypass)
-						{
-							user->WriteNumeric(ERR_BADCHANNELKEY, "%s %s :Cannot join channel (Incorrect channel key)",user->nick.c_str(), Ptr->name.c_str());
-							return NULL;
-						}
+						user->WriteNumeric(ERR_BADCHANNELKEY, "%s %s :Cannot join channel (Incorrect channel key)",user->nick.c_str(), Ptr->name.c_str());
+						return NULL;
 					}
 				}
 
 				if (Ptr->IsModeSet('i'))
 				{
-					MOD_RESULT = 0;
-					FOREACH_RESULT_I(Instance,I_OnCheckInvite,OnCheckInvite(user, Ptr));
-					if (!MOD_RESULT)
+					FIRST_MOD_RESULT(OnCheckInvite, MOD_RESULT, (user, Ptr));
+					if (!MOD_RESULT.check(invited))
 					{
-						if (!invited)
-						{
-							user->WriteNumeric(ERR_INVITEONLYCHAN, "%s %s :Cannot join channel (Invite only)",user->nick.c_str(), Ptr->name.c_str());
-							return NULL;
-						}
+						user->WriteNumeric(ERR_INVITEONLYCHAN, "%s %s :Cannot join channel (Invite only)",user->nick.c_str(), Ptr->name.c_str());
+						return NULL;
 					}
 				}
 
 				std::string limit = Ptr->GetModeParameter('l');
 				if (!limit.empty())
 				{
-					MOD_RESULT = 0;
-					FOREACH_RESULT_I(Instance, I_OnCheckLimit, OnCheckLimit(user, Ptr));
-					if (!MOD_RESULT)
+					FIRST_MOD_RESULT(OnCheckLimit, MOD_RESULT, (user, Ptr));
+					if (!MOD_RESULT.check((Ptr->GetUserCounter() < atol(limit.c_str()) || can_bypass)))
 					{
-						long llimit = atol(limit.c_str());
-						if (Ptr->GetUserCounter() >= llimit && !can_bypass)
-						{
-							user->WriteNumeric(ERR_CHANNELISFULL, "%s %s :Cannot join channel (Channel is full)",user->nick.c_str(), Ptr->name.c_str());
-							return NULL;
-						}
+						user->WriteNumeric(ERR_CHANNELISFULL, "%s %s :Cannot join channel (Channel is full)",user->nick.c_str(), Ptr->name.c_str());
+						return NULL;
 					}
 				}
 
@@ -393,7 +348,7 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 				 */
 				if (invited)
 				{
-					user->RemoveInvite(Ptr->name.c_str());
+					IS_LOCAL(user)->RemoveInvite(Ptr->name.c_str());
 				}
 			}
 		}
@@ -405,60 +360,40 @@ Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool
 		Ptr->SetDefaultModes();
 	}
 
-	return Channel::ForceChan(Instance, Ptr, user, privs, bursting, created_by_local);
+	return Channel::ForceChan(Ptr, user, privs, bursting, created_by_local);
 }
 
-Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const std::string &privs, bool bursting, bool created)
+Channel* Channel::ForceChan(Channel* Ptr, User* user, const std::string &privs, bool bursting, bool created)
 {
 	std::string nick = user->nick;
-	bool silent = false;
-
-	Ptr->AddUser(user);
 
-	/* Just in case they have no permissions */
-	user->chans[Ptr] = 0;
+	Membership* memb = Ptr->AddUser(user);
+	user->chans.insert(Ptr);
 
 	for (std::string::const_iterator x = privs.begin(); x != privs.end(); x++)
 	{
 		const char status = *x;
-		ModeHandler* mh = Instance->Modes->FindPrefix(status);
+		ModeHandler* mh = ServerInstance->Modes->FindMode(status, MODETYPE_CHANNEL);
 		if (mh)
 		{
 			/* Set, and make sure that the mode handler knows this mode was now set */
-			Ptr->SetPrefix(user, status, mh->GetPrefixRank(), true);
-			mh->OnModeChange(Instance->FakeClient, Instance->FakeClient, Ptr, nick, true);
-
-			switch (mh->GetPrefix())
-			{
-				/* These logic ops are SAFE IN THIS CASE because if the entry doesnt exist,
-				 * addressing operator[] creates it. If they do exist, it points to it.
-				 * At all other times where we dont want to create an item if it doesnt exist, we
-				 * must stick to ::find().
-				 */
-				case '@':
-					user->chans[Ptr] |= UCMODE_OP;
-				break;
-				case '%':
-					user->chans[Ptr] |= UCMODE_HOP;
-				break;
-				case '+':
-					user->chans[Ptr] |= UCMODE_VOICE;
-				break;
-			}
+			Ptr->SetPrefix(user, mh->GetModeChar(), true);
+			mh->OnModeChange(ServerInstance->FakeClient, ServerInstance->FakeClient, Ptr, nick, true);
 		}
 	}
 
-	FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, bursting, silent, created));
+	CUList except_list;
+	FOREACH_MOD(I_OnUserJoin,OnUserJoin(memb, bursting, created, except_list));
 
-	if (!silent)
-		Ptr->WriteChannel(user,"JOIN :%s",Ptr->name.c_str());
+	Ptr->WriteAllExcept(user, false, 0, except_list, "JOIN :%s", Ptr->name.c_str());
 
 	/* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */
-	std::string ms = Instance->Modes->ModeString(user, Ptr);
+	std::string ms = memb->modes;
+	for(unsigned int i=0; i < memb->modes.length(); i++)
+		ms.append(" ").append(user->nick);
 	if ((Ptr->GetUserCounter() > 1) && (ms.length()))
-		Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name.c_str(), ms.c_str());
+		Ptr->WriteAllExceptSender(user, ServerInstance->Config->CycleHostsFromUser, 0, "MODE %s +%s", Ptr->name.c_str(), ms.c_str());
 
-	/* Major improvement by Brain - we dont need to be calculating all this pointlessly for remote users */
 	if (IS_LOCAL(user))
 	{
 		if (Ptr->topicset)
@@ -468,218 +403,158 @@ Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const
 		}
 		Ptr->UserList(user);
 	}
-	FOREACH_MOD_I(Instance,I_OnPostJoin,OnPostJoin(user, Ptr));
+	FOREACH_MOD(I_OnPostJoin,OnPostJoin(memb));
 	return Ptr;
 }
 
 bool Channel::IsBanned(User* user)
 {
-	int result = 0;
-	DO_EACH_HOOK(ServerInstance, OnCheckBan, int modresult, (user, this))
-	{
-		result = banmatch_reduce(result, modresult);
-	}
-	WHILE_EACH_HOOK(ServerInstance, OnCheckBan);
+	ModResult result;
+	FIRST_MOD_RESULT(OnCheckChannelBan, result, (user, this));
 
-	if (result)
-		return (result < 0);
+	if (result != MOD_RES_PASSTHRU)
+		return (result == MOD_RES_DENY);
 
-	char mask[MAXBUF];
-	snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString());
 	for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
 	{
-		if ((InspIRCd::Match(user->GetFullHost(),i->data, NULL)) || // host
-			(InspIRCd::Match(user->GetFullRealHost(),i->data, NULL)) || // uncloaked host
-			(InspIRCd::MatchCIDR(mask, i->data, NULL))) // ip
-		{
+		if (CheckBan(user, i->data))
 			return true;
-		}
 	}
 	return false;
 }
 
-int Channel::GetExtBanStatus(const std::string &str, char type)
+bool Channel::CheckBan(User* user, const std::string& mask)
 {
-	int result = 0;
-	DO_EACH_HOOK(ServerInstance, OnCheckStringExtBan, int modresult, (str, this, type))
-	{
-		result = banmatch_reduce(result, modresult);
-	}
-	WHILE_EACH_HOOK(ServerInstance, OnCheckStringExtBan);
-
-	if (result)
-		return result;
+	ModResult result;
+	FIRST_MOD_RESULT(OnCheckBan, result, (user, this, mask));
+	if (result != MOD_RES_PASSTHRU)
+		return (result == MOD_RES_DENY);
 
-	// nobody decided for us, check the ban list
-	for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
-	{
-		if (i->data[0] != type || i->data[1] != ':')
-			continue;
+	// extbans were handled above, if this is one it obviously didn't match
+	if (mask[1] == ':')
+		return false;
 
-		std::string maskptr = i->data.substr(2);
-		ServerInstance->Logs->Log("EXTBANS", DEBUG, "Checking %s against %s, type is %c", str.c_str(), maskptr.c_str(), type);
+	std::string::size_type at = mask.find('@');
+	if (at == std::string::npos)
+		return false;
 
-		if (InspIRCd::Match(str, maskptr, NULL))
-			return -1;
+	char tomatch[MAXBUF];
+	snprintf(tomatch, MAXBUF, "%s!%s", user->nick.c_str(), user->ident.c_str());
+	std::string prefix = mask.substr(0, at);
+	if (InspIRCd::Match(tomatch, prefix, NULL))
+	{
+		std::string suffix = mask.substr(at + 1);
+		if (InspIRCd::Match(user->host, suffix, NULL) ||
+			InspIRCd::Match(user->dhost, suffix, NULL) ||
+			InspIRCd::MatchCIDR(user->GetIPString(), suffix, NULL))
+			return true;
 	}
-
-	return 0;
+	return false;
 }
 
-int Channel::GetExtBanStatus(User *user, char type)
+ModResult Channel::GetExtBanStatus(User *user, char type)
 {
-	int result = 0;
-	DO_EACH_HOOK(ServerInstance, OnCheckExtBan, int modresult, (user, this, type))
+	ModResult rv;
+	FIRST_MOD_RESULT(OnExtBanCheck, rv, (user, this, type));
+	if (rv != MOD_RES_PASSTHRU)
+		return rv;
+	for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
 	{
-		result = banmatch_reduce(result, modresult);
+		if (i->data[0] == type && i->data[1] == ':')
+		{
+			std::string val = i->data.substr(2);
+			if (CheckBan(user, val))
+				return MOD_RES_DENY;
+		}
 	}
-	WHILE_EACH_HOOK(ServerInstance, OnCheckExtBan);
-
-	if (result)
-		return result;
-
-	char mask[MAXBUF];
-	int rv = 0;
-	snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString());
-
-	// XXX: we should probably hook cloaked hosts in here somehow too..
-	rv = banmatch_reduce(rv, this->GetExtBanStatus(mask, type));
-	rv = banmatch_reduce(rv, this->GetExtBanStatus(user->GetFullHost(), type));
-	rv = banmatch_reduce(rv, this->GetExtBanStatus(user->GetFullRealHost(), type));
-	return rv;
+	return MOD_RES_PASSTHRU;
 }
 
 /* Channel::PartUser
  * remove a channel from a users record, and return the number of users left.
  * Therefore, if this function returns 0 the caller should delete the Channel.
  */
-long Channel::PartUser(User *user, std::string &reason)
+void Channel::PartUser(User *user, std::string &reason)
 {
-	bool silent = false;
-
 	if (!user)
-		return this->GetUserCounter();
+		return;
+
+	Membership* memb = GetUser(user);
 
-	UCListIter i = user->chans.find(this);
-	if (i != user->chans.end())
+	if (memb)
 	{
-		FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason, silent));
+		CUList except_list;
+		FOREACH_MOD(I_OnUserPart,OnUserPart(memb, reason, except_list));
 
-		if (!silent)
-			this->WriteChannel(user, "PART %s%s%s", this->name.c_str(), reason.empty() ? "" : " :", reason.c_str());
+		WriteAllExcept(user, false, 0, except_list, "PART %s%s%s", this->name.c_str(), reason.empty() ? "" : " :", reason.c_str());
 
-		user->chans.erase(i);
+		user->chans.erase(this);
 		this->RemoveAllPrefixes(user);
 	}
 
-	if (!this->DelUser(user)) /* if there are no users left on the channel... */
-	{
-		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
-		/* kill the record */
-		if (iter != ServerInstance->chanlist->end())
-		{
-			int MOD_RESULT = 0;
-			FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this));
-			if (MOD_RESULT == 1)
-				return 1; // delete halted by module
-			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
-			ServerInstance->chanlist->erase(iter);
-		}
-		return 0;
-	}
-
-	return this->GetUserCounter();
-}
-
-long Channel::ServerKickUser(User* user, const char* reason, const char* servername)
-{
-	if (servername == NULL || *ServerInstance->Config->HideWhoisServer)
-		servername = ServerInstance->Config->ServerName;
-
-	ServerInstance->FakeClient->server = servername;
-	return this->KickUser(ServerInstance->FakeClient, user, reason);
+	this->DelUser(user);
 }
 
-long Channel::KickUser(User *src, User *user, const char* reason)
+void Channel::KickUser(User *src, User *user, const char* reason)
 {
-	bool silent = false;
-
 	if (!src || !user || !reason)
-		return this->GetUserCounter();
+		return;
 
+	Membership* memb = GetUser(user);
 	if (IS_LOCAL(src))
 	{
-		if (!this->HasUser(user))
+		if (!memb)
 		{
 			src->WriteNumeric(ERR_USERNOTINCHANNEL, "%s %s %s :They are not on that channel",src->nick.c_str(), user->nick.c_str(), this->name.c_str());
-			return this->GetUserCounter();
+			return;
 		}
 		if ((ServerInstance->ULine(user->server)) && (!ServerInstance->ULine(src->server)))
 		{
 			src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s %s :Only a u-line may kick a u-line from a channel.",src->nick.c_str(), this->name.c_str());
-			return this->GetUserCounter();
+			return;
 		}
-		int MOD_RESULT = 0;
 
-		if (!ServerInstance->ULine(src->server))
-		{
-			MOD_RESULT = 0;
-			FOREACH_RESULT(I_OnUserPreKick,OnUserPreKick(src,user,this,reason));
-			if (MOD_RESULT == 1)
-				return this->GetUserCounter();
-		}
-		/* Set to -1 by OnUserPreKick if explicit allow was set */
-		if (MOD_RESULT != -1)
+		ModResult res;
+		if (ServerInstance->ULine(src->server))
+			res = MOD_RES_ALLOW;
+		else
+			FIRST_MOD_RESULT(OnUserPreKick, res, (src,memb,reason));
+
+		if (res == MOD_RES_DENY)
+			return;
+
+		if (res == MOD_RES_PASSTHRU)
 		{
-			FOREACH_RESULT(I_OnAccessCheck,OnAccessCheck(src,user,this,AC_KICK));
-			if ((MOD_RESULT == ACR_DENY) && (!ServerInstance->ULine(src->server)))
-				return this->GetUserCounter();
+			unsigned int them = this->GetPrefixValue(src);
+			unsigned int req = HALFOP_VALUE;
+			for (std::string::size_type i = 0; i < memb->modes.length(); i++)
+			{
+				ModeHandler* mh = ServerInstance->Modes->FindMode(memb->modes[i], MODETYPE_CHANNEL);
+				if (mh && mh->GetLevelRequired() > req)
+					req = mh->GetLevelRequired();
+			}
 
-			if ((MOD_RESULT == ACR_DEFAULT) || (!ServerInstance->ULine(src->server)))
+			if (them < req)
 			{
-				int them = this->GetStatus(src);
-				int us = this->GetStatus(user);
-   			 	if ((them < STATUS_HOP) || (them < us))
-				{
-					src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s %s :You must be a channel %soperator",src->nick.c_str(), this->name.c_str(), them == STATUS_HOP ? "" : "half-");
-					return this->GetUserCounter();
-				}
+				src->WriteNumeric(ERR_CHANOPRIVSNEEDED, "%s %s :You must be a channel %soperator",
+					src->nick.c_str(), this->name.c_str(), req > HALFOP_VALUE ? "" : "half-");
+				return;
 			}
 		}
 	}
 
-	FOREACH_MOD(I_OnUserKick,OnUserKick(src, user, this, reason, silent));
-
-	UCListIter i = user->chans.find(this);
-	if (i != user->chans.end())
+	if (memb)
 	{
-		/* zap it from the channel list of the user */
-		if (!silent)
-			this->WriteChannel(src, "KICK %s %s :%s", this->name.c_str(), user->nick.c_str(), reason);
+		CUList except_list;
+		FOREACH_MOD(I_OnUserKick,OnUserKick(src, memb, reason, except_list));
 
-		user->chans.erase(i);
-		this->RemoveAllPrefixes(user);
-	}
-
-	if (!this->DelUser(user))
-	/* if there are no users left on the channel */
-	{
-		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name.c_str());
+		WriteAllExcept(src, false, 0, except_list, "KICK %s %s :%s", name.c_str(), user->nick.c_str(), reason);
 
-		/* kill the record */
-		if (iter != ServerInstance->chanlist->end())
-		{
-			int MOD_RESULT = 0;
-			FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this));
-			if (MOD_RESULT == 1)
-				return 1; // delete halted by module
-			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
-			ServerInstance->chanlist->erase(iter);
-		}
-		return 0;
+		user->chans.erase(this);
+		this->RemoveAllPrefixes(user);
 	}
 
-	return this->GetUserCounter();
+	this->DelUser(user);
 }
 
 void Channel::WriteChannel(User* user, const char* text, ...)
@@ -699,7 +574,6 @@ void Channel::WriteChannel(User* user, const char* text, ...)
 
 void Channel::WriteChannel(User* user, const std::string &text)
 {
-	CUList *ulist = this->GetUsers();
 	char tb[MAXBUF];
 
 	if (!user)
@@ -708,14 +582,14 @@ void Channel::WriteChannel(User* user, const std::string &text)
 	snprintf(tb,MAXBUF,":%s %s", user->GetFullHost().c_str(), text.c_str());
 	std::string out = tb;
 
-	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+	for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
 	{
 		if (IS_LOCAL(i->first))
 			i->first->Write(out);
 	}
 }
 
-void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...)
+void Channel::WriteChannelWithServ(const std::string& ServName, const char* text, ...)
 {
 	char textbuffer[MAXBUF];
 	va_list argsPtr;
@@ -730,15 +604,14 @@ void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...)
 	this->WriteChannelWithServ(ServName, std::string(textbuffer));
 }
 
-void Channel::WriteChannelWithServ(const char* ServName, const std::string &text)
+void Channel::WriteChannelWithServ(const std::string& ServName, const std::string &text)
 {
-	CUList *ulist = this->GetUsers();
 	char tb[MAXBUF];
 
-	snprintf(tb,MAXBUF,":%s %s", ServName ? ServName : ServerInstance->Config->ServerName, text.c_str());
+	snprintf(tb,MAXBUF,":%s %s", ServName.empty() ? ServerInstance->Config->ServerName.c_str() : ServName.c_str(), text.c_str());
 	std::string out = tb;
 
-	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+	for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
 	{
 		if (IS_LOCAL(i->first))
 			i->first->Write(out);
@@ -770,33 +643,43 @@ void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList
 	if (!text)
 		return;
 
+	int offset = snprintf(textbuffer,MAXBUF,":%s ", user->GetFullHost().c_str());
+
 	va_start(argsPtr, text);
-	vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+	vsnprintf(textbuffer + offset, MAXBUF - offset, text, argsPtr);
 	va_end(argsPtr);
 
-	this->WriteAllExcept(user, serversource, status, except_list, std::string(textbuffer));
+	this->RawWriteAllExcept(user, serversource, status, except_list, std::string(textbuffer));
 }
 
 void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const std::string &text)
 {
-	CUList *ulist = this->GetUsers();
 	char tb[MAXBUF];
 
-	snprintf(tb,MAXBUF,":%s %s", user->GetFullHost().c_str(), text.c_str());
+	snprintf(tb,MAXBUF,":%s %s", serversource ? ServerInstance->Config->ServerName.c_str() : user->GetFullHost().c_str(), text.c_str());
 	std::string out = tb;
 
-	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+	this->RawWriteAllExcept(user, serversource, status, except_list, std::string(tb));
+}
+
+void Channel::RawWriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const std::string &out)
+{
+	unsigned int minrank = 0;
+	if (status)
 	{
-		if ((IS_LOCAL(i->first)) && (except_list.find(i->first) == except_list.end()))
+		ModeHandler* mh = ServerInstance->Modes->FindPrefix(status);
+		if (mh)
+			minrank = mh->GetPrefixRank();
+	}
+	for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
+	{
+		if (IS_LOCAL(i->first) && (except_list.find(i->first) == except_list.end()))
 		{
-			/* User doesnt have the status we're after */
-			if (status && !strchr(this->GetAllPrefixChars(i->first), status))
+			/* User doesn't have the status we're after */
+			if (minrank && i->second->getRank() < minrank)
 				continue;
 
-			if (serversource)
-				i->first->WriteServ(text);
-			else
-				i->first->Write(out);
+			i->first->Write(out);
 		}
 	}
 }
@@ -804,7 +687,7 @@ void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList
 void Channel::WriteAllExceptSender(User* user, bool serversource, char status, const std::string& text)
 {
 	CUList except_list;
-	except_list[user] = user->nick;
+	except_list.insert(user);
 	this->WriteAllExcept(user, serversource, status, except_list, std::string(text));
 }
 
@@ -815,8 +698,7 @@ void Channel::WriteAllExceptSender(User* user, bool serversource, char status, c
 int Channel::CountInvisible()
 {
 	int count = 0;
-	CUList *ulist= this->GetUsers();
-	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+	for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
 	{
 		if (!(i->first->IsModeSet('i')))
 			count++;
@@ -842,30 +724,13 @@ char* Channel::ChanModes(bool showkey)
 		{
 			*offset++ = n + 65;
 			extparam.clear();
-			switch (n)
+			if (n == 'k' - 65 && !showkey)
 			{
-				case CM_KEY:
-					// Unfortunately this must be special-cased, as we definitely don't want to always display key.
-					if (showkey)
-					{
-						extparam = this->GetModeParameter('k');
-					}
-					else
-					{
-						extparam = "<key>";
-					}
-					break;
-				case CM_NOEXTERNAL:
-				case CM_TOPICLOCK:
-				case CM_INVITEONLY:
-				case CM_MODERATED:
-				case CM_SECRET:
-				case CM_PRIVATE:
-					/* We know these have no parameters */
-				break;
-				default:
-					extparam = this->GetModeParameter(n + 65);
-				break;
+				extparam = "<key>";
+			}
+			else
+			{
+				extparam = this->GetModeParameter(n + 65);
 			}
 			if (!extparam.empty())
 			{
@@ -884,27 +749,18 @@ char* Channel::ChanModes(bool showkey)
 /* compile a userlist of a channel into a string, each nick seperated by
  * spaces and op, voice etc status shown as @ and +, and send it to 'user'
  */
-void Channel::UserList(User *user, CUList *ulist)
+void Channel::UserList(User *user)
 {
 	char list[MAXBUF];
 	size_t dlen, curlen;
-	int MOD_RESULT = 0;
-	bool call_modules = true;
 
 	if (!IS_LOCAL(user))
 		return;
 
-	FOREACH_RESULT(I_OnUserList,OnUserList(user, this, ulist));
-	if (MOD_RESULT == 1)
-		call_modules = false;
-
-	if (MOD_RESULT != -1)
+	if (this->IsModeSet('s') && !this->HasUser(user) && !user->HasPrivPermission("channels/auspex"))
 	{
-		if ((this->IsModeSet('s')) && (!this->HasUser(user)))
-		{
-			user->WriteNumeric(ERR_NOSUCHNICK, "%s %s :No such nick/channel",user->nick.c_str(), this->name.c_str());
-			return;
-		}
+		user->WriteNumeric(ERR_NOSUCHNICK, "%s %s :No such nick/channel",user->nick.c_str(), this->name.c_str());
+		return;
 	}
 
 	dlen = curlen = snprintf(list,MAXBUF,"%s %c %s :", user->nick.c_str(), this->IsModeSet('s') ? '@' : this->IsModeSet('p') ? '*' : '=',  this->name.c_str());
@@ -912,15 +768,12 @@ void Channel::UserList(User *user, CUList *ulist)
 	int numusers = 0;
 	char* ptr = list + dlen;
 
-	if (!ulist)
-		ulist = this->GetUsers();
-
 	/* Improvement by Brain - this doesnt change in value, so why was it inside
 	 * the loop?
 	 */
 	bool has_user = this->HasUser(user);
 
-	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+	for (UserMembIter i = userlist.begin(); i != userlist.end(); i++)
 	{
 		if ((!has_user) && (i->first->IsModeSet('i')))
 		{
@@ -931,20 +784,14 @@ void Channel::UserList(User *user, CUList *ulist)
 			continue;
 		}
 
-		if (i->first->Visibility && !i->first->Visibility->VisibleTo(user))
-			continue;
-
 		std::string prefixlist = this->GetPrefixChar(i->first);
 		std::string nick = i->first->nick;
 
-		if (call_modules)
-		{
-			FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->first, this, prefixlist, nick));
+		FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->second, prefixlist, nick));
 
-			/* Nick was nuked, a module wants us to skip it */
-			if (nick.empty())
-				continue;
-		}
+		/* Nick was nuked, a module wants us to skip it */
+		if (nick.empty())
+			continue;
 
 		size_t ptrlen = 0;
 
@@ -1011,42 +858,55 @@ void Channel::ResetMaxBans()
 const char* Channel::GetPrefixChar(User *user)
 {
 	static char pf[2] = {0, 0};
+	*pf = 0;
+	unsigned int bestrank = 0;
 
-	prefixlist::iterator n = prefixes.find(user);
-	if (n != prefixes.end())
+	UserMembIter m = userlist.find(user);
+	if (m != userlist.end())
 	{
-		if (n->second.size())
+		for(unsigned int i=0; i < m->second->modes.length(); i++)
 		{
-			/* If the user has any prefixes, their highest prefix
-			 * will always be at the head of the list, as the list is
-			 * sorted in rank order highest first (see SetPrefix()
-			 * for reasons why)
-			 */
-			*pf = n->second.begin()->first;
-			return pf;
+			char mchar = m->second->modes[i];
+			ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+			if (mh && mh->GetPrefixRank() > bestrank && mh->GetPrefix())
+			{
+				bestrank = mh->GetPrefixRank();
+				pf[0] = mh->GetPrefix();
+			}
 		}
 	}
-
-	*pf = 0;
 	return pf;
 }
 
+unsigned int Membership::getRank()
+{
+	char mchar = modes.c_str()[0];
+	unsigned int rv = 0;
+	if (mchar)
+	{
+		ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+		if (mh)
+			rv = mh->GetPrefixRank();
+	}
+	return rv;
+}
 
 const char* Channel::GetAllPrefixChars(User* user)
 {
-	static char prefix[MAXBUF];
+	static char prefix[64];
 	int ctr = 0;
-	*prefix = 0;
 
-	prefixlist::iterator n = prefixes.find(user);
-	if (n != prefixes.end())
+	UserMembIter m = userlist.find(user);
+	if (m != userlist.end())
 	{
-		for (std::vector<prefixtype>::iterator x = n->second.begin(); x != n->second.end(); x++)
+		for(unsigned int i=0; i < m->second->modes.length(); i++)
 		{
-			prefix[ctr++] = x->first;
+			char mchar = m->second->modes[i];
+			ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+			if (mh && mh->GetPrefix())
+				prefix[ctr++] = mh->GetPrefix();
 		}
 	}
-
 	prefix[ctr] = 0;
 
 	return prefix;
@@ -1054,92 +914,43 @@ const char* Channel::GetAllPrefixChars(User* user)
 
 unsigned int Channel::GetPrefixValue(User* user)
 {
-	prefixlist::iterator n = prefixes.find(user);
-	if (n != prefixes.end())
-	{
-		if (n->second.size())
-			return n->second.begin()->second;
-	}
-	return 0;
-}
-
-int Channel::GetStatusFlags(User *user)
-{
-	UCListIter i = user->chans.find(this);
-	if (i != user->chans.end())
-	{
-		return i->second;
-	}
-	return 0;
+	UserMembIter m = userlist.find(user);
+	if (m == userlist.end())
+		return 0;
+	return m->second->getRank();
 }
 
-int Channel::GetStatus(User *user)
+bool Channel::SetPrefix(User* user, char prefix, bool adding)
 {
-	if (ServerInstance->ULine(user->server))
-		return STATUS_OP;
-
-	UCListIter i = user->chans.find(this);
-	if (i != user->chans.end())
+	ModeHandler* delta_mh = ServerInstance->Modes->FindMode(prefix, MODETYPE_CHANNEL);
+	if (!delta_mh)
+		return false;
+	UserMembIter m = userlist.find(user);
+	if (m == userlist.end())
+		return false;
+	for(unsigned int i=0; i < m->second->modes.length(); i++)
 	{
-		if ((i->second & UCMODE_OP) > 0)
-		{
-			return STATUS_OP;
-		}
-		if ((i->second & UCMODE_HOP) > 0)
+		char mchar = m->second->modes[i];
+		ModeHandler* mh = ServerInstance->Modes->FindMode(mchar, MODETYPE_CHANNEL);
+		if (mh && mh->GetPrefixRank() <= delta_mh->GetPrefixRank())
 		{
-			return STATUS_HOP;
+			m->second->modes =
+				m->second->modes.substr(0,i) +
+				(adding ? std::string(1, prefix) : "") +
+				m->second->modes.substr(mchar == prefix ? i+1 : i);
+			return adding != (mchar == prefix);
 		}
-		if ((i->second & UCMODE_VOICE) > 0)
-		{
-			return STATUS_VOICE;
-		}
-		return STATUS_NORMAL;
 	}
-	return STATUS_NORMAL;
-}
-
-void Channel::SetPrefix(User* user, char prefix, unsigned int prefix_value, bool adding)
-{
-	prefixlist::iterator n = prefixes.find(user);
-	prefixtype pfx = std::make_pair(prefix,prefix_value);
 	if (adding)
-	{
-		if (n != prefixes.end())
-		{
-			if (std::find(n->second.begin(), n->second.end(), pfx) == n->second.end())
-			{
-				n->second.push_back(pfx);
-				/* We must keep prefixes in rank order, largest first.
-				 * This is for two reasons, firstly because x-chat *ass-u-me's* this
-				 * state, and secondly it turns out to be a benefit to us later.
-				 * See above in GetPrefix().
-				 */
-				std::sort(n->second.begin(), n->second.end(), ModeParser::PrefixComparison);
-			}
-		}
-		else
-		{
-			pfxcontainer one;
-			one.push_back(pfx);
-			prefixes.insert(std::make_pair<User*,pfxcontainer>(user, one));
-		}
-	}
-	else
-	{
-		if (n != prefixes.end())
-		{
-			pfxcontainer::iterator x = std::find(n->second.begin(), n->second.end(), pfx);
-			if (x != n->second.end())
-				n->second.erase(x);
-		}
-	}
+		m->second->modes += std::string(1, prefix);
+	return adding;
 }
 
 void Channel::RemoveAllPrefixes(User* user)
 {
-	prefixlist::iterator n = prefixes.find(user);
-	if (n != prefixes.end())
+	UserMembIter m = userlist.find(user);
+	if (m != userlist.end())
 	{
-		prefixes.erase(n);
+		m->second->modes.clear();
 	}
 }