X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fchannels.cpp;h=b0de06267ed7c1e81fbdbc5a1b5c16012acfeb04;hb=b3bcd98242b8764f52bcde3259d7bc0ef72f61e3;hp=f340e12bf1528b4edf9a75cc3ddb8aeff0e72129;hpb=d54fd9b1e6b31f69332a9241b5f17330c0ad61e0;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/channels.cpp b/src/channels.cpp
index f340e12bf..b0de06267 100644
--- a/src/channels.cpp
+++ b/src/channels.cpp
@@ -1,38 +1,43 @@
-/*   +------------------------------------+
- *   | Inspire Internet Relay Chat Daemon |
- *   +------------------------------------+
+/*       +------------------------------------+
+ *       | Inspire Internet Relay Chat Daemon |
+ *       +------------------------------------+
+ *
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *   E-mail:
- *   	  <brain@chatspike.net>
- *   	  <Craig@chatspike.net>
- * 
- * Written by Craig Edwards, Craig McLure, and others.
  * This program is free but copyrighted software; see
- *	the file COPYING for details.
+ *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-using namespace std;
+/* $Core: libIRCDchannels */
 
-#include <stdarg.h>
-#include "configreader.h"
 #include "inspircd.h"
-#include "users.h"
-#include "modules.h"
+#include <stdarg.h>
 #include "wildcard.h"
 #include "mode.h"
 
-chanrec::chanrec(InspIRCd* Instance) : ServerInstance(Instance)
+Channel::Channel(InspIRCd* Instance, const std::string &cname, time_t ts) : ServerInstance(Instance)
 {
-	*name = *topic = *setby = *key = 0;
-	created = topicset = limit = 0;
-	internal_userlist.clear();
+	chan_hash::iterator findchan = ServerInstance->chanlist->find(cname);
+	if (findchan != Instance->chanlist->end())
+		throw CoreException("Cannot create duplicate channel " + cname);
+
+	(*(ServerInstance->chanlist))[cname.c_str()] = this;
+	strlcpy(this->name, cname.c_str(), CHANMAX);
+	this->created = ts ? ts : ServerInstance->Time();
+	this->age = this->created;
+
+
+
+
+	*topic = *setby = *key = 0;
+	maxbans = topicset = limit = 0;
 	memset(&modes,0,64);
 }
 
-void chanrec::SetMode(char mode,bool mode_on)
+void Channel::SetMode(char mode,bool mode_on)
 {
 	modes[mode-65] = mode_on;
 	if (!mode_on)
@@ -40,23 +45,14 @@ void chanrec::SetMode(char mode,bool mode_on)
 }
 
 
-void chanrec::SetModeParam(char mode,const char* parameter,bool mode_on)
+void Channel::SetModeParam(char mode,const char* parameter,bool mode_on)
 {
-	ServerInstance->Log(DEBUG,"SetModeParam called");
-	
 	CustomModeList::iterator n = custom_mode_params.find(mode);	
 
 	if (mode_on)
 	{
 		if (n == custom_mode_params.end())
-		{
 			custom_mode_params[mode] = strdup(parameter);
-			ServerInstance->Log(DEBUG,"Custom mode parameter %c %s added",mode,parameter);
-		}
-		else
-		{
-			ServerInstance->Log(DEBUG, "Tried to set custom mode parameter for %c '%s' when it was already '%s'", mode, parameter, n->second);
-		}
 	}
 	else
 	{
@@ -68,43 +64,39 @@ void chanrec::SetModeParam(char mode,const char* parameter,bool mode_on)
 	}
 }
 
-bool chanrec::IsModeSet(char mode)
+bool Channel::IsModeSet(char mode)
 {
 	return modes[mode-65];
 }
 
-std::string chanrec::GetModeParameter(char mode)
+std::string Channel::GetModeParameter(char mode)
 {
-	if (mode == 'k')
-	{
-		return this->key;
-	}
-	else if (mode == 'l')
+	switch (mode)
 	{
-		return ConvToStr(this->limit);
-	}
-	else
-	{
-		CustomModeList::iterator n = custom_mode_params.find(mode);
-		if (n != custom_mode_params.end())
-		{
-			return n->second;
-		}
-		return "";
+		case 'k':
+			return this->key;
+		case 'l':
+			return ConvToStr(this->limit);
+		default:
+			CustomModeList::iterator n = custom_mode_params.find(mode);
+			if (n != custom_mode_params.end())
+				return n->second;
+			return "";
+		break;
 	}
 }
 
-long chanrec::GetUserCounter()
+long Channel::GetUserCounter()
 {
 	return (this->internal_userlist.size());
 }
 
-void chanrec::AddUser(userrec* user)
+void Channel::AddUser(User* user)
 {
-	internal_userlist[user] = user;
+	internal_userlist[user] = user->nick;
 }
 
-unsigned long chanrec::DelUser(userrec* user)
+unsigned long Channel::DelUser(User* user)
 {
 	CUListIter a = internal_userlist.find(user);
 	
@@ -120,17 +112,17 @@ unsigned long chanrec::DelUser(userrec* user)
 	return internal_userlist.size();
 }
 
-bool chanrec::HasUser(userrec* user)
+bool Channel::HasUser(User* user)
 {
 	return (internal_userlist.find(user) != internal_userlist.end());
 }
 
-void chanrec::AddOppedUser(userrec* user)
+void Channel::AddOppedUser(User* user)
 {
-	internal_op_userlist[user] = user;
+	internal_op_userlist[user] = user->nick;
 }
 
-void chanrec::DelOppedUser(userrec* user)
+void Channel::DelOppedUser(User* user)
 {
 	CUListIter a = internal_op_userlist.find(user);
 	if (a != internal_op_userlist.end())
@@ -140,12 +132,12 @@ void chanrec::DelOppedUser(userrec* user)
 	}
 }
 
-void chanrec::AddHalfoppedUser(userrec* user)
+void Channel::AddHalfoppedUser(User* user)
 {
-	internal_halfop_userlist[user] = user;
+	internal_halfop_userlist[user] = user->nick;
 }
 
-void chanrec::DelHalfoppedUser(userrec* user)
+void Channel::DelHalfoppedUser(User* user)
 {
 	CUListIter a = internal_halfop_userlist.find(user);
 
@@ -155,12 +147,12 @@ void chanrec::DelHalfoppedUser(userrec* user)
 	}
 }
 
-void chanrec::AddVoicedUser(userrec* user)
+void Channel::AddVoicedUser(User* user)
 {
-	internal_voice_userlist[user] = user;
+	internal_voice_userlist[user] = user->nick;
 }
 
-void chanrec::DelVoicedUser(userrec* user)
+void Channel::DelVoicedUser(User* user)
 {
 	CUListIter a = internal_voice_userlist.find(user);
 	
@@ -170,69 +162,128 @@ void chanrec::DelVoicedUser(userrec* user)
 	}
 }
 
-CUList* chanrec::GetUsers()
+CUList* Channel::GetUsers()
 {
 	return &internal_userlist;
 }
 
-CUList* chanrec::GetOppedUsers()
+CUList* Channel::GetOppedUsers()
 {
 	return &internal_op_userlist;
 }
 
-CUList* chanrec::GetHalfoppedUsers()
+CUList* Channel::GetHalfoppedUsers()
 {
 	return &internal_halfop_userlist;
 }
 
-CUList* chanrec::GetVoicedUsers()
+CUList* Channel::GetVoicedUsers()
 {
 	return &internal_voice_userlist;
 }
 
+void Channel::SetDefaultModes()
+{
+	ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s", ServerInstance->Config->DefaultModes);
+	irc::spacesepstream list(ServerInstance->Config->DefaultModes);
+	std::string modeseq;
+	std::string parameter;
+
+	list.GetToken(modeseq);
+
+	for (std::string::iterator n = modeseq.begin(); n != modeseq.end(); ++n)
+	{
+		ModeHandler* mode = ServerInstance->Modes->FindMode(*n, MODETYPE_CHANNEL);
+		if (mode)
+		{
+			if (mode->GetNumParams(true))
+				list.GetToken(parameter);
+			else
+				parameter.clear();
+
+			mode->OnModeChange(ServerInstance->FakeClient, ServerInstance->FakeClient, this, parameter, true);
+		}
+	}
+}
+
 /* 
  * add a channel to a user, creating the record for it if needed and linking
  * it to the user record 
  */
-chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bool override, const char* key)
+Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS)
 {
 	if (!user || !cn)
 		return NULL;
 
-	int created = 0;
 	char cname[MAXBUF];
 	int MOD_RESULT = 0;
-	strlcpy(cname,cn,CHANMAX);
+	std::string privs;
+	Channel *Ptr;
+
+	/*
+	 * We don't restrict the number of channels that remote users or users that are override-joining may be in.
+	 * We restrict local users to MaxChans channels.
+	 * We restrict local operators to OperMaxChans channels.
+	 * This is a lot more logical than how it was formerly. -- w00t
+	 */
+	if (IS_LOCAL(user) && !override)
+	{
+		if (user->GetMaxChans())
+		{
+			if (user->chans.size() >= user->GetMaxChans())
+			{
+				user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick, cn);
+				return NULL;
+			}
+		}
+		else
+		{
+			if (IS_OPER(user))
+			{
+				if (user->chans.size() >= Instance->Config->OperMaxChans)
+				{
+					user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick, cn);
+					return NULL;
+				}
+			}
+			else
+			{
+				if (user->chans.size() >= Instance->Config->MaxChans)
+				{
+					user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick, cn);
+					return NULL;
+				}
+			}
+		}
+	}
 
-	chanrec* Ptr = Instance->FindChan(cname);
+	strlcpy(cname, cn, CHANMAX);
+	Ptr = Instance->FindChan(cname);
 
 	if (!Ptr)
 	{
-		if (IS_LOCAL(user))
+		/*
+		 * Fix: desync bug was here, don't set @ on remote users - spanningtree handles their permissions. bug #358. -- w00t
+		 */
+		if (!IS_LOCAL(user))
+		{
+			if (!TS)
+				Instance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick, cn);
+		}
+		else
+		{
+			privs = "@";
+		}
+
+		if (IS_LOCAL(user) && override == false)
 		{
 			MOD_RESULT = 0;
-			FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,NULL,cname));
+			FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, NULL, cname, privs, key ? key : ""));
 			if (MOD_RESULT == 1)
 				return NULL;
 		}
 
-		/* create a new one */
-		Ptr = new chanrec(Instance);
-		Instance->chanlist[cname] = Ptr;
-
-		strlcpy(Ptr->name, cname,CHANMAX);
-		Ptr->modes[CM_TOPICLOCK] = Ptr->modes[CM_NOEXTERNAL] = 1;
-		Ptr->created = Instance->Time();
-		*Ptr->topic = 0;
-		strlcpy(Ptr->setby, user->nick,NICKMAX-1);
-		Ptr->topicset = 0;
-		Instance->Log(DEBUG,"chanrec::JoinUser(): created: %s",cname);
-		/*
-		 * set created to 2 to indicate user
-		 * is the first in the channel
-		 * and should be given ops
-		 */
-		created = 2;
+		Ptr = new Channel(Instance, cname, TS);
 	}
 	else
 	{
@@ -244,10 +295,10 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
 		 * remote users are allowed us to bypass channel modes
 		 * and bans (used by servers)
 		 */
-		if (IS_LOCAL(user)) /* was a check on fd > -1 */
+		if (IS_LOCAL(user) && override == false)
 		{
 			MOD_RESULT = 0;
-			FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,Ptr,cname));
+			FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, Ptr, cname, privs, key ? key : ""));
 			if (MOD_RESULT == 1)
 			{
 				return NULL;
@@ -260,42 +311,26 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
 					FOREACH_RESULT_I(Instance,I_OnCheckKey,OnCheckKey(user, Ptr, key ? key : ""));
 					if (!MOD_RESULT)
 					{
-						if (!key)
+						if ((!key) || strcmp(key,Ptr->key))
 						{
-							Instance->Log(DEBUG,"chanrec::JoinUser(): no key given in JOIN");
-							user->WriteServ("475 %s %s :Cannot join channel (Requires key)",user->nick, Ptr->name);
+							user->WriteNumeric(475, "%s %s :Cannot join channel (Incorrect channel key)",user->nick, Ptr->name);
 							return NULL;
 						}
-						else
-						{
-							if (strcmp(key,Ptr->key))
-							{
-								Instance->Log(DEBUG,"chanrec::JoinUser(): bad key given in JOIN");
-								user->WriteServ("475 %s %s :Cannot join channel (Incorrect key)",user->nick, Ptr->name);
-								return NULL;
-							}
-						}
 					}
 				}
-				if (Ptr->modes[CM_INVITEONLY])
+				if (Ptr->IsModeSet('i'))
 				{
 					MOD_RESULT = 0;
-					irc::string xname(Ptr->name);
 					FOREACH_RESULT_I(Instance,I_OnCheckInvite,OnCheckInvite(user, Ptr));
 					if (!MOD_RESULT)
 					{
-						if (user->IsInvited(xname))
+						if (!user->IsInvited(Ptr->name))
 						{
-							/* user was invited to channel */
-							/* there may be an optional channel NOTICE here */
-						}
-						else
-						{
-							user->WriteServ("473 %s %s :Cannot join channel (Invite only)",user->nick, Ptr->name);
+							user->WriteNumeric(473, "%s %s :Cannot join channel (Invite only)",user->nick, Ptr->name);
 							return NULL;
 						}
 					}
-					user->RemoveInvite(xname);
+					user->RemoveInvite(Ptr->name);
 				}
 				if (Ptr->limit)
 				{
@@ -305,182 +340,186 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo
 					{
 						if (Ptr->GetUserCounter() >= Ptr->limit)
 						{
-							user->WriteServ("471 %s %s :Cannot join channel (Channel is full)",user->nick, Ptr->name);
+							user->WriteNumeric(471, "%s %s :Cannot join channel (Channel is full)",user->nick, Ptr->name);
 							return NULL;
 						}
 					}
 				}
 				if (Ptr->bans.size())
 				{
-					MOD_RESULT = 0;
-					FOREACH_RESULT_I(Instance,I_OnCheckBan,OnCheckBan(user, Ptr));
-					char mask[MAXBUF];
-					sprintf(mask,"%s!%s@%s",user->nick, user->ident, user->GetIPString());
-					if (!MOD_RESULT)
+					if (Ptr->IsBanned(user))
 					{
-						for (BanList::iterator i = Ptr->bans.begin(); i != Ptr->bans.end(); i++)
-						{
-							/* This allows CIDR ban matching
-							 * 
-							 *	  Full masked host			Full unmasked host		     IP with/without CIDR
-							 */
-							if ((match(user->GetFullHost(),i->data)) || (match(user->GetFullRealHost(),i->data)) || (match(mask, i->data, true)))
-							{
-								user->WriteServ("474 %s %s :Cannot join channel (You're banned)",user->nick, Ptr->name);
-								return NULL;
-							}
-						}
+						user->WriteNumeric(474, "%s %s :Cannot join channel (You're banned)",user->nick, Ptr->name);
+						return NULL;
 					}
 				}
 			}
 		}
-		else
-		{
-			Instance->Log(DEBUG,"chanrec::JoinUser(): Overridden checks");
-		}
-		created = 1;
 	}
 
-	for (UserChanList::const_iterator index = user->chans.begin(); index != user->chans.end(); index++)
-	{
-		if ((*index)->channel == NULL)
-		{
-			return chanrec::ForceChan(Instance, Ptr, *index, user, created);
-		}
-	}
+	/* As spotted by jilles, dont bother to set this on remote users */
+	if (IS_LOCAL(user) && Ptr->GetUserCounter() == 0)
+		Ptr->SetDefaultModes();
 
-	/*
-	 * XXX: If the user is an oper here, we can just extend their user->chans vector by one
-	 * and put the channel in here. Same for remote users which are not bound by
-	 * the channel limits. Otherwise, nope, youre boned.
-	 */
-	if (!IS_LOCAL(user)) /* was a check on fd < 0 */
-	{
-		ucrec* a = new ucrec();
-		chanrec* c = chanrec::ForceChan(Instance, Ptr,a,user,created);
-		user->chans.push_back(a);
-		return c;
-	}
-	else if (*user->oper)
+	return Channel::ForceChan(Instance, Ptr, user, privs, bursting);
+}
+
+Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const std::string &privs, bool bursting)
+{
+	std::string nick = user->nick;
+	bool silent = false;
+
+	Ptr->AddUser(user);
+
+	/* Just in case they have no permissions */
+	user->chans[Ptr] = 0;
+
+	for (std::string::const_iterator x = privs.begin(); x != privs.end(); x++)
 	{
-		/* Oper allows extension up to the OPERMAXCHANS value */
-		if (user->chans.size() < OPERMAXCHANS)
+		const char status = *x;
+		ModeHandler* mh = Instance->Modes->FindPrefix(status);
+		if (mh)
 		{
-			ucrec* a = new ucrec();
-			chanrec* c = chanrec::ForceChan(Instance, Ptr,a,user,created);
-			user->chans.push_back(a);
-			return c;
+			/* Set, and make sure that the mode handler knows this mode was now set */
+			Ptr->SetPrefix(user, status, mh->GetPrefixRank(), true);
+			mh->OnModeChange(Instance->FakeClient, Instance->FakeClient, Ptr, nick, true);
+
+			switch (mh->GetPrefix())
+			{
+				/* These logic ops are SAFE IN THIS CASE because if the entry doesnt exist,
+				 * addressing operator[] creates it. If they do exist, it points to it.
+				 * At all other times where we dont want to create an item if it doesnt exist, we
+				 * must stick to ::find().
+				 */
+				case '@':
+					user->chans[Ptr] |= UCMODE_OP;
+				break;
+				case '%':
+					user->chans[Ptr] |= UCMODE_HOP;
+				break;
+				case '+':
+					user->chans[Ptr] |= UCMODE_VOICE;
+				break;
+			}
 		}
 	}
 
-	user->WriteServ("405 %s %s :You are on too many channels",user->nick, cname);
+	FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, bursting, silent));
+
+	if (!silent)
+		Ptr->WriteChannel(user,"JOIN :%s",Ptr->name);
 
-	if (created == 2)
+	/* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */
+	std::string ms = Instance->Modes->ModeString(user, Ptr);
+	if ((Ptr->GetUserCounter() > 1) && (ms.length()))
+		Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name, ms.c_str());
+
+	/* Major improvement by Brain - we dont need to be calculating all this pointlessly for remote users */
+	if (IS_LOCAL(user))
 	{
-		Instance->Log(DEBUG,"BLAMMO, Whacking channel.");
-		/* Things went seriously pear shaped, so take this away. bwahaha. */
-		chan_hash::iterator n = Instance->chanlist.find(cname);
-		if (n != Instance->chanlist.end())
+		if (Ptr->topicset)
 		{
-			Ptr->DelUser(user);
-			DELETE(Ptr);
-			Instance->chanlist.erase(n);
-			for (unsigned int index =0; index < user->chans.size(); index++)
-			{
-				if (user->chans[index]->channel == Ptr)
-				{
-					user->chans[index]->channel = NULL;
-					user->chans[index]->uc_modes = 0;	
-				}
-			}
+			user->WriteNumeric(332, "%s %s :%s", user->nick, Ptr->name, Ptr->topic);
+			user->WriteNumeric(333, "%s %s %s %lu", user->nick, Ptr->name, Ptr->setby, (unsigned long)Ptr->topicset);
 		}
+		Ptr->UserList(user);
 	}
-	else
+	FOREACH_MOD_I(Instance,I_OnPostJoin,OnPostJoin(user, Ptr));
+	return Ptr;
+}
+
+bool Channel::IsBanned(User* user)
+{
+	char mask[MAXBUF];
+	int MOD_RESULT = 0;
+	FOREACH_RESULT(I_OnCheckBan,OnCheckBan(user, this));
+
+	if (MOD_RESULT == -1)
+		return true;
+	else if (MOD_RESULT == 0)
 	{
-		for (unsigned int index =0; index < user->chans.size(); index++)
+		snprintf(mask, MAXBUF, "%s!%s@%s", user->nick, user->ident, user->GetIPString());
+		for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
 		{
-			if (user->chans[index]->channel == Ptr)
+			/* This allows CIDR ban matching
+			 * 
+			 *        Full masked host                      Full unmasked host                   IP with/without CIDR
+			 */
+			if ((match(user->GetFullHost(),i->data)) || (match(user->GetFullRealHost(),i->data)) || (match(mask, i->data, true)))
 			{
-				user->chans[index]->channel = NULL;
-				user->chans[index]->uc_modes = 0;
+				return true;
 			}
 		}
 	}
-	return NULL;
+	return false;
 }
 
-chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* user, int created)
+bool Channel::IsExtBanned(User *user, char type)
 {
-	if (created == 2)
-	{
-		/* first user in is given ops */
-		a->uc_modes = UCMODE_OP;
-		Ptr->AddOppedUser(user);
-		Ptr->SetPrefix(user, '@', OP_VALUE, true);
-	}
-	else
-	{
-		a->uc_modes = 0;
-	}
+	// XXX. do we need events?
+	char mask[MAXBUF];
+	char *maskptr;
 
-	a->channel = Ptr;
-	Ptr->AddUser(user);
-	Ptr->WriteChannel(user,"JOIN :%s",Ptr->name);
+	snprintf(mask, MAXBUF, "%s!%s@%s", user->nick, user->ident, user->GetIPString());
 
-	/* Major improvement by Brain - we dont need to be calculating all this pointlessly for remote users */
-	if (IS_LOCAL(user))
+	for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++)
 	{
-		if (Ptr->topicset)
+		if (i->data[0] != type || i->data[1] != ':')
+			continue;
+
+		// Iterate past char and : to get to the mask without doing a data copy(!)
+		maskptr = i->data;
+		maskptr++; // past the char
+		maskptr++; // past the :
+
+		/* This allows CIDR ban matching
+		 * 
+		 *        Full masked host                             Full unmasked host                     IP with/without CIDR
+		 */
+		if ((match(user->GetFullHost(), maskptr)) || (match(user->GetFullRealHost(), maskptr)) || (match(mask, maskptr, true)))
 		{
-			user->WriteServ("332 %s %s :%s", user->nick, Ptr->name, Ptr->topic);
-			user->WriteServ("333 %s %s %s %lu", user->nick, Ptr->name, Ptr->setby, (unsigned long)Ptr->topicset);
+			return true;
 		}
-		Ptr->UserList(user);
 	}
-	FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user,Ptr));
-	return Ptr;
+
+	return false;
 }
 
-/* chanrec::PartUser
- * remove a channel from a users record, and remove the record from the hash
- * if the channel has become empty
+/* Channel::PartUser
+ * remove a channel from a users record, and return the number of users left.
+ * Therefore, if this function returns 0 the caller should delete the Channel.
  */
-long chanrec::PartUser(userrec *user, const char* reason)
+long Channel::PartUser(User *user, const char* reason)
 {
+	bool silent = false;
+
 	if (!user)
 		return this->GetUserCounter();
 
-	for (unsigned int i =0; i < user->chans.size(); i++)
+	UCListIter i = user->chans.find(this);
+	if (i != user->chans.end())
 	{
-		/* zap it from the channel list of the user */
-		if (user->chans[i]->channel == this)
-		{
-			if (reason)
-			{
-				FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason));
-				this->WriteChannel(user, "PART %s :%s", this->name, reason);
-			}
-			else
-			{
-				FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, ""));
-				this->WriteChannel(user, "PART :%s", this->name);
-			}
-			user->chans[i]->uc_modes = 0;
-			user->chans[i]->channel = NULL;
-			this->RemoveAllPrefixes(user);
-			break;
-		}
+		FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason ? reason : "", silent));
+
+		if (!silent)
+			this->WriteChannel(user, "PART %s%s%s", this->name, reason ? " :" : "", reason ? reason : "");
+
+		user->chans.erase(i);
+		this->RemoveAllPrefixes(user);
 	}
 
 	if (!this->DelUser(user)) /* if there are no users left on the channel... */
 	{
-		chan_hash::iterator iter = ServerInstance->chanlist.find(this->name);
+		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
 		/* kill the record */
-		if (iter != ServerInstance->chanlist.end())
+		if (iter != ServerInstance->chanlist->end())
 		{
-			ServerInstance->Log(DEBUG,"del_channel: destroyed: %s", this->name);
-			FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this));
-			ServerInstance->chanlist.erase(iter);
+			int MOD_RESULT = 0;
+			FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this));
+			if (MOD_RESULT == 1)
+				return 1; // delete halted by module
+			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
+			ServerInstance->chanlist->erase(iter);
 		}
 		return 0;
 	}
@@ -488,8 +527,10 @@ long chanrec::PartUser(userrec *user, const char* reason)
 	return this->GetUserCounter();
 }
 
-long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggerevents)
+long Channel::ServerKickUser(User* user, const char* reason, bool triggerevents, const char* servername)
 {
+	bool silent = false;
+
 	if (!user || !reason)
 		return this->GetUserCounter();
 
@@ -502,31 +543,36 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven
 		}
 	}
 
+	if (servername == NULL || *ServerInstance->Config->HideWhoisServer)
+		servername = ServerInstance->Config->ServerName;
+
 	if (triggerevents)
 	{
-		FOREACH_MOD(I_OnUserKick,OnUserKick(NULL,user,this,reason));
+		FOREACH_MOD(I_OnUserKick,OnUserKick(NULL, user, this, reason, silent));
 	}
 
-	for (unsigned int i =0; i < user->chans.size(); i++)
+	UCListIter i = user->chans.find(this);
+	if (i != user->chans.end())
 	{
-		if (user->chans[i]->channel == this)
-		{
-			this->WriteChannelWithServ(ServerInstance->Config->ServerName, "KICK %s %s :%s", this->name, user->nick, reason);
-			user->chans[i]->uc_modes = 0;
-			user->chans[i]->channel = NULL;
-			this->RemoveAllPrefixes(user);
-			break;
-		}
+		if (!silent)
+			this->WriteChannelWithServ(servername, "KICK %s %s :%s", this->name, user->nick, reason);
+
+		user->chans.erase(i);
+		this->RemoveAllPrefixes(user);
 	}
 
 	if (!this->DelUser(user))
 	{
-		chan_hash::iterator iter = ServerInstance->chanlist.find(this->name);
+		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
 		/* kill the record */
-		if (iter != ServerInstance->chanlist.end())
+		if (iter != ServerInstance->chanlist->end())
 		{
-			FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this));
-			ServerInstance->chanlist.erase(iter);
+			int MOD_RESULT = 0;
+			FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this));
+			if (MOD_RESULT == 1)
+				return 1; // delete halted by module
+			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
+			ServerInstance->chanlist->erase(iter);
 		}
 		return 0;
 	}
@@ -534,8 +580,10 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven
 	return this->GetUserCounter();
 }
 
-long chanrec::KickUser(userrec *src, userrec *user, const char* reason)
+long Channel::KickUser(User *src, User *user, const char* reason)
 {
+	bool silent = false;
+
 	if (!src || !user || !reason)
 		return this->GetUserCounter();
 
@@ -543,12 +591,12 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason)
 	{
 		if (!this->HasUser(user))
 		{
-			src->WriteServ("441 %s %s %s :They are not on that channel",src->nick, user->nick, this->name);
+			src->WriteNumeric(441, "%s %s %s :They are not on that channel",src->nick, user->nick, this->name);
 			return this->GetUserCounter();
 		}
 		if ((ServerInstance->ULine(user->server)) && (!ServerInstance->ULine(src->server)))
 		{
-			src->WriteServ("482 %s %s :Only a u-line may kick a u-line from a channel.",src->nick, this->name);
+			src->WriteNumeric(482, "%s %s :Only a u-line may kick a u-line from a channel.",src->nick, this->name);
 			return this->GetUserCounter();
 		}
 		int MOD_RESULT = 0;
@@ -573,45 +621,40 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason)
 				int us = this->GetStatus(user);
    			 	if ((them < STATUS_HOP) || (them < us))
 				{
-					if (them == STATUS_HOP)
-					{
-						src->WriteServ("482 %s %s :You must be a channel operator",src->nick, this->name);
-					}
-					else
-					{
-						src->WriteServ("482 %s %s :You must be at least a half-operator",src->nick, this->name);
-					}
+					src->WriteNumeric(482, "%s %s :You must be a channel %soperator",src->nick, this->name, them == STATUS_HOP ? "" : "half-");
 					return this->GetUserCounter();
 				}
 			}
 		}
 	}
 
-	FOREACH_MOD(I_OnUserKick,OnUserKick(src,user,this,reason));
-			
-	for (UserChanList::const_iterator i = user->chans.begin(); i != user->chans.end(); i++)
+	FOREACH_MOD(I_OnUserKick,OnUserKick(src, user, this, reason, silent));
+
+	UCListIter i = user->chans.find(this);
+	if (i != user->chans.end())
 	{
 		/* zap it from the channel list of the user */
-		if ((*i)->channel == this)
-		{
+		if (!silent)
 			this->WriteChannel(src, "KICK %s %s :%s", this->name, user->nick, reason);
-			(*i)->uc_modes = 0;
-			(*i)->channel = NULL;
-			this->RemoveAllPrefixes(user);
-			break;
-		}
+
+		user->chans.erase(i);
+		this->RemoveAllPrefixes(user);
 	}
 
 	if (!this->DelUser(user))
 	/* if there are no users left on the channel */
 	{
-		chan_hash::iterator iter = ServerInstance->chanlist.find(this->name);
+		chan_hash::iterator iter = ServerInstance->chanlist->find(this->name);
 
 		/* kill the record */
-		if (iter != ServerInstance->chanlist.end())
+		if (iter != ServerInstance->chanlist->end())
 		{
-			FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this));
-			ServerInstance->chanlist.erase(iter);
+			int MOD_RESULT = 0;
+			FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this));
+			if (MOD_RESULT == 1)
+				return 1; // delete halted by module
+			FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this));
+			ServerInstance->chanlist->erase(iter);
 		}
 		return 0;
 	}
@@ -619,7 +662,7 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason)
 	return this->GetUserCounter();
 }
 
-void chanrec::WriteChannel(userrec* user, char* text, ...)
+void Channel::WriteChannel(User* user, const char* text, ...)
 {
 	char textbuffer[MAXBUF];
 	va_list argsPtr;
@@ -634,21 +677,25 @@ void chanrec::WriteChannel(userrec* user, char* text, ...)
 	this->WriteChannel(user, std::string(textbuffer));
 }
 
-void chanrec::WriteChannel(userrec* user, const std::string &text)
+void Channel::WriteChannel(User* user, const std::string &text)
 {
 	CUList *ulist = this->GetUsers();
+	char tb[MAXBUF];
 
 	if (!user)
 		return;
 
+	snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str());
+	std::string out = tb;
+
 	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 	{
-		if (IS_LOCAL(i->second))
-			user->WriteTo(i->second,text);
+		if (IS_LOCAL(i->first))
+			i->first->Write(out);
 	}
 }
 
-void chanrec::WriteChannelWithServ(const char* ServName, const char* text, ...)
+void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...)
 {
 	char textbuffer[MAXBUF];
 	va_list argsPtr;
@@ -663,98 +710,118 @@ void chanrec::WriteChannelWithServ(const char* ServName, const char* text, ...)
 	this->WriteChannelWithServ(ServName, std::string(textbuffer));
 }
 
-void chanrec::WriteChannelWithServ(const char* ServName, const std::string &text)
+void Channel::WriteChannelWithServ(const char* ServName, const std::string &text)
 {
 	CUList *ulist = this->GetUsers();
+	char tb[MAXBUF];
+
+	snprintf(tb,MAXBUF,":%s %s",ServName ? ServName : ServerInstance->Config->ServerName, text.c_str());
+	std::string out = tb;
 
 	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 	{
-		if (IS_LOCAL(i->second))
-			i->second->WriteServ(text);
+		if (IS_LOCAL(i->first))
+			i->first->Write(out);
 	}
 }
 
 /* write formatted text from a source user to all users on a channel except
  * for the sender (for privmsg etc) */
-void chanrec::WriteAllExceptSender(userrec* user, char status, char* text, ...)
+void Channel::WriteAllExceptSender(User* user, bool serversource, char status, const char* text, ...)
 {
 	char textbuffer[MAXBUF];
 	va_list argsPtr;
 
-	if (!user || !text)
+	if (!text)
 		return;
 
 	va_start(argsPtr, text);
 	vsnprintf(textbuffer, MAXBUF, text, argsPtr);
 	va_end(argsPtr);
 
-	this->WriteAllExceptSender(user, status, std::string(textbuffer));
+	this->WriteAllExceptSender(user, serversource, status, std::string(textbuffer));
 }
 
-void chanrec::WriteAllExceptSender(userrec* user, char status, const std::string& text)
+void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const char* text, ...)
 {
-	CUList *ulist;
+	char textbuffer[MAXBUF];
+	va_list argsPtr;
 
-	if (!user)
+	if (!text)
 		return;
 
-	switch (status)
-	{
-		case '@':
-			ulist = this->GetOppedUsers();
-			break;
-		case '%':
-			ulist = this->GetHalfoppedUsers();
-			break;
-		case '+':
-			ulist = this->GetVoicedUsers();
-			break;
-		default:
-			ulist = this->GetUsers();
-			break;
-	}
+	va_start(argsPtr, text);
+	vsnprintf(textbuffer, MAXBUF, text, argsPtr);
+	va_end(argsPtr);
+
+	this->WriteAllExcept(user, serversource, status, except_list, std::string(textbuffer));
+}
+
+void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const std::string &text)
+{
+	CUList *ulist = this->GetUsers();
+	char tb[MAXBUF];
+
+	snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str());
+	std::string out = tb;
 
 	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 	{
-		if ((IS_LOCAL(i->second)) && (user != i->second))
-			i->second->WriteFrom(user,text);
+		if ((IS_LOCAL(i->first)) && (except_list.find(i->first) == except_list.end()))
+		{
+			/* User doesnt have the status we're after */
+			if (status && !strchr(this->GetAllPrefixChars(i->first), status))
+				continue;
+
+			if (serversource)
+				i->first->WriteServ(text);
+			else
+				i->first->Write(out);
+		}
 	}
 }
 
+void Channel::WriteAllExceptSender(User* user, bool serversource, char status, const std::string& text)
+{
+	CUList except_list;
+	except_list[user] = user->nick;
+	this->WriteAllExcept(user, serversource, status, except_list, std::string(text));
+}
+
 /*
  * return a count of the users on a specific channel accounting for
  * invisible users who won't increase the count. e.g. for /LIST
  */
-int chanrec::CountInvisible()
+int Channel::CountInvisible()
 {
 	int count = 0;
 	CUList *ulist= this->GetUsers();
 	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 	{
-		if (!(i->second->modes[UM_INVISIBLE]))
+		if (!(i->first->IsModeSet('i')))
 			count++;
 	}
 
 	return count;
 }
 
-char* chanrec::ChanModes(bool showkey)
+char* Channel::ChanModes(bool showkey)
 {
 	static char scratch[MAXBUF];
 	static char sparam[MAXBUF];
 	char* offset = scratch;
-	std::string extparam = "";
+	std::string extparam;
 
 	*scratch = '\0';
 	*sparam = '\0';
 
-	/* This was still iterating up to 190, chanrec::custom_modes is only 64 elements -- Om */
+	/* This was still iterating up to 190, Channel::modes is only 64 elements -- Om */
 	for(int n = 0; n < 64; n++)
 	{
 		if(this->modes[n])
 		{
 			*offset++ = n + 65;
-			extparam = "";
+			extparam.clear();
 			switch (n)
 			{
 				case CM_KEY:
@@ -775,7 +842,7 @@ char* chanrec::ChanModes(bool showkey)
 					extparam = this->GetModeParameter(n + 65);
 				break;
 			}
-			if (extparam != "")
+			if (!extparam.empty())
 			{
 				charlcat(sparam,' ',MAXBUF);
 				strlcat(sparam,extparam.c_str(),MAXBUF);
@@ -792,25 +859,36 @@ char* chanrec::ChanModes(bool showkey)
 /* compile a userlist of a channel into a string, each nick seperated by
  * spaces and op, voice etc status shown as @ and +, and send it to 'user'
  */
-void chanrec::UserList(userrec *user)
+void Channel::UserList(User *user, CUList *ulist)
 {
 	char list[MAXBUF];
 	size_t dlen, curlen;
 	int MOD_RESULT = 0;
+	bool call_modules = true;
 
-	FOREACH_RESULT(I_OnUserList,OnUserList(user, this));
-	ServerInstance->Log(DEBUG,"MOD_RESULT for UserList = %d",MOD_RESULT);
-	if (MOD_RESULT == 1)
+	if (!IS_LOCAL(user))
 		return;
 
-	ServerInstance->Log(DEBUG,"Using builtin NAMES list generation");
+	FOREACH_RESULT(I_OnUserList,OnUserList(user, this, ulist));
+	if (MOD_RESULT == 1)
+		call_modules = false;
+
+	if (MOD_RESULT != -1)
+	{
+		if ((this->IsModeSet('s')) && (!this->HasUser(user)))
+		{
+			user->WriteNumeric(401, "%s %s :No such nick/channel",user->nick, this->name);
+			return;
+		}
+	}
 
-	dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, this->name);
+	dlen = curlen = snprintf(list,MAXBUF,"%s %c %s :", user->nick, this->IsModeSet('s') ? '@' : this->IsModeSet('p') ? '*' : '=',  this->name);
 
 	int numusers = 0;
 	char* ptr = list + dlen;
 
-	CUList *ulist= this->GetUsers();
+	if (!ulist)
+		ulist = this->GetUsers();
 
 	/* Improvement by Brain - this doesnt change in value, so why was it inside
 	 * the loop?
@@ -819,7 +897,7 @@ void chanrec::UserList(userrec *user)
 
 	for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
 	{
-		if ((!has_user) && (i->second->modes[UM_INVISIBLE]))
+		if ((!has_user) && (i->first->IsModeSet('i')))
 		{
 			/*
 			 * user is +i, and source not on the channel, does not show
@@ -828,80 +906,108 @@ void chanrec::UserList(userrec *user)
 			continue;
 		}
 
-		size_t ptrlen = snprintf(ptr, MAXBUF, "%s%s ", this->GetPrefixChar(i->second), i->second->nick);
+		if (i->first->Visibility && !i->first->Visibility->VisibleTo(user))
+			continue;
 
-		curlen += ptrlen;
-		ptr += ptrlen;
+		std::string prefixlist = this->GetPrefixChar(i->first);
+		std::string nick = i->first->nick;
 
-		numusers++;
+		if (call_modules)
+		{
+			FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->first, this, prefixlist, nick));
+	
+			/* Nick was nuked, a module wants us to skip it */
+			if (nick.empty())
+				continue;
+		}
+		
+		size_t ptrlen = 0;
 
 		if (curlen > (480-NICKMAX))
 		{
 			/* list overflowed into multiple numerics */
-			user->WriteServ(list);
+			user->WriteServ(std::string(list));
 
 			/* reset our lengths */
-			dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, this->name);
+			dlen = curlen = snprintf(list,MAXBUF,"%s %c %s :", user->nick, this->IsModeSet('s') ? '@' : this->IsModeSet('p') ? '*' : '=', this->name);
 			ptr = list + dlen;
 
 			ptrlen = 0;
 			numusers = 0;
 		}
+
+		ptrlen = snprintf(ptr, MAXBUF, "%s%s ", prefixlist.c_str(), nick.c_str());
+
+		curlen += ptrlen;
+		ptr += ptrlen;
+
+		numusers++;
 	}
 
 	/* if whats left in the list isnt empty, send it */
 	if (numusers)
 	{
-		user->WriteServ(list);
+		user->WriteNumeric(353,std::string(list));
 	}
 
-	user->WriteServ("366 %s %s :End of /NAMES list.", user->nick, this->name);
+	user->WriteNumeric(366, "%s %s :End of /NAMES list.", user->nick, this->name);
 }
 
-long chanrec::GetMaxBans()
+long Channel::GetMaxBans()
 {
-	std::string x;
+	/* Return the cached value if there is one */
+	if (this->maxbans)
+		return this->maxbans;
+
+	/* If there isnt one, we have to do some O(n) hax to find it the first time. (ick) */
 	for (std::map<std::string,int>::iterator n = ServerInstance->Config->maxbans.begin(); n != ServerInstance->Config->maxbans.end(); n++)
 	{
-		x = n->first;
-		if (match(this->name,x.c_str()))
+		if (match(this->name,n->first.c_str()))
 		{
+			this->maxbans = n->second;
 			return n->second;
 		}
 	}
-	return 64;
+
+	/* Screw it, just return the default of 64 */
+	this->maxbans = 64;
+	return this->maxbans;
 }
 
+void Channel::ResetMaxBans()
+{
+	this->maxbans = 0;
+}
 
 /* returns the status character for a given user on a channel, e.g. @ for op,
  * % for halfop etc. If the user has several modes set, the highest mode
  * the user has must be returned.
  */
-const char* chanrec::GetPrefixChar(userrec *user)
+const char* Channel::GetPrefixChar(User *user)
 {
-	static char px[2];
-	unsigned int mx = 0;
-
-	*px = 0;
-	*(px+1) = 0;
-
+	static char pf[2] = {0, 0};
+	
 	prefixlist::iterator n = prefixes.find(user);
 	if (n != prefixes.end())
 	{
-		for (std::vector<prefixtype>::iterator x = n->second.begin(); x != n->second.end(); x++)
+		if (n->second.size())
 		{
-			if (x->second > mx)
-			{
-				*px = x->first;
-				mx  = x->second;
-			}
+			/* If the user has any prefixes, their highest prefix
+			 * will always be at the head of the list, as the list is
+			 * sorted in rank order highest first (see SetPrefix()
+			 * for reasons why)
+			 */
+			*pf = n->second.begin()->first;
+			return pf;
 		}
 	}
 
-	return px;
+	*pf = 0;
+	return pf;
 }
 
-const char* chanrec::GetAllPrefixChars(userrec* user)
+
+const char* Channel::GetAllPrefixChars(User* user)
 {
 	static char prefix[MAXBUF];
 	int ctr = 0;
@@ -921,70 +1027,53 @@ const char* chanrec::GetAllPrefixChars(userrec* user)
 	return prefix;
 }
 
-unsigned int chanrec::GetPrefixValue(userrec* user)
+unsigned int Channel::GetPrefixValue(User* user)
 {
-	unsigned int mx = 0;
-
 	prefixlist::iterator n = prefixes.find(user);
 	if (n != prefixes.end())
 	{
-		for (std::vector<prefixtype>::iterator x = n->second.begin(); x != n->second.end(); x++)
-		{
-			if (x->second > mx)
-				mx  = x->second;
-		}
+		if (n->second.size())
+			return n->second.begin()->second;
 	}
-
-	return mx;
+	return 0;
 }
 
-
-int chanrec::GetStatusFlags(userrec *user)
+int Channel::GetStatusFlags(User *user)
 {
-	for (std::vector<ucrec*>::const_iterator i = user->chans.begin(); i != user->chans.end(); i++)
+	UCListIter i = user->chans.find(this);
+	if (i != user->chans.end())
 	{
-		if ((*i)->channel == this)
-		{
-			return (*i)->uc_modes;
-		}
+		return i->second;
 	}
 	return 0;
 }
 
-
-int chanrec::GetStatus(userrec *user)
+int Channel::GetStatus(User *user)
 {
 	if (ServerInstance->ULine(user->server))
 		return STATUS_OP;
 
-	for (std::vector<ucrec*>::const_iterator i = user->chans.begin(); i != user->chans.end(); i++)
+	UCListIter i = user->chans.find(this);
+	if (i != user->chans.end())
 	{
-		if ((*i)->channel == this)
+		if ((i->second & UCMODE_OP) > 0)
 		{
-			if (((*i)->uc_modes & UCMODE_OP) > 0)
-			{
-				return STATUS_OP;
-			}
-			if (((*i)->uc_modes & UCMODE_HOP) > 0)
-			{
-				return STATUS_HOP;
-			}
-			if (((*i)->uc_modes & UCMODE_VOICE) > 0)
-			{
-				return STATUS_VOICE;
-			}
-			return STATUS_NORMAL;
+			return STATUS_OP;
 		}
+		if ((i->second & UCMODE_HOP) > 0)
+		{
+			return STATUS_HOP;
+		}
+		if ((i->second & UCMODE_VOICE) > 0)
+		{
+			return STATUS_VOICE;
+		}
+		return STATUS_NORMAL;
 	}
 	return STATUS_NORMAL;
 }
 
-/*bool ModeParser::PrefixComparison(const prefixtype one, const prefixtype two)
-{       
-        return one.second > two.second;
-}*/
-
-void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, bool adding)
+void Channel::SetPrefix(User* user, char prefix, unsigned int prefix_value, bool adding)
 {
 	prefixlist::iterator n = prefixes.find(user);
 	prefixtype pfx = std::make_pair(prefix,prefix_value);
@@ -995,6 +1084,11 @@ void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, b
 			if (std::find(n->second.begin(), n->second.end(), pfx) == n->second.end())
 			{
 				n->second.push_back(pfx);
+				/* We must keep prefixes in rank order, largest first.
+				 * This is for two reasons, firstly because x-chat *ass-u-me's* this
+				 * state, and secondly it turns out to be a benefit to us later.
+				 * See above in GetPrefix().
+				 */
 				std::sort(n->second.begin(), n->second.end(), ModeParser::PrefixComparison);
 			}
 		}
@@ -1002,7 +1096,7 @@ void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, b
 		{
 			pfxcontainer one;
 			one.push_back(pfx);
-			prefixes.insert(std::make_pair<userrec*,pfxcontainer>(user, one));
+			prefixes.insert(std::make_pair<User*,pfxcontainer>(user, one));
 		}
 	}
 	else
@@ -1016,10 +1110,12 @@ void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, b
 	}
 }
 
-void chanrec::RemoveAllPrefixes(userrec* user)
+void Channel::RemoveAllPrefixes(User* user)
 {
 	prefixlist::iterator n = prefixes.find(user);
 	if (n != prefixes.end())
+	{
 		prefixes.erase(n);
+	}
 }