X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fchannels.cpp;h=d03f80f64e0c40edbe95df45fa36b7b6ac84d7a3;hb=7d7250484c352c13830e63ae41ee8faae40a9bd5;hp=edee36bf7b08ed98c304f296b0290c2f067f8c14;hpb=a25ebde22705d1169b817a6a6d6a0b8a08d24467;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/channels.cpp b/src/channels.cpp index edee36bf7..d03f80f64 100644 --- a/src/channels.cpp +++ b/src/channels.cpp @@ -2,7 +2,7 @@ * | Inspire Internet Relay Chat Daemon | * +------------------------------------+ * - * InspIRCd: (C) 2002-2007 InspIRCd Development Team + * InspIRCd: (C) 2002-2008 InspIRCd Development Team * See: http://www.inspircd.org/wiki/index.php/Credits * * This program is free but copyrighted software; see @@ -11,23 +11,30 @@ * --------------------------------------------------- */ +/* $Core: libIRCDchannels */ + #include "inspircd.h" #include -#include "configreader.h" -#include "users.h" -#include "modules.h" #include "wildcard.h" #include "mode.h" -chanrec::chanrec(InspIRCd* Instance) : ServerInstance(Instance) +Channel::Channel(InspIRCd* Instance, const std::string &cname, time_t ts) : ServerInstance(Instance) { - *name = *topic = *setby = *key = 0; - maxbans = created = topicset = limit = 0; - memset(&modes,0,64); - age = ServerInstance->Time(true); + chan_hash::iterator findchan = ServerInstance->chanlist->find(cname); + if (findchan != Instance->chanlist->end()) + throw CoreException("Cannot create duplicate channel " + cname); + + (*(ServerInstance->chanlist))[cname.c_str()] = this; + this->name.assign(cname, 0, ServerInstance->Config->Limits.ChanMax); + this->created = ts ? ts : ServerInstance->Time(); + this->age = this->created; + + + maxbans = topicset = limit = 0; + memset(&modes, 0, 64); } -void chanrec::SetMode(char mode,bool mode_on) +void Channel::SetMode(char mode,bool mode_on) { modes[mode-65] = mode_on; if (!mode_on) @@ -35,7 +42,7 @@ void chanrec::SetMode(char mode,bool mode_on) } -void chanrec::SetModeParam(char mode,const char* parameter,bool mode_on) +void Channel::SetModeParam(char mode,const char* parameter,bool mode_on) { CustomModeList::iterator n = custom_mode_params.find(mode); @@ -54,12 +61,12 @@ void chanrec::SetModeParam(char mode,const char* parameter,bool mode_on) } } -bool chanrec::IsModeSet(char mode) +bool Channel::IsModeSet(char mode) { return modes[mode-65]; } -std::string chanrec::GetModeParameter(char mode) +std::string Channel::GetModeParameter(char mode) { switch (mode) { @@ -76,17 +83,17 @@ std::string chanrec::GetModeParameter(char mode) } } -long chanrec::GetUserCounter() +long Channel::GetUserCounter() { return (this->internal_userlist.size()); } -void chanrec::AddUser(userrec* user) +void Channel::AddUser(User* user) { internal_userlist[user] = user->nick; } -unsigned long chanrec::DelUser(userrec* user) +unsigned long Channel::DelUser(User* user) { CUListIter a = internal_userlist.find(user); @@ -102,17 +109,17 @@ unsigned long chanrec::DelUser(userrec* user) return internal_userlist.size(); } -bool chanrec::HasUser(userrec* user) +bool Channel::HasUser(User* user) { return (internal_userlist.find(user) != internal_userlist.end()); } -void chanrec::AddOppedUser(userrec* user) +void Channel::AddOppedUser(User* user) { internal_op_userlist[user] = user->nick; } -void chanrec::DelOppedUser(userrec* user) +void Channel::DelOppedUser(User* user) { CUListIter a = internal_op_userlist.find(user); if (a != internal_op_userlist.end()) @@ -122,12 +129,12 @@ void chanrec::DelOppedUser(userrec* user) } } -void chanrec::AddHalfoppedUser(userrec* user) +void Channel::AddHalfoppedUser(User* user) { internal_halfop_userlist[user] = user->nick; } -void chanrec::DelHalfoppedUser(userrec* user) +void Channel::DelHalfoppedUser(User* user) { CUListIter a = internal_halfop_userlist.find(user); @@ -137,12 +144,12 @@ void chanrec::DelHalfoppedUser(userrec* user) } } -void chanrec::AddVoicedUser(userrec* user) +void Channel::AddVoicedUser(User* user) { internal_voice_userlist[user] = user->nick; } -void chanrec::DelVoicedUser(userrec* user) +void Channel::DelVoicedUser(User* user) { CUListIter a = internal_voice_userlist.find(user); @@ -152,33 +159,34 @@ void chanrec::DelVoicedUser(userrec* user) } } -CUList* chanrec::GetUsers() +CUList* Channel::GetUsers() { return &internal_userlist; } -CUList* chanrec::GetOppedUsers() +CUList* Channel::GetOppedUsers() { return &internal_op_userlist; } -CUList* chanrec::GetHalfoppedUsers() +CUList* Channel::GetHalfoppedUsers() { return &internal_halfop_userlist; } -CUList* chanrec::GetVoicedUsers() +CUList* Channel::GetVoicedUsers() { return &internal_voice_userlist; } -void chanrec::SetDefaultModes() +void Channel::SetDefaultModes() { + ServerInstance->Logs->Log("CHANNELS", DEBUG, "SetDefaultModes %s", ServerInstance->Config->DefaultModes); irc::spacesepstream list(ServerInstance->Config->DefaultModes); - std::string modeseq = list.GetToken(); + std::string modeseq; std::string parameter; - userrec* dummyuser = new userrec(ServerInstance); - dummyuser->SetFd(FD_MAGIC_NUMBER); + + list.GetToken(modeseq); for (std::string::iterator n = modeseq.begin(); n != modeseq.end(); ++n) { @@ -186,34 +194,68 @@ void chanrec::SetDefaultModes() if (mode) { if (mode->GetNumParams(true)) - parameter = list.GetToken().c_str(); + list.GetToken(parameter); else parameter.clear(); - mode->OnModeChange(dummyuser, dummyuser, this, parameter, true); + mode->OnModeChange(ServerInstance->FakeClient, ServerInstance->FakeClient, this, parameter, true); } } - - delete dummyuser; } /* * add a channel to a user, creating the record for it if needed and linking * it to the user record */ -chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bool override, const char* key, time_t TS) +Channel* Channel::JoinUser(InspIRCd* Instance, User *user, const char* cn, bool override, const char* key, bool bursting, time_t TS) { if (!user || !cn) return NULL; - bool new_channel = false; char cname[MAXBUF]; int MOD_RESULT = 0; - strlcpy(cname,cn,CHANMAX); - std::string privs; + Channel *Ptr; - chanrec* Ptr = Instance->FindChan(cname); + /* + * We don't restrict the number of channels that remote users or users that are override-joining may be in. + * We restrict local users to MaxChans channels. + * We restrict local operators to OperMaxChans channels. + * This is a lot more logical than how it was formerly. -- w00t + */ + if (IS_LOCAL(user) && !override) + { + if (user->GetMaxChans()) + { + if (user->chans.size() >= user->GetMaxChans()) + { + user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick.c_str(), cn); + return NULL; + } + } + else + { + if (IS_OPER(user)) + { + if (user->chans.size() >= Instance->Config->OperMaxChans) + { + user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick.c_str(), cn); + return NULL; + } + } + else + { + if (user->chans.size() >= Instance->Config->MaxChans) + { + user->WriteNumeric(405, "%s %s :You are on too many channels",user->nick.c_str(), cn); + return NULL; + } + } + } + } + + strlcpy(cname, cn, Instance->Config->Limits.ChanMax); + Ptr = Instance->FindChan(cname); if (!Ptr) { @@ -223,7 +265,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo if (!IS_LOCAL(user)) { if (!TS) - Instance->Log(DEBUG,"*** BUG *** chanrec::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick, cn); + Instance->Logs->Log("CHANNEL",DEBUG,"*** BUG *** Channel::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick.c_str(), cn); } else { @@ -233,27 +275,12 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo if (IS_LOCAL(user) && override == false) { MOD_RESULT = 0; - FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,NULL,cname,privs)); + FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, NULL, cname, privs, key ? key : "")); if (MOD_RESULT == 1) return NULL; } - /* create a new one */ - Ptr = new chanrec(Instance); - (*(Instance->chanlist))[cname] = Ptr; - - strlcpy(Ptr->name, cname,CHANMAX); - - /* As spotted by jilles, dont bother to set this on remote users */ - if (IS_LOCAL(user)) - Ptr->SetDefaultModes(); - - Ptr->created = TS ? TS : Instance->Time(); - Ptr->age = Ptr->created; - *Ptr->topic = 0; - *Ptr->setby = 0; - Ptr->topicset = 0; - new_channel = true; + Ptr = new Channel(Instance, cname, TS); } else { @@ -268,39 +295,39 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo if (IS_LOCAL(user) && override == false) { MOD_RESULT = 0; - FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,Ptr,cname,privs)); + FOREACH_RESULT_I(Instance,I_OnUserPreJoin, OnUserPreJoin(user, Ptr, cname, privs, key ? key : "")); if (MOD_RESULT == 1) { return NULL; } else if (MOD_RESULT == 0) { - if (*Ptr->key) + if (!Ptr->key.empty()) { MOD_RESULT = 0; FOREACH_RESULT_I(Instance,I_OnCheckKey,OnCheckKey(user, Ptr, key ? key : "")); if (!MOD_RESULT) { - if ((!key) || strcmp(key,Ptr->key)) + if ((!key) || Ptr->key == key) { - user->WriteServ("475 %s %s :Cannot join channel (Incorrect channel key)",user->nick, Ptr->name); + user->WriteNumeric(475, "%s %s :Cannot join channel (Incorrect channel key)",user->nick.c_str(), Ptr->name.c_str()); return NULL; } } } - if (Ptr->modes[CM_INVITEONLY]) + if (Ptr->IsModeSet('i')) { MOD_RESULT = 0; FOREACH_RESULT_I(Instance,I_OnCheckInvite,OnCheckInvite(user, Ptr)); if (!MOD_RESULT) { - if (!user->IsInvited(Ptr->name)) + if (!user->IsInvited(Ptr->name.c_str())) { - user->WriteServ("473 %s %s :Cannot join channel (Invite only)",user->nick, Ptr->name); + user->WriteNumeric(473, "%s %s :Cannot join channel (Invite only)",user->nick.c_str(), Ptr->name.c_str()); return NULL; } } - user->RemoveInvite(Ptr->name); + user->RemoveInvite(Ptr->name.c_str()); } if (Ptr->limit) { @@ -310,7 +337,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo { if (Ptr->GetUserCounter() >= Ptr->limit) { - user->WriteServ("471 %s %s :Cannot join channel (Channel is full)",user->nick, Ptr->name); + user->WriteNumeric(471, "%s %s :Cannot join channel (Channel is full)",user->nick.c_str(), Ptr->name.c_str()); return NULL; } } @@ -319,7 +346,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo { if (Ptr->IsBanned(user)) { - user->WriteServ("474 %s %s :Cannot join channel (You're banned)",user->nick, Ptr->name); + user->WriteNumeric(474, "%s %s :Cannot join channel (You're banned)",user->nick.c_str(), Ptr->name.c_str()); return NULL; } } @@ -327,58 +354,18 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo } } - /* NOTE: If the user is an oper here, we can extend their user->chans by up to - * OperMaxchans. For remote users which are not bound by the channel limits, - * we can extend infinitely. Otherwise, nope, youre restricted to MaxChans. - */ - - - - /* - * We place no restrictions on remote users, users that are override-joining, or users that are - * currently in under MaxChans channels. For all others, they won't get in here. -- w00t - */ - if (!IS_LOCAL(user) || override == true || user->chans.size() < Instance->Config->MaxChans) - { - return chanrec::ForceChan(Instance, Ptr, user, privs); - } + /* As spotted by jilles, dont bother to set this on remote users */ + if (IS_LOCAL(user) && Ptr->GetUserCounter() == 0) + Ptr->SetDefaultModes(); - /* - * If the above fails, and the user is an oper -- we let them in if they are under OperMaxChans. - * Otherwise, they're stuck, and need to override to get in, etc. -- w00t - */ - if (IS_OPER(user)) - { - if (user->chans.size() < Instance->Config->OperMaxChans) - { - return chanrec::ForceChan(Instance, Ptr, user, privs); - } - } - - user->WriteServ("405 %s %s :You are on too many channels",user->nick, cname); - - if (new_channel) - { - /* Things went seriously pear shaped, so take this away. bwahaha. */ - chan_hash::iterator n = Instance->chanlist->find(cname); - if (n != Instance->chanlist->end()) - { - Ptr->DelUser(user); - DELETE(Ptr); - Instance->chanlist->erase(n); - } - } - - return NULL; + return Channel::ForceChan(Instance, Ptr, user, privs, bursting); } -chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr, userrec* user, const std::string &privs) +Channel* Channel::ForceChan(InspIRCd* Instance, Channel* Ptr, User* user, const std::string &privs, bool bursting) { - userrec* dummyuser = new userrec(Instance); std::string nick = user->nick; bool silent = false; - dummyuser->SetFd(FD_MAGIC_NUMBER); Ptr->AddUser(user); /* Just in case they have no permissions */ @@ -390,18 +377,15 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr, userrec* user, con ModeHandler* mh = Instance->Modes->FindPrefix(status); if (mh) { + /* Set, and make sure that the mode handler knows this mode was now set */ Ptr->SetPrefix(user, status, mh->GetPrefixRank(), true); - /* Make sure that the mode handler knows this mode was now set */ - mh->OnModeChange(dummyuser, dummyuser, Ptr, nick, true); + mh->OnModeChange(Instance->FakeClient, Instance->FakeClient, Ptr, nick, true); switch (mh->GetPrefix()) { - /* These logic ops are SAFE IN THIS CASE - * because if the entry doesnt exist, - * addressing operator[] creates it. - * If they do exist, it points to it. - * At all other times where we dont want - * to create an item if it doesnt exist, we + /* These logic ops are SAFE IN THIS CASE because if the entry doesnt exist, + * addressing operator[] creates it. If they do exist, it points to it. + * At all other times where we dont want to create an item if it doesnt exist, we * must stick to ::find(). */ case '@': @@ -417,25 +401,23 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr, userrec* user, con } } - delete dummyuser; - - FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, silent)); + FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, bursting, silent)); if (!silent) - Ptr->WriteChannel(user,"JOIN :%s",Ptr->name); + Ptr->WriteChannel(user,"JOIN :%s",Ptr->name.c_str()); /* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */ std::string ms = Instance->Modes->ModeString(user, Ptr); if ((Ptr->GetUserCounter() > 1) && (ms.length())) - Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name, ms.c_str()); + Ptr->WriteAllExceptSender(user, true, 0, "MODE %s +%s", Ptr->name.c_str(), ms.c_str()); /* Major improvement by Brain - we dont need to be calculating all this pointlessly for remote users */ if (IS_LOCAL(user)) { if (Ptr->topicset) { - user->WriteServ("332 %s %s :%s", user->nick, Ptr->name, Ptr->topic); - user->WriteServ("333 %s %s %s %lu", user->nick, Ptr->name, Ptr->setby, (unsigned long)Ptr->topicset); + user->WriteNumeric(332, "%s %s :%s", user->nick.c_str(), Ptr->name.c_str(), Ptr->topic.c_str()); + user->WriteNumeric(333, "%s %s %s %lu", user->nick.c_str(), Ptr->name.c_str(), Ptr->setby.c_str(), (unsigned long)Ptr->topicset); } Ptr->UserList(user); } @@ -443,14 +425,17 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr, userrec* user, con return Ptr; } -bool chanrec::IsBanned(userrec* user) +bool Channel::IsBanned(User* user) { char mask[MAXBUF]; int MOD_RESULT = 0; FOREACH_RESULT(I_OnCheckBan,OnCheckBan(user, this)); - if (!MOD_RESULT) + + if (MOD_RESULT == -1) + return true; + else if (MOD_RESULT == 0) { - snprintf(mask, MAXBUF, "%s!%s@%s", user->nick, user->ident, user->GetIPString()); + snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString()); for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++) { /* This allows CIDR ban matching @@ -466,11 +451,39 @@ bool chanrec::IsBanned(userrec* user) return false; } -/* chanrec::PartUser +bool Channel::IsExtBanned(User *user, char type) +{ + // XXX. do we need events? + char mask[MAXBUF]; + + snprintf(mask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), user->GetIPString()); + + for (BanList::iterator i = this->bans.begin(); i != this->bans.end(); i++) + { + if (i->data[0] != type || i->data[1] != ':') + continue; + + // Iterate past char and : to get to the mask without doing a data copy(!) + std::string maskptr = i->data.substr(2); + + /* This allows CIDR ban matching + * + * Full masked host Full unmasked host IP with/without CIDR + */ + if ((match(user->GetFullHost(), maskptr)) || (match(user->GetFullRealHost(), maskptr)) || (match(mask, maskptr, true))) + { + return true; + } + } + + return false; +} + +/* Channel::PartUser * remove a channel from a users record, and return the number of users left. - * Therefore, if this function returns 0 the caller should delete the chanrec. + * Therefore, if this function returns 0 the caller should delete the Channel. */ -long chanrec::PartUser(userrec *user, const char* reason) +long Channel::PartUser(User *user, const char* reason) { bool silent = false; @@ -483,7 +496,7 @@ long chanrec::PartUser(userrec *user, const char* reason) FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason ? reason : "", silent)); if (!silent) - this->WriteChannel(user, "PART %s%s%s", this->name, reason ? " :" : "", reason ? reason : ""); + this->WriteChannel(user, "PART %s%s%s", this->name.c_str(), reason ? " :" : "", reason ? reason : ""); user->chans.erase(i); this->RemoveAllPrefixes(user); @@ -495,7 +508,11 @@ long chanrec::PartUser(userrec *user, const char* reason) /* kill the record */ if (iter != ServerInstance->chanlist->end()) { - FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); + int MOD_RESULT = 0; + FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this)); + if (MOD_RESULT == 1) + return 1; // delete halted by module + FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this)); ServerInstance->chanlist->erase(iter); } return 0; @@ -504,7 +521,7 @@ long chanrec::PartUser(userrec *user, const char* reason) return this->GetUserCounter(); } -long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggerevents) +long Channel::ServerKickUser(User* user, const char* reason, bool triggerevents, const char* servername) { bool silent = false; @@ -520,6 +537,9 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven } } + if (servername == NULL || *ServerInstance->Config->HideWhoisServer) + servername = ServerInstance->Config->ServerName; + if (triggerevents) { FOREACH_MOD(I_OnUserKick,OnUserKick(NULL, user, this, reason, silent)); @@ -529,7 +549,7 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven if (i != user->chans.end()) { if (!silent) - this->WriteChannelWithServ(ServerInstance->Config->ServerName, "KICK %s %s :%s", this->name, user->nick, reason); + this->WriteChannelWithServ(servername, "KICK %s %s :%s", this->name.c_str(), user->nick.c_str(), reason); user->chans.erase(i); this->RemoveAllPrefixes(user); @@ -541,7 +561,11 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven /* kill the record */ if (iter != ServerInstance->chanlist->end()) { - FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); + int MOD_RESULT = 0; + FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this)); + if (MOD_RESULT == 1) + return 1; // delete halted by module + FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this)); ServerInstance->chanlist->erase(iter); } return 0; @@ -550,7 +574,7 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven return this->GetUserCounter(); } -long chanrec::KickUser(userrec *src, userrec *user, const char* reason) +long Channel::KickUser(User *src, User *user, const char* reason) { bool silent = false; @@ -561,12 +585,12 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) { if (!this->HasUser(user)) { - src->WriteServ("441 %s %s %s :They are not on that channel",src->nick, user->nick, this->name); + src->WriteNumeric(441, "%s %s %s :They are not on that channel",src->nick.c_str(), user->nick.c_str(), this->name.c_str()); return this->GetUserCounter(); } if ((ServerInstance->ULine(user->server)) && (!ServerInstance->ULine(src->server))) { - src->WriteServ("482 %s %s :Only a u-line may kick a u-line from a channel.",src->nick, this->name); + src->WriteNumeric(482, "%s %s :Only a u-line may kick a u-line from a channel.",src->nick.c_str(), this->name.c_str()); return this->GetUserCounter(); } int MOD_RESULT = 0; @@ -591,7 +615,7 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) int us = this->GetStatus(user); if ((them < STATUS_HOP) || (them < us)) { - src->WriteServ("482 %s %s :You must be a channel %soperator",src->nick, this->name, them == STATUS_HOP ? "" : "half-"); + src->WriteNumeric(482, "%s %s :You must be a channel %soperator",src->nick.c_str(), this->name.c_str(), them == STATUS_HOP ? "" : "half-"); return this->GetUserCounter(); } } @@ -605,7 +629,7 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) { /* zap it from the channel list of the user */ if (!silent) - this->WriteChannel(src, "KICK %s %s :%s", this->name, user->nick, reason); + this->WriteChannel(src, "KICK %s %s :%s", this->name.c_str(), user->nick.c_str(), reason); user->chans.erase(i); this->RemoveAllPrefixes(user); @@ -614,12 +638,16 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) if (!this->DelUser(user)) /* if there are no users left on the channel */ { - chan_hash::iterator iter = ServerInstance->chanlist->find(this->name); + chan_hash::iterator iter = ServerInstance->chanlist->find(this->name.c_str()); /* kill the record */ if (iter != ServerInstance->chanlist->end()) { - FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); + int MOD_RESULT = 0; + FOREACH_RESULT_I(ServerInstance,I_OnChannelPreDelete, OnChannelPreDelete(this)); + if (MOD_RESULT == 1) + return 1; // delete halted by module + FOREACH_MOD(I_OnChannelDelete, OnChannelDelete(this)); ServerInstance->chanlist->erase(iter); } return 0; @@ -628,7 +656,7 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) return this->GetUserCounter(); } -void chanrec::WriteChannel(userrec* user, char* text, ...) +void Channel::WriteChannel(User* user, const char* text, ...) { char textbuffer[MAXBUF]; va_list argsPtr; @@ -643,7 +671,7 @@ void chanrec::WriteChannel(userrec* user, char* text, ...) this->WriteChannel(user, std::string(textbuffer)); } -void chanrec::WriteChannel(userrec* user, const std::string &text) +void Channel::WriteChannel(User* user, const std::string &text) { CUList *ulist = this->GetUsers(); char tb[MAXBUF]; @@ -651,7 +679,7 @@ void chanrec::WriteChannel(userrec* user, const std::string &text) if (!user) return; - snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str()); + snprintf(tb,MAXBUF,":%s %s", user->GetFullHost().c_str(), text.c_str()); std::string out = tb; for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) @@ -661,7 +689,7 @@ void chanrec::WriteChannel(userrec* user, const std::string &text) } } -void chanrec::WriteChannelWithServ(const char* ServName, const char* text, ...) +void Channel::WriteChannelWithServ(const char* ServName, const char* text, ...) { char textbuffer[MAXBUF]; va_list argsPtr; @@ -676,12 +704,12 @@ void chanrec::WriteChannelWithServ(const char* ServName, const char* text, ...) this->WriteChannelWithServ(ServName, std::string(textbuffer)); } -void chanrec::WriteChannelWithServ(const char* ServName, const std::string &text) +void Channel::WriteChannelWithServ(const char* ServName, const std::string &text) { CUList *ulist = this->GetUsers(); char tb[MAXBUF]; - snprintf(tb,MAXBUF,":%s %s",ServName ? ServName : ServerInstance->Config->ServerName, text.c_str()); + snprintf(tb,MAXBUF,":%s %s", ServName ? ServName : ServerInstance->Config->ServerName, text.c_str()); std::string out = tb; for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) @@ -693,7 +721,7 @@ void chanrec::WriteChannelWithServ(const char* ServName, const std::string &text /* write formatted text from a source user to all users on a channel except * for the sender (for privmsg etc) */ -void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status, char* text, ...) +void Channel::WriteAllExceptSender(User* user, bool serversource, char status, const char* text, ...) { char textbuffer[MAXBUF]; va_list argsPtr; @@ -708,7 +736,7 @@ void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status this->WriteAllExceptSender(user, serversource, status, std::string(textbuffer)); } -void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CUList &except_list, char* text, ...) +void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const char* text, ...) { char textbuffer[MAXBUF]; va_list argsPtr; @@ -723,34 +751,22 @@ void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CULi this->WriteAllExcept(user, serversource, status, except_list, std::string(textbuffer)); } -void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CUList &except_list, const std::string &text) +void Channel::WriteAllExcept(User* user, bool serversource, char status, CUList &except_list, const std::string &text) { - CUList *ulist; + CUList *ulist = this->GetUsers(); char tb[MAXBUF]; - switch (status) - { - case '@': - ulist = this->GetOppedUsers(); - break; - case '%': - ulist = this->GetHalfoppedUsers(); - break; - case '+': - ulist = this->GetVoicedUsers(); - break; - default: - ulist = this->GetUsers(); - break; - } - - snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str()); + snprintf(tb,MAXBUF,":%s %s", user->GetFullHost().c_str(), text.c_str()); std::string out = tb; for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { if ((IS_LOCAL(i->first)) && (except_list.find(i->first) == except_list.end())) { + /* User doesnt have the status we're after */ + if (status && !strchr(this->GetAllPrefixChars(i->first), status)) + continue; + if (serversource) i->first->WriteServ(text); else @@ -759,7 +775,7 @@ void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CULi } } -void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status, const std::string& text) +void Channel::WriteAllExceptSender(User* user, bool serversource, char status, const std::string& text) { CUList except_list; except_list[user] = user->nick; @@ -770,7 +786,7 @@ void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status * return a count of the users on a specific channel accounting for * invisible users who won't increase the count. e.g. for /LIST */ -int chanrec::CountInvisible() +int Channel::CountInvisible() { int count = 0; CUList *ulist= this->GetUsers(); @@ -783,7 +799,7 @@ int chanrec::CountInvisible() return count; } -char* chanrec::ChanModes(bool showkey) +char* Channel::ChanModes(bool showkey) { static char scratch[MAXBUF]; static char sparam[MAXBUF]; @@ -793,7 +809,7 @@ char* chanrec::ChanModes(bool showkey) *scratch = '\0'; *sparam = '\0'; - /* This was still iterating up to 190, chanrec::modes is only 64 elements -- Om */ + /* This was still iterating up to 190, Channel::modes is only 64 elements -- Om */ for(int n = 0; n < 64; n++) { if(this->modes[n]) @@ -837,20 +853,30 @@ char* chanrec::ChanModes(bool showkey) /* compile a userlist of a channel into a string, each nick seperated by * spaces and op, voice etc status shown as @ and +, and send it to 'user' */ -void chanrec::UserList(userrec *user, CUList *ulist) +void Channel::UserList(User *user, CUList *ulist) { char list[MAXBUF]; size_t dlen, curlen; int MOD_RESULT = 0; + bool call_modules = true; if (!IS_LOCAL(user)) return; FOREACH_RESULT(I_OnUserList,OnUserList(user, this, ulist)); if (MOD_RESULT == 1) - return; + call_modules = false; - dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, this->name); + if (MOD_RESULT != -1) + { + if ((this->IsModeSet('s')) && (!this->HasUser(user))) + { + user->WriteNumeric(401, "%s %s :No such nick/channel",user->nick.c_str(), this->name.c_str()); + return; + } + } + + dlen = curlen = snprintf(list,MAXBUF,"%s %c %s :", user->nick.c_str(), this->IsModeSet('s') ? '@' : this->IsModeSet('p') ? '*' : '=', this->name.c_str()); int numusers = 0; char* ptr = list + dlen; @@ -865,7 +891,7 @@ void chanrec::UserList(userrec *user, CUList *ulist) for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if ((!has_user) && (i->first->modes[UM_INVISIBLE])) + if ((!has_user) && (i->first->IsModeSet('i'))) { /* * user is +i, and source not on the channel, does not show @@ -877,39 +903,51 @@ void chanrec::UserList(userrec *user, CUList *ulist) if (i->first->Visibility && !i->first->Visibility->VisibleTo(user)) continue; - size_t ptrlen = snprintf(ptr, MAXBUF, "%s%s ", this->GetPrefixChar(i->first), i->second.c_str()); - /* OnUserList can change this - reset it back to normal */ - i->second = i->first->nick; + std::string prefixlist = this->GetPrefixChar(i->first); + std::string nick = i->first->nick; - curlen += ptrlen; - ptr += ptrlen; - - numusers++; + if (call_modules) + { + FOREACH_MOD(I_OnNamesListItem, OnNamesListItem(user, i->first, this, prefixlist, nick)); + + /* Nick was nuked, a module wants us to skip it */ + if (nick.empty()) + continue; + } + + size_t ptrlen = 0; - if (curlen > (480-NICKMAX)) + if (curlen + prefixlist.length() + nick.length() + 1 > 480) { /* list overflowed into multiple numerics */ user->WriteServ(std::string(list)); /* reset our lengths */ - dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, this->name); + dlen = curlen = snprintf(list,MAXBUF,"%s %c %s :", user->nick.c_str(), this->IsModeSet('s') ? '@' : this->IsModeSet('p') ? '*' : '=', this->name.c_str()); ptr = list + dlen; ptrlen = 0; numusers = 0; } + + ptrlen = snprintf(ptr, MAXBUF, "%s%s ", prefixlist.c_str(), nick.c_str()); + + curlen += ptrlen; + ptr += ptrlen; + + numusers++; } /* if whats left in the list isnt empty, send it */ if (numusers) { - user->WriteServ(std::string(list)); + user->WriteNumeric(353,std::string(list)); } - user->WriteServ("366 %s %s :End of /NAMES list.", user->nick, this->name); + user->WriteNumeric(366, "%s %s :End of /NAMES list.", user->nick.c_str(), this->name.c_str()); } -long chanrec::GetMaxBans() +long Channel::GetMaxBans() { /* Return the cached value if there is one */ if (this->maxbans) @@ -918,7 +956,7 @@ long chanrec::GetMaxBans() /* If there isnt one, we have to do some O(n) hax to find it the first time. (ick) */ for (std::map::iterator n = ServerInstance->Config->maxbans.begin(); n != ServerInstance->Config->maxbans.end(); n++) { - if (match(this->name,n->first.c_str())) + if (match(this->name,n->first)) { this->maxbans = n->second; return n->second; @@ -930,7 +968,7 @@ long chanrec::GetMaxBans() return this->maxbans; } -void chanrec::ResetMaxBans() +void Channel::ResetMaxBans() { this->maxbans = 0; } @@ -939,7 +977,7 @@ void chanrec::ResetMaxBans() * % for halfop etc. If the user has several modes set, the highest mode * the user has must be returned. */ -const char* chanrec::GetPrefixChar(userrec *user) +const char* Channel::GetPrefixChar(User *user) { static char pf[2] = {0, 0}; @@ -962,7 +1000,8 @@ const char* chanrec::GetPrefixChar(userrec *user) return pf; } -const char* chanrec::GetAllPrefixChars(userrec* user) + +const char* Channel::GetAllPrefixChars(User* user) { static char prefix[MAXBUF]; int ctr = 0; @@ -982,7 +1021,7 @@ const char* chanrec::GetAllPrefixChars(userrec* user) return prefix; } -unsigned int chanrec::GetPrefixValue(userrec* user) +unsigned int Channel::GetPrefixValue(User* user) { prefixlist::iterator n = prefixes.find(user); if (n != prefixes.end()) @@ -993,7 +1032,7 @@ unsigned int chanrec::GetPrefixValue(userrec* user) return 0; } -int chanrec::GetStatusFlags(userrec *user) +int Channel::GetStatusFlags(User *user) { UCListIter i = user->chans.find(this); if (i != user->chans.end()) @@ -1003,7 +1042,7 @@ int chanrec::GetStatusFlags(userrec *user) return 0; } -int chanrec::GetStatus(userrec *user) +int Channel::GetStatus(User *user) { if (ServerInstance->ULine(user->server)) return STATUS_OP; @@ -1028,7 +1067,7 @@ int chanrec::GetStatus(userrec *user) return STATUS_NORMAL; } -void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, bool adding) +void Channel::SetPrefix(User* user, char prefix, unsigned int prefix_value, bool adding) { prefixlist::iterator n = prefixes.find(user); prefixtype pfx = std::make_pair(prefix,prefix_value); @@ -1051,7 +1090,7 @@ void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, b { pfxcontainer one; one.push_back(pfx); - prefixes.insert(std::make_pair(user, one)); + prefixes.insert(std::make_pair(user, one)); } } else @@ -1065,7 +1104,7 @@ void chanrec::SetPrefix(userrec* user, char prefix, unsigned int prefix_value, b } } -void chanrec::RemoveAllPrefixes(userrec* user) +void Channel::RemoveAllPrefixes(User* user) { prefixlist::iterator n = prefixes.find(user); if (n != prefixes.end())