X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fchannels.cpp;h=e4b58a1a4853cd7b1a2d097c25358964537a8c8e;hb=959c67db271b593d32db022841d0723654a8dd67;hp=3f74698d507234bd06d4361ed9ca41fcf14ace3a;hpb=beb18cb120477fe85f60393c47151744713efe59;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/channels.cpp b/src/channels.cpp index 3f74698d5..e4b58a1a4 100644 --- a/src/channels.cpp +++ b/src/channels.cpp @@ -1,21 +1,16 @@ -/* +------------------------------------+ - * | Inspire Internet Relay Chat Daemon | - * +------------------------------------+ +/* +------------------------------------+ + * | Inspire Internet Relay Chat Daemon | + * +------------------------------------+ + * + * InspIRCd: (C) 2002-2007 InspIRCd Development Team + * See: http://www.inspircd.org/wiki/index.php/Credits * - * InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev. - * E-mail: - * - * - * - * Written by Craig Edwards, Craig McLure, and others. * This program is free but copyrighted software; see - * the file COPYING for details. + * the file COPYING for details. * * --------------------------------------------------- */ -using namespace std; - #include #include "configreader.h" #include "inspircd.h" @@ -27,9 +22,9 @@ using namespace std; chanrec::chanrec(InspIRCd* Instance) : ServerInstance(Instance) { *name = *topic = *setby = *key = 0; - created = topicset = limit = 0; - internal_userlist.clear(); + maxbans = created = topicset = limit = 0; memset(&modes,0,64); + age = ServerInstance->Time(true); } void chanrec::SetMode(char mode,bool mode_on) @@ -42,21 +37,12 @@ void chanrec::SetMode(char mode,bool mode_on) void chanrec::SetModeParam(char mode,const char* parameter,bool mode_on) { - ServerInstance->Log(DEBUG,"SetModeParam called"); - CustomModeList::iterator n = custom_mode_params.find(mode); if (mode_on) { if (n == custom_mode_params.end()) - { custom_mode_params[mode] = strdup(parameter); - ServerInstance->Log(DEBUG,"Custom mode parameter %c %s added",mode,parameter); - } - else - { - ServerInstance->Log(DEBUG, "Tried to set custom mode parameter for %c '%s' when it was already '%s'", mode, parameter, n->second); - } } else { @@ -75,22 +61,18 @@ bool chanrec::IsModeSet(char mode) std::string chanrec::GetModeParameter(char mode) { - if (mode == 'k') + switch (mode) { - return this->key; - } - else if (mode == 'l') - { - return ConvToStr(this->limit); - } - else - { - CustomModeList::iterator n = custom_mode_params.find(mode); - if (n != custom_mode_params.end()) - { - return n->second; - } - return ""; + case 'k': + return this->key; + case 'l': + return ConvToStr(this->limit); + default: + CustomModeList::iterator n = custom_mode_params.find(mode); + if (n != custom_mode_params.end()) + return n->second; + return ""; + break; } } @@ -101,7 +83,7 @@ long chanrec::GetUserCounter() void chanrec::AddUser(userrec* user) { - internal_userlist[user] = user; + internal_userlist[user] = user->nick; } unsigned long chanrec::DelUser(userrec* user) @@ -127,7 +109,7 @@ bool chanrec::HasUser(userrec* user) void chanrec::AddOppedUser(userrec* user) { - internal_op_userlist[user] = user; + internal_op_userlist[user] = user->nick; } void chanrec::DelOppedUser(userrec* user) @@ -142,7 +124,7 @@ void chanrec::DelOppedUser(userrec* user) void chanrec::AddHalfoppedUser(userrec* user) { - internal_halfop_userlist[user] = user; + internal_halfop_userlist[user] = user->nick; } void chanrec::DelHalfoppedUser(userrec* user) @@ -157,7 +139,7 @@ void chanrec::DelHalfoppedUser(userrec* user) void chanrec::AddVoicedUser(userrec* user) { - internal_voice_userlist[user] = user; + internal_voice_userlist[user] = user->nick; } void chanrec::DelVoicedUser(userrec* user) @@ -194,7 +176,7 @@ CUList* chanrec::GetVoicedUsers() * add a channel to a user, creating the record for it if needed and linking * it to the user record */ -chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bool override, const char* key) +chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bool override, const char* key, time_t TS) { if (!user || !cn) return NULL; @@ -210,9 +192,12 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo if (!Ptr) { + if ((!IS_LOCAL(user)) && (!TS)) + Instance->Log(DEBUG,"*** BUG *** chanrec::JoinUser called for REMOTE user '%s' on channel '%s' but no TS given!", user->nick, cn); + privs = "@"; - if (IS_LOCAL(user)) + if (IS_LOCAL(user) && override == false) { MOD_RESULT = 0; FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,NULL,cname,privs)); @@ -222,15 +207,19 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo /* create a new one */ Ptr = new chanrec(Instance); - Instance->chanlist[cname] = Ptr; + (*(Instance->chanlist))[cname] = Ptr; strlcpy(Ptr->name, cname,CHANMAX); - Ptr->modes[CM_TOPICLOCK] = Ptr->modes[CM_NOEXTERNAL] = 1; - Ptr->created = Instance->Time(); + + /* As spotted by jilles, dont bother to set this on remote users */ + if (IS_LOCAL(user)) + Ptr->modes[CM_TOPICLOCK] = Ptr->modes[CM_NOEXTERNAL] = 1; + + Ptr->created = TS ? TS : Instance->Time(); + Ptr->age = Ptr->created; *Ptr->topic = 0; *Ptr->setby = 0; Ptr->topicset = 0; - Instance->Log(DEBUG,"chanrec::JoinUser(): created: %s",cname); new_channel = true; } else @@ -243,7 +232,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo * remote users are allowed us to bypass channel modes * and bans (used by servers) */ - if (IS_LOCAL(user)) /* was a check on fd > -1 */ + if (IS_LOCAL(user) && override == false) { MOD_RESULT = 0; FOREACH_RESULT_I(Instance,I_OnUserPreJoin,OnUserPreJoin(user,Ptr,cname,privs)); @@ -269,11 +258,10 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo if (Ptr->modes[CM_INVITEONLY]) { MOD_RESULT = 0; - irc::string xname(Ptr->name); FOREACH_RESULT_I(Instance,I_OnCheckInvite,OnCheckInvite(user, Ptr)); if (!MOD_RESULT) { - if (user->IsInvited(xname)) + if (user->IsInvited(Ptr->name)) { /* user was invited to channel */ /* there may be an optional channel NOTICE here */ @@ -284,7 +272,7 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo return NULL; } } - user->RemoveInvite(xname); + user->RemoveInvite(Ptr->name); } if (Ptr->limit) { @@ -309,91 +297,58 @@ chanrec* chanrec::JoinUser(InspIRCd* Instance, userrec *user, const char* cn, bo } } } - else - { - Instance->Log(DEBUG,"chanrec::JoinUser(): Overridden checks"); - } - } - - for (UserChanList::const_iterator index = user->chans.begin(); index != user->chans.end(); index++) - { - if ((*index)->channel == NULL) - { - return chanrec::ForceChan(Instance, Ptr, *index, user, privs); - } } - /* - * XXX: If the user is an oper here, we can just extend their user->chans vector by one - * and put the channel in here. Same for remote users which are not bound by - * the channel limits. Otherwise, nope, youre boned. + /* NOTE: If the user is an oper here, we can extend their user->chans by up to + * OperMaxchans. For remote users which are not bound by the channel limits, + * we can extend infinitely. Otherwise, nope, youre restricted to MaxChans. */ - if (!IS_LOCAL(user)) /* was a check on fd < 0 */ + if (!IS_LOCAL(user) || override == true) { - ucrec* a = new ucrec(); - chanrec* c = chanrec::ForceChan(Instance, Ptr, a, user, privs); - user->chans.push_back(a); - return c; + return chanrec::ForceChan(Instance, Ptr, user, privs); } else if (*user->oper) { - /* Oper allows extension up to the OPERMAXCHANS value */ - if (user->chans.size() < OPERMAXCHANS) + /* Oper allows extension up to the OperMaxchans value */ + if (user->chans.size() < Instance->Config->OperMaxChans) { - ucrec* a = new ucrec(); - chanrec* c = chanrec::ForceChan(Instance, Ptr, a, user, privs); - user->chans.push_back(a); - return c; + return chanrec::ForceChan(Instance, Ptr, user, privs); } } + else if (user->chans.size() < Instance->Config->MaxChans) + { + return chanrec::ForceChan(Instance, Ptr, user, privs); + } + user->WriteServ("405 %s %s :You are on too many channels",user->nick, cname); if (new_channel) { - Instance->Log(DEBUG,"BLAMMO, Whacking channel."); /* Things went seriously pear shaped, so take this away. bwahaha. */ - chan_hash::iterator n = Instance->chanlist.find(cname); - if (n != Instance->chanlist.end()) + chan_hash::iterator n = Instance->chanlist->find(cname); + if (n != Instance->chanlist->end()) { Ptr->DelUser(user); DELETE(Ptr); - Instance->chanlist.erase(n); - for (unsigned int index =0; index < user->chans.size(); index++) - { - if (user->chans[index]->channel == Ptr) - { - user->chans[index]->channel = NULL; - user->chans[index]->uc_modes = 0; - } - } - } - } - else - { - for (unsigned int index =0; index < user->chans.size(); index++) - { - if (user->chans[index]->channel == Ptr) - { - user->chans[index]->channel = NULL; - user->chans[index]->uc_modes = 0; - } + Instance->chanlist->erase(n); } } + return NULL; } -chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* user, const std::string &privs) +chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr, userrec* user, const std::string &privs) { userrec* dummyuser = new userrec(Instance); std::string nick = user->nick; + bool silent = false; - a->uc_modes = 0; dummyuser->SetFd(FD_MAGIC_NUMBER); - - a->channel = Ptr; Ptr->AddUser(user); - user->ModChannelCount(1); + + /* Just in case they have no permissions */ + user->chans[Ptr] = 0; for (std::string::const_iterator x = privs.begin(); x != privs.end(); x++) { @@ -404,12 +359,36 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* u Ptr->SetPrefix(user, status, mh->GetPrefixRank(), true); /* Make sure that the mode handler knows this mode was now set */ mh->OnModeChange(dummyuser, dummyuser, Ptr, nick, true); + + switch (mh->GetPrefix()) + { + /* These logic ops are SAFE IN THIS CASE + * because if the entry doesnt exist, + * addressing operator[] creates it. + * If they do exist, it points to it. + * At all other times where we dont want + * to create an item if it doesnt exist, we + * must stick to ::find(). + */ + case '@': + user->chans[Ptr] |= UCMODE_OP; + break; + case '%': + user->chans[Ptr] |= UCMODE_HOP; + break; + case '+': + user->chans[Ptr] |= UCMODE_VOICE; + break; + } } } delete dummyuser; - Ptr->WriteChannel(user,"JOIN :%s",Ptr->name); + FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user, Ptr, silent)); + + if (!silent) + Ptr->WriteChannel(user,"JOIN :%s",Ptr->name); /* Theyre not the first ones in here, make sure everyone else sees the modes we gave the user */ std::string ms = Instance->Modes->ModeString(user, Ptr); @@ -426,7 +405,7 @@ chanrec* chanrec::ForceChan(InspIRCd* Instance, chanrec* Ptr,ucrec *a,userrec* u } Ptr->UserList(user); } - FOREACH_MOD_I(Instance,I_OnUserJoin,OnUserJoin(user,Ptr)); + FOREACH_MOD_I(Instance,I_OnPostJoin,OnPostJoin(user, Ptr)); return Ptr; } @@ -459,33 +438,31 @@ bool chanrec::IsBanned(userrec* user) */ long chanrec::PartUser(userrec *user, const char* reason) { + bool silent = false; + if (!user) return this->GetUserCounter(); - for (unsigned int i =0; i < user->chans.size(); i++) + UCListIter i = user->chans.find(this); + if (i != user->chans.end()) { - /* zap it from the channel list of the user */ - if (user->chans[i]->channel == this) - { - FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason ? reason : "")); + FOREACH_MOD(I_OnUserPart,OnUserPart(user, this, reason ? reason : "", silent)); + + if (!silent) this->WriteChannel(user, "PART %s%s%s", this->name, reason ? " :" : "", reason ? reason : ""); - user->chans[i]->uc_modes = 0; - user->chans[i]->channel = NULL; - user->ModChannelCount(-1); - this->RemoveAllPrefixes(user); - break; - } + + user->chans.erase(i); + this->RemoveAllPrefixes(user); } if (!this->DelUser(user)) /* if there are no users left on the channel... */ { - chan_hash::iterator iter = ServerInstance->chanlist.find(this->name); + chan_hash::iterator iter = ServerInstance->chanlist->find(this->name); /* kill the record */ - if (iter != ServerInstance->chanlist.end()) + if (iter != ServerInstance->chanlist->end()) { - ServerInstance->Log(DEBUG,"del_channel: destroyed: %s", this->name); FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); - ServerInstance->chanlist.erase(iter); + ServerInstance->chanlist->erase(iter); } return 0; } @@ -495,6 +472,8 @@ long chanrec::PartUser(userrec *user, const char* reason) long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggerevents) { + bool silent = false; + if (!user || !reason) return this->GetUserCounter(); @@ -509,29 +488,27 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven if (triggerevents) { - FOREACH_MOD(I_OnUserKick,OnUserKick(NULL,user,this,reason)); + FOREACH_MOD(I_OnUserKick,OnUserKick(NULL, user, this, reason, silent)); } - for (unsigned int i =0; i < user->chans.size(); i++) + UCListIter i = user->chans.find(this); + if (i != user->chans.end()) { - if (user->chans[i]->channel == this) - { + if (!silent) this->WriteChannelWithServ(ServerInstance->Config->ServerName, "KICK %s %s :%s", this->name, user->nick, reason); - user->chans[i]->uc_modes = 0; - user->chans[i]->channel = NULL; - this->RemoveAllPrefixes(user); - break; - } + + user->chans.erase(i); + this->RemoveAllPrefixes(user); } if (!this->DelUser(user)) { - chan_hash::iterator iter = ServerInstance->chanlist.find(this->name); + chan_hash::iterator iter = ServerInstance->chanlist->find(this->name); /* kill the record */ - if (iter != ServerInstance->chanlist.end()) + if (iter != ServerInstance->chanlist->end()) { FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); - ServerInstance->chanlist.erase(iter); + ServerInstance->chanlist->erase(iter); } return 0; } @@ -541,6 +518,8 @@ long chanrec::ServerKickUser(userrec* user, const char* reason, bool triggereven long chanrec::KickUser(userrec *src, userrec *user, const char* reason) { + bool silent = false; + if (!src || !user || !reason) return this->GetUserCounter(); @@ -585,31 +564,29 @@ long chanrec::KickUser(userrec *src, userrec *user, const char* reason) } } - FOREACH_MOD(I_OnUserKick,OnUserKick(src,user,this,reason)); - - for (UserChanList::const_iterator i = user->chans.begin(); i != user->chans.end(); i++) + FOREACH_MOD(I_OnUserKick,OnUserKick(src, user, this, reason, silent)); + + UCListIter i = user->chans.find(this); + if (i != user->chans.end()) { /* zap it from the channel list of the user */ - if ((*i)->channel == this) - { + if (!silent) this->WriteChannel(src, "KICK %s %s :%s", this->name, user->nick, reason); - (*i)->uc_modes = 0; - (*i)->channel = NULL; - this->RemoveAllPrefixes(user); - break; - } + + user->chans.erase(i); + this->RemoveAllPrefixes(user); } if (!this->DelUser(user)) /* if there are no users left on the channel */ { - chan_hash::iterator iter = ServerInstance->chanlist.find(this->name); + chan_hash::iterator iter = ServerInstance->chanlist->find(this->name); /* kill the record */ - if (iter != ServerInstance->chanlist.end()) + if (iter != ServerInstance->chanlist->end()) { FOREACH_MOD(I_OnChannelDelete,OnChannelDelete(this)); - ServerInstance->chanlist.erase(iter); + ServerInstance->chanlist->erase(iter); } return 0; } @@ -635,14 +612,18 @@ void chanrec::WriteChannel(userrec* user, char* text, ...) void chanrec::WriteChannel(userrec* user, const std::string &text) { CUList *ulist = this->GetUsers(); + char tb[MAXBUF]; if (!user) return; + snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str()); + std::string out = tb; + for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if (IS_LOCAL(i->second)) - user->WriteTo(i->second,text); + if (IS_LOCAL(i->first)) + i->first->Write(out); } } @@ -664,11 +645,15 @@ void chanrec::WriteChannelWithServ(const char* ServName, const char* text, ...) void chanrec::WriteChannelWithServ(const char* ServName, const std::string &text) { CUList *ulist = this->GetUsers(); + char tb[MAXBUF]; + + snprintf(tb,MAXBUF,":%s %s",ServName ? ServName : ServerInstance->Config->ServerName, text.c_str()); + std::string out = tb; for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if (IS_LOCAL(i->second)) - i->second->WriteServ(text); + if (IS_LOCAL(i->first)) + i->first->Write(out); } } @@ -689,9 +674,25 @@ void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status this->WriteAllExceptSender(user, serversource, status, std::string(textbuffer)); } -void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status, const std::string& text) +void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CUList &except_list, char* text, ...) +{ + char textbuffer[MAXBUF]; + va_list argsPtr; + + if (!text) + return; + + va_start(argsPtr, text); + vsnprintf(textbuffer, MAXBUF, text, argsPtr); + va_end(argsPtr); + + this->WriteAllExcept(user, serversource, status, except_list, std::string(textbuffer)); +} + +void chanrec::WriteAllExcept(userrec* user, bool serversource, char status, CUList &except_list, const std::string &text) { CUList *ulist; + char tb[MAXBUF]; switch (status) { @@ -709,18 +710,28 @@ void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status break; } + snprintf(tb,MAXBUF,":%s %s",user->GetFullHost(),text.c_str()); + std::string out = tb; + for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if ((IS_LOCAL(i->second)) && (user != i->second)) + if ((IS_LOCAL(i->first)) && (except_list.find(i->first) == except_list.end())) { if (serversource) - i->second->WriteServ(text); + i->first->WriteServ(text); else - i->second->WriteFrom(user,text); + i->first->Write(out); } } } +void chanrec::WriteAllExceptSender(userrec* user, bool serversource, char status, const std::string& text) +{ + CUList except_list; + except_list[user] = user->nick; + this->WriteAllExcept(user, serversource, status, except_list, std::string(text)); +} + /* * return a count of the users on a specific channel accounting for * invisible users who won't increase the count. e.g. for /LIST @@ -731,7 +742,7 @@ int chanrec::CountInvisible() CUList *ulist= this->GetUsers(); for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if (!(i->second->modes[UM_INVISIBLE])) + if (!(i->first->IsModeSet('i'))) count++; } @@ -743,7 +754,7 @@ char* chanrec::ChanModes(bool showkey) static char scratch[MAXBUF]; static char sparam[MAXBUF]; char* offset = scratch; - std::string extparam = ""; + std::string extparam; *scratch = '\0'; *sparam = '\0'; @@ -792,7 +803,7 @@ char* chanrec::ChanModes(bool showkey) /* compile a userlist of a channel into a string, each nick seperated by * spaces and op, voice etc status shown as @ and +, and send it to 'user' */ -void chanrec::UserList(userrec *user) +void chanrec::UserList(userrec *user, CUList *ulist) { char list[MAXBUF]; size_t dlen, curlen; @@ -801,19 +812,17 @@ void chanrec::UserList(userrec *user) if (!IS_LOCAL(user)) return; - FOREACH_RESULT(I_OnUserList,OnUserList(user, this)); - ServerInstance->Log(DEBUG,"MOD_RESULT for UserList = %d",MOD_RESULT); + FOREACH_RESULT(I_OnUserList,OnUserList(user, this, ulist)); if (MOD_RESULT == 1) return; - ServerInstance->Log(DEBUG,"Using builtin NAMES list generation"); - dlen = curlen = snprintf(list,MAXBUF,"353 %s = %s :", user->nick, this->name); int numusers = 0; char* ptr = list + dlen; - CUList *ulist= this->GetUsers(); + if (!ulist) + ulist = this->GetUsers(); /* Improvement by Brain - this doesnt change in value, so why was it inside * the loop? @@ -822,7 +831,7 @@ void chanrec::UserList(userrec *user) for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++) { - if ((!has_user) && (i->second->modes[UM_INVISIBLE])) + if ((!has_user) && (i->first->modes[UM_INVISIBLE])) { /* * user is +i, and source not on the channel, does not show @@ -831,7 +840,12 @@ void chanrec::UserList(userrec *user) continue; } - size_t ptrlen = snprintf(ptr, MAXBUF, "%s%s ", this->GetPrefixChar(i->second), i->second->nick); + if (i->first->Visibility && !i->first->Visibility->VisibleTo(user)) + continue; + + size_t ptrlen = snprintf(ptr, MAXBUF, "%s%s ", this->GetPrefixChar(i->first), i->second.c_str()); + /* OnUserList can change this - reset it back to normal */ + i->second = i->first->nick; curlen += ptrlen; ptr += ptrlen; @@ -863,16 +877,29 @@ void chanrec::UserList(userrec *user) long chanrec::GetMaxBans() { + /* Return the cached value if there is one */ + if (this->maxbans) + return this->maxbans; + + /* If there isnt one, we have to do some O(n) hax to find it the first time. (ick) */ for (std::map::iterator n = ServerInstance->Config->maxbans.begin(); n != ServerInstance->Config->maxbans.end(); n++) { if (match(this->name,n->first.c_str())) { + this->maxbans = n->second; return n->second; } } - return 64; + + /* Screw it, just return the default of 64 */ + this->maxbans = 64; + return this->maxbans; } +void chanrec::ResetMaxBans() +{ + this->maxbans = 0; +} /* returns the status character for a given user on a channel, e.g. @ for op, * % for halfop etc. If the user has several modes set, the highest mode @@ -932,43 +959,37 @@ unsigned int chanrec::GetPrefixValue(userrec* user) return 0; } - int chanrec::GetStatusFlags(userrec *user) { - for (std::vector::const_iterator i = user->chans.begin(); i != user->chans.end(); i++) + UCListIter i = user->chans.find(this); + if (i != user->chans.end()) { - if ((*i)->channel == this) - { - return (*i)->uc_modes; - } + return i->second; } return 0; } - int chanrec::GetStatus(userrec *user) { if (ServerInstance->ULine(user->server)) return STATUS_OP; - for (std::vector::const_iterator i = user->chans.begin(); i != user->chans.end(); i++) + UCListIter i = user->chans.find(this); + if (i != user->chans.end()) { - if ((*i)->channel == this) + if ((i->second & UCMODE_OP) > 0) { - if (((*i)->uc_modes & UCMODE_OP) > 0) - { - return STATUS_OP; - } - if (((*i)->uc_modes & UCMODE_HOP) > 0) - { - return STATUS_HOP; - } - if (((*i)->uc_modes & UCMODE_VOICE) > 0) - { - return STATUS_VOICE; - } - return STATUS_NORMAL; + return STATUS_OP; + } + if ((i->second & UCMODE_HOP) > 0) + { + return STATUS_HOP; } + if ((i->second & UCMODE_VOICE) > 0) + { + return STATUS_VOICE; + } + return STATUS_NORMAL; } return STATUS_NORMAL; } @@ -1014,6 +1035,8 @@ void chanrec::RemoveAllPrefixes(userrec* user) { prefixlist::iterator n = prefixes.find(user); if (n != prefixes.end()) + { prefixes.erase(n); + } }