X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fcmd_nick.cpp;h=16b3d2b94e79e777fa0b1703d4f61f5945831767;hb=77123f4dec9f29105f6c0ceea0262cfe8e9eaa1a;hp=f35a8fd8c0b5e280b0802b9f0c162918a69966d1;hpb=53aaf31285c1168b1d0d1aca5e67b6323b0d0910;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/cmd_nick.cpp b/src/cmd_nick.cpp
index f35a8fd8c..16b3d2b94 100644
--- a/src/cmd_nick.cpp
+++ b/src/cmd_nick.cpp
@@ -2,10 +2,10 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  Inspire is copyright (C) 2002-2005 ChatSpike-Dev.
+ *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
  *                       E-mail:
- *                <brain.net>
- *                <Craig.net>
+ *                <brain@chatspike.net>
+ *                <Craig@chatspike.net>
  *
  * Written by Craig Edwards, Craig McLure, and others.
  * This program is free but copyrighted software; see
@@ -14,57 +14,31 @@
  * ---------------------------------------------------
  */
 
-using namespace std;
-
-#include "inspircd_config.h"
-#include "inspircd.h"
-#include "inspircd_io.h"
-#include <time.h>
 #include <string>
-#ifdef GCC3
-#include <ext/hash_map>
-#else
-#include <hash_map>
-#endif
-#include <map>
-#include <sstream>
 #include <vector>
-#include <deque>
+#include "inspircd_config.h"
+#include "configreader.h"
+#include "hash_map.h"
 #include "users.h"
-#include "ctables.h"
-#include "globals.h"
 #include "modules.h"
-#include "dynamic.h"
-#include "wildcard.h"
-#include "message.h"
 #include "commands.h"
-#include "mode.h"
 #include "xline.h"
-#include "inspstring.h"
 #include "dnsqueue.h"
 #include "dns.h"
 #include "helperfuncs.h"
 #include "hashcomp.h"
-#include "socketengine.h"
-#include "typedefs.h"
-#include "command_parse.h"
 #include "cmd_nick.h"
 
 extern ServerConfig* Config;
-extern InspIRCd* ServerInstance;
 extern int MODCOUNT;
 extern std::vector<Module*> modules;
 extern std::vector<ircd_module*> factory;
 extern time_t TIME;
-extern user_hash clientlist;
-extern chan_hash chanlist;
-extern whowas_hash whowas;
-extern std::vector<userrec*> all_opers;
-extern std::vector<userrec*> local_users;
-extern userrec* fd_ref_table[65536];
 
 void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 {
+	char oldnick[NICKMAX];
+
 	if (pcnt < 1) 
 	{
 		log(DEBUG,"not enough params for handle_nick");
@@ -92,20 +66,30 @@ void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 	}
 	if (irc::string(user->nick) == irc::string(parameters[0]))
 	{
-		log(DEBUG,"old nick is new nick, skipping");
-		strlcpy(user->nick,parameters[0],NICKMAX);
+		/* If its exactly the same, even case, dont do anything. */
+		if (!strcmp(user->nick,parameters[0]))
+			return;
+		/* Its a change of case. People insisted that they should be
+		 * able to do silly things like this even though the RFC says
+		 * the nick AAA is the same as the nick aaa.
+		 */
+		log(DEBUG,"old nick is new nick, not updating hash (case change only)");
+		strlcpy(oldnick, user->nick, NICKMAX - 1);
+		int MOD_RESULT = 0;
+		FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
+		if (MOD_RESULT)
+			return;
 		if (user->registered == 7)
 			WriteCommon(user,"NICK %s",parameters[0]);
+		strlcpy(user->nick, parameters[0], NICKMAX - 1);
+		FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(user,oldnick));
 		return;
 	}
 	else
 	{
-		if (strlen(parameters[0]) > 1)
+		if ((*parameters[0] == ':') && (*(parameters[0]+1) != 0))
 		{
-			if (parameters[0][0] == ':')
-			{
-				*parameters[0]++;
-			}
+			parameters[0]++;
 		}
 		if (matches_qline(parameters[0]))
 		{
@@ -128,7 +112,7 @@ void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 	if (user->registered == 7)
 	{
 		int MOD_RESULT = 0;
-		FOREACH_RESULT(OnUserPreNick(user,parameters[0]));
+		FOREACH_RESULT(I_OnUserPreNick,OnUserPreNick(user,parameters[0]));
 		if (MOD_RESULT) {
 			// if a module returns true, the nick change is silently forbidden.
 			return;
@@ -137,9 +121,8 @@ void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 		WriteCommon(user,"NICK %s",parameters[0]);
 		
 	}
-	
-	char oldnick[NICKMAX];
-	strlcpy(oldnick,user->nick,NICKMAX);
+
+	strlcpy(oldnick, user->nick, NICKMAX - 1);
 
 	/* change the nick of the user in the users_hash */
 	user = ReHashNick(user->nick, parameters[0]);
@@ -147,7 +130,7 @@ void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 	if (!user) return;
 	if (!user->nick) return;
 
-	strlcpy(user->nick, parameters[0],NICKMAX);
+	strlcpy(user->nick, parameters[0], NICKMAX - 1);
 
 	log(DEBUG,"new nick set: %s",user->nick);
 	
@@ -176,12 +159,11 @@ void cmd_nick::Handle (char **parameters, int pcnt, userrec *user)
 	if (user->registered == 3)
 	{
 		/* user is registered now, bit 0 = USER command, bit 1 = sent a NICK command */
-		FOREACH_MOD OnUserRegister(user);
-		ConnectUser(user);
+		FOREACH_MOD(I_OnUserRegister,OnUserRegister(user));
+		//ConnectUser(user,NULL);
 	}
 	if (user->registered == 7)
 	{
-		FOREACH_MOD OnUserPostNick(user,oldnick);
+		FOREACH_MOD(I_OnUserPostNick,OnUserPostNick(user,oldnick));
 	}
 }
-