X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fcommand_parse.cpp;h=b446d2b9af9224a8e1f6effc686772087443ab4c;hb=219993bc9018d9f0d9568330d7a972b68b785d27;hp=36b3d712cfbcacd14cd09e2efa311cebff9251f5;hpb=c6a3d4bafc70dc9bd99b9da37c4b12a5324d4e0f;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/command_parse.cpp b/src/command_parse.cpp index 36b3d712c..b446d2b9a 100644 --- a/src/command_parse.cpp +++ b/src/command_parse.cpp @@ -2,8 +2,8 @@ * | Inspire Internet Relay Chat Daemon | * +------------------------------------+ * - * InspIRCd: (C) 2002-2008 InspIRCd Development Team - * See: http://www.inspircd.org/wiki/index.php/Credits + * InspIRCd: (C) 2002-2009 InspIRCd Development Team + * See: http://wiki.inspircd.org/Credits * * This program is free but copyrighted software; see * the file COPYING for details. @@ -69,10 +69,10 @@ int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vector dupes; + std::set dupes; /* Create two lists, one for channel names, one for keys */ @@ -103,7 +103,7 @@ int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vectorHandle(new_parameters, user); - dupes[item.c_str()] = true; + dupes.insert(item.c_str()); } } return 1; @@ -120,7 +120,7 @@ int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vector dupes; + std::set dupes; /* Only one commasepstream here */ irc::commasepstream items1(parameters[splithere]); @@ -145,7 +145,7 @@ int CommandParser::LoopCall(User* user, Command* CommandObj, const std::vectorHandle(new_parameters, user); - dupes[item.c_str()] = true; + dupes.insert(item.c_str()); } } /* By returning 1 we tell our caller that nothing is to be done, @@ -262,10 +262,20 @@ bool CommandParser::ProcessCommand(User *user, std::string &cmd) command_p.push_back(token); std::transform(command.begin(), command.end(), command.begin(), ::toupper); - + /* find the command, check it exists */ Commandtable::iterator cm = cmdlist.find(command); - + + /* Modify the user's penalty regardless of whether or not the command exists */ + bool do_more = true; + if (!user->HasPrivPermission("users/flood/no-throttle")) + { + // If it *doesn't* exist, give it a slightly heftier penalty than normal to deter flooding us crap + user->IncreasePenalty(cm != cmdlist.end() ? cm->second->Penalty : 2); + do_more = (user->Penalty < 10); + } + + if (cm == cmdlist.end()) { int MOD_RESULT = 0; @@ -310,7 +320,7 @@ bool CommandParser::ProcessCommand(User *user, std::string &cmd) { // BE CAREFUL: .end() returns past the end of the vector, hence decrement. std::vector::iterator it = --command_p.end(); - + lparam.insert(0, " " + *(it)); command_p.erase(it); // remove last element } @@ -336,14 +346,6 @@ bool CommandParser::ProcessCommand(User *user, std::string &cmd) if (MOD_RESULT == 1) return true; - /* Modify the user's penalty */ - bool do_more = true; - if (!user->HasPrivPermission("users/flood/no-throttle")) - { - user->IncreasePenalty(cm->second->Penalty); - do_more = (user->Penalty < 10); - } - /* activity resets the ping pending timer */ if (user->MyClass) user->nping = ServerInstance->Time() + user->MyClass->GetPingTime(); @@ -374,7 +376,7 @@ bool CommandParser::ProcessCommand(User *user, std::string &cmd) user->nick.c_str(), command.c_str()); } - ServerInstance->SNO->WriteToSnoMask('d', "%s denied for %s (%s@%s)", + ServerInstance->SNO->WriteToSnoMask('t', "%s denied for %s (%s@%s)", command.c_str(), user->nick.c_str(), user->ident.c_str(), user->host.c_str()); return do_more; } @@ -429,7 +431,6 @@ void CommandParser::RemoveCommand(Commandtable::iterator safei, const char* sour if (x->source == std::string(source)) { cmdlist.erase(safei); - delete x; } } @@ -506,26 +507,23 @@ bool CommandParser::ReloadCommand(std::string cmd, User* user) cmdlist.erase(cmdlist.find(cmd)); RFCCommands.erase(cmd); - std::transform(cmd.begin(), cmd.end(), cmd.begin(), ::tolower); delete cmdptr; dlclose(command->second); - - snprintf(filename, MAXBUF, "cmd_%s.so", cmd.c_str()); - const char* err = this->LoadCommand(filename); - if (err) - { - if (user) - user->WriteServ("NOTICE %s :*** Error loading 'cmd_%s.so': %s", user->nick.c_str(), cmd.c_str(), err); - return false; - } - - return true; } - return false; + std::transform(cmd.begin(), cmd.end(), cmd.begin(), ::tolower); + snprintf(filename, MAXBUF, "cmd_%s.so", cmd.c_str()); + const char* err = this->LoadCommand(filename); + if (err) + { + if (user) + user->WriteServ("NOTICE %s :*** Error loading '%s': %s", user->nick.c_str(), filename, err); + return false; + } + return true; } -CmdResult cmd_reload::Handle(const std::vector& parameters, User *user) +CmdResult CommandReload::Handle(const std::vector& parameters, User *user) { if (parameters.size() < 1) return CMD_FAILURE; @@ -534,12 +532,12 @@ CmdResult cmd_reload::Handle(const std::vector& parameters, User *u if (ServerInstance->Parser->ReloadCommand(parameters[0], user)) { user->WriteServ("NOTICE %s :*** Successfully reloaded command '%s'", user->nick.c_str(), parameters[0].c_str()); - ServerInstance->SNO->WriteToSnoMask('A', "RELOAD: %s reloaded the '%s' command.", user->nick.c_str(), parameters[0].c_str()); + ServerInstance->SNO->WriteToSnoMask('a', "RELOAD: %s reloaded the '%s' command.", user->nick.c_str(), parameters[0].c_str()); return CMD_SUCCESS; } else { - user->WriteServ("NOTICE %s :*** Could not reload command '%s' -- fix this problem, then /REHASH as soon as possible!", user->nick.c_str(), parameters[0].c_str()); + user->WriteServ("NOTICE %s :*** Could not reload command '%s'. The command will not work until reloaded successfully.", user->nick.c_str(), parameters[0].c_str()); return CMD_FAILURE; } } @@ -606,7 +604,51 @@ void CommandParser::SetupCommandTable() } if (cmdlist.find("RELOAD") == cmdlist.end()) - this->CreateCommand(new cmd_reload(ServerInstance)); + this->CreateCommand(new CommandReload(ServerInstance)); +} + +int CommandParser::TranslateUIDs(const std::vector to, const std::vector &source, std::string &dest) +{ + std::vector::const_iterator items = source.begin(); + std::vector::const_iterator types = to.begin(); + User* user = NULL; + int translations = 0; + dest.clear(); + + while (items != source.end() && types != to.end()) + { + TranslateType t = *types; + std::string item = *items; + types++; + items++; + + switch (t) + { + case TR_NICK: + /* Translate single nickname */ + user = ServerInstance->FindNick(item); + if (user) + { + dest.append(user->uuid); + translations++; + } + else + dest.append(item); + break; + break; + case TR_END: + case TR_TEXT: + default: + /* Do nothing */ + dest.append(item); + break; + } + dest.append(" "); + } + + if (!dest.empty()) + dest.erase(dest.end() - 1); + return translations; } int CommandParser::TranslateUIDs(TranslateType to, const std::string &source, std::string &dest) @@ -629,46 +671,6 @@ int CommandParser::TranslateUIDs(TranslateType to, const std::string &source, st else dest = source; break; - case TR_NICKLIST: - { - /* Translate comma seperated list of nicknames */ - irc::commasepstream items(source); - while (items.GetToken(item)) - { - user = ServerInstance->FindNick(item); - if (user) - { - dest.append(user->uuid); - translations++; - } - else - dest.append(item); - dest.append(","); - } - if (!dest.empty()) - dest.erase(dest.end() - 1); - } - break; - case TR_SPACENICKLIST: - { - /* Translate space seperated list of nicknames */ - irc::spacesepstream items(source); - while (items.GetToken(item)) - { - user = ServerInstance->FindNick(item); - if (user) - { - dest.append(user->uuid); - translations++; - } - else - dest.append(item); - dest.append(" "); - } - if (!dest.empty()) - dest.erase(dest.end() - 1); - } - break; case TR_END: case TR_TEXT: default: @@ -679,5 +681,3 @@ int CommandParser::TranslateUIDs(TranslateType to, const std::string &source, st return translations; } - -