X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fhelperfuncs.cpp;h=8b93be24500e9cb681aaf8d8a7155f2459f088ee;hb=b3ea96554e5334c27030c14b72ea1c69c253bde0;hp=3ff94e4f6e27b2e923bc9936807997fbb989535a;hpb=cbefea57e9b68df8a272e9041e079b647f627554;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/helperfuncs.cpp b/src/helperfuncs.cpp
index 3ff94e4f6..8b93be245 100644
--- a/src/helperfuncs.cpp
+++ b/src/helperfuncs.cpp
@@ -128,7 +128,7 @@ void InspIRCd::SendError(const std::string &s)
 	{
 		if ((*i)->registered == REG_ALL)
 		{
-		   	(*i)->WriteServ("NOTICE %s :%s",(*i)->nick,s.c_str());
+		   	(*i)->WriteServ("NOTICE %s :%s",(*i)->nick.c_str(),s.c_str());
 	   	}
 		else
 		{
@@ -182,7 +182,7 @@ bool InspIRCd::IsValidMask(const std::string &mask)
 }
 
 /* true for valid channel name, false else */
-bool InspIRCd::IsChannel(const char *chname)
+bool IsChannelHandler::Call(const char *chname)
 {
 	char *c;
 
@@ -268,7 +268,7 @@ bool IsIdentHandler::Call(const char* n)
 	return true;
 }
 
-bool InspIRCd::IsSID(const std::string &str)
+bool IsSIDHandler::Call(const std::string &str)
 {
 	/* Returns true if the string given is exactly 3 characters long,
 	 * starts with a digit, and the other two characters are A-Z or digits
@@ -308,10 +308,29 @@ bool InspIRCd::OpenLog(char**, int)
 		if (Config->logpath.empty())
 		{
 			std::string path = std::string(home) + "/.inspircd";
-			if (!mkdir(path.c_str(), 0700))
+			// This tries to create the ~/.inspircd. If it succeeds, then we go ahead and use it.
+			// If it fails due to an existing target, then we use it anyway.
+			// Either way, we make sure we can get write access to the log at this point.
+			if (!mkdir(path.c_str(), 0700) || errno == EEXIST)
 			{
 				/* Log to ~/.inspircd/ircd.log */
 				Config->logpath = path + "/startup.log";
+				FILE* fd = fopen(Config->logpath.c_str(), "a+");
+				if (!fd)
+				{
+					// Could not get write access... Why?
+					if (errno == ENOTDIR)
+						// ~/.inspircd is not actually a directory!
+						printf("\nWARNING: Unable to create directory: %s (Exists and is not a directory)\n", path.c_str());
+					else
+						// Not writable for some other reason (no +w access, readonly fs, file too big, whatever).
+						printf("\nWARNING: No write access to %s (%s)\n", Config->logpath.c_str(), strerror(errno));
+					Config->logpath = "./startup.log";
+				}
+				else
+				{
+					Config->log_file = fd;
+				}
 			}
 			else
 			{
@@ -321,7 +340,8 @@ bool InspIRCd::OpenLog(char**, int)
 			}
 		}
 
-		Config->log_file = fopen(Config->logpath.c_str(),"a+");
+		if (!Config->log_file)
+			Config->log_file = fopen(Config->logpath.c_str(),"a+");
 	}
 	else
 	{