X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Finspsocket.cpp;h=964582062db41f2e4daec79154c81c177d645cdb;hb=e2af2347fc035d702e45f12e772223a8d578410d;hp=fc0f7537ad239bb4c2aec3781b96ad4ac7154664;hpb=3af9d9b0605a503ed16a8b8314587451979103d7;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/inspsocket.cpp b/src/inspsocket.cpp
index fc0f7537a..964582062 100644
--- a/src/inspsocket.cpp
+++ b/src/inspsocket.cpp
@@ -2,645 +2,410 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                       E-mail:
- *                <brain@chatspike.net>
- *           	  <Craig@chatspike.net>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
+ *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
+#include "inspircd.h"
 #include "socket.h"
-#include "configreader.h"
 #include "inspstring.h"
 #include "socketengine.h"
-#include "inspircd.h"
-
-using irc::sockets::OpenTCPSocket;
-using irc::sockets::insp_inaddr;
-using irc::sockets::insp_sockaddr;
-
-bool InspSocket::Readable()
-{
-	return ((this->state != I_CONNECTING) && (this->WaitingForWriteEvent == false));
-}
 
-InspSocket::InspSocket(InspIRCd* SI)
+BufferedSocket::BufferedSocket()
 {
-	this->state = I_DISCONNECTED;
-	this->fd = -1;
-	this->WaitingForWriteEvent = false;
-	this->Instance = SI;
-	this->IsIOHooked = false;
+	Timeout = NULL;
+	state = I_ERROR;
 }
 
-InspSocket::InspSocket(InspIRCd* SI, int newfd, const char* ip)
+BufferedSocket::BufferedSocket(int newfd)
 {
+	Timeout = NULL;
 	this->fd = newfd;
 	this->state = I_CONNECTED;
-	strlcpy(this->IP,ip,MAXBUF);
-	this->WaitingForWriteEvent = false;
-	this->Instance = SI;
-	this->IsIOHooked = false;
-	if (this->fd > -1)
-		this->Instance->SE->AddFd(this);
+	if (fd > -1)
+		ServerInstance->SE->AddFd(this);
 }
 
-InspSocket::InspSocket(InspIRCd* SI, const std::string &ipaddr, int aport, bool listening, unsigned long maxtime)
+void BufferedSocket::DoConnect(const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
 {
-	this->fd = -1;
-	this->Instance = SI;
-	strlcpy(host,ipaddr.c_str(),MAXBUF);
-	this->WaitingForWriteEvent = false;
-	this->IsIOHooked = false;
-	if (listening)
+	BufferedSocketError err = BeginConnect(ipaddr, aport, maxtime, connectbindip);
+	if (err != I_ERR_NONE)
 	{
-		if ((this->fd = OpenTCPSocket()) == ERROR)
-		{
-			this->fd = -1;
-			this->state = I_ERROR;
-			this->OnError(I_ERR_SOCKET);
-			this->Instance->Log(DEBUG,"OpenTCPSocket() error");
-			return;
-		}
-		else
-		{
-			if (!SI->BindSocket(this->fd,this->client,this->server,aport,(char*)ipaddr.c_str()))
-			{
-				this->Instance->Log(DEBUG,"BindSocket() error %s",strerror(errno));
-				this->Close();
-				this->fd = -1;
-				this->state = I_ERROR;
-				this->OnError(I_ERR_BIND);
-				this->ClosePending = true;
-				return;
-			}
-			else
-			{
-				this->state = I_LISTENING;
-				if (this->fd > -1)
-				{
-					if (!this->Instance->SE->AddFd(this))
-					{
-						this->Close();
-						this->state = I_ERROR;
-						this->OnError(I_ERR_NOMOREFDS);
-					}
-				}
-				this->Instance->Log(DEBUG,"New socket now in I_LISTENING state");
-				return;
-			}
-		}			
+		state = I_ERROR;
+		SetError(strerror(errno));
+		OnError(err);
 	}
-	else
+}
+
+BufferedSocketError BufferedSocket::BeginConnect(const std::string &ipaddr, int aport, unsigned long maxtime, const std::string &connectbindip)
+{
+	irc::sockets::sockaddrs addr, bind;
+	if (!irc::sockets::aptosa(ipaddr.c_str(), aport, &addr))
 	{
-		strlcpy(this->host,ipaddr.c_str(),MAXBUF);
-		this->port = aport;
+		ServerInstance->Logs->Log("SOCKET", DEBUG, "BUG: Hostname passed to BufferedSocket, rather than an IP address!");
+		return I_ERR_CONNECT;
+	}
 
-		if (insp_aton(host,&addy) < 1)
-		{
-			this->Instance->Log(DEBUG,"You cannot pass hostnames to InspSocket, resolve them first with Resolver!");
-			this->Close();
-			this->fd = -1;
-			this->state = I_ERROR;
-			this->OnError(I_ERR_RESOLVE);
-			return;
-		}
-		else
+	bind.sa.sa_family = 0;
+	if (!connectbindip.empty())
+	{
+		if (!irc::sockets::aptosa(connectbindip.c_str(), 0, &bind))
 		{
-			this->Instance->Log(DEBUG,"No need to resolve %s",this->host);
-			strlcpy(this->IP,host,MAXBUF);
-			timeout_val = maxtime;
-			this->DoConnect();
+			return I_ERR_BIND;
 		}
 	}
-}
 
-void InspSocket::WantWrite()
-{
-	this->Instance->SE->WantWrite(this);
-	this->WaitingForWriteEvent = true;
+	return BeginConnect(addr, bind, maxtime);
 }
 
-void InspSocket::SetQueues(int nfd)
+static void IncreaseOSBuffers(int fd)
 {
 	// attempt to increase socket sendq and recvq as high as its possible
 	int sendbuf = 32768;
 	int recvbuf = 32768;
-	setsockopt(nfd,SOL_SOCKET,SO_SNDBUF,(const void *)&sendbuf,sizeof(sendbuf));
-	setsockopt(nfd,SOL_SOCKET,SO_RCVBUF,(const void *)&recvbuf,sizeof(sendbuf));
+	setsockopt(fd,SOL_SOCKET,SO_SNDBUF,(const char *)&sendbuf,sizeof(sendbuf));
+	setsockopt(fd,SOL_SOCKET,SO_RCVBUF,(const char *)&recvbuf,sizeof(recvbuf));
+	// on failure, do nothing. I'm a little sick of people trying to interpret this message as a result of why their incorrect setups don't work.
 }
 
-/* Most irc servers require you to specify the ip you want to bind to.
- * If you dont specify an IP, they rather dumbly bind to the first IP
- * of the box (e.g. INADDR_ANY). In InspIRCd, we scan thought the IP
- * addresses we've bound server ports to, and we try and bind our outbound
- * connections to the first usable non-loopback and non-any IP we find.
- * This is easier to configure when you have a lot of links and a lot
- * of servers to configure.
- */
-bool InspSocket::BindAddr()
+BufferedSocketError BufferedSocket::BeginConnect(const irc::sockets::sockaddrs& dest, const irc::sockets::sockaddrs& bind, unsigned long timeout)
 {
-	insp_inaddr n;
-	ConfigReader Conf(this->Instance);
-
-	this->Instance->Log(DEBUG,"In InspSocket::BindAddr()");
-	for (int j =0; j < Conf.Enumerate("bind"); j++)
-	{
-		std::string Type = Conf.ReadValue("bind","type",j);
-		std::string IP = Conf.ReadValue("bind","address",j);
-		if (Type == "servers")
-		{
-			if ((IP != "*") && (IP != "127.0.0.1") && (IP != ""))
-			{
-				insp_sockaddr s;
+	if (fd < 0)
+		fd = socket(dest.sa.sa_family, SOCK_STREAM, 0);
 
-				if (insp_aton(IP.c_str(),&n) > 0)
-				{
-					this->Instance->Log(DEBUG,"Found an IP to bind to: %s",IP.c_str());
-#ifdef IPV6
-					s.sin6_addr = n;
-					s.sin6_family = AF_FAMILY;
-#else
-					s.sin_addr = n;
-					s.sin_family = AF_FAMILY;
-#endif
-					if (bind(this->fd,(struct sockaddr*)&s,sizeof(s)) < 0)
-					{
-						this->Instance->Log(DEBUG,"Cant bind()");
-						this->state = I_ERROR;
-						this->OnError(I_ERR_BIND);
-						this->fd = -1;
-						return false;
-					}
-					this->Instance->Log(DEBUG,"bind() reports outbound fd bound to ip %s",IP.c_str());
-					return true;
-				}
-				else
-				{
-					this->Instance->Log(DEBUG,"Address '%s' was not an IP address",IP.c_str());
-				}
-			}
-		}
-	}
-	this->Instance->Log(DEBUG,"Found no suitable IPs to bind, binding INADDR_ANY");
-	return true;
-}
+	if (fd < 0)
+		return I_ERR_SOCKET;
 
-bool InspSocket::DoConnect()
-{
-	this->Instance->Log(DEBUG,"In DoConnect()");
-	if ((this->fd = socket(AF_FAMILY, SOCK_STREAM, 0)) == -1)
+	if (bind.sa.sa_family != 0)
 	{
-		this->Instance->Log(DEBUG,"Cant socket()");
-		this->state = I_ERROR;
-		this->OnError(I_ERR_SOCKET);
-		return false;
+		if (ServerInstance->SE->Bind(fd, &bind.sa, sa_size(bind)) < 0)
+			return I_ERR_BIND;
 	}
 
-	if ((strstr(this->IP,"::ffff:") != (char*)&this->IP) && (strstr(this->IP,"::FFFF:") != (char*)&this->IP))
-	{
-		if (!this->BindAddr())
-			return false;
-	}
+	ServerInstance->SE->NonBlocking(fd);
 
-	this->Instance->Log(DEBUG,"Part 2 DoConnect() %s",this->IP);
-	insp_aton(this->IP,&addy);
-#ifdef IPV6
-	addr.sin6_family = AF_FAMILY;
-	memcpy(&addr.sin6_addr, &addy, sizeof(insp_inaddr));
-	addr.sin6_port = htons(this->port);
-#else
-	addr.sin_family = AF_FAMILY;
-	addr.sin_addr = addy;
-	addr.sin_port = htons(this->port);
-#endif
-
-	int flags;
-	flags = fcntl(this->fd, F_GETFL, 0);
-	fcntl(this->fd, F_SETFL, flags | O_NONBLOCK);
-
-	if (connect(this->fd, (sockaddr*)&this->addr,sizeof(this->addr)) == -1)
+	if (ServerInstance->SE->Connect(this, &dest.sa, sa_size(dest)) == -1)
 	{
 		if (errno != EINPROGRESS)
-		{
-			this->Instance->Log(DEBUG,"Error connect() %d: %s",this->fd,strerror(errno));
-			this->OnError(I_ERR_CONNECT);
-			this->Close();
-			this->state = I_ERROR;
-			return false;
-		}
-
-		this->Timeout = new SocketTimeout(this->GetFd(), this->Instance, this, timeout_val, this->Instance->Time());
-		this->Instance->Timers->AddTimer(this->Timeout);
+			return I_ERR_CONNECT;
 	}
+
 	this->state = I_CONNECTING;
-	if (this->fd > -1)
-	{
-		if (!this->Instance->SE->AddFd(this))
-		{
-			this->OnError(I_ERR_NOMOREFDS);
-			this->Close();
-			this->state = I_ERROR;
-			return false;
-		}
-		this->SetQueues(this->fd);
-	}
-	this->Instance->Log(DEBUG,"Returning true from InspSocket::DoConnect");
-	return true;
-}
 
+	if (!ServerInstance->SE->AddFd(this, true))
+		return I_ERR_NOMOREFDS;
 
-void InspSocket::Close()
+	this->Timeout = new SocketTimeout(this->GetFd(), this, timeout, ServerInstance->Time());
+	ServerInstance->Timers->AddTimer(this->Timeout);
+
+	IncreaseOSBuffers(fd);
+
+	ServerInstance->Logs->Log("SOCKET", DEBUG,"BufferedSocket::DoConnect success");
+	return I_ERR_NONE;
+}
+
+void StreamSocket::Close()
 {
+	/* Save this, so we dont lose it,
+	 * otherise on failure, error messages
+	 * might be inaccurate.
+	 */
+	int save = errno;
 	if (this->fd > -1)
 	{
-                if (this->IsIOHooked && Instance->Config->GetIOHook(this))
+		if (IOHook)
 		{
 			try
 			{
-				Instance->Config->GetIOHook(this)->OnRawSocketClose(this->fd);
+				IOHook->OnStreamSocketClose(this);
 			}
-			catch (ModuleException& modexcept)
+			catch (CoreException& modexcept)
 			{
-				Instance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
+				ServerInstance->Logs->Log("SOCKET", DEFAULT,"%s threw an exception: %s",
+					modexcept.GetSource(), modexcept.GetReason());
 			}
 		}
-		this->OnClose();
-		shutdown(this->fd,2);
-		close(this->fd);
+		ServerInstance->SE->Shutdown(this, 2);
+		ServerInstance->SE->DelFd(this);
+		ServerInstance->SE->Close(this);
+		fd = -1;
 	}
+	errno = save;
 }
 
-std::string InspSocket::GetIP()
+void StreamSocket::cull()
 {
-	return this->IP;
+	Close();
 }
 
-char* InspSocket::Read()
+bool StreamSocket::GetNextLine(std::string& line, char delim)
 {
-	if ((fd < 0) || (fd > MAX_DESCRIPTORS))
-		return NULL;
-
-	int n = 0;
+	std::string::size_type i = recvq.find(delim);
+	if (i == std::string::npos)
+		return false;
+	line = recvq.substr(0, i - 1);
+	// TODO is this the most efficient way to split?
+	recvq = recvq.substr(i + 1);
+	return true;
+}
 
-	if (this->IsIOHooked)
+void StreamSocket::DoRead()
+{
+	if (IOHook)
 	{
-		int result2 = 0;
-		int MOD_RESULT = 0;
+		int rv = -1;
 		try
 		{
-			MOD_RESULT = Instance->Config->GetIOHook(this)->OnRawSocketRead(this->fd,this->ibuf,sizeof(this->ibuf),result2);
-		}
-		catch (ModuleException& modexcept)
-		{
-			Instance->Log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
-		}
-		if (MOD_RESULT < 0)
-		{
-			n = -1;
-			errno = EAGAIN;
+			rv = IOHook->OnStreamSocketRead(this, recvq);
 		}
-		else
+		catch (CoreException& modexcept)
 		{
-			n = result2;
+			ServerInstance->Logs->Log("SOCKET", DEFAULT, "%s threw an exception: %s",
+				modexcept.GetSource(), modexcept.GetReason());
+			return;
 		}
+		if (rv > 0)
+			OnDataReady();
+		if (rv < 0)
+			SetError("Read Error"); // will not overwrite a better error message
 	}
 	else
 	{
-		n = recv(this->fd,this->ibuf,sizeof(this->ibuf),0);
-	}
-
-	if ((n > 0) && (n <= (int)sizeof(this->ibuf)))
-	{
-		ibuf[n] = 0;
-		return ibuf;
-	}
-	else
-	{
-		int err = errno;
-		if (err == EAGAIN)
+		char* ReadBuffer = ServerInstance->GetReadBuffer();
+		int n = recv(fd, ReadBuffer, ServerInstance->Config->NetBufferSize, 0);
+		if (n > 0)
+		{
+			recvq.append(ReadBuffer, n);
+			OnDataReady();
+		}
+		else if (n == 0)
 		{
-			return "";
+			error = "Connection closed";
 		}
-		else
+		else if (errno != EAGAIN && errno != EINTR)
 		{
-			if (!n)
-				this->Instance->Log(DEBUG,"EOF or error on socket: EOF");
-			else
-				this->Instance->Log(DEBUG,"EOF or error on socket: %s",strerror(err));
-			return NULL;
+			error = strerror(errno);
 		}
 	}
 }
 
-void InspSocket::MarkAsClosed()
+void StreamSocket::DoWrite()
 {
-	this->Instance->Log(DEBUG,"Marked as closed");
-}
-
-// There are two possible outcomes to this function.
-// It will either write all of the data, or an undefined amount.
-// If an undefined amount is written the connection has failed
-// and should be aborted.
-int InspSocket::Write(const std::string &data)
-{
-	/* Try and append the data to the back of the queue, and send it on its way
-	 */
-	outbuffer.push_back(data);
-	this->Instance->SE->WantWrite(this);
-	return (!this->FlushWriteBuffer());
-}
+	if (sendq.empty())
+		return;
 
-bool InspSocket::FlushWriteBuffer()
-{
-	errno = 0;
-	if ((this->fd > -1) && (this->state == I_CONNECTED))
+	if (IOHook)
 	{
-		if (this->IsIOHooked)
+		int rv = -1;
+		try
 		{
-			while (outbuffer.size() && (errno != EAGAIN))
+			while (!sendq.empty())
 			{
-				try
+				std::string& front = sendq.front();
+				int itemlen = front.length();
+				rv = IOHook->OnStreamSocketWrite(this, front);
+				if (rv > 0)
 				{
-					int result = Instance->Config->GetIOHook(this)->OnRawSocketWrite(this->fd, outbuffer[0].c_str(), outbuffer[0].length());
-					if (result > 0)
-					{
-						if ((unsigned int)result == outbuffer[0].length())
-						{
-							outbuffer.pop_front();
-						}
-						else
-						{
-							std::string temp = outbuffer[0].substr(result);
-							outbuffer[0] = temp;
-							errno = EAGAIN;
-						}
-					}
-					else if ((result == -1) && (errno != EAGAIN))
-					{
-						this->Instance->Log(DEBUG,"Write error on socket: %s",strerror(errno));
-						this->OnError(I_ERR_WRITE);
-						this->state = I_ERROR;
-						this->Instance->SE->DelFd(this);
-						this->Close();
-						return true;
-					}
+					// consumed the entire string, and is ready for more
+					sendq_len -= itemlen;
+					sendq.pop_front();
 				}
-				catch (ModuleException& modexcept)
+				else if (rv == 0)
 				{
-					Instance->Log(DEBUG,"Module exception caught: %s",modexcept.GetReason());
-					return true;
+					// socket has blocked. Stop trying to send data.
+					// IOHook has requested unblock notification from the socketengine
+
+					// Since it is possible that a partial write took place, adjust sendq_len
+					sendq_len = sendq_len - itemlen + front.length();
+					return;
+				}
+				else
+				{
+					SetError("Write Error"); // will not overwrite a better error message
+					return;
 				}
 			}
 		}
-		else
+		catch (CoreException& modexcept)
+		{
+			ServerInstance->Logs->Log("SOCKET", DEBUG,"%s threw an exception: %s",
+				modexcept.GetSource(), modexcept.GetReason());
+		}
+	}
+	else
+	{
+		// Prepare a writev() call to write all buffers efficiently
+		int bufcount = sendq.size();
+		
+		// cap the number of buffers at IOV_MAX
+		if (bufcount > IOV_MAX)
+			bufcount = IOV_MAX;
+
+		iovec* iovecs = new iovec[bufcount];
+		for(int i=0; i < bufcount; i++)
+		{
+			iovecs[i].iov_base = const_cast<char*>(sendq[i].data());
+			iovecs[i].iov_len = sendq[i].length();
+		}
+		int rv = writev(fd, iovecs, bufcount);
+		delete[] iovecs;
+		if (rv == (int)sendq_len)
 		{
-			/* If we have multiple lines, try to send them all,
-			 * not just the first one -- Brain
-			 */
-			while (outbuffer.size() && (errno != EAGAIN))
+			// it's our lucky day, everything got written out. Fast cleanup.
+			sendq_len = 0;
+			sendq.clear();
+		}
+		else if (rv > 0)
+		{
+			// Partial write. Clean out strings from the sendq
+			sendq_len -= rv;
+			while (rv > 0 && !sendq.empty())
 			{
-				/* Send a line */
-				int result = write(this->fd,outbuffer[0].c_str(),outbuffer[0].length());
-				if (result > 0)
+				std::string& front = sendq.front();
+				if (front.length() < (size_t)rv)
 				{
-					if ((unsigned int)result == outbuffer[0].length())
-					{
-						/* The whole block was written (usually a line)
-						 * Pop the block off the front of the queue,
-						 * dont set errno, because we are clear of errors
-						 * and want to try and write the next block too.
-						 */
-						outbuffer.pop_front();
-					}
-					else
-					{
-						std::string temp = outbuffer[0].substr(result);
-						outbuffer[0] = temp;
-						/* We didnt get the whole line out. arses.
-						 * Try again next time, i guess. Set errno,
-						 * because we shouldnt be writing any more now,
-						 * until the socketengine says its safe to do so.
-						 */
-						errno = EAGAIN;
-					}
+					// this string got fully written out
+					rv -= front.length();
+					sendq.pop_front();
 				}
-				else if ((result == -1) && (errno != EAGAIN))
+				else
 				{
-					this->Instance->Log(DEBUG,"Write error on socket: %s",strerror(errno));
-					this->OnError(I_ERR_WRITE);
-					this->state = I_ERROR;
-					this->Instance->SE->DelFd(this);
-					this->Close();
-					return true;
+					// stopped in the middle of this string
+					front = front.substr(rv);
+					rv = 0;
 				}
 			}
 		}
+		else if (rv == 0)
+		{
+			error = "Connection closed";
+		}
+		else if (errno != EAGAIN && errno != EINTR)
+		{
+			error = strerror(errno);
+		}
+		if (sendq_len && error.empty())
+			ServerInstance->SE->WantWrite(this);
 	}
+}
 
-	if ((errno == EAGAIN) && (fd > -1))
+void StreamSocket::WriteData(const std::string &data)
+{
+	bool newWrite = sendq.empty() && !data.empty();
+
+	/* Append the data to the back of the queue ready for writing */
+	sendq.push_back(data);
+	sendq_len += data.length();
+
+	if (newWrite)
 	{
-		this->Instance->SE->WantWrite(this);
+		// TODO perhaps we should try writing first, before asking SE about writes?
+		// DoWrite();
+		ServerInstance->SE->WantWrite(this);
 	}
-
-	return (fd < 0);
 }
 
-void SocketTimeout::Tick(time_t now)
+void SocketTimeout::Tick(time_t)
 {
+	ServerInstance->Logs->Log("SOCKET", DEBUG,"SocketTimeout::Tick");
+
 	if (ServerInstance->SE->GetRef(this->sfd) != this->sock)
-	{
-		ServerInstance->Log(DEBUG,"Our socket has been deleted before the timeout was reached.");
 		return;
-	}
 
 	if (this->sock->state == I_CONNECTING)
 	{
-		ServerInstance->Log(DEBUG,"Timed out, current=%lu",now);
-		// for non-listening sockets, the timeout can occur
+		// for connecting sockets, the timeout can occur
 		// which causes termination of the connection after
 		// the given number of seconds without a successful
 		// connection.
 		this->sock->OnTimeout();
 		this->sock->OnError(I_ERR_TIMEOUT);
-		this->sock->timeout = true;
-		ServerInstance->SE->DelFd(this->sock);
+
 		/* NOTE: We must set this AFTER DelFd, as we added
 		 * this socket whilst writeable. This means that we
 		 * must DELETE the socket whilst writeable too!
 		 */
 		this->sock->state = I_ERROR;
-		this->sock->Close();
-		delete this->sock;
-		return;
-	}
-}
-
-bool InspSocket::Poll()
-{
-	if (this->Instance->SE->GetRef(this->fd) != this)
-		return false;
-
-	int incoming = -1;
-
-	if ((fd < 0) || (fd > MAX_DESCRIPTORS))
-		return false;
-
-	switch (this->state)
-	{
-		case I_CONNECTING:
-			this->Instance->Log(DEBUG,"State = I_CONNECTING");
-			/* Our socket was in write-state, so delete it and re-add it
-			 * in read-state.
-			 */
-			if (this->fd > -1)
-			{
-				this->Instance->SE->DelFd(this);
-				this->SetState(I_CONNECTED);
-				if (!this->Instance->SE->AddFd(this))
-					return false;
-			}
-			if (this->IsIOHooked)
-			{
-				try
-				{
-					Instance->Config->GetIOHook(this)->OnRawSocketConnect(this->fd);
-				}
-				catch (ModuleException& modexcept)
-				{
-					Instance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
-				}
-			}
-			return this->OnConnected();
-		break;
-		case I_LISTENING:
-			length = sizeof (client);
-			incoming = accept (this->fd, (sockaddr*)&client,&length);
-
-#ifdef IPV6
-			this->OnIncomingConnection(incoming, (char*)insp_ntoa(client.sin6_addr));
-#else
-			this->OnIncomingConnection(incoming, (char*)insp_ntoa(client.sin_addr));
-#endif
-
-			if (this->IsIOHooked)
-			{
-				try
-				{
-#ifdef IPV6
-					Instance->Config->GetIOHook(this)->OnRawSocketAccept(incoming, insp_ntoa(client.sin6_addr), this->port);
-#else
-					Instance->Config->GetIOHook(this)->OnRawSocketAccept(incoming, insp_ntoa(client.sin_addr), this->port);
-#endif
-				}
-				catch (ModuleException& modexcept)
-				{
-					Instance->Log(DEBUG,"Module exception cought: %s",modexcept.GetReason());
-				}
-			}
 
-			this->SetQueues(incoming);
-			return true;
-		break;
-		case I_CONNECTED:
-			/* Process the read event */
-			return this->OnDataReady();
-		break;
-		default:
-		break;
+		ServerInstance->GlobalCulls.AddItem(sock);
 	}
-	return true;
-}
 
-void InspSocket::SetState(InspSocketState s)
-{
-	this->Instance->Log(DEBUG,"Socket state change");
-	this->state = s;
+	this->sock->Timeout = NULL;
 }
 
-InspSocketState InspSocket::GetState()
-{
-	return this->state;
-}
+void BufferedSocket::OnConnected() { }
+void BufferedSocket::OnTimeout() { return; }
 
-int InspSocket::GetFd()
+void BufferedSocket::DoWrite()
 {
-	return this->fd;
+	if (state == I_CONNECTING)
+	{
+		state = I_CONNECTED;
+		this->OnConnected();
+		if (GetIOHook())
+			GetIOHook()->OnStreamSocketConnect(this);
+	}
+	this->StreamSocket::DoWrite();
 }
 
-bool InspSocket::OnConnected() { return true; }
-void InspSocket::OnError(InspSocketError e) { return; }
-int InspSocket::OnDisconnect() { return 0; }
-int InspSocket::OnIncomingConnection(int newfd, char* ip) { return 0; }
-bool InspSocket::OnDataReady() { return true; }
-bool InspSocket::OnWriteReady() { return true; }
-void InspSocket::OnTimeout() { return; }
-void InspSocket::OnClose() { return; }
-
-InspSocket::~InspSocket()
+BufferedSocket::~BufferedSocket()
 {
 	this->Close();
+	if (Timeout)
+	{
+		ServerInstance->Timers->DelTimer(Timeout);
+		Timeout = NULL;
+	}
 }
 
-void InspSocket::HandleEvent(EventType et, int errornum)
+void StreamSocket::HandleEvent(EventType et, int errornum)
 {
+	BufferedSocketError errcode = I_ERR_OTHER;
 	switch (et)
 	{
 		case EVENT_ERROR:
-			this->Instance->SE->DelFd(this);
-			this->Close();
-			delete this;
-			return;
-		break;
-		case EVENT_READ:
-			if (!this->Poll())
+		{
+			SetError(strerror(errornum));
+			switch (errornum)
 			{
-				this->Instance->SE->DelFd(this);
-				this->Close();
-				delete this;
-				return;
+				case ETIMEDOUT:
+					errcode = I_ERR_TIMEOUT;
+					break;
+				case ECONNREFUSED:
+				case 0:
+					errcode = I_ERR_CONNECT;
+					break;
+				case EADDRINUSE:
+					errcode = I_ERR_BIND;
+					break;
+				case EPIPE:
+				case EIO:
+					errcode = I_ERR_WRITE;
+					break;
 			}
-		break;
+			break;
+		}
+		case EVENT_READ:
+		{
+			DoRead();
+			break;
+		}
 		case EVENT_WRITE:
-			if (this->WaitingForWriteEvent)
-			{
-				this->WaitingForWriteEvent = false;
-				if (!this->OnWriteReady())
-				{
-					this->Instance->SE->DelFd(this);
-					this->Close();
-					delete this;
-					return;
-				}
-			}
-			if (this->state == I_CONNECTING)
-			{
-				/* This might look wrong as if we should be actually calling
-				 * with EVENT_WRITE, but trust me it is correct. There are some
-				 * writeability-state things in the read code, because of how
-				 * InspSocket used to work regarding write buffering in previous
-				 * versions of InspIRCd. - Brain
-				 */
-				this->HandleEvent(EVENT_READ);
-				return;
-			}
-			else
-			{
-				Instance->Log(DEBUG,"State=%d CONNECTED=%d", this->state, I_CONNECTED);
-				if (this->FlushWriteBuffer())
-				{
-					this->Instance->SE->DelFd(this);
-					this->Close();
-					delete this;
-					return;
-				}
-			}
-		break;
+		{
+			DoWrite();
+			break;
+		}
+	}
+	if (!error.empty())
+	{
+		ServerInstance->Logs->Log("SOCKET", DEBUG, "Error on FD %d - '%s'", fd, error.c_str());
+		OnError(errcode);
+		ServerInstance->GlobalCulls.AddItem(this);
 	}
 }