X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmode.cpp;h=5793b4e665083d284f44f3cbe76ede8748f001b7;hb=100c6c419c319663c43796d5d69f738df8d0f583;hp=71fce24d82658e3935d58c77e7758f9a382ed7b3;hpb=b2ac8cc0a6405946a388b80df3be21bc276a61f3;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/mode.cpp b/src/mode.cpp
index 71fce24d8..5793b4e66 100644
--- a/src/mode.cpp
+++ b/src/mode.cpp
@@ -587,7 +587,8 @@ ModeHandler::Id ModeParser::AllocateModeId(ModeType mt)
 void ModeParser::AddMode(ModeHandler* mh)
 {
 	if (!ModeParser::IsModeChar(mh->GetModeChar()))
-		throw ModuleException("Invalid letter for mode " + mh->name);
+		throw ModuleException(InspIRCd::Format("Mode letter for %s is invalid: %c",
+			mh->name.c_str(), mh->GetModeChar()));
 
 	/* A mode prefix of ',' is not acceptable, it would fuck up server to server.
 	 * A mode prefix of ':' will fuck up both server to server, and client to server.
@@ -597,15 +598,19 @@ void ModeParser::AddMode(ModeHandler* mh)
 	if (pm)
 	{
 		if ((pm->GetPrefix() > 126) || (pm->GetPrefix() == ',') || (pm->GetPrefix() == ':') || (pm->GetPrefix() == '#'))
-			throw ModuleException("Invalid prefix for mode " + mh->name);
+			throw ModuleException(InspIRCd::Format("Mode prefix for %s is invalid: %c",
+				mh->name.c_str(), pm->GetPrefix()));
 
-		if (FindPrefix(pm->GetPrefix()))
-			throw ModuleException("Prefix already exists for mode " + mh->name);
+		PrefixMode* otherpm = FindPrefix(pm->GetPrefix());
+		if (otherpm)
+			throw ModuleException(InspIRCd::Format("Mode prefix for %s already by used by %s from %s: %c",
+				mh->name.c_str(), otherpm->name.c_str(), otherpm->creator->ModuleSourceFile.c_str(), pm->GetPrefix()));
 	}
 
 	ModeHandler*& slot = modehandlers[mh->GetModeType()][mh->GetModeChar()-65];
 	if (slot)
-		throw ModuleException("Letter is already in use for mode " + mh->name);
+		throw ModuleException(InspIRCd::Format("Mode letter for %s already by used by %s from %s: %c",
+			mh->name.c_str(), slot->name.c_str(), slot->creator->ModuleSourceFile.c_str(), mh->GetModeChar()));
 
 	// The mode needs an id if it is either a user mode, a simple mode (flag) or a parameter mode.
 	// Otherwise (for listmodes and prefix modes) the id remains MODEID_MAX, which is invalid.
@@ -613,8 +618,13 @@ void ModeParser::AddMode(ModeHandler* mh)
 	if ((mh->GetModeType() == MODETYPE_USER) || (mh->IsParameterMode()) || (!mh->IsListMode()))
 		modeid = AllocateModeId(mh->GetModeType());
 
-	if (!modehandlersbyname[mh->GetModeType()].insert(std::make_pair(mh->name, mh)).second)
-		throw ModuleException("Mode name already in use: " + mh->name);
+	std::pair<ModeHandlerMap::iterator, bool> res = modehandlersbyname[mh->GetModeType()].insert(std::make_pair(mh->name, mh)); 
+	if (!res.second)
+	{
+		ModeHandler* othermh = res.first->second;
+		throw ModuleException(InspIRCd::Format("Mode name %s already used by %c from %s",
+			mh->name.c_str(), othermh->GetModeChar(), othermh->creator->ModuleSourceFile.c_str()));
+	}
 
 	// Everything is fine, add the mode
 
@@ -630,8 +640,6 @@ void ModeParser::AddMode(ModeHandler* mh)
 		mhlist.prefix.push_back(pm);
 	else if (mh->IsListModeBase())
 		mhlist.list.push_back(mh->IsListModeBase());
-
-	RecreateModeListFor004Numeric();
 }
 
 bool ModeParser::DelMode(ModeHandler* mh)
@@ -689,8 +697,6 @@ bool ModeParser::DelMode(ModeHandler* mh)
 		mhlist.prefix.erase(std::find(mhlist.prefix.begin(), mhlist.prefix.end(), mh->IsPrefixMode()));
 	else if (mh->IsListModeBase())
 		mhlist.list.erase(std::find(mhlist.list.begin(), mhlist.list.end(), mh->IsListModeBase()));
-
-	RecreateModeListFor004Numeric();
 	return true;
 }
 
@@ -720,27 +726,6 @@ PrefixMode* ModeParser::FindPrefixMode(unsigned char modeletter)
 	return mh->IsPrefixMode();
 }
 
-std::string ModeParser::CreateModeList(ModeType mt, bool needparam)
-{
-	std::string modestr;
-
-	for (unsigned char mode = 'A'; mode <= 'z'; mode++)
-	{
-		ModeHandler* mh = modehandlers[mt][mode-65];
-		if ((mh) && ((!needparam) || (mh->NeedsParam(true))))
-			modestr.push_back(mode);
-	}
-
-	return modestr;
-}
-
-void ModeParser::RecreateModeListFor004Numeric()
-{
-	Cached004ModeList[0] = CreateModeList(MODETYPE_USER);
-	Cached004ModeList[1] = CreateModeList(MODETYPE_CHANNEL);
-	Cached004ModeList[2] = CreateModeList(MODETYPE_CHANNEL, true);
-}
-
 PrefixMode* ModeParser::FindPrefix(unsigned const char pfxletter)
 {
 	const PrefixModeList& list = GetPrefixModes();