X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fextra%2Fm_pgsql.cpp;h=85d092241d2074627e42d00f0ae9beb60684724b;hb=b4a174ee9c32d62ea6bf010e837e8c5b1c3d36a3;hp=3bda30fb38b396c67e0a7ff40fcb5d11b01fb089;hpb=b6dbd6caab62bc2c0d11ce5a45d511611eb9c2ef;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/extra/m_pgsql.cpp b/src/modules/extra/m_pgsql.cpp index 3bda30fb3..e1db996c8 100644 --- a/src/modules/extra/m_pgsql.cpp +++ b/src/modules/extra/m_pgsql.cpp @@ -1,27 +1,46 @@ -/* +------------------------------------+ - * | Inspire Internet Relay Chat Daemon | - * +------------------------------------+ +/* + * InspIRCd -- Internet Relay Chat Daemon * - * InspIRCd: (C) 2002-2009 InspIRCd Development Team - * See: http://wiki.inspircd.org/Credits + * Copyright (C) 2016 Adam + * Copyright (C) 2015 Daniel Vassdal + * Copyright (C) 2013, 2016-2020 Sadie Powell + * Copyright (C) 2012-2015 Attila Molnar + * Copyright (C) 2012 Robby + * Copyright (C) 2009-2010 Daniel De Graaf + * Copyright (C) 2009 Uli Schlachter + * Copyright (C) 2008 Thomas Stagner + * Copyright (C) 2007, 2009-2010 Craig Edwards + * Copyright (C) 2007, 2009 Dennis Friis + * Copyright (C) 2007 Robin Burchell + * Copyright (C) 2006 Oliver Lupton * - * This program is free but copyrighted software; see - * the file COPYING for details. + * This file is part of InspIRCd. InspIRCd is free software: you can + * redistribute it and/or modify it under the terms of the GNU General Public + * License as published by the Free Software Foundation, version 2. * - * --------------------------------------------------- + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS + * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more + * details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . */ +/// $CompilerFlags: -Iexecute("pg_config --includedir" "POSTGRESQL_INCLUDE_DIR") +/// $LinkerFlags: -Lexecute("pg_config --libdir" "POSTGRESQL_LIBRARY_DIR") -lpq + +/// $PackageInfo: require_system("arch") postgresql-libs +/// $PackageInfo: require_system("centos") postgresql-devel +/// $PackageInfo: require_system("darwin") postgresql +/// $PackageInfo: require_system("debian") libpq-dev +/// $PackageInfo: require_system("ubuntu") libpq-dev + + #include "inspircd.h" #include -#include #include -#include "m_sqlv2.h" - -/* $ModDesc: PostgreSQL Service Provider module for all other m_sql* modules, uses v2 of the SQL API */ -/* $CompileFlags: -Iexec("pg_config --includedir") eval("my $s = `pg_config --version`;$s =~ /^.*?(\d+)\.(\d+)\.(\d+).*?$/;my $v = hex(sprintf("0x%02x%02x%02x", $1, $2, $3));print "-DPGSQL_HAS_ESCAPECONN" if(($v >= 0x080104) || ($v >= 0x07030F && $v < 0x070400) || ($v >= 0x07040D && $v < 0x080000) || ($v >= 0x080008 && $v < 0x080100));") */ -/* $LinkerFlags: -Lexec("pg_config --libdir") -lpq */ -/* $ModDep: m_sqlv2.h */ - +#include "modules/sql.h" /* SQLConn rewritten by peavey to * use EventHandler instead of @@ -32,94 +51,44 @@ /* Forward declare, so we can have the typedef neatly at the top */ class SQLConn; +class ModulePgSQL; -typedef std::map ConnMap; +typedef insp::flat_map ConnMap; -/* CREAD, Connecting and wants read event - * CWRITE, Connecting and wants write event - * WREAD, Connected/Working and wants read event - * WWRITE, Connected/Working and wants write event - * RREAD, Resetting and wants read event - * RWRITE, Resetting and wants write event - */ -enum SQLstatus { CREAD, CWRITE, WREAD, WWRITE, RREAD, RWRITE }; - -unsigned long count(const char * const str, char a) +enum SQLstatus { - unsigned long n = 0; - for (const char *p = reinterpret_cast(str); *p; ++p) - { - if (*p == '?') - ++n; - } - return n; -} + // The connection has died. + DEAD, -/** SQLhost::GetDSN() - Overload to return correct DSN for PostgreSQL - */ -std::string SQLhost::GetDSN() -{ - std::ostringstream conninfo("connect_timeout = '2'"); - - if (ip.length()) - conninfo << " hostaddr = '" << ip << "'"; - - if (port) - conninfo << " port = '" << port << "'"; - - if (name.length()) - conninfo << " dbname = '" << name << "'"; + // Connecting and wants read event. + CREAD, - if (user.length()) - conninfo << " user = '" << user << "'"; + // Connecting and wants write event. + CWRITE, - if (pass.length()) - conninfo << " password = '" << pass << "'"; - - if (ssl) - { - conninfo << " sslmode = 'require'"; - } - else - { - conninfo << " sslmode = 'disable'"; - } + // Connected/working and wants read event. + WREAD, - return conninfo.str(); -} + // Connected/working and wants write event. + WWRITE +}; class ReconnectTimer : public Timer { private: - Module* mod; + ModulePgSQL* mod; public: - ReconnectTimer(InspIRCd* SI, Module* m) - : Timer(5, SI->Time(), false), mod(m) + ReconnectTimer(ModulePgSQL* m) : Timer(5, false), mod(m) { } - virtual void Tick(time_t TIME); + bool Tick(time_t TIME) CXX11_OVERRIDE; }; - -/** Used to resolve sql server hostnames - */ -class SQLresolver : public Resolver +struct QueueItem { - private: - SQLhost host; - Module* mod; - public: - SQLresolver(Module* m, InspIRCd* Instance, const SQLhost& hi, bool &cached) - : Resolver(Instance, hi.host, DNS_QUERY_FORWARD, cached, (Module*)m), host(hi), mod(m) - { - } - - virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached, int resultnum = 0); - - virtual void OnError(ResolverError e, const std::string &errormessage) - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "PgSQL: DNS lookup failed (%s), dying horribly", errormessage.c_str()); - } + SQL::Query* c; + std::string q; + QueueItem(SQL::Query* C, const std::string& Q) : c(C), q(Q) {} }; /** PgSQLresult is a subclass of the mostly-pure-virtual class SQLresult. @@ -129,273 +98,210 @@ class SQLresolver : public Resolver * data is passes to the module nearly as directly as if it was using the API directly itself. */ -class PgSQLresult : public SQLresult +class PgSQLresult : public SQL::Result { PGresult* res; int currentrow; int rows; - int cols; + std::vector colnames; - SQLfieldList* fieldlist; - SQLfieldMap* fieldmap; -public: - PgSQLresult(Module* self, Module* to, unsigned long rid, PGresult* result) - : SQLresult(self, to, rid), res(result), currentrow(0), fieldlist(NULL), fieldmap(NULL) + void getColNames() + { + colnames.resize(PQnfields(res)); + for(unsigned int i=0; i < colnames.size(); i++) + { + colnames[i] = PQfname(res, i); + } + } + public: + PgSQLresult(PGresult* result) : res(result), currentrow(0) { rows = PQntuples(res); - cols = PQnfields(res); + if (!rows) + rows = ConvToNum(PQcmdTuples(res)); } ~PgSQLresult() { - /* If we allocated these, free them... */ - if(fieldlist) - delete fieldlist; - - if(fieldmap) - delete fieldmap; - PQclear(res); } - virtual int Rows() - { - if(!cols && !rows) - { - return atoi(PQcmdTuples(res)); - } - else - { - return rows; - } - } - - virtual int Cols() + int Rows() CXX11_OVERRIDE { - return PQnfields(res); + return rows; } - virtual std::string ColName(int column) + void GetCols(std::vector& result) CXX11_OVERRIDE { - char* name = PQfname(res, column); - - return (name) ? name : ""; + if (colnames.empty()) + getColNames(); + result = colnames; } - virtual int ColNum(const std::string &column) + bool HasColumn(const std::string& column, size_t& index) CXX11_OVERRIDE { - int n = PQfnumber(res, column.c_str()); + if (colnames.empty()) + getColNames(); - if(n == -1) - { - throw SQLbadColName(); - } - else + for (size_t i = 0; i < colnames.size(); ++i) { - return n; + if (colnames[i] == column) + { + index = i; + return true; + } } + return false; } - virtual SQLfield GetValue(int row, int column) + SQL::Field GetValue(int row, int column) { char* v = PQgetvalue(res, row, column); + if (!v || PQgetisnull(res, row, column)) + return SQL::Field(); - if(v) - { - return SQLfield(std::string(v, PQgetlength(res, row, column)), PQgetisnull(res, row, column)); - } - else - { - throw SQLbadColName(); - } + return SQL::Field(std::string(v, PQgetlength(res, row, column))); } - virtual SQLfieldList& GetRow() + bool GetRow(SQL::Row& result) CXX11_OVERRIDE { - /* In an effort to reduce overhead we don't actually allocate the list - * until the first time it's needed...so... - */ - if(fieldlist) - { - fieldlist->clear(); - } - else + if (currentrow >= PQntuples(res)) + return false; + int ncols = PQnfields(res); + + for(int i = 0; i < ncols; i++) { - fieldlist = new SQLfieldList; + result.push_back(GetValue(currentrow, i)); } + currentrow++; - if(currentrow < PQntuples(res)) - { - int ncols = PQnfields(res); + return true; + } +}; - for(int i = 0; i < ncols; i++) - { - fieldlist->push_back(GetValue(currentrow, i)); - } +/** SQLConn represents one SQL session. + */ +class SQLConn : public SQL::Provider, public EventHandler +{ + public: + reference conf; /* The entry */ + std::deque queue; + PGconn* sql; /* PgSQL database connection handle */ + SQLstatus status; /* PgSQL database connection status */ + QueueItem qinprog; /* If there is currently a query in progress */ - currentrow++; - } + SQLConn(Module* Creator, ConfigTag* tag) + : SQL::Provider(Creator, tag->getString("id")) + , conf(tag) + , sql(NULL) + , status(CWRITE) + , qinprog(NULL, "") + { + if (!DoConnect()) + DelayReconnect(); + } - return *fieldlist; + CullResult cull() CXX11_OVERRIDE + { + this->SQL::Provider::cull(); + ServerInstance->Modules->DelService(*this); + return this->EventHandler::cull(); } - virtual SQLfieldMap& GetRowMap() + ~SQLConn() { - /* In an effort to reduce overhead we don't actually allocate the map - * until the first time it's needed...so... - */ - if(fieldmap) + SQL::Error err(SQL::BAD_DBID); + if (qinprog.c) { - fieldmap->clear(); + qinprog.c->OnError(err); + delete qinprog.c; } - else + for(std::deque::iterator i = queue.begin(); i != queue.end(); i++) { - fieldmap = new SQLfieldMap; + SQL::Query* q = i->c; + q->OnError(err); + delete q; } - - if(currentrow < PQntuples(res)) - { - int ncols = PQnfields(res); - - for(int i = 0; i < ncols; i++) - { - fieldmap->insert(std::make_pair(ColName(i), GetValue(currentrow, i))); - } - - currentrow++; - } - - return *fieldmap; + Close(); } - virtual SQLfieldList* GetRowPtr() + void OnEventHandlerRead() CXX11_OVERRIDE { - SQLfieldList* fl = new SQLfieldList; - - if(currentrow < PQntuples(res)) - { - int ncols = PQnfields(res); - - for(int i = 0; i < ncols; i++) - { - fl->push_back(GetValue(currentrow, i)); - } - - currentrow++; - } - - return fl; + DoEvent(); } - virtual SQLfieldMap* GetRowMapPtr() + void OnEventHandlerWrite() CXX11_OVERRIDE { - SQLfieldMap* fm = new SQLfieldMap; - - if(currentrow < PQntuples(res)) - { - int ncols = PQnfields(res); - - for(int i = 0; i < ncols; i++) - { - fm->insert(std::make_pair(ColName(i), GetValue(currentrow, i))); - } - - currentrow++; - } - - return fm; + DoEvent(); } - virtual void Free(SQLfieldMap* fm) + void OnEventHandlerError(int errornum) CXX11_OVERRIDE { - delete fm; + DelayReconnect(); } - virtual void Free(SQLfieldList* fl) + std::string GetDSN() { - delete fl; - } -}; + std::ostringstream conninfo("connect_timeout = '5'"); + std::string item; -/** SQLConn represents one SQL session. - */ -class SQLConn : public EventHandler -{ - private: - InspIRCd* ServerInstance; - SQLhost confhost; /* The entry */ - Module* us; /* Pointer to the SQL provider itself */ - PGconn* sql; /* PgSQL database connection handle */ - SQLstatus status; /* PgSQL database connection status */ - bool qinprog; /* If there is currently a query in progress */ - QueryQueue queue; /* Queue of queries waiting to be executed on this connection */ - time_t idle; /* Time we last heard from the database */ + if (conf->readString("host", item)) + conninfo << " host = '" << item << "'"; - public: - SQLConn(InspIRCd* SI, Module* self, const SQLhost& hi) - : EventHandler(), ServerInstance(SI), confhost(hi), us(self), sql(NULL), status(CWRITE), qinprog(false) - { - idle = this->ServerInstance->Time(); - if(!DoConnect()) - { - ServerInstance->Logs->Log("m_pgsql",DEFAULT, "WARNING: Could not connect to database with id: " + ConvToStr(hi.id)); - DelayReconnect(); - } - } + if (conf->readString("port", item)) + conninfo << " port = '" << item << "'"; - ~SQLConn() - { - Close(); - } + if (conf->readString("name", item)) + conninfo << " dbname = '" << item << "'"; - virtual void HandleEvent(EventType et, int errornum) - { - switch (et) - { - case EVENT_READ: - OnDataReady(); - break; + if (conf->readString("user", item)) + conninfo << " user = '" << item << "'"; - case EVENT_WRITE: - OnWriteReady(); - break; + if (conf->readString("pass", item)) + conninfo << " password = '" << item << "'"; - case EVENT_ERROR: - DelayReconnect(); - break; + if (conf->getBool("ssl")) + conninfo << " sslmode = 'require'"; + else + conninfo << " sslmode = 'disable'"; - default: - break; - } + return conninfo.str(); + } + + bool HandleConnectError(const char* reason) + { + ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Could not connect to the \"%s\" database: %s", + GetId().c_str(), reason); + return false; } bool DoConnect() { - if(!(sql = PQconnectStart(confhost.GetDSN().c_str()))) - return false; + sql = PQconnectStart(GetDSN().c_str()); + if (!sql) + return HandleConnectError("PQconnectStart returned NULL"); if(PQstatus(sql) == CONNECTION_BAD) - return false; + return HandleConnectError("connection status is bad"); if(PQsetnonblocking(sql, 1) == -1) - return false; + return HandleConnectError("unable to mark fd as non-blocking"); - /* OK, we've initalised the connection, now to get it hooked into the socket engine + /* OK, we've initialised the connection, now to get it hooked into the socket engine * and then start polling it. */ - this->fd = PQsocket(sql); - - if(this->fd <= -1) - return false; + SetFd(PQsocket(sql)); + if(!HasFd()) + return HandleConnectError("PQsocket returned an invalid fd"); - if (!this->ServerInstance->SE->AddFd(this)) - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Couldn't add pgsql socket to socket engine"); - return false; - } + if (!SocketEngine::AddFd(this, FD_WANT_NO_WRITE | FD_WANT_NO_READ)) + return HandleConnectError("could not add the pgsql socket to the socket engine"); /* Socket all hooked into the engine, now to tell PgSQL to start connecting */ - return DoPoll(); + if (!DoPoll()) + return HandleConnectError("could not poll the connection state"); + + return true; } bool DoPoll() @@ -403,50 +309,45 @@ class SQLConn : public EventHandler switch(PQconnectPoll(sql)) { case PGRES_POLLING_WRITING: - ServerInstance->SE->WantWrite(this); + SocketEngine::ChangeEventMask(this, FD_WANT_POLL_WRITE | FD_WANT_NO_READ); status = CWRITE; return true; case PGRES_POLLING_READING: + SocketEngine::ChangeEventMask(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE); status = CREAD; return true; case PGRES_POLLING_FAILED: + SocketEngine::ChangeEventMask(this, FD_WANT_NO_READ | FD_WANT_NO_WRITE); + status = DEAD; return false; case PGRES_POLLING_OK: + SocketEngine::ChangeEventMask(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE); status = WWRITE; - return DoConnectedPoll(); + DoConnectedPoll(); + return true; default: return true; } } - bool DoConnectedPoll() + void DoConnectedPoll() { - if(!qinprog && queue.totalsize()) +restart: + while (qinprog.q.empty() && !queue.empty()) { /* There's no query currently in progress, and there's queries in the queue. */ - SQLrequest& query = queue.front(); - DoQuery(query); + DoQuery(queue.front()); + queue.pop_front(); } - if(PQconsumeInput(sql)) + if (PQconsumeInput(sql)) { - /* We just read stuff from the server, that counts as it being alive - * so update the idle-since time :p - */ - idle = this->ServerInstance->Time(); - if (PQisBusy(sql)) { /* Nothing happens here */ } - else if (qinprog) + else if (qinprog.c) { - /* Grab the request we're processing */ - SQLrequest& query = queue.front(); - - /* Get a pointer to the module we're about to return the result to */ - Module* to = query.GetSource(); - /* Fetch the result.. */ PGresult* result = PQgetResult(sql); @@ -462,43 +363,31 @@ class SQLConn : public EventHandler result = temp; } - if(to) + /* ..and the result */ + PgSQLresult reply(result); + switch(PQresultStatus(result)) { - /* ..and the result */ - PgSQLresult reply(us, to, query.id, result); - - /* Fix by brain, make sure the original query gets sent back in the reply */ - reply.query = query.query.q; - - switch(PQresultStatus(result)) + case PGRES_EMPTY_QUERY: + case PGRES_BAD_RESPONSE: + case PGRES_FATAL_ERROR: { - case PGRES_EMPTY_QUERY: - case PGRES_BAD_RESPONSE: - case PGRES_FATAL_ERROR: - reply.error.Id(SQL_QREPLY_FAIL); - reply.error.Str(PQresultErrorMessage(result)); - default: - ; - /* No action, other values are not errors */ + SQL::Error err(SQL::QREPLY_FAIL, PQresultErrorMessage(result)); + qinprog.c->OnError(err); + break; } - - reply.Send(); - - /* PgSQLresult's destructor will free the PGresult */ - } - else - { - /* If the client module is unloaded partway through a query then the provider will set - * the pointer to NULL. We cannot just cancel the query as the result will still come - * through at some point...and it could get messy if we play with invalid pointers... - */ - PQclear(result); + default: + /* Other values are not errors */ + qinprog.c->OnResult(reply); } - qinprog = false; - queue.pop(); - DoConnectedPoll(); + + delete qinprog.c; + qinprog = QueueItem(NULL, ""); + goto restart; + } + else + { + qinprog.q.clear(); } - return true; } else { @@ -508,263 +397,122 @@ class SQLConn : public EventHandler * Returning true so the core doesn't try and close the connection. */ DelayReconnect(); - return true; - } - } - - bool DoResetPoll() - { - switch(PQresetPoll(sql)) - { - case PGRES_POLLING_WRITING: - ServerInstance->SE->WantWrite(this); - status = CWRITE; - return DoPoll(); - case PGRES_POLLING_READING: - status = CREAD; - return true; - case PGRES_POLLING_FAILED: - return false; - case PGRES_POLLING_OK: - status = WWRITE; - return DoConnectedPoll(); - default: - return true; } } - bool OnDataReady() - { - /* Always return true here, false would close the socket - we need to do that ourselves with the pgsql API */ - return DoEvent(); - } - - bool OnWriteReady() - { - /* Always return true here, false would close the socket - we need to do that ourselves with the pgsql API */ - return DoEvent(); - } - - bool OnConnected() - { - return DoEvent(); - } - void DelayReconnect(); - bool DoEvent() + void DoEvent() { - bool ret; - if((status == CREAD) || (status == CWRITE)) { - ret = DoPoll(); + DoPoll(); + } + else if (status == WREAD || status == WWRITE) + { + DoConnectedPoll(); } - else if((status == RREAD) || (status == RWRITE)) + } + + void Submit(SQL::Query *req, const std::string& q) CXX11_OVERRIDE + { + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Executing PostgreSQL query: " + q); + if (qinprog.q.empty()) { - ret = DoResetPoll(); + DoQuery(QueueItem(req,q)); } else { - ret = DoConnectedPoll(); + // wait your turn. + queue.push_back(QueueItem(req,q)); } - return ret; } - SQLerror DoQuery(SQLrequest &req) + void Submit(SQL::Query *req, const std::string& q, const SQL::ParamList& p) CXX11_OVERRIDE { - if((status == WREAD) || (status == WWRITE)) + std::string res; + unsigned int param = 0; + for(std::string::size_type i = 0; i < q.length(); i++) { - if(!qinprog) + if (q[i] != '?') + res.push_back(q[i]); + else { - /* Parse the command string and dispatch it */ - - /* Pointer to the buffer we screw around with substitution in */ - char* query; - /* Pointer to the current end of query, where we append new stuff */ - char* queryend; - - /* Total length of the unescaped parameters */ - unsigned long maxparamlen, paramcount; - - /* The length of the longest parameter */ - maxparamlen = 0; - - for(ParamL::iterator i = req.query.p.begin(); i != req.query.p.end(); i++) - { - if (i->size() > maxparamlen) - maxparamlen = i->size(); - } - - /* How many params are there in the query? */ - paramcount = count(req.query.q.c_str(), '?'); - - /* This stores copy of params to be inserted with using numbered params 1;3B*/ - ParamL paramscopy(req.query.p); - - /* To avoid a lot of allocations, allocate enough memory for the biggest the escaped query could possibly be. - * sizeofquery + (maxtotalparamlength*2) + 1 - * - * The +1 is for null-terminating the string for PQsendQuery() - */ - - query = new char[req.query.q.length() + (maxparamlen*paramcount*2) + 1]; - queryend = query; - - /* Okay, now we have a buffer large enough we need to start copying the query into it and escaping and substituting - * the parameters into it... - */ - - for(unsigned int i = 0; i < req.query.q.length(); i++) + if (param < p.size()) { - if(req.query.q[i] == '?') - { - /* We found a place to substitute..what fun. - * Use the PgSQL calls to escape and write the - * escaped string onto the end of our query buffer, - * then we "just" need to make sure queryend is - * pointing at the right place. - */ - - /* Is it numbered parameter? - */ - - bool numbered; - numbered = false; - - /* Numbered parameter number :| - */ - unsigned int paramnum; - paramnum = 0; - - /* Let's check if it's a numbered param. And also calculate it's number. - */ - - while ((i < req.query.q.length() - 1) && (req.query.q[i+1] >= '0') && (req.query.q[i+1] <= '9')) - { - numbered = true; - ++i; - paramnum = paramnum * 10 + req.query.q[i] - '0'; - } - - if (paramnum > paramscopy.size() - 1) - { - /* index is out of range! - */ - numbered = false; - } - - if (numbered) - { - int error = 0; - size_t len = 0; - -#ifdef PGSQL_HAS_ESCAPECONN - len = PQescapeStringConn(sql, queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length(), &error); -#else - len = PQescapeString (queryend, paramscopy[paramnum].c_str(), paramscopy[paramnum].length()); -#endif - if (error) - { - ServerInstance->Logs->Log("m_pgsql", DEBUG, "BUG: Apparently PQescapeStringConn() failed somehow...don't know how or what to do..."); - } - - /* Incremenet queryend to the end of the newly escaped parameter */ - queryend += len; - } - else if (req.query.p.size()) - { - int error = 0; - size_t len = 0; - -#ifdef PGSQL_HAS_ESCAPECONN - len = PQescapeStringConn(sql, queryend, req.query.p.front().c_str(), req.query.p.front().length(), &error); -#else - len = PQescapeString (queryend, req.query.p.front().c_str(), req.query.p.front().length()); -#endif - if(error) - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Apparently PQescapeStringConn() failed somehow...don't know how or what to do..."); - } - - /* Incremenet queryend to the end of the newly escaped parameter */ - queryend += len; - - /* Remove the parameter we just substituted in */ - req.query.p.pop_front(); - } - else - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: Found a substitution location but no parameter to substitute :|"); - break; - } - } - else - { - *queryend = req.query.q[i]; - queryend++; - } + std::string parm = p[param++]; + std::vector buffer(parm.length() * 2 + 1); + int error; + size_t escapedsize = PQescapeStringConn(sql, &buffer[0], parm.data(), parm.length(), &error); + if (error) + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "BUG: Apparently PQescapeStringConn() failed"); + res.append(&buffer[0], escapedsize); } + } + } + Submit(req, res); + } - /* Null-terminate the query */ - *queryend = 0; - req.query.q = query; - - if(PQsendQuery(sql, query)) - { - qinprog = true; - delete[] query; - return SQLerror(); - } - else + void Submit(SQL::Query *req, const std::string& q, const SQL::ParamMap& p) CXX11_OVERRIDE + { + std::string res; + for(std::string::size_type i = 0; i < q.length(); i++) + { + if (q[i] != '$') + res.push_back(q[i]); + else + { + std::string field; + i++; + while (i < q.length() && isalnum(q[i])) + field.push_back(q[i++]); + i--; + + SQL::ParamMap::const_iterator it = p.find(field); + if (it != p.end()) { - delete[] query; - return SQLerror(SQL_QSEND_FAIL, PQerrorMessage(sql)); + std::string parm = it->second; + std::vector buffer(parm.length() * 2 + 1); + int error; + size_t escapedsize = PQescapeStringConn(sql, &buffer[0], parm.data(), parm.length(), &error); + if (error) + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "BUG: Apparently PQescapeStringConn() failed"); + res.append(&buffer[0], escapedsize); } } } - return SQLerror(SQL_BAD_CONN, "Can't query until connection is complete"); + Submit(req, res); } - SQLerror Query(const SQLrequest &req) + void DoQuery(const QueueItem& req) { - queue.push(req); + if (status != WREAD && status != WWRITE) + { + // whoops, not connected... + SQL::Error err(SQL::BAD_CONN); + req.c->OnError(err); + delete req.c; + return; + } - if(!qinprog && queue.totalsize()) + if(PQsendQuery(sql, req.q.c_str())) { - /* There's no query currently in progress, and there's queries in the queue. */ - SQLrequest& query = queue.front(); - return DoQuery(query); + qinprog = req; } else { - return SQLerror(); + SQL::Error err(SQL::QSEND_FAIL, PQerrorMessage(sql)); + req.c->OnError(err); + delete req.c; } } - void OnUnloadModule(Module* mod) - { - queue.PurgeModule(mod); - } - - const SQLhost GetConfHost() - { - return confhost; - } - void Close() { - if (!this->ServerInstance->SE->DelFd(this)) - { - if (sql && PQstatus(sql) == CONNECTION_BAD) - { - this->ServerInstance->SE->DelFd(this, true); - } - else - { - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: PQsocket cant be removed from socket engine!"); - } - } + status = DEAD; + + if (HasFd() && SocketEngine::HasFd(GetFd())) + SocketEngine::DelFd(this); if(sql) { @@ -772,277 +520,127 @@ class SQLConn : public EventHandler sql = NULL; } } - }; class ModulePgSQL : public Module { - private: + public: ConnMap connections; - unsigned long currid; - char* sqlsuccess; ReconnectTimer* retimer; - public: - ModulePgSQL(InspIRCd* Me) - : Module(Me), currid(0) + ModulePgSQL() + : retimer(NULL) { - ServerInstance->Modules->UseInterface("SQLutils"); - - sqlsuccess = new char[strlen(SQLSUCCESS)+1]; - - strlcpy(sqlsuccess, SQLSUCCESS, strlen(SQLSUCCESS)); - - if (!ServerInstance->Modules->PublishFeature("SQL", this)) - { - throw ModuleException("BUG: PgSQL Unable to publish feature 'SQL'"); - } - - ReadConf(); - - ServerInstance->Modules->PublishInterface("SQL", this); - Implementation eventlist[] = { I_OnUnloadModule, I_OnRequest, I_OnRehash, I_OnUserRegister, I_OnCheckReady, I_OnUserDisconnect }; - ServerInstance->Modules->Attach(eventlist, this, 6); } - virtual ~ModulePgSQL() + ~ModulePgSQL() { - if (retimer) - ServerInstance->Timers->DelTimer(retimer); + delete retimer; ClearAllConnections(); - delete[] sqlsuccess; - ServerInstance->Modules->UnpublishInterface("SQL", this); - ServerInstance->Modules->UnpublishFeature("SQL"); - ServerInstance->Modules->DoneWithInterface("SQLutils"); } - - virtual void OnRehash(User* user, const std::string ¶meter) + void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE { ReadConf(); } - bool HasHost(const SQLhost &host) - { - for (ConnMap::iterator iter = connections.begin(); iter != connections.end(); iter++) - { - if (host == iter->second->GetConfHost()) - return true; - } - return false; - } - - bool HostInConf(const SQLhost &h) - { - ConfigReader conf(ServerInstance); - for(int i = 0; i < conf.Enumerate("database"); i++) - { - SQLhost host; - host.id = conf.ReadValue("database", "id", i); - host.host = conf.ReadValue("database", "hostname", i); - host.port = conf.ReadInteger("database", "port", i, true); - host.name = conf.ReadValue("database", "name", i); - host.user = conf.ReadValue("database", "username", i); - host.pass = conf.ReadValue("database", "password", i); - host.ssl = conf.ReadFlag("database", "ssl", "0", i); - if (h == host) - return true; - } - return false; - } - void ReadConf() { - ClearOldConnections(); - - ConfigReader conf(ServerInstance); - for(int i = 0; i < conf.Enumerate("database"); i++) + ConnMap conns; + ConfigTagList tags = ServerInstance->Config->ConfTags("database"); + for(ConfigIter i = tags.first; i != tags.second; i++) { - SQLhost host; - int ipvalid; - - host.id = conf.ReadValue("database", "id", i); - host.host = conf.ReadValue("database", "hostname", i); - host.port = conf.ReadInteger("database", "port", i, true); - host.name = conf.ReadValue("database", "name", i); - host.user = conf.ReadValue("database", "username", i); - host.pass = conf.ReadValue("database", "password", i); - host.ssl = conf.ReadFlag("database", "ssl", "0", i); - - if (HasHost(host)) + if (!stdalgo::string::equalsci(i->second->getString("module"), "pgsql")) continue; - -#ifdef IPV6 - if (strchr(host.host.c_str(),':')) - { - in6_addr blargle; - ipvalid = inet_pton(AF_INET6, host.host.c_str(), &blargle); - } - else -#endif - { - in_addr blargle; - ipvalid = inet_aton(host.host.c_str(), &blargle); - } - - if(ipvalid > 0) - { - /* The conversion succeeded, we were given an IP and we can give it straight to SQLConn */ - host.ip = host.host; - this->AddConn(host); - } - else if(ipvalid == 0) + std::string id = i->second->getString("id"); + ConnMap::iterator curr = connections.find(id); + if (curr == connections.end()) { - /* Conversion failed, assume it's a host */ - SQLresolver* resolver; - - try + SQLConn* conn = new SQLConn(this, i->second); + if (conn->status != DEAD) { - bool cached; - resolver = new SQLresolver(this, ServerInstance, host, cached); - ServerInstance->AddResolver(resolver, cached); - } - catch(...) - { - /* THE WORLD IS COMING TO AN END! */ + conns.insert(std::make_pair(id, conn)); + ServerInstance->Modules->AddService(*conn); } + // If the connection is dead it has already been queued for culling + // at the end of the main loop so we don't need to delete it here. } else { - /* Invalid address family, die horribly. */ - ServerInstance->Logs->Log("m_pgsql",DEBUG, "BUG: insp_aton failed returning -1, oh noes."); - } - } - } - - void ClearOldConnections() - { - ConnMap::iterator iter,safei; - for (iter = connections.begin(); iter != connections.end(); iter++) - { - if (!HostInConf(iter->second->GetConfHost())) - { - delete iter->second; - safei = iter; - --iter; - connections.erase(safei); + conns.insert(*curr); + connections.erase(curr); } } + ClearAllConnections(); + conns.swap(connections); } void ClearAllConnections() { - ConnMap::iterator i; - while ((i = connections.begin()) != connections.end()) + for(ConnMap::iterator i = connections.begin(); i != connections.end(); i++) { - connections.erase(i); + i->second->cull(); delete i->second; } + connections.clear(); } - void AddConn(const SQLhost& hi) - { - if (HasHost(hi)) - { - ServerInstance->Logs->Log("m_pgsql",DEFAULT, "WARNING: A pgsql connection with id: %s already exists, possibly due to DNS delay. Aborting connection attempt.", hi.id.c_str()); - return; - } - - SQLConn* newconn; - - /* The conversion succeeded, we were given an IP and we can give it straight to SQLConn */ - newconn = new SQLConn(ServerInstance, this, hi); - - connections.insert(std::make_pair(hi.id, newconn)); - } - - void ReconnectConn(SQLConn* conn) + void OnUnloadModule(Module* mod) CXX11_OVERRIDE { - for (ConnMap::iterator iter = connections.begin(); iter != connections.end(); iter++) + SQL::Error err(SQL::BAD_DBID); + for(ConnMap::iterator i = connections.begin(); i != connections.end(); i++) { - if (conn == iter->second) + SQLConn* conn = i->second; + if (conn->qinprog.c && conn->qinprog.c->creator == mod) { - delete iter->second; - connections.erase(iter); - break; + conn->qinprog.c->OnError(err); + delete conn->qinprog.c; + conn->qinprog.c = NULL; } - } - retimer = new ReconnectTimer(ServerInstance, this); - ServerInstance->Timers->AddTimer(retimer); - } - - virtual const char* OnRequest(Request* request) - { - if(strcmp(SQLREQID, request->GetId()) == 0) - { - SQLrequest* req = (SQLrequest*)request; - ConnMap::iterator iter; - if((iter = connections.find(req->dbid)) != connections.end()) + std::deque::iterator j = conn->queue.begin(); + while (j != conn->queue.end()) { - /* Execute query */ - req->id = NewID(); - req->error = iter->second->Query(*req); - - return (req->error.Id() == SQL_NO_ERROR) ? sqlsuccess : NULL; - } - else - { - req->error.Id(SQL_BAD_DBID); - return NULL; + SQL::Query* q = j->c; + if (q->creator == mod) + { + q->OnError(err); + delete q; + j = conn->queue.erase(j); + } + else + j++; } } - return NULL; - } - - virtual void OnUnloadModule(Module* mod, const std::string& name) - { - /* When a module unloads we have to check all the pending queries for all our connections - * and set the Module* specifying where the query came from to NULL. If the query has already - * been dispatched then when it is processed it will be dropped if the pointer is NULL. - * - * If the queries we find are not already being executed then we can simply remove them immediately. - */ - for(ConnMap::iterator iter = connections.begin(); iter != connections.end(); iter++) - { - iter->second->OnUnloadModule(mod); - } - } - - unsigned long NewID() - { - if (currid+1 == 0) - currid++; - - return ++currid; } - virtual Version GetVersion() + Version GetVersion() CXX11_OVERRIDE { - return Version("$Id$", VF_VENDOR|VF_SERVICEPROVIDER, API_VERSION); + return Version("Provides the ability for SQL modules to query a PostgreSQL database.", VF_VENDOR); } }; -/* move this here to use AddConn, rather that than having the whole - * module above SQLConn, since this is buggin me right now :/ - */ -void SQLresolver::OnLookupComplete(const std::string &result, unsigned int ttl, bool cached, int resultnum) -{ - if (!resultnum) - { - host.ip = result; - ((ModulePgSQL*)mod)->AddConn(host); - ((ModulePgSQL*)mod)->ClearOldConnections(); - } -} - -void ReconnectTimer::Tick(time_t time) +bool ReconnectTimer::Tick(time_t time) { - ((ModulePgSQL*)mod)->ReadConf(); + mod->retimer = NULL; + mod->ReadConf(); + delete this; + return false; } void SQLConn::DelayReconnect() { - ((ModulePgSQL*)us)->ReconnectConn(this); + status = DEAD; + ModulePgSQL* mod = (ModulePgSQL*)(Module*)creator; + + ConnMap::iterator it = mod->connections.find(conf->getString("id")); + if (it != mod->connections.end()) + mod->connections.erase(it); + ServerInstance->GlobalCulls.AddItem((EventHandler*)this); + if (!mod->retimer) + { + mod->retimer = new ReconnectTimer(mod); + ServerInstance->Timers.AddTimer(mod->retimer); + } } MODULE_INIT(ModulePgSQL)