X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_channames.cpp;h=c2bf9feecdb99d57b9eef6e1be278e4fbe3ad71a;hb=551d687ec6d7ce44be35fae0dd7345fe73c4f63a;hp=92774edff7575230ebb350ef1f1d784471851d37;hpb=44f42a13de52c8025942ddab42f51feb36821782;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_channames.cpp b/src/modules/m_channames.cpp
index 92774edff..c2bf9feec 100644
--- a/src/modules/m_channames.cpp
+++ b/src/modules/m_channames.cpp
@@ -23,44 +23,45 @@
 
 static std::bitset<256> allowedmap;
 
-class NewIsChannelHandler : public HandlerBase2<bool, const char*, size_t>
+class NewIsChannelHandler : public HandlerBase2<bool, const std::string&, size_t>
 {
  public:
 	NewIsChannelHandler() { }
 	virtual ~NewIsChannelHandler() { }
-	virtual bool Call(const char*, size_t);
+	virtual bool Call(const std::string&, size_t);
 };
 
-bool NewIsChannelHandler::Call(const char* c, size_t max)
+bool NewIsChannelHandler::Call(const std::string& channame, size_t max)
 {
-		/* check for no name - don't check for !*chname, as if it is empty, it won't be '#'! */
-		if (!c || *c++ != '#')
+	if (channame.empty() || channame.length() > max || channame[0] != '#')
+		return false;
+
+	for (std::string::const_iterator c = channame.begin(); c != channame.end(); ++c)
+	{
+		unsigned int i = *c & 0xFF;
+		if (!allowedmap[i])
 			return false;
+	}
 
-		while (*c && --max)
-		{
-			unsigned int i = *c++ & 0xFF;
-			if (!allowedmap[i])
-				return false;
-		}
-		// a name of exactly max length will have max = 1 here; the null does not trigger --max
-		return max;
+	return true;
 }
 
 class ModuleChannelNames : public Module
 {
- private:
 	NewIsChannelHandler myhandler;
-	caller2<bool, const char*, size_t> rememberer;
+	caller2<bool, const std::string&, size_t> rememberer;
 	bool badchan;
 
  public:
-	ModuleChannelNames() : rememberer(ServerInstance->IsChannel)
+	ModuleChannelNames() : rememberer(ServerInstance->IsChannel), badchan(false)
+	{
+	}
+
+	void init()
 	{
 		ServerInstance->IsChannel = &myhandler;
-		badchan = false;
 		Implementation eventlist[] = { I_OnRehash, I_OnUserKick };
-		ServerInstance->Modules->Attach(eventlist, this, 2);
+		ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 		OnRehash(NULL);
 	}
 
@@ -70,7 +71,7 @@ class ModuleChannelNames : public Module
 		std::vector<Channel*> chanvec;
 		for (chan_hash::const_iterator i = ServerInstance->chanlist->begin(); i != ServerInstance->chanlist->end(); ++i)
 		{
-			if (!ServerInstance->IsChannel(i->second->name.c_str(), MAXBUF))
+			if (!ServerInstance->IsChannel(i->second->name, MAXBUF))
 				chanvec.push_back(i->second);
 		}
 		std::vector<Channel*>::reverse_iterator c2 = chanvec.rbegin();
@@ -95,9 +96,9 @@ class ModuleChannelNames : public Module
 
 	virtual void OnRehash(User* user)
 	{
-		ConfigReader Conf;
-		std::string denyToken = Conf.ReadValue("channames", "denyrange", 0);
-		std::string allowToken = Conf.ReadValue("channames", "allowrange", 0);
+		ConfigTag* tag = ServerInstance->Config->ConfValue("channames");
+		std::string denyToken = tag->getString("denyrange");
+		std::string allowToken = tag->getString("allowrange");
 		allowedmap.set();
 
 		irc::portparser denyrange(denyToken, false);