X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_cloaking.cpp;h=daa04cf9bd2a6a4da5d77cfd2bf3cc6dc41e3322;hb=80e81e3b81b779901fd9d67f8ae030ee30c0bcec;hp=f4cfdb54f8b07c7186e11f1e5b27b1196a6c5ee5;hpb=fc4fc43ec232407b38d7ca182cb92c5cac4287aa;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/m_cloaking.cpp b/src/modules/m_cloaking.cpp index f4cfdb54f..daa04cf9b 100644 --- a/src/modules/m_cloaking.cpp +++ b/src/modules/m_cloaking.cpp @@ -1,13 +1,20 @@ /* * InspIRCd -- Internet Relay Chat Daemon * + * Copyright (C) 2017, 2019 B00mX0r + * Copyright (C) 2017 Sheogorath + * Copyright (C) 2016 Adam + * Copyright (C) 2014 Thomas Fargeix + * Copyright (C) 2013, 2018 Attila Molnar + * Copyright (C) 2013, 2016-2020 Sadie Powell + * Copyright (C) 2012 Robby + * Copyright (C) 2011 jackmcbarn * Copyright (C) 2009-2010 Daniel De Graaf - * Copyright (C) 2006-2008 Robin Burchell - * Copyright (C) 2008 Pippijn van Steenhoven - * Copyright (C) 2003-2008 Craig Edwards - * Copyright (C) 2007 John Brooks - * Copyright (C) 2007 Dennis Friis - * Copyright (C) 2006 Oliver Lupton + * Copyright (C) 2007-2009 Robin Burchell + * Copyright (C) 2007-2008 Dennis Friis + * Copyright (C) 2007 John Brooks + * Copyright (C) 2006 Oliver Lupton + * Copyright (C) 2003, 2007-2008, 2010 Craig Edwards * * This file is part of InspIRCd. InspIRCd is free software: you can * redistribute it and/or modify it under the terms of the GNU General Public @@ -24,18 +31,13 @@ #include "inspircd.h" -#include "hash.h" - -/* $ModDesc: Provides masking of user hostnames */ +#include "modules/hash.h" enum CloakMode { - /** 1.2-compatible host-based cloak */ - MODE_COMPAT_HOST, - /** 1.2-compatible IP-only cloak */ - MODE_COMPAT_IPONLY, /** 2.0 cloak of "half" of the hostname plus the full IP hash */ MODE_HALF_CLOAK, + /** 2.0 cloak of IP hash, split at 2 common CIDR range points */ MODE_OPAQUE }; @@ -43,24 +45,75 @@ enum CloakMode // lowercase-only encoding similar to base64, used for hash output static const char base32[] = "0123456789abcdefghijklmnopqrstuv"; -/** Handles user mode +x - */ -class CloakUser : public ModeHandler +// The minimum length of a cloak key. +static const size_t minkeylen = 30; + +struct CloakInfo +{ + // The method used for cloaking users. + CloakMode mode; + + // The number of parts of the hostname shown when using half cloaking. + unsigned int domainparts; + + // Whether to ignore the case of a hostname when cloaking it. + bool ignorecase; + + // The secret used for generating cloaks. + std::string key; + + // The prefix for cloaks (e.g. MyNet-). + std::string prefix; + + // The suffix for IP cloaks (e.g. .IP). + std::string suffix; + + CloakInfo(CloakMode Mode, const std::string& Key, const std::string& Prefix, const std::string& Suffix, bool IgnoreCase, unsigned int DomainParts = 0) + : mode(Mode) + , domainparts(DomainParts) + , ignorecase(IgnoreCase) + , key(Key) + , prefix(Prefix) + , suffix(Suffix) + { + } +}; + +typedef std::vector CloakList; + +class CloakExtItem : public SimpleExtItem { public: - LocalStringExt ext; + CloakExtItem(Module* Creator) + : SimpleExtItem("cloaks", ExtensionItem::EXT_USER, Creator) + { + } + + std::string ToHuman(const Extensible* container, void* item) const CXX11_OVERRIDE + { + return stdalgo::string::join(*static_cast(item), ' '); + } +}; +class CloakUser : public ModeHandler +{ + public: + bool active; + CloakExtItem ext; std::string debounce_uid; time_t debounce_ts; int debounce_count; CloakUser(Module* source) - : ModeHandler(source, "cloak", 'x', PARAM_NONE, MODETYPE_USER), - ext("cloaked_host", source), debounce_ts(0), debounce_count(0) + : ModeHandler(source, "cloak", 'x', PARAM_NONE, MODETYPE_USER) + , active(false) + , ext(source) + , debounce_ts(0) + , debounce_count(0) { } - ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) + ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE { LocalUser* user = IS_LOCAL(dest); @@ -70,7 +123,9 @@ class CloakUser : public ModeHandler */ if (!user) { - dest->SetMode('x',adding); + // Remote setters broadcast mode before host while local setters do the opposite, so this takes that into account + active = IS_LOCAL(source) ? adding : !adding; + dest->SetMode(this, adding); return MODEACTION_ALLOW; } @@ -87,7 +142,7 @@ class CloakUser : public ModeHandler debounce_ts = ServerInstance->Time(); } - if (adding == user->IsModeSet('x')) + if (adding == user->IsModeSet(this)) return MODEACTION_DENY; /* don't allow this user to spam modechanges */ @@ -97,21 +152,30 @@ class CloakUser : public ModeHandler if (adding) { // assume this is more correct - if (user->registered != REG_ALL && user->host != user->dhost) + if (user->registered != REG_ALL && user->GetRealHost() != user->GetDisplayedHost()) return MODEACTION_DENY; - std::string* cloak = ext.get(user); - - if (!cloak) + CloakList* cloaks = ext.get(user); + if (!cloaks) { /* Force creation of missing cloak */ - creator->OnUserConnect(user); - cloak = ext.get(user); + try + { + creator->OnUserConnect(user); + cloaks = ext.get(user); + } + catch (CoreException& modexcept) + { + ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Exception caught when generating cloak: " + modexcept.GetReason()); + return MODEACTION_DENY; + } } - if (cloak) + + // If we have a cloak then set the hostname. + if (cloaks && !cloaks->empty()) { - user->ChangeDisplayedHost(cloak->c_str()); - user->SetMode('x',true); + user->ChangeDisplayedHost(cloaks->front()); + user->SetMode(this, true); return MODEACTION_ALLOW; } else @@ -122,12 +186,11 @@ class CloakUser : public ModeHandler /* User is removing the mode, so restore their real host * and make it match the displayed one. */ - user->SetMode('x',false); - user->ChangeDisplayedHost(user->host.c_str()); + user->SetMode(this, false); + user->ChangeDisplayedHost(user->GetRealHost().c_str()); return MODEACTION_ALLOW; } } - }; class CommandCloak : public Command @@ -139,67 +202,68 @@ class CommandCloak : public Command syntax = ""; } - CmdResult Handle(const std::vector ¶meters, User *user); + CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE; }; class ModuleCloaking : public Module { public: CloakUser cu; - CloakMode mode; CommandCloak ck; - std::string prefix; - std::string suffix; - std::string key; - unsigned int compatkey[4]; - const char* xtab[4]; + std::vector cloaks; dynamic_reference Hash; - ModuleCloaking() : cu(this), mode(MODE_OPAQUE), ck(this), Hash(this, "hash/md5") - { - } - - void init() + ModuleCloaking() + : cu(this) + , ck(this) + , Hash(this, "hash/md5") { - OnRehash(NULL); - - ServerInstance->Modules->AddService(cu); - ServerInstance->Modules->AddService(ck); - ServerInstance->Modules->AddService(cu.ext); - - Implementation eventlist[] = { I_OnRehash, I_OnCheckBan, I_OnUserConnect, I_OnChangeHost }; - ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation)); } - /** This function takes a domain name string and returns just the last two domain parts, - * or the last domain part if only two are available. Failing that it just returns what it was given. + /** Takes a domain name and retrieves the subdomain which should be visible. + * This is usually the last \p domainparts labels but if not enough are + * present then all but the most specific label are used. If the domain name + * consists of one label only then none are used. * - * For example, if it is passed "svn.inspircd.org" it will return ".inspircd.org". - * If it is passed "brainbox.winbot.co.uk" it will return ".co.uk", - * and if it is passed "localhost.localdomain" it will return ".localdomain". + * Here are some examples for how domain names will be shortened assuming + * \p domainparts is set to the default of 3. * - * This is used to ensure a significant part of the host is always cloaked (see Bug #216) + * "this.is.an.example.com" => ".an.example.com" + * "an.example.com" => ".example.com" + * "example.com" => ".com" + * "localhost" => "" + * + * @param host The hostname to cloak. + * @param domainparts The number of domain labels that should be visible. + * @return The visible segment of the hostname. */ - std::string LastTwoDomainParts(const std::string &host) + std::string VisibleDomainParts(const std::string& host, unsigned int domainparts) { - int dots = 0; - std::string::size_type splitdot = host.length(); + // The position at which we found the last dot. + std::string::const_reverse_iterator dotpos; + + // The number of dots we have seen so far. + unsigned int seendots = 0; - for (std::string::size_type x = host.length() - 1; x; --x) + for (std::string::const_reverse_iterator iter = host.rbegin(); iter != host.rend(); ++iter) { - if (host[x] == '.') - { - splitdot = x; - dots++; - } - if (dots >= 3) + if (*iter != '.') + continue; + + // We have found a dot! + dotpos = iter; + seendots += 1; + + // Do we have enough segments to stop? + if (seendots >= domainparts) break; } - if (splitdot == host.length()) + // We only returns a domain part if more than one label is + // present. See above for a full explanation. + if (!seendots) return ""; - else - return host.substr(splitdot); + return std::string(dotpos.base() - 1, host.end()); } /** @@ -208,17 +272,20 @@ class ModuleCloaking : public Module * @param id A unique ID for this type of item (to make it unique if the item matches) * @param len The length of the output. Maximum for MD5 is 16 characters. */ - std::string SegmentCloak(const std::string& item, char id, int len) + std::string SegmentCloak(const CloakInfo& info, const std::string& item, char id, size_t len) { std::string input; - input.reserve(key.length() + 3 + item.length()); + input.reserve(info.key.length() + 3 + item.length()); input.append(1, id); - input.append(key); + input.append(info.key); input.append(1, '\0'); // null does not terminate a C++ string - input.append(item); + if (info.ignorecase) + std::transform(item.begin(), item.end(), std::back_inserter(input), ::tolower); + else + input.append(item); - std::string rv = Hash->sum(input).substr(0,len); - for(int i=0; i < len; i++) + std::string rv = Hash->GenerateRaw(input).substr(0,len); + for(size_t i = 0; i < len; i++) { // this discards 3 bits per byte. We have an // overabundance of bits in the hash output, doesn't @@ -228,70 +295,13 @@ class ModuleCloaking : public Module return rv; } - std::string CompatCloak4(const char* ip) - { - irc::sepstream seps(ip, '.'); - std::string octet[4]; - int i[4]; - - for (int j = 0; j < 4; j++) - { - seps.GetToken(octet[j]); - i[j] = atoi(octet[j].c_str()); - } - - octet[3] = octet[0] + "." + octet[1] + "." + octet[2] + "." + octet[3]; - octet[2] = octet[0] + "." + octet[1] + "." + octet[2]; - octet[1] = octet[0] + "." + octet[1]; - - /* Reset the Hash module and send it our IV */ - - std::string rv; - - /* Send the Hash module a different hex table for each octet group's Hash sum */ - for (int k = 0; k < 4; k++) - { - rv.append(Hash->sumIV(compatkey, xtab[(compatkey[k]+i[k]) % 4], octet[k]).substr(0,6)); - if (k < 3) - rv.append("."); - } - /* Stick them all together */ - return rv; - } - - std::string CompatCloak6(const char* ip) - { - std::vector hashies; - std::string item; - int rounds = 0; - - /* Reset the Hash module and send it our IV */ - - for (const char* input = ip; *input; input++) - { - item += *input; - if (item.length() > 7) - { - hashies.push_back(Hash->sumIV(compatkey, xtab[(compatkey[0]+rounds) % 4], item).substr(0,8)); - item.clear(); - } - rounds++; - } - if (!item.empty()) - { - hashies.push_back(Hash->sumIV(compatkey, xtab[(compatkey[0]+rounds) % 4], item).substr(0,8)); - } - /* Stick them all together */ - return irc::stringjoiner(":", hashies, 0, hashies.size() - 1).GetJoined(); - } - - std::string SegmentIP(const irc::sockets::sockaddrs& ip, bool full) + std::string SegmentIP(const CloakInfo& info, const irc::sockets::sockaddrs& ip, bool full) { std::string bindata; - int hop1, hop2, hop3; - int len1, len2; + size_t hop1, hop2, hop3; + size_t len1, len2; std::string rv; - if (ip.sa.sa_family == AF_INET6) + if (ip.family() == AF_INET6) { bindata = std::string((const char*)ip.in6.sin6_addr.s6_addr, 16); hop1 = 8; @@ -301,7 +311,7 @@ class ModuleCloaking : public Module len2 = 4; // pfx s1.s2.s3. (xxxx.xxxx or s4) sfx // 6 4 4 9/6 - rv.reserve(prefix.length() + 26 + suffix.length()); + rv.reserve(info.prefix.length() + 26 + info.suffix.length()); } else { @@ -311,67 +321,74 @@ class ModuleCloaking : public Module hop3 = 2; len1 = len2 = 3; // pfx s1.s2. (xxx.xxx or s3) sfx - rv.reserve(prefix.length() + 15 + suffix.length()); + rv.reserve(info.prefix.length() + 15 + info.suffix.length()); } - rv.append(prefix); - rv.append(SegmentCloak(bindata, 10, len1)); + rv.append(info.prefix); + rv.append(SegmentCloak(info, bindata, 10, len1)); rv.append(1, '.'); bindata.erase(hop1); - rv.append(SegmentCloak(bindata, 11, len2)); + rv.append(SegmentCloak(info, bindata, 11, len2)); if (hop2) { rv.append(1, '.'); bindata.erase(hop2); - rv.append(SegmentCloak(bindata, 12, len2)); + rv.append(SegmentCloak(info, bindata, 12, len2)); } if (full) { rv.append(1, '.'); bindata.erase(hop3); - rv.append(SegmentCloak(bindata, 13, 6)); - rv.append(suffix); + rv.append(SegmentCloak(info, bindata, 13, 6)); + rv.append(info.suffix); } else { - char buf[50]; - if (ip.sa.sa_family == AF_INET6) + if (ip.family() == AF_INET6) { - snprintf(buf, 50, ".%02x%02x.%02x%02x%s", + rv.append(InspIRCd::Format(".%02x%02x.%02x%02x%s", ip.in6.sin6_addr.s6_addr[2], ip.in6.sin6_addr.s6_addr[3], - ip.in6.sin6_addr.s6_addr[0], ip.in6.sin6_addr.s6_addr[1], suffix.c_str()); + ip.in6.sin6_addr.s6_addr[0], ip.in6.sin6_addr.s6_addr[1], info.suffix.c_str())); } else { const unsigned char* ip4 = (const unsigned char*)&ip.in4.sin_addr; - snprintf(buf, 50, ".%d.%d%s", ip4[1], ip4[0], suffix.c_str()); + rv.append(InspIRCd::Format(".%d.%d%s", ip4[1], ip4[0], info.suffix.c_str())); } - rv.append(buf); } return rv; } - ModResult OnCheckBan(User* user, Channel* chan, const std::string& mask) + ModResult OnCheckBan(User* user, Channel* chan, const std::string& mask) CXX11_OVERRIDE { LocalUser* lu = IS_LOCAL(user); if (!lu) return MOD_RES_PASSTHRU; + // Force the creation of cloaks if not already set. OnUserConnect(lu); - std::string* cloak = cu.ext.get(user); - /* Check if they have a cloaked host, but are not using it */ - if (cloak && *cloak != user->dhost) + + // If the user has no cloaks (i.e. UNIX socket) then we do nothing here. + CloakList* cloaklist = cu.ext.get(user); + if (!cloaklist || cloaklist->empty()) + return MOD_RES_PASSTHRU; + + // Check if they have a cloaked host but are not using it. + for (CloakList::const_iterator iter = cloaklist->begin(); iter != cloaklist->end(); ++iter) { - char cmask[MAXBUF]; - snprintf(cmask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), cloak->c_str()); - if (InspIRCd::Match(cmask,mask)) - return MOD_RES_DENY; + const std::string& cloak = *iter; + if (cloak != user->GetDisplayedHost()) + { + const std::string cloakMask = user->nick + "!" + user->ident + "@" + cloak; + if (InspIRCd::Match(cloakMask, mask)) + return MOD_RES_DENY; + } } return MOD_RES_PASSTHRU; } - void Prioritize() + void Prioritize() CXX11_OVERRIDE { /* Needs to be after m_banexception etc. */ ServerInstance->Modules->SetPriority(this, I_OnCheckBan, PRIORITY_LAST); @@ -379,190 +396,161 @@ class ModuleCloaking : public Module // this unsets umode +x on every host change. If we are actually doing a +x // mode change, we will call SetMode back to true AFTER the host change is done. - void OnChangeHost(User* u, const std::string& host) + void OnChangeHost(User* u, const std::string& host) CXX11_OVERRIDE { - if(u->IsModeSet('x')) + if (u->IsModeSet(cu) && !cu.active) { - u->SetMode('x', false); - u->WriteServ("MODE %s -x", u->nick.c_str()); - } - } + u->SetMode(cu, false); - ~ModuleCloaking() - { + LocalUser* luser = IS_LOCAL(u); + if (!luser) + return; + + Modes::ChangeList modechangelist; + modechangelist.push_remove(&cu); + ClientProtocol::Events::Mode modeevent(ServerInstance->FakeClient, NULL, u, modechangelist); + luser->Send(modeevent); + } + cu.active = false; } - Version GetVersion() + Version GetVersion() CXX11_OVERRIDE { std::string testcloak = "broken"; - if (Hash) + if (Hash && !cloaks.empty()) { - switch (mode) + const CloakInfo& info = cloaks.front(); + switch (info.mode) { - case MODE_COMPAT_HOST: - testcloak = prefix + "-" + Hash->sumIV(compatkey, xtab[0], "*").substr(0,10); - break; - case MODE_COMPAT_IPONLY: - testcloak = Hash->sumIV(compatkey, xtab[0], "*").substr(0,10); - break; case MODE_HALF_CLOAK: - testcloak = prefix + SegmentCloak("*", 3, 8) + suffix; + // Use old cloaking verification to stay compatible with 2.0 + // But verify domainparts and ignorecase when use 3.0-only features + if (info.domainparts == 3 && !info.ignorecase) + testcloak = info.prefix + SegmentCloak(info, "*", 3, 8) + info.suffix; + else + { + irc::sockets::sockaddrs sa; + testcloak = GenCloak(info, sa, "", testcloak + ConvToStr(info.domainparts)) + (info.ignorecase ? "-ci" : ""); + } break; case MODE_OPAQUE: - testcloak = prefix + SegmentCloak("*", 4, 8) + suffix; + testcloak = info.prefix + SegmentCloak(info, "*", 4, 8) + info.suffix + (info.ignorecase ? "-ci" : ""); } } - return Version("Provides masking of user hostnames", VF_COMMON|VF_VENDOR, testcloak); + return Version("Adds user mode x (cloak) which allows user hostnames to be hidden.", VF_COMMON|VF_VENDOR, testcloak); } - void OnRehash(User* user) + void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE { - ConfigTag* tag = ServerInstance->Config->ConfValue("cloak"); - prefix = tag->getString("prefix"); - suffix = tag->getString("suffix", ".IP"); - - std::string modestr = tag->getString("mode"); - if (modestr == "compat-host") - mode = MODE_COMPAT_HOST; - else if (modestr == "compat-ip") - mode = MODE_COMPAT_IPONLY; - else if (modestr == "half") - mode = MODE_HALF_CLOAK; - else if (modestr == "full") - mode = MODE_OPAQUE; - else - throw ModuleException("Bad value for ; must be one of compat-host, compat-ip, half, full"); + ConfigTagList tags = ServerInstance->Config->ConfTags("cloak"); + if (tags.first == tags.second) + throw ModuleException("You have loaded the cloaking module but not configured any tags!"); - if (mode == MODE_COMPAT_HOST || mode == MODE_COMPAT_IPONLY) + std::vector newcloaks; + for (ConfigIter i = tags.first; i != tags.second; ++i) { - bool lowercase = tag->getBool("lowercase"); - - /* These are *not* using the need_positive parameter of ReadInteger - - * that will limit the valid values to only the positive values in a - * signed int. Instead, accept any value that fits into an int and - * cast it to an unsigned int. That will, a bit oddly, give us the full - * spectrum of an unsigned integer. - Special - * - * We must limit the keys or else we get different results on - * amd64/x86 boxes. - psychon */ - const unsigned int limit = 0x80000000; - compatkey[0] = (unsigned int) tag->getInt("key1"); - compatkey[1] = (unsigned int) tag->getInt("key2"); - compatkey[2] = (unsigned int) tag->getInt("key3"); - compatkey[3] = (unsigned int) tag->getInt("key4"); - - if (!lowercase) + ConfigTag* tag = i->second; + + // Ensure that we have the parameter. + const std::string key = tag->getString("key"); + if (key.empty()) + throw ModuleException("You have not defined a cloaking key. Define as a " + ConvToStr(minkeylen) + "+ character network-wide secret, at " + tag->getTagLocation()); + + // If we are the first cloak method then mandate a strong key. + if (i == tags.first && key.length() < minkeylen) + throw ModuleException("Your cloaking key is not secure. It should be at least " + ConvToStr(minkeylen) + " characters long, at " + tag->getTagLocation()); + + const bool ignorecase = tag->getBool("ignorecase"); + const std::string mode = tag->getString("mode"); + const std::string prefix = tag->getString("prefix"); + const std::string suffix = tag->getString("suffix", ".IP"); + if (stdalgo::string::equalsci(mode, "half")) { - xtab[0] = "F92E45D871BCA630"; - xtab[1] = "A1B9D80C72E653F4"; - xtab[2] = "1ABC078934DEF562"; - xtab[3] = "ABCDEF5678901234"; + unsigned int domainparts = tag->getUInt("domainparts", 3, 1, 10); + newcloaks.push_back(CloakInfo(MODE_HALF_CLOAK, key, prefix, suffix, ignorecase, domainparts)); } + else if (stdalgo::string::equalsci(mode, "full")) + newcloaks.push_back(CloakInfo(MODE_OPAQUE, key, prefix, suffix, ignorecase)); else - { - xtab[0] = "f92e45d871bca630"; - xtab[1] = "a1b9d80c72e653f4"; - xtab[2] = "1abc078934def562"; - xtab[3] = "abcdef5678901234"; - } - - if (prefix.empty()) - prefix = ServerInstance->Config->Network; - - if (!compatkey[0] || !compatkey[1] || !compatkey[2] || !compatkey[3] || - compatkey[0] >= limit || compatkey[1] >= limit || compatkey[2] >= limit || compatkey[3] >= limit) - { - std::string detail; - if (!compatkey[0] || compatkey[0] >= limit) - detail = " is not valid, it may be set to a too high/low value, or it may not exist."; - else if (!compatkey[1] || compatkey[1] >= limit) - detail = " is not valid, it may be set to a too high/low value, or it may not exist."; - else if (!compatkey[2] || compatkey[2] >= limit) - detail = " is not valid, it may be set to a too high/low value, or it may not exist."; - else if (!compatkey[3] || compatkey[3] >= limit) - detail = " is not valid, it may be set to a too high/low value, or it may not exist."; - - throw ModuleException("You have not defined cloak keys for m_cloaking!!! THIS IS INSECURE AND SHOULD BE CHECKED! - " + detail); - } - } - else - { - key = tag->getString("key"); - if (key.empty() || key == "secret") - throw ModuleException("You have not defined cloak keys for m_cloaking. Define as a network-wide secret."); + throw ModuleException(mode + " is an invalid value for ; acceptable values are 'half' and 'full', at " + tag->getTagLocation()); } + + // The cloak configuration was valid so we can apply it. + cloaks.swap(newcloaks); } - std::string GenCloak(const irc::sockets::sockaddrs& ip, const std::string& ipstr, const std::string& host) + std::string GenCloak(const CloakInfo& info, const irc::sockets::sockaddrs& ip, const std::string& ipstr, const std::string& host) { std::string chost; irc::sockets::sockaddrs hostip; bool host_is_ip = irc::sockets::aptosa(host, ip.port(), hostip) && hostip == ip; - switch (mode) + switch (info.mode) { - case MODE_COMPAT_HOST: - { - if (!host_is_ip) - { - std::string tail = LastTwoDomainParts(host); - - // xtab is not used here due to a bug in 1.2 cloaking - chost = prefix + "-" + Hash->sumIV(compatkey, "0123456789abcdef", host).substr(0,8) + tail; - - /* Fix by brain - if the cloaked host is > the max length of a host (64 bytes - * according to the DNS RFC) then they get cloaked as an IP. - */ - if (chost.length() <= 64) - break; - } - // fall through to IP cloak - } - case MODE_COMPAT_IPONLY: - if (ip.sa.sa_family == AF_INET6) - chost = CompatCloak6(ipstr.c_str()); - else - chost = CompatCloak4(ipstr.c_str()); - break; case MODE_HALF_CLOAK: { if (!host_is_ip) - chost = prefix + SegmentCloak(host, 1, 6) + LastTwoDomainParts(host); + chost = info.prefix + SegmentCloak(info, host, 1, 6) + VisibleDomainParts(host, info.domainparts); if (chost.empty() || chost.length() > 50) - chost = SegmentIP(ip, false); + chost = SegmentIP(info, ip, false); break; } case MODE_OPAQUE: default: - chost = SegmentIP(ip, true); + chost = SegmentIP(info, ip, true); } return chost; } - void OnUserConnect(LocalUser* dest) + void OnSetUserIP(LocalUser* user) CXX11_OVERRIDE { - std::string* cloak = cu.ext.get(dest); - if (cloak) + // Connecting users are handled in OnUserConnect not here. + if (user->registered != REG_ALL || user->quitting) return; - cu.ext.set(dest, GenCloak(dest->client_sa, dest->GetIPString(), dest->host)); + // Remove the cloaks and generate new ones. + cu.ext.unset(user); + OnUserConnect(user); + + // If a user is using a cloak then update it. + if (user->IsModeSet(cu)) + { + CloakList* cloaklist = cu.ext.get(user); + user->ChangeDisplayedHost(cloaklist->front()); + } + } + + void OnUserConnect(LocalUser* dest) CXX11_OVERRIDE + { + if (cu.ext.get(dest)) + return; + + // TODO: decide how we are going to cloak AF_UNIX hostnames. + if (dest->client_sa.family() != AF_INET && dest->client_sa.family() != AF_INET6) + return; + + CloakList cloaklist; + for (std::vector::const_iterator iter = cloaks.begin(); iter != cloaks.end(); ++iter) + cloaklist.push_back(GenCloak(*iter, dest->client_sa, dest->GetIPString(), dest->GetRealHost())); + cu.ext.set(dest, cloaklist); } }; -CmdResult CommandCloak::Handle(const std::vector ¶meters, User *user) +CmdResult CommandCloak::Handle(User* user, const Params& parameters) { ModuleCloaking* mod = (ModuleCloaking*)(Module*)creator; - irc::sockets::sockaddrs sa; - std::string cloak; - - if (irc::sockets::aptosa(parameters[0], 0, sa)) - cloak = mod->GenCloak(sa, parameters[0], parameters[0]); - else - cloak = mod->GenCloak(sa, "", parameters[0]); - user->WriteServ("NOTICE %s :*** Cloak for %s is %s", user->nick.c_str(), parameters[0].c_str(), cloak.c_str()); + // If we're cloaking an IP address we pass it in the IP field too. + irc::sockets::sockaddrs sa; + const char* ipaddr = irc::sockets::aptosa(parameters[0], 0, sa) ? parameters[0].c_str() : ""; + unsigned int id = 0; + for (std::vector::const_iterator iter = mod->cloaks.begin(); iter != mod->cloaks.end(); ++iter) + { + const std::string cloak = mod->GenCloak(*iter, sa, ipaddr, parameters[0]); + user->WriteNotice(InspIRCd::Format("*** Cloak #%u for %s is %s", ++id, parameters[0].c_str(), cloak.c_str())); + } return CMD_SUCCESS; }