X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_dnsbl.cpp;h=c2f666c7ec1202cd24c56069a61dfcdd4d8af8b2;hb=7c197db72eab03321e4f3e847054e13126520504;hp=ab4c2e76d6e2950cfc1e1a8edea51ddde6b6b547;hpb=38ee4b2f89e1ba66bb0c50b2bae559acf5c2c007;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_dnsbl.cpp b/src/modules/m_dnsbl.cpp
index ab4c2e76d..c2f666c7e 100644
--- a/src/modules/m_dnsbl.cpp
+++ b/src/modules/m_dnsbl.cpp
@@ -34,6 +34,7 @@ class DNSBLConfEntry
 		long duration;
 		int bitmask;
 		DNSBLConfEntry(): duration(86400),bitmask(0) {}
+		~DNSBLConfEntry() { }
 };
 
 
@@ -63,29 +64,14 @@ class DNSBLResolver : public Resolver
 			if(result.length())
 			{
 				unsigned int bitmask=0;
-				unsigned int octetpos=0;
-				std::string tmp = result;
+				in_addr resultip;
 
-				while(tmp.length()>0)
-				{
-					std::string octet;
-					/* Fix by brain, npos is -1, so unsigned int will never match */
-					std::string::size_type lastdot = tmp.rfind(".");
-
-					if (lastdot == std::string::npos)
-					{
-						octet=tmp;
-						tmp.clear();
-					}
-					else
-					{
-						octet=tmp.substr(lastdot+1,tmp.length()-lastdot+1);
-						tmp.resize(lastdot);
-					}
-
-					bitmask += (256 ^ octetpos) * atoi(octet.c_str());
-					octetpos += 1;
-				}
+				/* Convert the result to an in_addr (we can gaurantee we got ipv4)
+				 * Whoever did the loop that was here before, I AM CONFISCATING
+				 * YOUR CRACKPIPE. you know who you are. -- Brain
+				 */
+				inet_aton(result.c_str(), &resultip);
+				bitmask = resultip.s_addr >> 24; /* Last octet (network byte order */
 
 				bitmask &= ConfEntry->bitmask;
 
@@ -112,19 +98,19 @@ class DNSBLResolver : public Resolver
 						case DNSBLConfEntry::I_KLINE:
 						{
 							ServerInstance->AddKLine(ConfEntry->duration, ServerInstance->Config->ServerName, reason, std::string("*@") + them->GetIPString());
-							FOREACH_MOD(I_OnAddKLine,OnAddKLine(ServerInstance->Duration(ConfEntry->duration), NULL, reason, std::string("*@") + them->GetIPString()));
+							FOREACH_MOD(I_OnAddKLine,OnAddKLine(ConfEntry->duration, NULL, reason, std::string("*@") + them->GetIPString()));
 							break;
 						}
 						case DNSBLConfEntry::I_GLINE:
 						{
 							ServerInstance->AddGLine(ConfEntry->duration, ServerInstance->Config->ServerName, reason, std::string("*@") + them->GetIPString());
-							FOREACH_MOD(I_OnAddGLine,OnAddGLine(ServerInstance->Duration(ConfEntry->duration), NULL, reason, std::string("*@") + them->GetIPString()));
+							FOREACH_MOD(I_OnAddGLine,OnAddGLine(ConfEntry->duration, NULL, reason, std::string("*@") + them->GetIPString()));
 							break;
 						}
 						case DNSBLConfEntry::I_ZLINE:
 						{
 							ServerInstance->AddZLine(ConfEntry->duration, ServerInstance->Config->ServerName, reason, them->GetIPString());
-				            FOREACH_MOD(I_OnAddZLine,OnAddZLine(ServerInstance->Duration(ConfEntry->duration), NULL, reason, them->GetIPString()));
+							FOREACH_MOD(I_OnAddZLine,OnAddZLine(ConfEntry->duration, NULL, reason, them->GetIPString()));
 							break;
 						}
 						case DNSBLConfEntry::I_UNKNOWN:
@@ -194,11 +180,9 @@ class ModuleDNSBL : public Module
 	void ClearEntries()
 	{
 		std::vector<DNSBLConfEntry *>::iterator i;
-		while ((i = DNSBLConfEntries.begin()) != DNSBLConfEntries.end())
-		{
-			DNSBLConfEntries.erase(i);
+		for (std::vector<DNSBLConfEntry *>::iterator i = DNSBLConfEntries.begin(); i != DNSBLConfEntries.end(); i++)
 			delete *i;
-		}
+		DNSBLConfEntries.clear();
 	}
 
 	/** Fill our conf vector with data