X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_helpop.cpp;h=b36bf2e803e17450d518592d11428d04ae0ce26d;hb=05e6330fbd6e9a427c09cf90e2cada10656c48f7;hp=f16c64e82f483dff55f2b67442392b16bd13bf96;hpb=7d93921aabd9c608821baec8a871aff844dfae49;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_helpop.cpp b/src/modules/m_helpop.cpp
index f16c64e82..b36bf2e80 100644
--- a/src/modules/m_helpop.cpp
+++ b/src/modules/m_helpop.cpp
@@ -22,7 +22,7 @@ static std::map<irc::string, std::string> helpop_map;
 class Helpop : public ModeHandler
 {
  public:
-	Helpop(InspIRCd* Instance, Module* Creator) : ModeHandler(Creator, 'h', PARAM_NONE, MODETYPE_USER)
+	Helpop(Module* Creator) : ModeHandler(Creator, "helpop", 'h', PARAM_NONE, MODETYPE_USER)
 	{
 		oper = true;
 	}
@@ -55,7 +55,7 @@ class Helpop : public ModeHandler
 class CommandHelpop : public Command
 {
  public:
-	CommandHelpop(Module* Creator) : Command(Creator, "HELPOP", 0)
+	CommandHelpop(Module* Creator) : Command(Creator, "HELP", 0)
 	{
 		syntax = "<any-text>";
 	}
@@ -104,11 +104,7 @@ class CommandHelpop : public Command
 			user->WriteServ("292 %s : -", user->nick.c_str());
 			user->WriteServ("292 %s :*** End of HELPOP", user->nick.c_str());
 		}
-
-		/* We dont want these going out over the network, return CMD_FAILURE
-		 * to make sure the protocol module thinks theyre not worth sending.
-		 */
-		return CMD_FAILURE;
+		return CMD_SUCCESS;
 	}
 };
 
@@ -120,8 +116,8 @@ class ModuleHelpop : public Module
 		Helpop ho;
 
 	public:
-		ModuleHelpop(InspIRCd* Me)
-			: Module(Me), cmd(this), ho(Me, this)
+		ModuleHelpop()
+			: cmd(this), ho(this)
 		{
 			ReadConfig();
 			if (!ServerInstance->Modes->AddMode(&ho))
@@ -133,14 +129,17 @@ class ModuleHelpop : public Module
 
 		virtual void ReadConfig()
 		{
-			ConfigReader MyConf(ServerInstance);
+			ConfigReader MyConf;
 
 			helpop_map.clear();
 
-			for (int i = 0; i < MyConf.Enumerate("helpop"); i++)
+			ConfigTagList tags = ServerInstance->Config->ConfTags("helpop");
+			for(ConfigIter i = tags.first; i != tags.second; ++i)
 			{
-				irc::string key = assign(MyConf.ReadValue("helpop", "key", i));
-				std::string value = MyConf.ReadValue("helpop", "value", i, true); /* Linefeeds allowed! */
+				ConfigTag* tag = i->second;
+				irc::string key = assign(tag->getString("key"));
+				std::string value;
+				tag->readString("value", value, true); /* Linefeeds allowed */
 
 				if (key == "index")
 				{
@@ -153,12 +152,12 @@ class ModuleHelpop : public Module
 			if (helpop_map.find("start") == helpop_map.end())
 			{
 				// error!
-				throw ModuleException("m_helpop: Helpop file is missing important entries. Please check the example conf.");
+				throw ModuleException("m_helpop: Helpop file is missing important entry 'start'. Please check the example conf.");
 			}
 			else if (helpop_map.find("nohelp") == helpop_map.end())
 			{
 				// error!
-				throw ModuleException("m_helpop: Helpop file is missing important entries. Please check the example conf.");
+				throw ModuleException("m_helpop: Helpop file is missing important entry 'nohelp'. Please check the example conf.");
 			}
 
 		}
@@ -179,12 +178,11 @@ class ModuleHelpop : public Module
 
 		virtual ~ModuleHelpop()
 		{
-			ServerInstance->Modes->DelMode(&ho);
 		}
 
 		virtual Version GetVersion()
 		{
-			return Version("/helpop Command, Works like Unreal helpop", VF_COMMON | VF_VENDOR, API_VERSION);
+			return Version("/helpop Command, Works like Unreal helpop", VF_VENDOR | VF_COMMON);
 		}
 };