X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_httpd.cpp;h=f3ec3298bd8823b154b4c9fb5017159ba7bea800;hb=HEAD;hp=eba78b98bbc88e3f855997297d7e05a0c3ad3333;hpb=d185decae97752368d5cf62311cbc0d1a52aa22c;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/m_httpd.cpp b/src/modules/m_httpd.cpp index eba78b98b..f3ec3298b 100644 --- a/src/modules/m_httpd.cpp +++ b/src/modules/m_httpd.cpp @@ -1,200 +1,291 @@ -/* +------------------------------------+ - * | Inspire Internet Relay Chat Daemon | - * +------------------------------------+ +/* + * InspIRCd -- Internet Relay Chat Daemon * - * InspIRCd: (C) 2002-2008 InspIRCd Development Team - * See: http://www.inspircd.org/wiki/index.php/Credits + * Copyright (C) 2019 linuxdaemon + * Copyright (C) 2018 edef + * Copyright (C) 2013-2014, 2017-2020 Sadie Powell + * Copyright (C) 2012-2016 Attila Molnar + * Copyright (C) 2012 Robby + * Copyright (C) 2009 Uli Schlachter + * Copyright (C) 2009 Daniel De Graaf + * Copyright (C) 2008 Robin Burchell + * Copyright (C) 2007 John Brooks + * Copyright (C) 2007 Dennis Friis + * Copyright (C) 2006, 2008, 2010 Craig Edwards * - * This program is free but copyrighted software; see - * the file COPYING for details. + * This file is part of InspIRCd. InspIRCd is free software: you can + * redistribute it and/or modify it under the terms of the GNU General Public + * License as published by the Free Software Foundation, version 2. * - * --------------------------------------------------- + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS + * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more + * details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . */ -#include "inspircd.h" -#include "httpd.h" +/// $CompilerFlags: -Ivendor_directory("http_parser") -/* $ModDesc: Provides HTTP serving facilities to modules */ -/* $ModDep: httpd.h */ + +#include "inspircd.h" +#include "iohook.h" +#include "modules/httpd.h" + +#ifdef __GNUC__ +# pragma GCC diagnostic push +#endif + +// Fix warnings about the use of commas at end of enumerator lists and long long +// on C++03. +#if defined __clang__ +# pragma clang diagnostic ignored "-Wc++11-extensions" +# pragma clang diagnostic ignored "-Wc++11-long-long" +#elif defined __GNUC__ +# pragma GCC diagnostic ignored "-Wlong-long" +# if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 8)) +# pragma GCC diagnostic ignored "-Wpedantic" +# else +# pragma GCC diagnostic ignored "-pedantic" +# endif +#endif + +// Fix warnings about shadowing in http_parser. +#ifdef __GNUC__ +# pragma GCC diagnostic ignored "-Wshadow" +#endif + +#include + +#ifdef __GNUC__ +# pragma GCC diagnostic pop +#endif class ModuleHttpServer; static ModuleHttpServer* HttpModule; -static bool claimed; - -/** HTTP socket states - */ -enum HttpState -{ - HTTP_LISTEN = 0, - HTTP_SERVE_WAIT_REQUEST = 1, /* Waiting for a full request */ - HTTP_SERVE_RECV_POSTDATA = 2, /* Waiting to finish recieving POST data */ - HTTP_SERVE_SEND_DATA = 3 /* Sending response */ -}; +static insp::intrusive_list sockets; +static Events::ModuleEventProvider* aclevprov; +static Events::ModuleEventProvider* reqevprov; +static http_parser_settings parser_settings; /** A socket used for HTTP transport */ -class HttpServerSocket : public BufferedSocket +class HttpServerSocket : public BufferedSocket, public Timer, public insp::intrusive_list_node { - FileReader* index; - HttpState InternalState; + private: + friend class ModuleHttpServer; - HTTPHeaders headers; - std::string reqbuffer; - std::string postdata; - unsigned int postsize; - std::string request_type; + http_parser parser; + http_parser_url url; + std::string ip; std::string uri; - std::string http_version; + HTTPHeaders headers; + std::string body; + size_t total_buffers; + int status_code; - public: + /** True if this object is in the cull list + */ + bool waitingcull; + bool messagecomplete; - HttpServerSocket(InspIRCd* SI, std::string shost, int iport, bool listening, unsigned long maxtime, FileReader* index_page) : BufferedSocket(SI, shost, iport, listening, maxtime), index(index_page), postsize(0) + bool Tick(time_t currtime) CXX11_OVERRIDE { - InternalState = HTTP_LISTEN; + if (!messagecomplete) + { + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "HTTP socket %d timed out", GetFd()); + Close(); + return false; + } + + return true; } - HttpServerSocket(InspIRCd* SI, int newfd, char* ip, FileReader* ind) : BufferedSocket(SI, newfd, ip), index(ind), postsize(0) + template + static int Callback(http_parser* p) { - InternalState = HTTP_SERVE_WAIT_REQUEST; + HttpServerSocket* sock = static_cast(p->data); + return (sock->*f)(); } - FileReader* GetIndex() + template + static int DataCallback(http_parser* p, const char* buf, size_t len) { - return index; + HttpServerSocket* sock = static_cast(p->data); + return (sock->*f)(buf, len); } - ~HttpServerSocket() + static void ConfigureParser() { + http_parser_settings_init(&parser_settings); + parser_settings.on_message_begin = Callback<&HttpServerSocket::OnMessageBegin>; + parser_settings.on_url = DataCallback<&HttpServerSocket::OnUrl>; + parser_settings.on_header_field = DataCallback<&HttpServerSocket::OnHeaderField>; + parser_settings.on_body = DataCallback<&HttpServerSocket::OnBody>; + parser_settings.on_message_complete = Callback<&HttpServerSocket::OnMessageComplete>; } - virtual int OnIncomingConnection(int newsock, char* ip) + int OnMessageBegin() { - if (InternalState == HTTP_LISTEN) + uri.clear(); + header_state = HEADER_NONE; + body.clear(); + total_buffers = 0; + return 0; + } + + bool AcceptData(size_t len) + { + total_buffers += len; + return total_buffers < 8192; + } + + int OnUrl(const char* buf, size_t len) + { + if (!AcceptData(len)) { - new HttpServerSocket(this->Instance, newsock, ip, index); + status_code = HTTP_STATUS_URI_TOO_LONG; + return -1; } - return true; + uri.append(buf, len); + return 0; + } + + enum { HEADER_NONE, HEADER_FIELD, HEADER_VALUE } header_state; + std::string header_field; + std::string header_value; + + void OnHeaderComplete() + { + headers.SetHeader(header_field, header_value); + header_field.clear(); + header_value.clear(); + } + + int OnHeaderField(const char* buf, size_t len) + { + if (header_state == HEADER_VALUE) + OnHeaderComplete(); + header_state = HEADER_FIELD; + if (!AcceptData(len)) + { + status_code = HTTP_STATUS_REQUEST_HEADER_FIELDS_TOO_LARGE; + return -1; + } + header_field.append(buf, len); + return 0; + } + + int OnHeaderValue(const char* buf, size_t len) + { + header_state = HEADER_VALUE; + if (!AcceptData(len)) + { + status_code = HTTP_STATUS_REQUEST_HEADER_FIELDS_TOO_LARGE; + return -1; + } + header_value.append(buf, len); + return 0; } - virtual void OnClose() + int OnHeadersComplete() { + if (header_state != HEADER_NONE) + OnHeaderComplete(); + return 0; } - std::string Response(int response) + int OnBody(const char* buf, size_t len) { - switch (response) + if (!AcceptData(len)) { - case 100: - return "CONTINUE"; - case 101: - return "SWITCHING PROTOCOLS"; - case 200: - return "OK"; - case 201: - return "CREATED"; - case 202: - return "ACCEPTED"; - case 203: - return "NON-AUTHORITATIVE INFORMATION"; - case 204: - return "NO CONTENT"; - case 205: - return "RESET CONTENT"; - case 206: - return "PARTIAL CONTENT"; - case 300: - return "MULTIPLE CHOICES"; - case 301: - return "MOVED PERMENANTLY"; - case 302: - return "FOUND"; - case 303: - return "SEE OTHER"; - case 304: - return "NOT MODIFIED"; - case 305: - return "USE PROXY"; - case 307: - return "TEMPORARY REDIRECT"; - case 400: - return "BAD REQUEST"; - case 401: - return "UNAUTHORIZED"; - case 402: - return "PAYMENT REQUIRED"; - case 403: - return "FORBIDDEN"; - case 404: - return "NOT FOUND"; - case 405: - return "METHOD NOT ALLOWED"; - case 406: - return "NOT ACCEPTABLE"; - case 407: - return "PROXY AUTHENTICATION REQUIRED"; - case 408: - return "REQUEST TIMEOUT"; - case 409: - return "CONFLICT"; - case 410: - return "GONE"; - case 411: - return "LENGTH REQUIRED"; - case 412: - return "PRECONDITION FAILED"; - case 413: - return "REQUEST ENTITY TOO LARGE"; - case 414: - return "REQUEST-URI TOO LONG"; - case 415: - return "UNSUPPORTED MEDIA TYPE"; - case 416: - return "REQUESTED RANGE NOT SATISFIABLE"; - case 417: - return "EXPECTATION FAILED"; - case 500: - return "INTERNAL SERVER ERROR"; - case 501: - return "NOT IMPLEMENTED"; - case 502: - return "BAD GATEWAY"; - case 503: - return "SERVICE UNAVAILABLE"; - case 504: - return "GATEWAY TIMEOUT"; - case 505: - return "HTTP VERSION NOT SUPPORTED"; - default: - return "WTF"; - break; + status_code = HTTP_STATUS_PAYLOAD_TOO_LARGE; + return -1; + } + body.append(buf, len); + return 0; + } + int OnMessageComplete() + { + messagecomplete = true; + ServeData(); + return 0; + } + + public: + HttpServerSocket(int newfd, const std::string& IP, ListenSocket* via, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server, unsigned int timeoutsec) + : BufferedSocket(newfd) + , Timer(timeoutsec) + , ip(IP) + , status_code(0) + , waitingcull(false) + , messagecomplete(false) + { + if ((!via->iohookprovs.empty()) && (via->iohookprovs.back())) + { + via->iohookprovs.back()->OnAccept(this, client, server); + // IOHook may have errored + if (!getError().empty()) + { + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "HTTP socket %d encountered a hook error: %s", + GetFd(), getError().c_str()); + Close(); + return; + } } + + parser.data = this; + http_parser_init(&parser, HTTP_REQUEST); + ServerInstance->Timers.AddTimer(this); } - void SendHTTPError(int response) + ~HttpServerSocket() { - HTTPHeaders empty; - std::string data = "Server error "+ConvToStr(response)+": "+Response(response)+"
"+ - "Powered by InspIRCd"; + sockets.erase(this); + } + + void Close() CXX11_OVERRIDE + { + if (waitingcull || !HasFd()) + return; - SendHeaders(data.length(), response, empty); - this->Write(data); - this->FlushWriteBuffer(); + waitingcull = true; + BufferedSocket::Close(); + ServerInstance->GlobalCulls.AddItem(this); } - void SendHeaders(unsigned long size, int response, HTTPHeaders &rheaders) + void OnError(BufferedSocketError err) CXX11_OVERRIDE { + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "HTTP socket %d encountered an error: %d - %s", + GetFd(), err, getError().c_str()); + Close(); + } - this->Write(http_version + " "+ConvToStr(response)+" "+Response(response)+"\r\n"); + void SendHTTPError(unsigned int response, const char* errstr = NULL) + { + if (!errstr) + errstr = http_status_str((http_status)response); + + ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Sending HTTP error %u: %s", response, errstr); + static HTTPHeaders empty; + std::string data = InspIRCd::Format( + "" + "

Error %u

%s


" + "Powered by InspIRCd", + response, errstr); + + Page(data, response, &empty); + } - time_t local = this->Instance->Time(); - struct tm *timeinfo = gmtime(&local); - char *date = asctime(timeinfo); - date[strlen(date) - 1] = '\0'; - rheaders.CreateHeader("Date", date); + void SendHeaders(unsigned long size, unsigned int response, HTTPHeaders &rheaders) + { + WriteData(InspIRCd::Format("HTTP/%u.%u %u %s\r\n", parser.http_major ? parser.http_major : 1, parser.http_major ? parser.http_minor : 1, response, http_status_str((http_status)response))); - rheaders.CreateHeader("Server", "InspIRCd/m_httpd.so/1.2"); + rheaders.CreateHeader("Date", InspIRCd::TimeString(ServerInstance->Time(), "%a, %d %b %Y %H:%M:%S GMT", true)); + rheaders.CreateHeader("Server", INSPIRCD_BRANCH); rheaders.SetHeader("Content-Length", ConvToStr(size)); if (size) @@ -202,246 +293,196 @@ class HttpServerSocket : public BufferedSocket else rheaders.RemoveHeader("Content-Type"); - /* Supporting Connection: keep-alive causes a whole world of hurt syncronizing timeouts, + /* Supporting Connection: keep-alive causes a whole world of hurt synchronizing timeouts, * so remove it, its not essential for what we need. */ rheaders.SetHeader("Connection", "Close"); - this->Write(rheaders.GetFormattedHeaders()); - this->Write("\r\n"); + WriteData(rheaders.GetFormattedHeaders()); + WriteData("\r\n"); } - virtual bool OnDataReady() + void OnDataReady() CXX11_OVERRIDE { - const char* data = this->Read(); - - /* Check that the data read is a valid pointer and it has some content */ - if (!data || !*data) - return false; + if (parser.upgrade || HTTP_PARSER_ERRNO(&parser)) + return; + http_parser_execute(&parser, &parser_settings, recvq.data(), recvq.size()); + if (parser.upgrade) + SendHTTPError(status_code ? status_code : 400); + else if (HTTP_PARSER_ERRNO(&parser)) + SendHTTPError(status_code ? status_code : 400, http_errno_description((http_errno)parser.http_errno)); + } - if (InternalState == HTTP_SERVE_RECV_POSTDATA) - { - postdata.append(data); - if (postdata.length() >= postsize) - ServeData(); - } - else + void ServeData() + { + ModResult MOD_RESULT; + std::string method = http_method_str(static_cast(parser.method)); + HTTPRequestURI parsed; + ParseURI(uri, parsed); + HTTPRequest acl(method, parsed, &headers, this, ip, body); + FIRST_MOD_RESULT_CUSTOM(*aclevprov, HTTPACLEventListener, OnHTTPACLCheck, MOD_RESULT, (acl)); + if (MOD_RESULT != MOD_RES_DENY) { - reqbuffer.append(data); - - if (reqbuffer.length() >= 8192) + HTTPRequest request(method, parsed, &headers, this, ip, body); + FIRST_MOD_RESULT_CUSTOM(*reqevprov, HTTPRequestEventListener, OnHTTPRequest, MOD_RESULT, (request)); + if (MOD_RESULT == MOD_RES_PASSTHRU) { - Instance->Logs->Log("m_httpd",DEBUG, "m_httpd dropped connection due to an oversized request buffer"); - reqbuffer.clear(); - return false; + SendHTTPError(404); } - - if (InternalState == HTTP_SERVE_WAIT_REQUEST) - CheckRequestBuffer(); } + } - return true; + void Page(const std::string& s, unsigned int response, HTTPHeaders* hheaders) + { + SendHeaders(s.length(), response, *hheaders); + WriteData(s); + BufferedSocket::Close(true); } - void CheckRequestBuffer() + void Page(std::stringstream* n, unsigned int response, HTTPHeaders* hheaders) { - std::string::size_type reqend = reqbuffer.find("\r\n\r\n"); - if (reqend == std::string::npos) - return; + Page(n->str(), response, hheaders); + } - // We have the headers; parse them all - std::string::size_type hbegin = 0, hend; - while ((hend = reqbuffer.find("\r\n", hbegin)) != std::string::npos) - { - if (hbegin == hend) - break; + bool ParseURI(const std::string& uristr, HTTPRequestURI& out) + { + http_parser_url_init(&url); + if (http_parser_parse_url(uristr.c_str(), uristr.size(), 0, &url) != 0) + return false; - if (request_type.empty()) + if (url.field_set & (1 << UF_PATH)) + { + // Normalise the path. + std::vector pathsegments; + irc::sepstream pathstream(uri.substr(url.field_data[UF_PATH].off, url.field_data[UF_PATH].len), '/'); + for (std::string pathsegment; pathstream.GetToken(pathsegment); ) { - std::istringstream cheader(std::string(reqbuffer, hbegin, hend - hbegin)); - cheader >> request_type; - cheader >> uri; - cheader >> http_version; - - if (request_type.empty() || uri.empty() || http_version.empty()) + if (pathsegment == ".") { - SendHTTPError(400); - SetWrite(); - return; + // Stay at the current level. + continue; } - hbegin = hend + 2; - continue; - } - - std::string cheader = reqbuffer.substr(hbegin, hend - hbegin); + if (pathsegment == "..") + { + // Traverse up to the previous level. + if (!pathsegments.empty()) + pathsegments.pop_back(); + continue; + } - std::string::size_type fieldsep = cheader.find(':'); - if ((fieldsep == std::string::npos) || (fieldsep == 0) || (fieldsep == cheader.length() - 1)) - { - SendHTTPError(400); - SetWrite(); - return; + pathsegments.push_back(pathsegment); } - headers.SetHeader(cheader.substr(0, fieldsep), cheader.substr(fieldsep + 2)); - - hbegin = hend + 2; + out.path.reserve(url.field_data[UF_PATH].len); + out.path.append("/").append(stdalgo::string::join(pathsegments, '/')); } - reqbuffer.erase(0, reqend + 4); + if (url.field_set & (1 << UF_FRAGMENT)) + out.fragment = uri.substr(url.field_data[UF_FRAGMENT].off, url.field_data[UF_FRAGMENT].len); - std::transform(request_type.begin(), request_type.end(), request_type.begin(), ::toupper); - std::transform(http_version.begin(), http_version.end(), http_version.begin(), ::toupper); + std::string param_str; + if (url.field_set & (1 << UF_QUERY)) + param_str = uri.substr(url.field_data[UF_QUERY].off, url.field_data[UF_QUERY].len); - if ((http_version != "HTTP/1.1") && (http_version != "HTTP/1.0")) + irc::sepstream param_stream(param_str, '&'); + std::string token; + std::string::size_type eq_pos; + while (param_stream.GetToken(token)) { - SendHTTPError(505); - SetWrite(); - return; - } - - if (headers.IsSet("Content-Length") && (postsize = atoi(headers.GetHeader("Content-Length").c_str())) != 0) - { - InternalState = HTTP_SERVE_RECV_POSTDATA; - - if (reqbuffer.length() >= postsize) + eq_pos = token.find('='); + if (eq_pos == std::string::npos) { - postdata = reqbuffer.substr(0, postsize); - reqbuffer.erase(0, postsize); + out.query_params.insert(std::make_pair(token, "")); } - else if (!reqbuffer.empty()) - { - postdata = reqbuffer; - reqbuffer.clear(); - } - - if (postdata.length() >= postsize) - ServeData(); - - return; - } - - ServeData(); - } - - void ServeData() - { - InternalState = HTTP_SERVE_SEND_DATA; - - if ((request_type == "GET") && (uri == "/")) - { - HTTPHeaders empty; - SendHeaders(index->ContentSize(), 200, empty); - this->Write(index->Contents()); - this->FlushWriteBuffer(); - SetWrite(); - } - else - { - claimed = false; - HTTPRequest httpr(request_type,uri,&headers,this,this->GetIP(),postdata); - Event acl((char*)&httpr, (Module*)HttpModule, "httpd_acl"); - acl.Send(this->Instance); - if (!claimed) + else { - Event e((char*)&httpr, (Module*)HttpModule, "httpd_url"); - e.Send(this->Instance); - if (!claimed) - { - SendHTTPError(404); - SetWrite(); - } + out.query_params.insert(std::make_pair(token.substr(0, eq_pos), token.substr(eq_pos + 1))); } } + return true; } +}; - - bool OnWriteReady() - { - Instance->Logs->Log("m_httpd",DEBUG,"OnWriteReady()"); - return false; - } - - void Page(std::stringstream* n, int response, HTTPHeaders *hheaders) +class HTTPdAPIImpl : public HTTPdAPIBase +{ + public: + HTTPdAPIImpl(Module* parent) + : HTTPdAPIBase(parent) { - SendHeaders(n->str().length(), response, *hheaders); - this->Write(n->str()); - this->FlushWriteBuffer(); - SetWrite(); } - void SetWrite() + void SendResponse(HTTPDocumentResponse& resp) CXX11_OVERRIDE { - Instance->Logs->Log("m_httpd",DEBUG,"SetWrite()"); - this->WaitingForWriteEvent = true; - Instance->SE->WantWrite(this); + resp.src.sock->Page(resp.document, resp.responsecode, &resp.headers); } }; class ModuleHttpServer : public Module { - std::vector httpsocks; - public: + HTTPdAPIImpl APIImpl; + unsigned int timeoutsec; + Events::ModuleEventProvider acleventprov; + Events::ModuleEventProvider reqeventprov; - void ReadConfig() + public: + ModuleHttpServer() + : APIImpl(this) + , acleventprov(this, "event/http-acl") + , reqeventprov(this, "event/http-request") { - int port; - std::string host; - std::string bindip; - std::string indexfile; - FileReader* index; - HttpServerSocket* http; - ConfigReader c(ServerInstance); - - httpsocks.clear(); - - for (int i = 0; i < c.Enumerate("http"); i++) - { - host = c.ReadValue("http", "host", i); - bindip = c.ReadValue("http", "ip", i); - port = c.ReadInteger("http", "port", i, true); - indexfile = c.ReadValue("http", "index", i); - index = new FileReader(ServerInstance, indexfile); - if (!index->Exists()) - throw ModuleException("Can't read index file: "+indexfile); - http = new HttpServerSocket(ServerInstance, bindip, port, true, 0, index); - httpsocks.push_back(http); - } + aclevprov = &acleventprov; + reqevprov = &reqeventprov; + HttpServerSocket::ConfigureParser(); } - ModuleHttpServer(InspIRCd* Me) : Module(Me) + void init() CXX11_OVERRIDE { - ReadConfig(); HttpModule = this; - Implementation eventlist[] = { I_OnRequest }; - ServerInstance->Modules->Attach(eventlist, this, 1); } - virtual const char* OnRequest(Request* request) + void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE { - claimed = true; - HTTPDocument* doc = (HTTPDocument*)request->GetData(); - HttpServerSocket* sock = (HttpServerSocket*)doc->sock; - sock->Page(doc->GetDocument(), doc->GetResponseCode(), &doc->headers); - return NULL; + ConfigTag* tag = ServerInstance->Config->ConfValue("httpd"); + timeoutsec = tag->getDuration("timeout", 10, 1); } + ModResult OnAcceptConnection(int nfd, ListenSocket* from, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server) CXX11_OVERRIDE + { + if (!stdalgo::string::equalsci(from->bind_tag->getString("type"), "httpd")) + return MOD_RES_PASSTHRU; + + sockets.push_front(new HttpServerSocket(nfd, client->addr(), from, client, server, timeoutsec)); + return MOD_RES_ALLOW; + } + + void OnUnloadModule(Module* mod) CXX11_OVERRIDE + { + for (insp::intrusive_list::const_iterator i = sockets.begin(); i != sockets.end(); ) + { + HttpServerSocket* sock = *i; + ++i; + if (sock->GetModHook(mod)) + { + sock->cull(); + delete sock; + } + } + } - virtual ~ModuleHttpServer() + CullResult cull() CXX11_OVERRIDE { - for (size_t i = 0; i < httpsocks.size(); i++) + for (insp::intrusive_list::const_iterator i = sockets.begin(); i != sockets.end(); ++i) { - ServerInstance->SE->DelFd(httpsocks[i]); - httpsocks[i]->Close(); - delete httpsocks[i]->GetIndex(); + HttpServerSocket* sock = *i; + sock->Close(); } - ServerInstance->BufferedSocketCull(); + return Module::cull(); } - virtual Version GetVersion() + Version GetVersion() CXX11_OVERRIDE { - return Version(1,2,0,0,VF_VENDOR|VF_SERVICEPROVIDER,API_VERSION); + return Version("Allows the server administrator to serve various useful resources over HTTP.", VF_VENDOR); } };