X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_jumpserver.cpp;h=0e8f13c4d4f0efe41c4ae0cd01db91bb8deb29bd;hb=7107ec12d8640d35cfe3d5002db1bc1deb33625d;hp=80c9dc611964c7894025d75c944e02f4eb63093d;hpb=8882a85bf93835924baf68e20725d00e5594aea2;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_jumpserver.cpp b/src/modules/m_jumpserver.cpp
index 80c9dc611..0e8f13c4d 100644
--- a/src/modules/m_jumpserver.cpp
+++ b/src/modules/m_jumpserver.cpp
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
@@ -27,10 +27,9 @@ class CommandJumpserver : public Command
 	std::string reason;
 	int port;
 
-	CommandJumpserver (InspIRCd* Instance) : Command(Instance, "JUMPSERVER", "o", 0)
+	CommandJumpserver(Module* Creator) : Command(Creator, "JUMPSERVER", 0, 4)
 	{
-		this->source = "m_jumpserver.so";
-		syntax = "[<server> <port> <+/-a> :<reason>]";
+		flags_needed = 'o'; syntax = "[<server> <port> <+/-an> <reason>]";
 		redirect_to.clear();
 		reason.clear();
 		port = 0;
@@ -56,7 +55,7 @@ class CommandJumpserver : public Command
 
 			port = 0;
 			redirect_to.clear();
-			return CMD_LOCALONLY;
+			return CMD_SUCCESS;
 		}
 
 		port = 0;
@@ -80,9 +79,19 @@ class CommandJumpserver : public Command
 					case 'n':
 						redirect_new_users = direction;
 					break;
+					default:
+						user->WriteServ("NOTICE %s :*** Invalid JUMPSERVER flag: %c", user->nick.c_str(), *n);
+						return CMD_FAILURE;
+					break;
 				}
 			}
 
+			if (!atoi(parameters[1].c_str()))
+			{
+				user->WriteServ("NOTICE %s :*** Invalid port number", user->nick.c_str());
+				return CMD_FAILURE;
+			}
+
 			if (redirect_all_immediately)
 			{
 				/* Redirect everyone but the oper sending the command */
@@ -117,21 +126,18 @@ class CommandJumpserver : public Command
 					reason.c_str());
 		}
 
-		return CMD_LOCALONLY;
+		return CMD_SUCCESS;
 	}
 };
 
 
 class ModuleJumpServer : public Module
 {
-	CommandJumpserver*	js;
+	CommandJumpserver js;
  public:
-	ModuleJumpServer(InspIRCd* Me)
-		: Module(Me)
+	ModuleJumpServer() : js(this)
 	{
-
-		js = new CommandJumpserver(ServerInstance);
-		ServerInstance->AddCommand(js);
+		ServerInstance->AddCommand(&js);
 		Implementation eventlist[] = { I_OnUserRegister };
 		ServerInstance->Modules->Attach(eventlist, this, 1);
 	}
@@ -140,21 +146,22 @@ class ModuleJumpServer : public Module
 	{
 	}
 
-	virtual int OnUserRegister(User* user)
+	virtual ModResult OnUserRegister(User* user)
 	{
-		if (js->port && js->redirect_new_users)
+		if (js.port && js.redirect_new_users)
 		{
-			user->WriteNumeric(10, "%s %s %d :Please use this Server/Port instead", user->nick.c_str(), js->redirect_to.c_str(), js->port);
-			ServerInstance->Users->QuitUser(user, js->reason);
-			return 0;
+			user->WriteNumeric(10, "%s %s %d :Please use this Server/Port instead",
+				user->nick.c_str(), js.redirect_to.c_str(), js.port);
+			ServerInstance->Users->QuitUser(user, js.reason);
+			return MOD_RES_PASSTHRU;
 		}
-		return 0;
+		return MOD_RES_PASSTHRU;
 	}
 
 
 	virtual Version GetVersion()
 	{
-		return Version(1,2,0,1,VF_VENDOR,API_VERSION);
+		return Version("Provides support for the RPL_REDIR numeric", VF_VENDOR, API_VERSION);
 	}
 
 };