X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_kicknorejoin.cpp;h=01d3aee71843939ee104c26ba025df10419a62ff;hb=a85bc774f9c4acbb2dbc1d9ddd02a460c5555391;hp=8ed472d313a65b7499ca506a438a9ba1dc981e35;hpb=1cb05553e286227e6bbd463d0b4b8cae40ff3940;p=user%2Fhenk%2Fcode%2Finspircd.git

diff --git a/src/modules/m_kicknorejoin.cpp b/src/modules/m_kicknorejoin.cpp
index 8ed472d31..01d3aee71 100644
--- a/src/modules/m_kicknorejoin.cpp
+++ b/src/modules/m_kicknorejoin.cpp
@@ -27,31 +27,44 @@
 
 /* $ModDesc: Provides channel mode +J (delay rejoin after kick) */
 
-typedef std::map<User*, time_t> delaylist;
+typedef std::map<std::string, time_t> delaylist;
 
 /** Handles channel mode +J
  */
-class KickRejoin : public ParamChannelModeHandler
+class KickRejoin : public ModeHandler
 {
+	static const unsigned int max = 60;
  public:
 	SimpleExtItem<delaylist> ext;
-	KickRejoin(Module* Creator) : ParamChannelModeHandler(Creator, "kicknorejoin", 'J'), ext("norejoinusers", Creator) { }
-
-	bool ParamValidate(std::string& parameter)
+	KickRejoin(Module* Creator)
+		: ModeHandler(Creator, "kicknorejoin", 'J', PARAM_SETONLY, MODETYPE_CHANNEL)
+		, ext("norejoinusers", Creator)
 	{
-		int v = atoi(parameter.c_str());
-		if (v <= 0)
-			return false;
-		parameter = ConvToStr(v);
-		return true;
 	}
 
-	ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding)
+	ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string& parameter, bool adding) CXX11_OVERRIDE
 	{
-		ModeAction rv = ParamChannelModeHandler::OnModeChange(source, dest, channel, parameter, adding);
-		if (rv == MODEACTION_ALLOW && !adding)
+		if (adding)
+		{
+			int v = ConvToInt(parameter);
+			if (v <= 0)
+				return MODEACTION_DENY;
+			if (parameter == channel->GetModeParameter(this))
+				return MODEACTION_DENY;
+
+			if ((IS_LOCAL(source) && ((unsigned int)v > max)))
+				v = max;
+
+			parameter = ConvToStr(v);
+		}
+		else
+		{
+			if (!channel->IsModeSet(this))
+				return MODEACTION_DENY;
+
 			ext.unset(channel);
-		return rv;
+		}
+		return MODEACTION_ALLOW;
 	}
 };
 
@@ -60,13 +73,12 @@ class ModuleKickNoRejoin : public Module
 	KickRejoin kr;
 
 public:
-
 	ModuleKickNoRejoin()
 		: kr(this)
 	{
 	}
 
-	void init()
+	void init() CXX11_OVERRIDE
 	{
 		ServerInstance->Modules->AddService(kr);
 		ServerInstance->Modules->AddService(kr.ext);
@@ -74,47 +86,43 @@ public:
 		ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 	}
 
-	ModResult OnUserPreJoin(User* user, Channel* chan, const std::string& cname, std::string& privs, const std::string& keygiven)
+	ModResult OnUserPreJoin(LocalUser* user, Channel* chan, const std::string& cname, std::string& privs, const std::string& keygiven) CXX11_OVERRIDE
 	{
 		if (chan)
 		{
 			delaylist* dl = kr.ext.get(chan);
 			if (dl)
 			{
-				std::vector<User*> itemstoremove;
-
-				for (delaylist::iterator iter = dl->begin(); iter != dl->end(); iter++)
+				for (delaylist::iterator iter = dl->begin(); iter != dl->end(); )
 				{
 					if (iter->second > ServerInstance->Time())
 					{
-						if (iter->first == user)
+						if (iter->first == user->uuid)
 						{
 							std::string modeparam = chan->GetModeParameter(&kr);
 							user->WriteNumeric(ERR_DELAYREJOIN, "%s %s :You must wait %s seconds after being kicked to rejoin (+J)",
 								user->nick.c_str(), chan->name.c_str(), modeparam.c_str());
 							return MOD_RES_DENY;
 						}
+						++iter;
 					}
 					else
 					{
 						// Expired record, remove.
-						itemstoremove.push_back(iter->first);
+						dl->erase(iter++);
 					}
 				}
 
-				for (unsigned int i = 0; i < itemstoremove.size(); i++)
-					dl->erase(itemstoremove[i]);
-
-				if (!dl->size())
+				if (dl->empty())
 					kr.ext.unset(chan);
 			}
 		}
 		return MOD_RES_PASSTHRU;
 	}
 
-	void OnUserKick(User* source, Membership* memb, const std::string &reason, CUList& excepts)
+	void OnUserKick(User* source, Membership* memb, const std::string &reason, CUList& excepts) CXX11_OVERRIDE
 	{
-		if (memb->chan->IsModeSet(&kr) && (source != memb->user))
+		if (memb->chan->IsModeSet(&kr) && (IS_LOCAL(memb->user)) && (source != memb->user))
 		{
 			delaylist* dl = kr.ext.get(memb->chan);
 			if (!dl)
@@ -122,19 +130,14 @@ public:
 				dl = new delaylist;
 				kr.ext.set(memb->chan, dl);
 			}
-			(*dl)[memb->user] = ServerInstance->Time() + ConvToInt(memb->chan->GetModeParameter(&kr));
+			(*dl)[memb->user->uuid] = ServerInstance->Time() + ConvToInt(memb->chan->GetModeParameter(&kr));
 		}
 	}
 
-	~ModuleKickNoRejoin()
-	{
-	}
-
-	Version GetVersion()
+	Version GetVersion() CXX11_OVERRIDE
 	{
 		return Version("Channel mode to delay rejoin after kick", VF_VENDOR);
 	}
 };
 
-
 MODULE_INIT(ModuleKickNoRejoin)