X-Git-Url: https://git.netwichtig.de/gitweb/?a=blobdiff_plain;f=src%2Fmodules%2Fm_nickflood.cpp;h=04d7c8b5e2cc86d28e812cf578bcc4a64639f282;hb=382662a8a4ae5c501b096643cb8f09d2d9d084d0;hp=d560774fc6280dd5c5ba9a5d6180473418568d05;hpb=e4acbc95b8b6cd5b28d38a2242c02e8ff4991e4a;p=user%2Fhenk%2Fcode%2Finspircd.git diff --git a/src/modules/m_nickflood.cpp b/src/modules/m_nickflood.cpp index d560774fc..04d7c8b5e 100644 --- a/src/modules/m_nickflood.cpp +++ b/src/modules/m_nickflood.cpp @@ -1,56 +1,62 @@ -/* +------------------------------------+ - * | Inspire Internet Relay Chat Daemon | - * +------------------------------------+ +/* + * InspIRCd -- Internet Relay Chat Daemon * - * InspIRCd: (C) 2002-2008 InspIRCd Development Team - * See: http://www.inspircd.org/wiki/index.php/Credits + * Copyright (C) 2009 Daniel De Graaf + * Copyright (C) 2007, 2009 Robin Burchell * - * This program is free but copyrighted software; see - * the file COPYING for details. + * This file is part of InspIRCd. InspIRCd is free software: you can + * redistribute it and/or modify it under the terms of the GNU General Public + * License as published by the Free Software Foundation, version 2. * - * --------------------------------------------------- + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS + * FOR A PARTICULAR PURPOSE. See the GNU General Public License for more + * details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . */ + #include "inspircd.h" /* $ModDesc: Provides channel mode +F (nick flood protection) */ /** Holds settings and state associated with channel mode +F */ -class nickfloodsettings : public classbase +class nickfloodsettings { public: - - int secs; - int nicks; + unsigned int secs; + unsigned int nicks; time_t reset; time_t unlocktime; - int counter; - bool locked; - InspIRCd* ServerInstance; - - nickfloodsettings() : secs(0), nicks(0) {}; + unsigned int counter; - nickfloodsettings(int b, int c) : secs(b), nicks(c) + nickfloodsettings(unsigned int b, unsigned int c) + : secs(b), nicks(c), unlocktime(0), counter(0) { - reset = time(NULL) + secs; - counter = 0; - locked = false; - }; + reset = ServerInstance->Time() + secs; + } void addnick() { - counter++; - if (time(NULL) > reset) + if (ServerInstance->Time() > reset) { - counter = 0; - reset = time(NULL) + secs; + counter = 1; + reset = ServerInstance->Time() + secs; } + else + counter++; } bool shouldlock() { - return (counter >= this->nicks); + /* XXX HACK: using counter + 1 here now to allow the counter to only be incremented + * on successful nick changes; this will be checked before the counter is + * incremented. + */ + return ((ServerInstance->Time() <= reset) && (counter == this->nicks)); } void clear() @@ -60,222 +66,161 @@ class nickfloodsettings : public classbase bool islocked() { - if (locked) - { - if (time(NULL) > unlocktime) - { - locked = false; - return false; - } - else - { - return true; - } - } - return false; + if (ServerInstance->Time() > unlocktime) + unlocktime = 0; + + return (unlocktime != 0); } void lock() { - locked = true; - unlocktime = time(NULL) + 60; + unlocktime = ServerInstance->Time() + 60; } - }; -/** Handles channel mode +j +/** Handles channel mode +F */ class NickFlood : public ModeHandler { public: - NickFlood(InspIRCd* Instance) : ModeHandler(Instance, 'F', 1, 0, false, MODETYPE_CHANNEL, false) { } - - ModePair ModeSet(User* source, User* dest, Channel* channel, const std::string ¶meter) - { - nickfloodsettings* x; - if (channel->GetExt("nickflood",x)) - return std::make_pair(true, ConvToStr(x->nicks)+":"+ConvToStr(x->secs)); - else - return std::make_pair(false, parameter); - } - - bool CheckTimeStamp(time_t theirs, time_t ours, const std::string &their_param, const std::string &our_param, Channel* channel) - { - /* When TS is equal, the alphabetically later one wins */ - return (their_param < our_param); - } + SimpleExtItem ext; + NickFlood(Module* Creator) : ModeHandler(Creator, "nickflood", 'F', PARAM_SETONLY, MODETYPE_CHANNEL), + ext("nickflood", Creator) { } ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string ¶meter, bool adding) { - nickfloodsettings* dummy; - if (adding) { - char ndata[MAXBUF]; - char* data = ndata; - strlcpy(ndata,parameter.c_str(),MAXBUF); - char* nicks = data; - char* secs = NULL; - while (*data) + std::string::size_type colon = parameter.find(':'); + if ((colon == std::string::npos) || (parameter.find('-') != std::string::npos)) { - if (*data == ':') - { - *data = 0; - data++; - secs = data; - break; - } - else data++; + source->WriteNumeric(608, "%s %s :Invalid flood parameter",source->nick.c_str(),channel->name.c_str()); + return MODEACTION_DENY; } - if (secs) + /* Set up the flood parameters for this channel */ + unsigned int nnicks = ConvToInt(parameter.substr(0, colon)); + unsigned int nsecs = ConvToInt(parameter.substr(colon+1)); + + if ((nnicks<1) || (nsecs<1)) { - /* Set up the flood parameters for this channel */ - int nnicks = atoi(nicks); - int nsecs = atoi(secs); - if ((nnicks<1) || (nsecs<1)) - { - source->WriteServ("608 %s %s :Invalid flood parameter",source->nick,channel->name); - parameter.clear(); - return MODEACTION_DENY; - } - else - { - if (!channel->GetExt("nickflood", dummy)) - { - parameter = ConvToStr(nnicks) + ":" +ConvToStr(nsecs); - nickfloodsettings *f = new nickfloodsettings(nsecs,nnicks); - channel->Extend("nickflood", f); - channel->SetMode('F', true); - channel->SetModeParam('F', parameter.c_str(), true); - return MODEACTION_ALLOW; - } - else - { - std::string cur_param = channel->GetModeParameter('F'); - parameter = ConvToStr(nnicks) + ":" +ConvToStr(nsecs); - if (cur_param == parameter) - { - // mode params match - return MODEACTION_DENY; - } - else - { - // new mode param, replace old with new - if ((nsecs > 0) && (nnicks > 0)) - { - nickfloodsettings* f; - channel->GetExt("nickflood", f); - delete f; - f = new nickfloodsettings(nsecs, nnicks); - channel->Shrink("nickflood"); - channel->Extend("nickflood", f); - channel->SetModeParam('F', cur_param.c_str(), false); - channel->SetModeParam('F', parameter.c_str(), true); - return MODEACTION_ALLOW; - } - else - { - return MODEACTION_DENY; - } - } - } - } - } - else - { - source->WriteServ("608 %s %s :Invalid flood parameter",source->nick,channel->name); + source->WriteNumeric(608, "%s %s :Invalid flood parameter",source->nick.c_str(),channel->name.c_str()); return MODEACTION_DENY; } + + nickfloodsettings* f = ext.get(channel); + if ((f) && (nnicks == f->nicks) && (nsecs == f->secs)) + // mode params match + return MODEACTION_DENY; + + ext.set(channel, new nickfloodsettings(nsecs, nnicks)); + parameter = ConvToStr(nnicks) + ":" + ConvToStr(nsecs); + channel->SetModeParam('F', parameter); + return MODEACTION_ALLOW; } else { - if (channel->GetExt("nickflood", dummy)) - { - nickfloodsettings *f; - channel->GetExt("nickflood", f); - delete f; - channel->Shrink("nickflood"); - channel->SetMode('F', false); - return MODEACTION_ALLOW; - } + if (!channel->IsModeSet('F')) + return MODEACTION_DENY; + + ext.unset(channel); + channel->SetModeParam('F', ""); + return MODEACTION_ALLOW; } - return MODEACTION_DENY; } }; class ModuleNickFlood : public Module { - NickFlood* jf; - + NickFlood nf; + public: - - ModuleNickFlood(InspIRCd* Me) - : Module(Me) + + ModuleNickFlood() + : nf(this) + { + } + + void init() { - - jf = new NickFlood(ServerInstance); - if (!ServerInstance->AddMode(jf)) - throw ModuleException("Could not add new modes!"); - Implementation eventlist[] = { I_OnChannelDelete, I_OnUserPreNick }; - ServerInstance->Modules->Attach(eventlist, this, 2); + ServerInstance->Modules->AddService(nf); + ServerInstance->Modules->AddService(nf.ext); + Implementation eventlist[] = { I_OnUserPreNick, I_OnUserPostNick }; + ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation)); } - virtual int OnUserPreNick(User* user, const std::string &newnick) + ModResult OnUserPreNick(User* user, const std::string &newnick) { - if (isdigit(newnick[0])) /* allow switches to UID */ - return 0; + if (ServerInstance->NICKForced.get(user)) /* Allow forced nick changes */ + return MOD_RES_PASSTHRU; for (UCListIter i = user->chans.begin(); i != user->chans.end(); i++) { - Channel *channel = i->first; + Channel *channel = *i; + ModResult res; - nickfloodsettings *f; - if (channel->GetExt("nickflood", f)) + nickfloodsettings *f = nf.ext.get(channel); + if (f) { - if (CHANOPS_EXEMPT(ServerInstance, 'F') && channel->GetStatus(user) == STATUS_OP) + res = ServerInstance->OnCheckExemption(user,channel,"nickflood"); + if (res == MOD_RES_ALLOW) continue; if (f->islocked()) { - user->WriteServ("447 %s :%s has been locked for nickchanges for 60 seconds because there have been more than %d nick changes in %d seconds", user->nick, channel->name, f->nicks, f->secs); - return 1; + user->WriteNumeric(447, "%s :%s has been locked for nickchanges for 60 seconds because there have been more than %u nick changes in %u seconds", user->nick.c_str(), channel->name.c_str(), f->nicks, f->secs); + return MOD_RES_DENY; } - f->addnick(); if (f->shouldlock()) { f->clear(); f->lock(); - channel->WriteChannelWithServ((char*)ServerInstance->Config->ServerName, "NOTICE %s :No nick changes are allowed for 60 seconds because there have been more than %d nick changes in %d seconds.", channel->name, f->nicks, f->secs); - return 1; + channel->WriteChannelWithServ((char*)ServerInstance->Config->ServerName.c_str(), "NOTICE %s :No nick changes are allowed for 60 seconds because there have been more than %u nick changes in %u seconds.", channel->name.c_str(), f->nicks, f->secs); + return MOD_RES_DENY; } } } - return 0; + return MOD_RES_PASSTHRU; } - - void OnChannelDelete(Channel* chan) + + /* + * XXX: HACK: We do the increment on the *POST* event here (instead of all together) because we have no way of knowing whether other modules would block a nickchange. + */ + void OnUserPostNick(User* user, const std::string &oldnick) { - nickfloodsettings *f; - if (chan->GetExt("nickflood",f)) + if (isdigit(user->nick[0])) /* allow switches to UID */ + return; + + for (UCListIter i = user->chans.begin(); i != user->chans.end(); ++i) { - delete f; - chan->Shrink("nickflood"); + Channel *channel = *i; + ModResult res; + + nickfloodsettings *f = nf.ext.get(channel); + if (f) + { + res = ServerInstance->OnCheckExemption(user,channel,"nickflood"); + if (res == MOD_RES_ALLOW) + return; + + /* moved this here to avoid incrementing the counter for nick + * changes that are denied for some other reason (bans, +N, etc.) + * per bug #874. + */ + f->addnick(); + } } } - - virtual ~ModuleNickFlood() + ~ModuleNickFlood() { - ServerInstance->Modes->DelMode(jf); - delete jf; } - - virtual Version GetVersion() + + Version GetVersion() { - return Version(1, 1, 0, 0, VF_COMMON | VF_VENDOR, API_VERSION); + return Version("Channel mode F - nick flood protection", VF_VENDOR); } };